linux-user/main: Allow setting tb-size
PATCH 1/1 linux-user/main: Allow setting tb-size
While qemu-system can set tb-size using -accel tcg,tb-size=n, there is no similar knob for qemu-user. Add one in a way similar to how one-insn-per-tb is already handled.
--- linux-user/main.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
linux-user/main.c +12 -0
@@ -72,6 +72,7 @@ char *exec_path;char real_exec_path[PATH_MAX ];static bool opt_one_insn_per_tb; +static unsigned long opt_tb_size;static const char *argv0;static const char *gdbstub;static envlist_t *envlist;
@@ -418,6 +419,13 @@ static void handle_arg_one_insn_per_tb(const char *arg) opt_one_insn_per_tb = true; } +static void handle_arg_tb_size (const char *arg) +{ +if (qemu_strtoul (arg,NULL ,0 , &opt_tb_size)) { +usage (EXIT_FAILURE ); + } +} +static void handle_arg_strace (const char *arg) { enable_strace = true;
@@ -507,6 +515,8 @@ static const struct qemu_argument arg_table[] = { {"one-insn-per-tb" ,"QEMU_ONE_INSN_PER_TB" , false, handle_arg_one_insn_per_tb, "", "run with one guest instruction per emulated TB"}, + {"tb-size", "QEMU_TB_SIZE", true, handle_arg_tb_size, + "size", "TCG translation block cache size"}, {"strace", "QEMU_STRACE", false, handle_arg_strace, "", "log system calls"}, {"seed", "QEMU_RAND_SEED", true, handle_arg_seed,
@@ -803,6 +813,8 @@ int main(int argc, char **argv, char **envp)accel_init_interfaces (ac);object_property_set_bool (OBJECT (accel),"one-insn-per-tb" , opt_one_insn_per_tb, &error_abort); +object_property_set_int (OBJECT (accel),"tb-size" , + opt_tb_size, &error_abort); ac->init_machine (NULL ); }
Signature · 1 line
2.45.2
Quoted 8 lines · Ilya Leoshkevich
While qemu-system can set tb-size using -accel tcg,tb-size=n, there is no similar knob for qemu-user. Add one in a way similar to how one-insn-per-tb is already handled.
Signed-off-by Ilya Leoshkevich<[email protected]>--- linux-user/main.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
r~
Quoted 8 lines · Ilya Leoshkevich
While qemu-system can set tb-size using -accel tcg,tb-size=n, there is no similar knob for qemu-user. Add one in a way similar to how one-insn-per-tb is already handled.
Signed-off-by Ilya Leoshkevich <[email protected]>--- linux-user/main.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Missing similar change in bsd-user/main.c, otherwise:
Quoted 8 lines · On 30.07.2024 23:54 Ilya Leoshkevich wrote:
While qemu-system can set tb-size using -accel tcg,tb-size=n, there is no similar knob for qemu-user. Add one in a way similar to how one-insn-per-tb is already handled.
Signed-off-by Ilya Leoshkevich<[email protected]>--- linux-user/main.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Right now (commit 661c2e1a) it looks like this change never made it to linux-user/main.c in the master branch.
Interestingly enough the changes for bsd-user/main.c were merged in early November.
Did this patch just get lost, or is there a reason it was appied to bsd-user but not linux-user (despite the initial effort to maintain feature parity)? It looks like a useful feature to have and compiling from source for a 12 line patch is not very convenient.