6.19.7-rc1 review
Subsystems (10)
Sasha Levin
maintainerPATCH 273/311 net: sched: avoid qdisc_reset_all_tx_gt() vs dequeue race for lockless qdiscs
In reply to Sasha LevinFrom: Koichiro Den <[email protected]>
[ Upstream commit 7f083faf59d14c04e01ec05a7507f036c965acf8 ]
When shrinking the number of real tx queues, netif_set_real_num_tx_queues() calls qdisc_reset_all_tx_gt() to flush qdiscs for queues which will no longer be used.
qdisc_reset_all_tx_gt() currently serializes qdisc_reset() with qdisc_lock(). However, for lockless qdiscs, the dequeue path is serialized by qdisc_run_begin/end() using qdisc->seqlock instead, so qdisc_reset() can run concurrently with __qdisc_run() and free skbs while they are still being dequeued, leading to UAF.
This can easily be reproduced on e.g. virtio-net by imposing heavy traffic while frequently changing the number of queue pairs:
iperf3 -ub0 -c $peer -t 0 &
while :; do
ethtool -L eth0 combined 1
ethtool -L eth0 combined 2
done
With KASAN enabled, this leads to reports like:
BUG: KASAN: slab-use-after-free in __qdisc_run+0x133f/0x1760 ... Call Trace: <TASK> ... __qdisc_run+0x133f/0x1760 __dev_queue_xmit+0x248f/0x3550 ip_finish_output2+0xa42/0x2110 ip_output+0x1a7/0x410 ip_send_skb+0x2e6/0x480 udp_send_skb+0xb0a/0x1590 udp_sendmsg+0x13c9/0x1fc0 ... </TASK> Allocated by task 1270 on cpu 5 at 44.558414s: ... alloc_skb_with_frags+0x84/0x7c0 sock_alloc_send_pskb+0x69a/0x830 __ip_append_data+0x1b86/0x48c0 ip_make_skb+0x1e8/0x2b0 udp_sendmsg+0x13a6/0x1fc0 ... Freed by task 1306 on cpu 3 at 44.558445s: ... kmem_cache_free+0x117/0x5e0 pfifo_fast_reset+0x14d/0x580 qdisc_reset+0x9e/0x5f0 netif_set_real_num_tx_queues+0x303/0x840 virtnet_set_channels+0x1bf/0x260 [virtio_net] ethnl_set_channels+0x684/0xae0 ethnl_default_set_doit+0x31a/0x890 ...
Serialize qdisc_reset_all_tx_gt() against the lockless dequeue path by taking qdisc->seqlock for TCQ_F_NOLOCK qdiscs, matching the serialization model already used by dev_reset_queue().
Additionally clear QDISC_STATE_NON_EMPTY after reset so the qdisc state reflects an empty queue, avoiding needless re-scheduling.
--- include/net/sch_generic.h | 10 ++++++++++ 1 file changed, 10 insertions(+)
include/net/sch_generic.h +10 -0
@@ -778,13 +778,23 @@ static inline bool skb_skip_tc_classify(struct sk_buff *skb)static inline void qdisc_reset_all_tx_gt (struct net_device *dev,unsigned int i) {struct Qdisc *qdisc; +bool nolock;for (; i < dev->num_tx_queues; i++) { qdisc =rtnl_dereference (netdev_get_tx_queue (dev, i)->qdisc);if (qdisc) { + nolock = qdisc->flags &TCQ_F_NOLOCK ; + +if (nolock) +spin_lock_bh (&qdisc->seqlock);spin_lock_bh (qdisc_lock (qdisc));qdisc_reset (qdisc);spin_unlock_bh (qdisc_lock (qdisc)); +if (nolock) { +clear_bit (__QDISC_STATE_MISSED, &qdisc->state); +clear_bit (__QDISC_STATE_DRAINING, &qdisc->state); +spin_unlock_bh (&qdisc->seqlock); + } } } }
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 274/311 tcp: secure_seq: add back ports to TS offset
In reply to Sasha LevinFrom: Eric Dumazet <[email protected]>
[ Upstream commit 165573e41f2f66ef98940cf65f838b2cb575d9d1 ]
This reverts 28ee1b746f49 ("secure_seq: downgrade to per-host timestamp offsets")
tcp_tw_recycle went away in 2017.
Zhouyan Deng reported off-path TCP source port leakage via SYN cookie side-channel that can be fixed in multiple ways.
One of them is to bring back TCP ports in TS offset randomization.
As a bonus, we perform a single siphash() computation to provide both an ISN and a TS offset.
--- include/net/secure_seq.h | 45 ++++++++++++++++++---- include/net/tcp.h | 6 ++- net/core/secure_seq.c | 80 +++++++++++++++------------------------- net/ipv4/syncookies.c | 11 ++++-- net/ipv4/tcp_input.c | 8 +++- net/ipv4/tcp_ipv4.c | 37 +++++++++---------- net/ipv6/syncookies.c | 11 ++++-- net/ipv6/tcp_ipv6.c | 37 +++++++++---------- 8 files changed, 127 insertions(+), 108 deletions(-)
include/net/secure_seq.h +38 -7
@@ -5,16 +5,47 @@#include <linux/types.h> struct net ; +extern struct net init_net; + +union tcp_seq_and_ts_off { +struct { +u32 seq; +u32 ts_off; + }; +u64 hash64; +};u64 secure_ipv4_port_ephemeral (__be32 saddr,__be32 daddr,__be16 dport);u64 secure_ipv6_port_ephemeral (const __be32 *saddr,const __be32 *daddr,__be16 dport); -u32 secure_tcp_seq (__be32 saddr,__be32 daddr, -__be16 sport,__be16 dport); -u32 secure_tcp_ts_off (const struct net *net,__be32 saddr,__be32 daddr); -u32 secure_tcpv6_seq (const __be32 *saddr,const __be32 *daddr, -__be16 sport,__be16 dport); -u32 secure_tcpv6_ts_off (const struct net *net, -const __be32 *saddr,const __be32 *daddr); +union tcp_seq_and_ts_off +secure_tcp_seq_and_ts_off (const struct net *net,__be32 saddr,__be32 daddr, +__be16 sport,__be16 dport); + +static inline u32 secure_tcp_seq (__be32 saddr,__be32 daddr, +__be16 sport,__be16 dport) +{ +union tcp_seq_and_ts_off ts; + + ts =secure_tcp_seq_and_ts_off (&init_net, saddr, daddr, + sport, dport); + +return ts.seq; +} + +union tcp_seq_and_ts_off +secure_tcpv6_seq_and_ts_off (const struct net *net,const __be32 *saddr, +const __be32 *daddr, +__be16 sport,__be16 dport); + +static inline u32 secure_tcpv6_seq (const __be32 *saddr,const __be32 *daddr, +__be16 sport,__be16 dport) +{ +union tcp_seq_and_ts_off ts; + + ts =secure_tcpv6_seq_and_ts_off (&init_net, saddr, daddr, + sport, dport); +return ts.seq; +}#endif /* _NET_SECURE_SEQ */
include/net/tcp.h +4 -2
@@ -43,6 +43,7 @@#include <net/dst.h> #include <net/mptcp.h> #include <net/xfrm.h> +#include <net/secure_seq.h> #include <linux/seq_file.h> #include <linux/memcontrol.h>
@@ -2437,8 +2438,9 @@ struct tcp_request_sock_ops {struct flowi *fl, struct request_sock *req, u32 tw_isn); -u32 (*init_seq)(const struct sk_buff *skb); -u32 (*init_ts_off)(const struct net *net,const struct sk_buff *skb); +union tcp_seq_and_ts_off (*init_seq_and_ts_off)( +const struct net *net, +const struct sk_buff *skb); int (*send_synack)(const struct sock *sk, struct dst_entry *dst, struct flowi *fl, struct request_sock *req, struct tcp_fastopen_cookie *foc,
net/core/secure_seq.c +29 -51
122 lines not on this page · raw message
net/ipv4/syncookies.c +8 -3
@@ -378,9 +378,14 @@ static struct request_sock *cookie_tcp_check(struct net *net, struct sock *sk,tcp_parse_options (net, skb, &tcp_opt,0 ,NULL );if (tcp_opt.saw_tstamp && tcp_opt.rcv_tsecr) { - tsoff =secure_tcp_ts_off (net, -ip_hdr (skb)->daddr, -ip_hdr (skb)->saddr); +union tcp_seq_and_ts_off st; + + st =secure_tcp_seq_and_ts_off (net, +ip_hdr (skb)->daddr, +ip_hdr (skb)->saddr, +tcp_hdr (skb)->dest, +tcp_hdr (skb)->source); + tsoff = st.ts_off; tcp_opt.rcv_tsecr -= tsoff; }
net/ipv4/tcp_input.c +6 -2
@@ -7411,6 +7411,7 @@ int tcp_conn_request(struct request_sock_ops *rsk_ops,const struct tcp_sock *tp =tcp_sk (sk);struct net *net =sock_net (sk);struct sock *fastopen_sk =NULL ; +union tcp_seq_and_ts_off st;struct request_sock *req;bool want_cookie = false;struct dst_entry *dst;
@@ -7480,9 +7481,12 @@ int tcp_conn_request(struct request_sock_ops *rsk_ops,if (!dst) goto drop_and_free; +if (tmp_opt.tstamp_ok || (!want_cookie && !isn)) + st = af_ops->init_seq_and_ts_off (net, skb); +if (tmp_opt.tstamp_ok) {tcp_rsk (req)->req_usec_ts =dst_tcp_usec_ts (dst); -tcp_rsk (req)->ts_off = af_ops->init_ts_off (net, skb); +tcp_rsk (req)->ts_off = st.ts_off; }if (!want_cookie && !isn) {int max_syn_backlog =READ_ONCE (net->ipv4.sysctl_max_syn_backlog);
@@ -7504,7 +7508,7 @@ int tcp_conn_request(struct request_sock_ops *rsk_ops, goto drop_and_release; } - isn = af_ops->init_seq (skb); + isn = st.seq; }tcp_ecn_create_request (req, skb, sk, dst);
net/ipv4/tcp_ipv4.c +17 -20
@@ -104,17 +104,14 @@ static DEFINE_PER_CPU(struct sock_bh_locked, ipv4_tcp_sk) = {static DEFINE_MUTEX (tcp_exit_batch_mutex); -static u32 tcp_v4_init_seq (const struct sk_buff *skb) +static union tcp_seq_and_ts_off +tcp_v4_init_seq_and_ts_off (const struct net *net,const struct sk_buff *skb) { -return secure_tcp_seq (ip_hdr (skb)->daddr, -ip_hdr (skb)->saddr, -tcp_hdr (skb)->dest, -tcp_hdr (skb)->source); -} - -static u32 tcp_v4_init_ts_off (const struct net *net,const struct sk_buff *skb) -{ -return secure_tcp_ts_off (net,ip_hdr (skb)->daddr,ip_hdr (skb)->saddr); +return secure_tcp_seq_and_ts_off (net, +ip_hdr (skb)->daddr, +ip_hdr (skb)->saddr, +tcp_hdr (skb)->dest, +tcp_hdr (skb)->source); }int tcp_twsk_unique (struct sock *sk,struct sock *sktw,void *twp)
@@ -326,15 +323,16 @@ int tcp_v4_connect(struct sock *sk, struct sockaddr_unsized *uaddr, int addr_len rt =NULL ;if (likely (!tp->repair)) { +union tcp_seq_and_ts_off st; + + st =secure_tcp_seq_and_ts_off (net, + inet->inet_saddr, + inet->inet_daddr, + inet->inet_sport, + usin->sin_port);if (!tp->write_seq) -WRITE_ONCE (tp->write_seq, -secure_tcp_seq (inet->inet_saddr, - inet->inet_daddr, - inet->inet_sport, - usin->sin_port)); -WRITE_ONCE (tp->tsoffset, -secure_tcp_ts_off (net, inet->inet_saddr, - inet->inet_daddr)); +WRITE_ONCE (tp->write_seq, st.seq); +WRITE_ONCE (tp->tsoffset, st.ts_off); }atomic_set (&inet->inet_id,get_random_u16 ());
@@ -1677,8 +1675,7 @@ const struct tcp_request_sock_ops tcp_request_sock_ipv4_ops = { .cookie_init_seq = cookie_v4_init_sequence, #endif .route_req = tcp_v4_route_req, - .init_seq = tcp_v4_init_seq, - .init_ts_off = tcp_v4_init_ts_off, + .init_seq_and_ts_off = tcp_v4_init_seq_and_ts_off, .send_synack = tcp_v4_send_synack, };
net/ipv6/syncookies.c +8 -3
@@ -151,9 +151,14 @@ static struct request_sock *cookie_tcp_check(struct net *net, struct sock *sk,tcp_parse_options (net, skb, &tcp_opt,0 ,NULL );if (tcp_opt.saw_tstamp && tcp_opt.rcv_tsecr) { - tsoff =secure_tcpv6_ts_off (net, -ipv6_hdr (skb)->daddr.s6_addr32, -ipv6_hdr (skb)->saddr.s6_addr32); +union tcp_seq_and_ts_off st; + + st =secure_tcpv6_seq_and_ts_off (net, +ipv6_hdr (skb)->daddr.s6_addr32, +ipv6_hdr (skb)->saddr.s6_addr32, +tcp_hdr (skb)->dest, +tcp_hdr (skb)->source); + tsoff = st.ts_off; tcp_opt.rcv_tsecr -= tsoff; }
net/ipv6/tcp_ipv6.c +17 -20
@@ -104,18 +104,14 @@ static void inet6_sk_rx_dst_set(struct sock *sk, const struct sk_buff *skb) } } -static u32 tcp_v6_init_seq (const struct sk_buff *skb) +static union tcp_seq_and_ts_off +tcp_v6_init_seq_and_ts_off (const struct net *net,const struct sk_buff *skb) { -return secure_tcpv6_seq (ipv6_hdr (skb)->daddr.s6_addr32, -ipv6_hdr (skb)->saddr.s6_addr32, -tcp_hdr (skb)->dest, -tcp_hdr (skb)->source); -} - -static u32 tcp_v6_init_ts_off (const struct net *net,const struct sk_buff *skb) -{ -return secure_tcpv6_ts_off (net,ipv6_hdr (skb)->daddr.s6_addr32, -ipv6_hdr (skb)->saddr.s6_addr32); +return secure_tcpv6_seq_and_ts_off (net, +ipv6_hdr (skb)->daddr.s6_addr32, +ipv6_hdr (skb)->saddr.s6_addr32, +tcp_hdr (skb)->dest, +tcp_hdr (skb)->source); } static int tcp_v6_pre_connect(struct sock *sk, struct sockaddr_unsized *uaddr,
@@ -318,14 +314,16 @@ static int tcp_v6_connect(struct sock *sk, struct sockaddr_unsized *uaddr,sk_set_txhash (sk);if (likely (!tp->repair)) { +union tcp_seq_and_ts_off st; + + st =secure_tcpv6_seq_and_ts_off (net, + np->saddr.s6_addr32, + sk->sk_v6_daddr.s6_addr32, + inet->inet_sport, + inet->inet_dport);if (!tp->write_seq) -WRITE_ONCE (tp->write_seq, -secure_tcpv6_seq (np->saddr.s6_addr32, - sk->sk_v6_daddr.s6_addr32, - inet->inet_sport, - inet->inet_dport)); - tp->tsoffset =secure_tcpv6_ts_off (net, np->saddr.s6_addr32, - sk->sk_v6_daddr.s6_addr32); +WRITE_ONCE (tp->write_seq, st.seq); + tp->tsoffset = st.ts_off; }if (tcp_fastopen_defer_connect (sk, &err))
@@ -814,8 +812,7 @@ const struct tcp_request_sock_ops tcp_request_sock_ipv6_ops = { .cookie_init_seq = cookie_v6_init_sequence, #endif .route_req = tcp_v6_route_req, - .init_seq = tcp_v6_init_seq, - .init_ts_off = tcp_v6_init_ts_off, + .init_seq_and_ts_off = tcp_v6_init_seq_and_ts_off, .send_synack = tcp_v6_send_synack, };
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 275/311 net: nfc: nci: Fix zero-length proprietary notifications
In reply to Sasha LevinFrom: Ian Ray <[email protected]>
[ Upstream commit f7d92f11bd33a6eb49c7c812255ef4ab13681f0f ]
NCI NFC controllers may have proprietary OIDs with zero-length payload. One example is: drivers/nfc/nxp-nci/core.c, NXP_NCI_RF_TXLDO_ERROR_NTF.
Allow a zero length payload in proprietary notifications *only*.
Before:
-- >8 --
kernel: nci: nci_recv_frame: len 3
-- >8 --
After:
-- >8 --
kernel: nci: nci_recv_frame: len 3
kernel: nci: nci_ntf_packet: NCI RX: MT=ntf, PBF=0, GID=0x1, OID=0x23, plen=0
kernel: nci: nci_ntf_packet: unknown ntf opcode 0x123
kernel: nfc nfc0: NFC: RF transmitter couldn't start. Bad power and/or configuration? -- >8 --
After fixing the hardware:
-- >8 --
kernel: nci: nci_recv_frame: len 27
kernel: nci: nci_ntf_packet: NCI RX: MT=ntf, PBF=0, GID=0x1, OID=0x5, plen=24
kernel: nci: nci_rf_intf_activated_ntf_packet: rf_discovery_id 1 -- >8 --
--- net/nfc/nci/core.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
net/nfc/nci/core.c +11 -1
@@ -1482,10 +1482,20 @@ static bool nci_valid_size(struct sk_buff *skb)unsigned int hdr_size =NCI_CTRL_HDR_SIZE ;if (skb->len < hdr_size || - !nci_plen (skb->data) || skb->len < hdr_size +nci_plen (skb->data)) {return false; } + +if (!nci_plen (skb->data)) { +/* Allow zero length in proprietary notifications (0x20 - 0x3F). */ +if (nci_opcode_oid (nci_opcode (skb->data)) >=0x20 && +nci_mt (skb->data) ==NCI_MT_NTF_PKT ) +return true; + +/* Disallow zero length otherwise. */ +return false; + } +return true; }
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 276/311 net_sched: sch_fq: clear q->band_pkt_count[] in fq_reset()
In reply to Sasha LevinFrom: Eric Dumazet <[email protected]>
[ Upstream commit a4c2b8be2e5329e7fac6e8f64ddcb8958155cfcb ]
When/if a NIC resets, queues are deactivated by dev_deactivate_many(), then reactivated when the reset operation completes.
fq_reset() removes all the skbs from various queues.
If we do not clear q->band_pkt_count[], these counters keep growing and can eventually reach sch->limit, preventing new packets to be queued.
Many thanks to Praveen for discovering the root cause.
--- net/sched/sch_fq.c | 1 + 1 file changed, 1 insertion(+)
net/sched/sch_fq.c +1 -0
@@ -829,6 +829,7 @@ static void fq_reset(struct Qdisc *sch)for (idx =0 ; idx <FQ_BANDS ; idx++) { q->band_flows[idx].new_flows.first =NULL ; q->band_flows[idx].old_flows.first =NULL ; + q->band_pkt_count[idx] =0 ; } q->delayed =RB_ROOT ; q->flows =0 ;
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 277/311 net: devmem: use READ_ONCE/WRITE_ONCE on binding->dev
In reply to Sasha LevinFrom: Bobby Eshleman <[email protected]>
[ Upstream commit 40bf00ec2ee271df5ba67593991760adf8b5d0ed ]
binding->dev is protected on the write-side in mp_dmabuf_devmem_uninstall() against concurrent writes, but due to the concurrent bare reads in net_devmem_get_binding() and validate_xmit_unreadable_skb() it should be wrapped in a READ_ONCE/WRITE_ONCE pair to make sure no compiler optimizations play with the underlying register in unforeseen ways.
Doesn't present a critical bug because the known compiler optimizations don't result in bad behavior. There is no tearing on u64, and load omissions/invented loads would only break if additional binding->dev references were inlined together (they aren't right now).
This just more strictly follows the linux memory model (i.e., "Lock-Protected Writes With Lockless Reads" in tools/memory-model/Documentation/access-marking.txt).
--- net/core/dev.c | 2 +- net/core/devmem.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-)
net/core/dev.c +1 -1
@@ -3983,7 +3983,7 @@ static struct sk_buff *validate_xmit_unreadable_skb(struct sk_buff *skb,if (shinfo->nr_frags >0 ) { niov =netmem_to_net_iov (skb_frag_netmem (&shinfo->frags[0 ]));if (net_is_devmem_iov (niov) && -net_devmem_iov_binding (niov)->dev != dev) +READ_ONCE (net_devmem_iov_binding (niov)->dev) != dev) goto out_free; }
net/core/devmem.c +4 -2
@@ -387,7 +387,8 @@ struct net_devmem_dmabuf_binding *net_devmem_get_binding(struct sock *sk,* net_device. */ dst_dev =dst_dev_rcu (dst); -if (unlikely (!dst_dev) ||unlikely (dst_dev != binding->dev)) { +if (unlikely (!dst_dev) || +unlikely (dst_dev !=READ_ONCE (binding->dev))) { err = -ENODEV ; goto out_unlock; }
@@ -504,7 +505,8 @@ static void mp_dmabuf_devmem_uninstall(void *mp_priv,xa_erase (&binding->bound_rxqs, xa_idx);if (xa_empty (&binding->bound_rxqs)) {mutex_lock (&binding->lock); - binding->dev =NULL ; +ASSERT_EXCLUSIVE_WRITER (binding->dev); +WRITE_ONCE (binding->dev,NULL );mutex_unlock (&binding->lock); }break ;
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 278/311 nfc: nci: free skb on nci_transceive early error paths
In reply to Sasha LevinFrom: Jakub Kicinski <[email protected]>
[ Upstream commit 7bd4b0c4779f978a6528c9b7937d2ca18e936e2c ]
nci_transceive() takes ownership of the skb passed by the caller, but the -EPROTO, -EINVAL, and -EBUSY error paths return without freeing it.
Due to issues clearing NCI_DATA_EXCHANGE fixed by subsequent changes the nci/nci_dev selftest hits the error path occasionally in NIPA, and kmemleak detects leaks:
unreferenced object 0xff11000015ce6a40 (size 640):
comm "nci_dev", pid 3954, jiffies 4295441246
hex dump (first 32 bytes):
6b 6b 6b 6b 00 a4 00 0c 02 e1 03 6b 6b 6b 6b 6b kkkk.......kkkkk 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk
backtrace (crc 7c40cc2a):
kmem_cache_alloc_node_noprof+0x492/0x630
__alloc_skb+0x11e/0x5f0
alloc_skb_with_frags+0xc6/0x8f0
sock_alloc_send_pskb+0x326/0x3f0
nfc_alloc_send_skb+0x94/0x1d0
rawsock_sendmsg+0x162/0x4c0
do_syscall_64+0x117/0xfc0--- net/nfc/nci/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
net/nfc/nci/core.c +7 -2
@@ -1035,18 +1035,23 @@ static int nci_transceive(struct nfc_dev *nfc_dev, struct nfc_target *target,struct nci_conn_info *conn_info; conn_info = ndev->rf_conn_info; -if (!conn_info) +if (!conn_info) { +kfree_skb (skb);return -EPROTO ; + }pr_debug ("target_idx %d, len %d\n" , target->idx, skb->len);if (!ndev->target_active_prot) {pr_err ("unable to exchange data, no active target\n" ); +kfree_skb (skb);return -EINVAL ; } -if (test_and_set_bit (NCI_DATA_EXCHANGE , &ndev->flags)) +if (test_and_set_bit (NCI_DATA_EXCHANGE , &ndev->flags)) { +kfree_skb (skb);return -EBUSY ; + }/* store cb and context to be used on receiving data */ conn_info->data_exchange_cb = cb;
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 279/311 nfc: nci: complete pending data exchange on device close
In reply to Sasha LevinFrom: Jakub Kicinski <[email protected]>
[ Upstream commit 66083581945bd5b8e99fe49b5aeb83d03f62d053 ]
In nci_close_device(), complete any pending data exchange before closing. The data exchange callback (e.g. rawsock_data_exchange_complete) holds a socket reference.
NIPA occasionally hits this leak:
unreferenced object 0xff1100000f435000 (size 2048):
comm "nci_dev", pid 3954, jiffies 4295441245 hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
27 00 01 40 00 00 00 00 00 00 00 00 00 00 00 00 '..@............
backtrace (crc ec2b3c5):
__kmalloc_noprof+0x4db/0x730
sk_prot_alloc.isra.0+0xe4/0x1d0
sk_alloc+0x36/0x760
rawsock_create+0xd1/0x540
nfc_sock_create+0x11f/0x280
__sock_create+0x22d/0x630
__sys_socket+0x115/0x1d0
__x64_sys_socket+0x72/0xd0
do_syscall_64+0x117/0xfc0
entry_SYSCALL_64_after_hwframe+0x4b/0x53--- net/nfc/nci/core.c | 9 +++++++++ 1 file changed, 9 insertions(+)
net/nfc/nci/core.c +9 -0
@@ -567,6 +567,10 @@ static int nci_close_device(struct nci_dev *ndev)flush_workqueue (ndev->cmd_wq);timer_delete_sync (&ndev->cmd_timer);timer_delete_sync (&ndev->data_timer); +if (test_bit (NCI_DATA_EXCHANGE , &ndev->flags)) +nci_data_exchange_complete (ndev,NULL , + ndev->cur_conn_id, + -ENODEV );mutex_unlock (&ndev->req_lock);return 0 ; }
@@ -598,6 +602,11 @@ static int nci_close_device(struct nci_dev *ndev)flush_workqueue (ndev->cmd_wq);timer_delete_sync (&ndev->cmd_timer); +timer_delete_sync (&ndev->data_timer); + +if (test_bit (NCI_DATA_EXCHANGE , &ndev->flags)) +nci_data_exchange_complete (ndev,NULL , ndev->cur_conn_id, + -ENODEV );/* Clear flags except NCI_UNREG */ ndev->flags &=BIT (NCI_UNREG );
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 280/311 nfc: nci: clear NCI_DATA_EXCHANGE before calling completion callback
In reply to Sasha LevinFrom: Jakub Kicinski <[email protected]>
[ Upstream commit 0efdc02f4f6d52f8ca5d5889560f325a836ce0a8 ]
Move clear_bit(NCI_DATA_EXCHANGE) before invoking the data exchange callback in nci_data_exchange_complete().
The callback (e.g. rawsock_data_exchange_complete) may immediately schedule another data exchange via schedule_work(tx_work). On a multi-CPU system, tx_work can run and reach nci_transceive() before the current nci_data_exchange_complete() clears the flag, causing test_and_set_bit(NCI_DATA_EXCHANGE) to return -EBUSY and the new transfer to fail.
This causes intermittent flakes in nci/nci_dev in NIPA:
# # RUN NCI.NCI1_0.t4t_tag_read ...
# # t4t_tag_read: Test terminated by timeout
# # FAIL NCI.NCI1_0.t4t_tag_read
# not ok 3 NCI.NCI1_0.t4t_tag_read
--- net/nfc/nci/data.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
net/nfc/nci/data.c +8 -4
@@ -33,7 +33,8 @@ void nci_data_exchange_complete(struct nci_dev *ndev, struct sk_buff *skb, conn_info =nci_get_conn_info_by_conn_id (ndev, conn_id);if (!conn_info) {kfree_skb (skb); - goto exit; +clear_bit (NCI_DATA_EXCHANGE , &ndev->flags); +return ; } cb = conn_info->data_exchange_cb;
@@ -45,6 +46,12 @@ void nci_data_exchange_complete(struct nci_dev *ndev, struct sk_buff *skb,timer_delete_sync (&ndev->data_timer);clear_bit (NCI_DATA_EXCHANGE_TO , &ndev->flags); +/* Mark the exchange as done before calling the callback. +* The callback (e.g. rawsock_data_exchange_complete) may +* want to immediately queue another data exchange. +*/ +clear_bit (NCI_DATA_EXCHANGE , &ndev->flags); +if (cb) {/* forward skb to nfc core */ cb (cb_context, skb, err);
@@ -54,9 +61,6 @@ void nci_data_exchange_complete(struct nci_dev *ndev, struct sk_buff *skb,/* no waiting callback, free skb */ kfree_skb (skb); } - -exit: -clear_bit (NCI_DATA_EXCHANGE , &ndev->flags); }/* ----------------- NCI TX Data ----------------- */
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 281/311 nfc: rawsock: cancel tx_work before socket teardown
In reply to Sasha LevinFrom: Jakub Kicinski <[email protected]>
[ Upstream commit d793458c45df2aed498d7f74145eab7ee22d25aa ]
In rawsock_release(), cancel any pending tx_work and purge the write queue before orphaning the socket. rawsock_tx_work runs on the system workqueue and calls nfc_data_exchange which dereferences the NCI device. Without synchronization, tx_work can race with socket and device teardown when a process is killed (e.g. by SIGKILL), leading to use-after-free or leaked references.
Set SEND_SHUTDOWN first so that if tx_work is already running it will see the flag and skip transmitting, then use cancel_work_sync to wait for any in-progress execution to finish, and finally purge any remaining queued skbs.
--- net/nfc/rawsock.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
net/nfc/rawsock.c +11 -0
@@ -67,6 +67,17 @@ static int rawsock_release(struct socket *sock)if (sock->type ==SOCK_RAW )nfc_sock_unlink (&raw_sk_list, sk); +if (sk->sk_state ==TCP_ESTABLISHED ) { +/* Prevent rawsock_tx_work from starting new transmits and +* wait for any in-progress work to finish. This must happen +* before the socket is orphaned to avoid a race where +* rawsock_tx_work runs after the NCI device has been freed. +*/ + sk->sk_shutdown |=SEND_SHUTDOWN ; +cancel_work_sync (&nfc_rawsock (sk)->tx_work); +rawsock_write_queue_purge (sk); + } +sock_orphan (sk);sock_put (sk);
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 282/311 net: stmmac: Fix error handling in VLAN add and delete paths
In reply to Sasha LevinFrom: Ovidiu Panait <[email protected]>
[ Upstream commit 35dfedce442c4060cfe5b98368bc9643fb995716 ]
stmmac_vlan_rx_add_vid() updates active_vlans and the VLAN hash register before writing the HW filter entry. If the filter write fails, it leaves a stale VID in active_vlans and the hash register.
stmmac_vlan_rx_kill_vid() has the reverse problem: it clears active_vlans before removing the HW filter. On failure, the VID is gone from active_vlans but still present in the HW filter table.
To fix this, reorder the operations to update the hash table first, then attempt the HW filter operation. If the HW filter fails, roll back both the active_vlans bitmap and the hash table by calling stmmac_vlan_update() again.
--- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +14 -4
@@ -6746,9 +6746,13 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vidif (priv->hw->num_vlan) { ret =stmmac_add_hw_vlan_rx_fltr (priv, ndev, priv->hw, proto, vid); -if (ret) +if (ret) { +clear_bit (vid, priv->active_vlans); +stmmac_vlan_update (priv, is_double); goto err_pm_put; + } } + err_pm_put:pm_runtime_put (priv->device);
@@ -6772,15 +6776,21 @@ static int stmmac_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vi is_double = true;clear_bit (vid, priv->active_vlans); + ret =stmmac_vlan_update (priv, is_double); +if (ret) { +set_bit (vid, priv->active_vlans); + goto del_vlan_error; + }if (priv->hw->num_vlan) { ret =stmmac_del_hw_vlan_rx_fltr (priv, ndev, priv->hw, proto, vid); -if (ret) +if (ret) { +set_bit (vid, priv->active_vlans); +stmmac_vlan_update (priv, is_double); goto del_vlan_error; + } } - ret =stmmac_vlan_update (priv, is_double); - del_vlan_error:pm_runtime_put (priv->device);
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 283/311 net: stmmac: Improve double VLAN handling
In reply to Sasha LevinFrom: Ovidiu Panait <[email protected]>
[ Upstream commit e38200e361cbe331806dc454c76c11c7cd95e1b9 ]
The double VLAN bits (EDVLP, ESVL, DOVLTC) are handled inconsistently between the two vlan_update_hash() implementations:
- dwxgmac2_update_vlan_hash() explicitly clears the double VLAN bits when is_double is false, meaning that adding a 802.1Q VLAN will disable double VLAN mode:
$ ip link add link eth0 name eth0.200 type vlan id 200 protocol 802.1ad $ ip link add link eth0 name eth0.100 type vlan id 100 # Double VLAN bits no longer set
- vlan_update_hash() sets these bits and only clears them when the last VLAN has been removed, so double VLAN mode remains enabled even after all 802.1AD VLANs are removed.
Address both issues by tracking the number of active 802.1AD VLANs in priv->num_double_vlans. Pass this count to stmmac_vlan_update() so both implementations correctly set the double VLAN bits when any 802.1AD VLAN is active, and clear them only when none remain.
Also update vlan_update_hash() to explicitly clear the double VLAN bits when is_double is false, matching the dwxgmac2 behavior.
Stable-dep-of: bd7ad51253a7 ("net: stmmac: Fix VLAN HW state restore")
--- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + .../net/ethernet/stmicro/stmmac/stmmac_main.c | 16 ++++++++++++---- .../net/ethernet/stmicro/stmmac/stmmac_vlan.c | 8 ++++++++ 3 files changed, 21 insertions(+), 4 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac.h +1 -0
@@ -322,6 +322,7 @@ struct stmmac_priv {void __iomem *ptpaddr;void __iomem *estaddr;unsigned long active_vlans[BITS_TO_LONGS (VLAN_N_VID )]; +unsigned int num_double_vlans;int sfty_irq;int sfty_ce_irq;int sfty_ue_irq;
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +12 -4
@@ -6727,6 +6727,7 @@ static int stmmac_vlan_update(struct stmmac_priv *priv, bool is_double)static int stmmac_vlan_rx_add_vid (struct net_device *ndev,__be16 proto,u16 vid) {struct stmmac_priv *priv =netdev_priv (ndev); +unsigned int num_double_vlans;bool is_double = false;int ret;
@@ -6738,7 +6739,8 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid is_double = true;set_bit (vid, priv->active_vlans); - ret =stmmac_vlan_update (priv, is_double); + num_double_vlans = priv->num_double_vlans + is_double; + ret =stmmac_vlan_update (priv, num_double_vlans);if (ret) {clear_bit (vid, priv->active_vlans); goto err_pm_put;
@@ -6748,11 +6750,13 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid ret =stmmac_add_hw_vlan_rx_fltr (priv, ndev, priv->hw, proto, vid);if (ret) {clear_bit (vid, priv->active_vlans); -stmmac_vlan_update (priv, is_double); +stmmac_vlan_update (priv, priv->num_double_vlans); goto err_pm_put; } } + priv->num_double_vlans = num_double_vlans; + err_pm_put:pm_runtime_put (priv->device);
@@ -6765,6 +6769,7 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vidstatic int stmmac_vlan_rx_kill_vid (struct net_device *ndev,__be16 proto,u16 vid) {struct stmmac_priv *priv =netdev_priv (ndev); +unsigned int num_double_vlans;bool is_double = false;int ret;
@@ -6776,7 +6781,8 @@ static int stmmac_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vi is_double = true;clear_bit (vid, priv->active_vlans); - ret =stmmac_vlan_update (priv, is_double); + num_double_vlans = priv->num_double_vlans - is_double; + ret =stmmac_vlan_update (priv, num_double_vlans);if (ret) {set_bit (vid, priv->active_vlans); goto del_vlan_error;
@@ -6786,11 +6792,13 @@ static int stmmac_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vi ret =stmmac_del_hw_vlan_rx_fltr (priv, ndev, priv->hw, proto, vid);if (ret) {set_bit (vid, priv->active_vlans); -stmmac_vlan_update (priv, is_double); +stmmac_vlan_update (priv, priv->num_double_vlans); goto del_vlan_error; } } + priv->num_double_vlans = num_double_vlans; + del_vlan_error:pm_runtime_put (priv->device);
drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c +8 -0
@@ -183,6 +183,10 @@ static void vlan_update_hash(struct mac_device_info *hw, u32 hash, value |=VLAN_EDVLP ; value |=VLAN_ESVL ; value |=VLAN_DOVLTC ; + }else { + value &= ~VLAN_EDVLP ; + value &= ~VLAN_ESVL ; + value &= ~VLAN_DOVLTC ; }writel (value, ioaddr +VLAN_TAG );
@@ -193,6 +197,10 @@ static void vlan_update_hash(struct mac_device_info *hw, u32 hash, value |=VLAN_EDVLP ; value |=VLAN_ESVL ; value |=VLAN_DOVLTC ; + }else { + value &= ~VLAN_EDVLP ; + value &= ~VLAN_ESVL ; + value &= ~VLAN_DOVLTC ; }writel (value | perfect_match, ioaddr +VLAN_TAG );
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 284/311 net: stmmac: Fix VLAN HW state restore
In reply to Sasha LevinFrom: Ovidiu Panait <[email protected]>
[ Upstream commit bd7ad51253a76fb35886d01cfe9a37f0e4ed6709 ]
When the network interface is opened or resumed, a DMA reset is performed, which resets all hardware state, including VLAN state. Currently, only the resume path is restoring the VLAN state via stmmac_restore_hw_vlan_rx_fltr(), but that is incomplete: the VLAN hash table and the VLAN_TAG control bits are not restored.
Therefore, add stmmac_vlan_restore(), which restores the full VLAN state by updating both the HW filter entries and the hash table, and call it from both the open and resume paths.
The VLAN restore is moved outside of phylink_rx_clk_stop_block/unblock in the resume path because receive clock stop is already disabled when stmmac supports VLAN.
Also, remove the hash readback code in vlan_restore_hw_rx_fltr() that attempts to restore VTHM by reading VLAN_HASH_TABLE, as it always reads zero after DMA reset, making it dead code.
--- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 24 +++++++++++++++++-- .../net/ethernet/stmicro/stmmac/stmmac_vlan.c | 10 -------- 2 files changed, 22 insertions(+), 12 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +22 -2
@@ -140,6 +140,7 @@ static void stmmac_tx_timer_arm(struct stmmac_priv *priv, u32 queue);static void stmmac_flush_tx_descriptors (struct stmmac_priv *priv,int queue);static void stmmac_set_dma_operation_mode (struct stmmac_priv *priv,u32 txmode,u32 rxmode,u32 chan); +static int stmmac_vlan_restore (struct stmmac_priv *priv);#ifdef CONFIG_DEBUG_FS static const struct net_device_ops stmmac_netdev_ops;
@@ -4064,6 +4065,8 @@ static int __stmmac_open(struct net_device *dev,phylink_start (priv->phylink); +stmmac_vlan_restore (priv); + ret =stmmac_request_irq (dev);if (ret) goto irq_error;
@@ -6805,6 +6808,23 @@ static int stmmac_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vireturn ret; } +static int stmmac_vlan_restore (struct stmmac_priv *priv) +{ +int ret; + +if (!(priv->dev->features &NETIF_F_VLAN_FEATURES )) +return 0 ; + +if (priv->hw->num_vlan) +stmmac_restore_hw_vlan_rx_fltr (priv, priv->dev, priv->hw); + + ret =stmmac_vlan_update (priv, priv->num_double_vlans); +if (ret) +netdev_err (priv->dev,"Failed to restore VLANs\n" ); + +return ret; +} +static int stmmac_bpf (struct net_device *dev,struct netdev_bpf *bpf) {struct stmmac_priv *priv =netdev_priv (dev);
@@ -8197,10 +8217,10 @@ int stmmac_resume(struct device *dev)stmmac_init_coalesce (priv);phylink_rx_clk_stop_block (priv->phylink);stmmac_set_rx_mode (ndev); - -stmmac_restore_hw_vlan_rx_fltr (priv, ndev, priv->hw);phylink_rx_clk_stop_unblock (priv->phylink); +stmmac_vlan_restore (priv); +stmmac_enable_all_queues (priv);stmmac_enable_all_dma_irq (priv);
drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c +0 -10
@@ -139,9 +139,6 @@ static int vlan_del_hw_rx_fltr(struct net_device *dev,static void vlan_restore_hw_rx_fltr (struct net_device *dev,struct mac_device_info *hw) { -void __iomem *ioaddr = hw->pcsr; -u32 value; -u32 hash;u32 val;int i;
@@ -158,13 +155,6 @@ static void vlan_restore_hw_rx_fltr(struct net_device *dev,vlan_write_filter (dev, hw, i, val); } } - - hash =readl (ioaddr +VLAN_HASH_TABLE ); -if (hash &VLAN_VLHT ) { - value =readl (ioaddr +VLAN_TAG ); - value |=VLAN_VTHM ; -writel (value, ioaddr +VLAN_TAG ); - } } static void vlan_update_hash(struct mac_device_info *hw, u32 hash,
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 285/311 net: stmmac: Defer VLAN HW configuration when interface is down
In reply to Sasha LevinFrom: Ovidiu Panait <[email protected]>
[ Upstream commit 2cd70e3968f505996d5fefdf7ca684f0f4575734 ]
VLAN register accesses on the MAC side require the PHY RX clock to be active. When the network interface is down, the PHY is suspended and the RX clock is unavailable, causing VLAN operations to fail with timeouts.
The VLAN core automatically removes VID 0 after the interface goes down and re-adds it when it comes back up, so these timeouts happen during normal interface down/up:
# ip link set end1 down
renesas-gbeth 15c40000.ethernet end1: Timeout accessing MAC_VLAN_Tag_Filter
renesas-gbeth 15c40000.ethernet end1: failed to kill vid 0081/0Adding VLANs while the interface is down also fails:
# ip link add link end1 name end1.10 type vlan id 10
renesas-gbeth 15c40000.ethernet end1: Timeout accessing MAC_VLAN_Tag_Filter
RTNETLINK answers: Device or resource busyTo fix this, check if the interface is up before accessing VLAN registers. The software state is always kept up to date regardless of interface state.
When the interface is brought up, stmmac_vlan_restore() is called to write the VLAN state to hardware.
--- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ++ .../net/ethernet/stmicro/stmmac/stmmac_vlan.c | 42 ++++++++++--------- 2 files changed, 26 insertions(+), 19 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +3 -0
@@ -6721,6 +6721,9 @@ static int stmmac_vlan_update(struct stmmac_priv *priv, bool is_double) hash =0 ; } +if (!netif_running (priv->dev)) +return 0 ; +return stmmac_update_vlan_hash (priv, priv->hw, hash, pmatch, is_double); }
drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c +23 -19
83 lines not on this page · raw message
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 286/311 block: use trylock to avoid lockdep circular dependency in sysfs
In reply to Sasha LevinFrom: Ming Lei <[email protected]>
[ Upstream commit ce8ee8583ed83122405eabaa8fb351be4d9dc65c ]
Use trylock instead of blocking lock acquisition for update_nr_hwq_lock in queue_requests_store() and elv_iosched_store() to avoid circular lock dependency with kernfs active reference during concurrent disk deletion:
update_nr_hwq_lock -> kn->active (via del_gendisk -> kobject_del) kn->active -> update_nr_hwq_lock (via sysfs write path)
Return -EBUSY when the lock is not immediately available.
--- block/blk-sysfs.c | 8 +++++++- block/elevator.c | 12 +++++++++++- 2 files changed, 18 insertions(+), 2 deletions(-)
block/blk-sysfs.c +7 -1
@@ -78,8 +78,14 @@ queue_requests_store(struct gendisk *disk, const char *page, size_t count)/* * Serialize updating nr_requests with concurrent queue_requests_store() * and switching elevator. +* +* Use trylock to avoid circular lock dependency with kernfs active +* reference during concurrent disk deletion: +* update_nr_hwq_lock -> kn->active (via del_gendisk -> kobject_del) +* kn->active -> update_nr_hwq_lock (via this sysfs write path) */ -down_write (&set->update_nr_hwq_lock); +if (!down_write_trylock (&set->update_nr_hwq_lock)) +return -EBUSY ;if (nr == q->nr_requests) goto unlock;
block/elevator.c +11 -1
@@ -806,7 +806,16 @@ ssize_t elv_iosched_store(struct gendisk *disk, const char *buf,elv_iosched_load_module (ctx.name); ctx.type =elevator_find_get (ctx.name); -down_read (&set->update_nr_hwq_lock); +/* +* Use trylock to avoid circular lock dependency with kernfs active +* reference during concurrent disk deletion: +* update_nr_hwq_lock -> kn->active (via del_gendisk -> kobject_del) +* kn->active -> update_nr_hwq_lock (via this sysfs write path) +*/ +if (!down_read_trylock (&set->update_nr_hwq_lock)) { + ret = -EBUSY ; + goto out; + }if (!blk_queue_no_elv_switch (q)) { ret =elevator_change (q, &ctx);if (!ret)
@@ -816,6 +825,7 @@ ssize_t elv_iosched_store(struct gendisk *disk, const char *buf, }up_read (&set->update_nr_hwq_lock); +out:if (ctx.type)elevator_put (ctx.type);return ret;
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 287/311 net: Provide a PREEMPT_RT specific check for netdev_queue::_xmit_lock
In reply to Sasha LevinFrom: Sebastian Andrzej Siewior <[email protected]>
[ Upstream commit b824c3e16c1904bf80df489e293d1e3cbf98896d ]
After acquiring netdev_queue::_xmit_lock the number of the CPU owning the lock is recorded in netdev_queue::xmit_lock_owner. This works as long as the BH context is not preemptible.
On PREEMPT_RT the softirq context is preemptible and without the softirq-lock it is possible to have multiple user in __dev_queue_xmit() submitting a skb on the same CPU. This is fine in general but this means also that the current CPU is recorded as netdev_queue::xmit_lock_owner. This in turn leads to the recursion alert and the skb is dropped.
Instead checking the for CPU number, that owns the lock, PREEMPT_RT can check if the lockowner matches the current task.
Add netif_tx_owned() which returns true if the current context owns the lock by comparing the provided CPU number with the recorded number. This resembles the current check by negating the condition (the current check returns true if the lock is not owned).
On PREEMPT_RT use rt_mutex_owner() to return the lock owner and compare the current task against it.
Use the new helper in __dev_queue_xmit() and netif_local_xmit_active() which provides a similar check.
Update comments regarding pairing READ_ONCE().
--- include/linux/netdevice.h | 27 ++++++++++++++++++++++----- net/core/dev.c | 5 +---- net/core/netpoll.c | 2 +- 3 files changed, 24 insertions(+), 10 deletions(-)
include/linux/netdevice.h +22 -5
@@ -4708,7 +4708,7 @@ static inline u32 netif_msg_init(int debug_value, int default_msg_enable_bits)static inline void __netif_tx_lock (struct netdev_queue *txq,int cpu) {spin_lock (&txq->_xmit_lock); -/* Pairs with READ_ONCE() in __dev_queue_xmit() */ +/* Pairs with READ_ONCE() in netif_tx_owned() */ WRITE_ONCE (txq->xmit_lock_owner, cpu); }
@@ -4726,7 +4726,7 @@ static inline void __netif_tx_release(struct netdev_queue *txq)static inline void __netif_tx_lock_bh (struct netdev_queue *txq) {spin_lock_bh (&txq->_xmit_lock); -/* Pairs with READ_ONCE() in __dev_queue_xmit() */ +/* Pairs with READ_ONCE() in netif_tx_owned() */ WRITE_ONCE (txq->xmit_lock_owner,smp_processor_id ()); }
@@ -4735,7 +4735,7 @@ static inline bool __netif_tx_trylock(struct netdev_queue *txq)bool ok =spin_trylock (&txq->_xmit_lock);if (likely (ok)) { -/* Pairs with READ_ONCE() in __dev_queue_xmit() */ +/* Pairs with READ_ONCE() in netif_tx_owned() */ WRITE_ONCE (txq->xmit_lock_owner,smp_processor_id ()); }return ok;
@@ -4743,14 +4743,14 @@ static inline bool __netif_tx_trylock(struct netdev_queue *txq)static inline void __netif_tx_unlock (struct netdev_queue *txq) { -/* Pairs with READ_ONCE() in __dev_queue_xmit() */ +/* Pairs with READ_ONCE() in netif_tx_owned() */ WRITE_ONCE (txq->xmit_lock_owner,-1 );spin_unlock (&txq->_xmit_lock); }static inline void __netif_tx_unlock_bh (struct netdev_queue *txq) { -/* Pairs with READ_ONCE() in __dev_queue_xmit() */ +/* Pairs with READ_ONCE() in netif_tx_owned() */ WRITE_ONCE (txq->xmit_lock_owner,-1 );spin_unlock_bh (&txq->_xmit_lock); }
@@ -4843,6 +4843,23 @@ static inline void netif_tx_disable(struct net_device *dev)local_bh_enable (); } +#ifndef CONFIG_PREEMPT_RT +static inline bool netif_tx_owned (struct netdev_queue *txq,unsigned int cpu) +{ +/* Other cpus might concurrently change txq->xmit_lock_owner +* to -1 or to their cpu id, but not to our id. +*/ +return READ_ONCE (txq->xmit_lock_owner) == cpu; +} + +#else +static inline bool netif_tx_owned (struct netdev_queue *txq,unsigned int cpu) +{ +return rt_mutex_owner (&txq->_xmit_lock.lock) == current; +} + +#endif +static inline void netif_addr_lock (struct net_device *dev) {unsigned char nest_level =0 ;
net/core/dev.c +1 -4
@@ -4814,10 +4814,7 @@ int __dev_queue_xmit(struct sk_buff *skb, struct net_device *sb_dev)if (dev->flags &IFF_UP ) {int cpu =smp_processor_id ();/* ok because BHs are off */ -/* Other cpus might concurrently change txq->xmit_lock_owner -* to -1 or to their cpu id, but not to our id. -*/ -if (READ_ONCE (txq->xmit_lock_owner) != cpu) { +if (!netif_tx_owned (txq, cpu)) {bool is_list = false;if (dev_xmit_recursion ())
net/core/netpoll.c +1 -1
@@ -132,7 +132,7 @@ static int netif_local_xmit_active(struct net_device *dev)for (i =0 ; i < dev->num_tx_queues; i++) {struct netdev_queue *txq =netdev_get_tx_queue (dev, i); -if (READ_ONCE (txq->xmit_lock_owner) ==smp_processor_id ()) +if (netif_tx_owned (txq,smp_processor_id ()))return 1 ; }
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 288/311 netfilter: nf_tables: unconditionally bump set->nelems before insertion
In reply to Sasha LevinFrom: Pablo Neira Ayuso <[email protected]>
[ Upstream commit def602e498a4f951da95c95b1b8ce8ae68aa733a ]
In case that the set is full, a new element gets published then removed without waiting for the RCU grace period, while RCU reader can be walking over it already.
To address this issue, add the element transaction even if set is full, but toggle the set_full flag to report -ENFILE so the abort path safely unwinds the set to its previous state.
As for element updates, decrement set->nelems to restore it.
A simpler fix is to call synchronize_rcu() in the error path. However, with a large batch adding elements to already maxed-out set, this could cause noticeable slowdown of such batches.
--- net/netfilter/nf_tables_api.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-)
net/netfilter/nf_tables_api.c +16 -14
@@ -7169,6 +7169,7 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set,struct nft_data_desc desc;enum nft_registers dreg;struct nft_trans *trans; +bool set_full = false;u64 expiration;u64 timeout;int err, i;
@@ -7455,10 +7456,18 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set,if (err <0 ) goto err_elem_free; +if (!(flags &NFT_SET_ELEM_CATCHALL )) { +unsigned int max =nft_set_maxsize (set), nelems; + + nelems =atomic_inc_return (&set->nelems); +if (nelems > max) + set_full = true; + } + trans =nft_trans_elem_alloc (ctx,NFT_MSG_NEWSETELEM , set);if (trans ==NULL ) { err = -ENOMEM ; - goto err_elem_free; + goto err_set_size; } ext->genmask =nft_genmask_cur (ctx->net);
@@ -7510,7 +7519,7 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set, ue->priv = elem_priv;nft_trans_commit_list_add_elem (ctx->net, trans); - goto err_elem_free; + goto err_set_size; } } }
@@ -7528,23 +7537,16 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set, goto err_element_clash; } -if (!(flags &NFT_SET_ELEM_CATCHALL )) { -unsigned int max =nft_set_maxsize (set); - -if (!atomic_add_unless (&set->nelems,1 , max)) { - err = -ENFILE ; - goto err_set_full; - } - } -nft_trans_container_elem (trans)->elems[0 ].priv = elem.priv;nft_trans_commit_list_add_elem (ctx->net, trans); -return 0 ; -err_set_full: -nft_setelem_remove (ctx->net, set, elem.priv); +return set_full ? -ENFILE :0 ; + err_element_clash:kfree (trans); +err_set_size: +if (!(flags &NFT_SET_ELEM_CATCHALL )) +atomic_dec (&set->nelems); err_elem_free:nf_tables_set_elem_destroy (ctx, set, elem.priv); err_parse_data:
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 289/311 netfilter: nf_tables: clone set on flush only
In reply to Sasha LevinFrom: Pablo Neira Ayuso <[email protected]>
[ Upstream commit fb7fb4016300ac622c964069e286dc83166a5d52 ]
Syzbot with fault injection triggered a failing memory allocation with GFP_KERNEL which results in a WARN splat:
iter.err
WARNING: net/netfilter/nf_tables_api.c:845 at nft_map_deactivate+0x34e/0x3c0 net/netfilter/nf_tables_api.c:845, CPU#0: syz.0.17/5992 Modules linked in: CPU: 0 UID: 0 PID: 5992 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026 RIP: 0010:nft_map_deactivate+0x34e/0x3c0 net/netfilter/nf_tables_api.c:845 Code: 8b 05 86 5a 4e 09 48 3b 84 24 a0 00 00 00 75 62 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc cc e8 63 6d fa f7 90 <0f> 0b 90 43 +80 7c 35 00 00 0f 85 23 fe ff ff e9 26 fe ff ff 89 d9 RSP: 0018:ffffc900045af780 EFLAGS: 00010293 RAX: ffffffff89ca45bd RBX: 00000000fffffff4 RCX: ffff888028111e40 RDX: 0000000000000000 RSI: 00000000fffffff4 RDI: 0000000000000000 RBP: ffffc900045af870 R08: 0000000000400dc0 R09: 00000000ffffffff R10: dffffc0000000000 R11: fffffbfff1d141db R12: ffffc900045af7e0 R13: 1ffff920008b5f24 R14: dffffc0000000000 R15: ffffc900045af920 FS: 000055557a6a5500(0000) GS:ffff888125496000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fb5ea271fc0 CR3: 000000003269e000 CR4: 00000000003526f0 Call Trace: <TASK> __nft_release_table+0xceb/0x11f0 net/netfilter/nf_tables_api.c:12115 nft_rcv_nl_event+0xc25/0xdb0 net/netfilter/nf_tables_api.c:12187 notifier_call_chain+0x19d/0x3a0 kernel/notifier.c:85 blocking_notifier_call_chain+0x6a/0x90 kernel/notifier.c:380 netlink_release+0x123b/0x1ad0 net/netlink/af_netlink.c:761 __sock_release net/socket.c:662 [inline] sock_close+0xc3/0x240 net/socket.c:1455
Restrict set clone to the flush set command in the preparation phase. Add NFT_ITER_UPDATE_CLONE and use it for this purpose, update the rbtree and pipapo backends to only clone the set when this iteration type is used.
As for the existing NFT_ITER_UPDATE type, update the pipapo backend to use the existing set clone if available, otherwise use the existing set representation. After this update, there is no need to clone a set that is being deleted, this includes bound anonymous set.
An alternative approach to NFT_ITER_UPDATE_CLONE is to add a .clone interface and call it from the flush set path.
--- include/net/netfilter/nf_tables.h | 2 ++ net/netfilter/nf_tables_api.c | 10 +++++++++- net/netfilter/nft_set_hash.c | 1 + net/netfilter/nft_set_pipapo.c | 11 +++++++++-- net/netfilter/nft_set_rbtree.c | 8 +++++--- 5 files changed, 26 insertions(+), 6 deletions(-)
include/net/netfilter/nf_tables.h +2 -0
@@ -317,11 +317,13 @@ static inline void *nft_elem_priv_cast(const struct nft_elem_priv *priv)* @NFT_ITER_UNSPEC: unspecified, to catch errors * @NFT_ITER_READ: read-only iteration over set elements * @NFT_ITER_UPDATE: iteration under mutex to update set element state +* @NFT_ITER_UPDATE_CLONE: clone set before iteration under mutex to update element */ enum nft_iter_type {NFT_ITER_UNSPEC ,NFT_ITER_READ ,NFT_ITER_UPDATE , +NFT_ITER_UPDATE_CLONE , };struct nft_set ;
net/netfilter/nf_tables_api.c +9 -1
@@ -832,6 +832,11 @@ static void nft_map_catchall_deactivate(const struct nft_ctx *ctx, } } +/* Use NFT_ITER_UPDATE iterator even if this may be called from the preparation +* phase, the set clone might already exist from a previous command, or it might +* be a set that is going away and does not require a clone. The netns and +* netlink release paths also need to work on the live set. +*/ static void nft_map_deactivate (const struct nft_ctx *ctx,struct nft_set *set) {struct nft_set_iter iter = {
@@ -7891,9 +7896,12 @@ static int nft_set_catchall_flush(const struct nft_ctx *ctx,static int nft_set_flush (struct nft_ctx *ctx,struct nft_set *set,u8 genmask) { +/* The set backend might need to clone the set, do it now from the +* preparation phase, use NFT_ITER_UPDATE_CLONE iterator type. +*/ struct nft_set_iter iter = { .genmask = genmask, - .type =NFT_ITER_UPDATE , + .type =NFT_ITER_UPDATE_CLONE , .fn = nft_setelem_flush, };
net/netfilter/nft_set_hash.c +1 -0
@@ -374,6 +374,7 @@ static void nft_rhash_walk(const struct nft_ctx *ctx, struct nft_set *set, {switch (iter->type) {case NFT_ITER_UPDATE : +case NFT_ITER_UPDATE_CLONE :/* only relevant for netlink dumps which use READ type */ WARN_ON_ONCE (iter->skip !=0 );
net/netfilter/nft_set_pipapo.c +9 -2
@@ -2145,13 +2145,20 @@ static void nft_pipapo_walk(const struct nft_ctx *ctx, struct nft_set *set,const struct nft_pipapo_match *m;switch (iter->type) { -case NFT_ITER_UPDATE : +case NFT_ITER_UPDATE_CLONE : m =pipapo_maybe_clone (set);if (!m) { iter->err = -ENOMEM ;return ; } - +nft_pipapo_do_walk (ctx, set, m, iter); +break ; +case NFT_ITER_UPDATE : +if (priv->clone) + m = priv->clone; +else + m =rcu_dereference_protected (priv->match, +nft_pipapo_transaction_mutex_held (set));nft_pipapo_do_walk (ctx, set, m, iter);break ;case NFT_ITER_READ :
net/netfilter/nft_set_rbtree.c +5 -3
@@ -810,13 +810,15 @@ static void nft_rbtree_walk(const struct nft_ctx *ctx,struct nft_rbtree *priv =nft_set_priv (set);switch (iter->type) { -case NFT_ITER_UPDATE : -lockdep_assert_held (&nft_pernet (ctx->net)->commit_mutex); - +case NFT_ITER_UPDATE_CLONE :if (nft_array_may_resize (set) <0 ) { iter->err = -ENOMEM ;break ; } + fallthrough; +case NFT_ITER_UPDATE : +lockdep_assert_held (&nft_pernet (ctx->net)->commit_mutex); +nft_rbtree_do_walk (ctx, set, iter);break ;case NFT_ITER_READ :
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 290/311 netfilter: nft_set_pipapo: split gc into unlink and reclaim phase
In reply to Sasha LevinFrom: Florian Westphal <[email protected]>
[ Upstream commit 9df95785d3d8302f7c066050117b04cd3c2048c2 ]
Yiming Qian reports Use-after-free in the pipapo set type:
Under a large number of expired elements, commit-time GC can run for a very long time in a non-preemptible context, triggering soft lockup warnings and RCU stall reports (local denial of service).
We must split GC in an unlink and a reclaim phase.
We cannot queue elements for freeing until pointers have been swapped. Expired elements are still exposed to both the packet path and userspace dumpers via the live copy of the data structure.
call_rcu() does not protect us: dump operations or element lookups starting after call_rcu has fired can still observe the free'd element, unless the commit phase has made enough progress to swap the clone and live pointers before any new reader has picked up the old version.
This a similar approach as done recently for the rbtree backend in commit 35f83a75529a ("netfilter: nft_set_rbtree: don't gc elements on insert").
--- include/net/netfilter/nf_tables.h | 5 +++ net/netfilter/nf_tables_api.c | 5 --- net/netfilter/nft_set_pipapo.c | 51 ++++++++++++++++++++++++++----- net/netfilter/nft_set_pipapo.h | 2 ++ 4 files changed, 50 insertions(+), 13 deletions(-)
include/net/netfilter/nf_tables.h +5 -0
@@ -1860,6 +1860,11 @@ struct nft_trans_gc {struct rcu_head rcu; }; +static inline int nft_trans_gc_space (const struct nft_trans_gc *trans) +{ +return NFT_TRANS_GC_BATCHCOUNT - trans->count; +} +static inline void nft_ctx_update (struct nft_ctx *ctx,const struct nft_trans *trans) {
net/netfilter/nf_tables_api.c +0 -5
@@ -10480,11 +10480,6 @@ static void nft_trans_gc_queue_work(struct nft_trans_gc *trans)schedule_work (&trans_gc_work); } -static int nft_trans_gc_space (struct nft_trans_gc *trans) -{ -return NFT_TRANS_GC_BATCHCOUNT - trans->count; -} -struct nft_trans_gc *nft_trans_gc_queue_async (struct nft_trans_gc *gc,unsigned int gc_seq,gfp_t gfp) {
net/netfilter/nft_set_pipapo.c +43 -8
110 lines not on this page · raw message
net/netfilter/nft_set_pipapo.h +2 -0
@@ -156,12 +156,14 @@ struct nft_pipapo_match {* @clone: Copy where pending insertions and deletions are kept * @width: Total bytes to be matched for one packet, including padding * @last_gc: Timestamp of last garbage collection run, jiffies +* @gc_head: list of nft_trans_gc to queue up for mem reclaim */ struct nft_pipapo {struct nft_pipapo_match __rcu *match;struct nft_pipapo_match *clone;int width;unsigned long last_gc; +struct list_head gc_head; };struct nft_pipapo_elem ;
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 291/311 net: ethernet: mtk_eth_soc: Reset prog ptr to old_prog in case of error in mtk_xdp_setup()
In reply to Sasha LevinFrom: Lorenzo Bianconi <[email protected]>
[ Upstream commit 0abc73c8a40fd64ac1739c90bb4f42c418d27a5e ]
Reset eBPF program pointer to old_prog and do not decrease its ref-count if mtk_open routine in mtk_xdp_setup() fails.
--- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
drivers/net/ethernet/mediatek/mtk_eth_soc.c +12 -3
@@ -3749,12 +3749,21 @@ static int mtk_xdp_setup(struct net_device *dev, struct bpf_prog *prog,mtk_stop (dev); old_prog =rcu_replace_pointer (eth->prog, prog,lockdep_rtnl_is_held ()); + +if (netif_running (dev) && need_update) { +int err; + + err =mtk_open (dev); +if (err) { +rcu_assign_pointer (eth->prog, old_prog); + +return err; + } + } +if (old_prog)bpf_prog_put (old_prog); -if (netif_running (dev) && need_update) -return mtk_open (dev); -return 0 ; }
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 292/311 selftests/harness: order TEST_F and XFAIL_ADD constructors
In reply to Sasha LevinFrom: Sun Jian <[email protected]>
[ Upstream commit 6be2681514261324c8ee8a1c6f76cefdf700220f ]
TEST_F() allocates and registers its struct __test_metadata via mmap() inside its constructor, and only then assigns the _##fixture_##test##_object pointer.
XFAIL_ADD() runs in a constructor too and reads _##fixture_##test##_object to initialize xfail->test. If XFAIL_ADD runs first, xfail->test can be NULL and the expected failure will be reported as FAIL.
Use constructor priorities to ensure TEST_F registration runs before XFAIL_ADD, without adding extra state or runtime lookups.
--- tools/testing/selftests/kselftest_harness.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
tools/testing/selftests/kselftest_harness.h +5 -2
@@ -76,6 +76,9 @@ static inline void __kselftest_memset_safe(void *s, int c, size_t n)memset (s, c, n); } +#define KSELFTEST_PRIO_TEST_F 20000 +#define KSELFTEST_PRIO_XFAIL 20001 +#define TEST_TIMEOUT_DEFAULT 30/* Utilities exposed to the test definitions */
@@ -465,7 +468,7 @@ static inline void __kselftest_memset_safe(void *s, int c, size_t n) fixture_name##_teardown(_metadata, self, variant); \ } \ static struct __test_metadata *_##fixture_name##_##test_name##_object; \ - static void __attribute__((constructor)) \ + static void __attribute__((constructor(KSELFTEST_PRIO_TEST_F))) \ _register_##fixture_name##_##test_name(void) \ { \ struct __test_metadata *object = mmap(NULL, sizeof(*object), \
@@ -880,7 +883,7 @@ struct __test_xfail { .fixture = &_##fixture_name##_fixture_object, \ .variant = &_##fixture_name##_##variant_name##_object, \ }; \ - static void __attribute__((constructor)) \ + static void __attribute__((constructor(KSELFTEST_PRIO_XFAIL))) \ _register_##fixture_name##_##variant_name##_##test_name##_xfail(void) \ { \ _##fixture_name##_##variant_name##_##test_name##_xfail.test = \
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 293/311 net: bridge: fix nd_tbl NULL dereference when IPv6 is disabled
In reply to Sasha LevinFrom: Fernando Fernandez Mancera <[email protected]>
[ Upstream commit e5e890630533bdc15b26a34bb8e7ef539bdf1322 ]
When booting with the 'ipv6.disable=1' parameter, the nd_tbl is never initialized because inet6_init() exits before ndisc_init() is called which initializes it. Then, if neigh_suppress is enabled and an ICMPv6 Neighbor Discovery packet reaches the bridge, br_do_suppress_nd() will dereference ipv6_stub->nd_tbl which is NULL, passing it to neigh_lookup(). This causes a kernel NULL pointer dereference.
BUG: kernel NULL pointer dereference, address: 0000000000000268 Oops: 0000 [#1] PREEMPT SMP NOPTI [...] RIP: 0010:neigh_lookup+0x16/0xe0 [...] Call Trace: <IRQ> ? neigh_lookup+0x16/0xe0 br_do_suppress_nd+0x160/0x290 [bridge] br_handle_frame_finish+0x500/0x620 [bridge] br_handle_frame+0x353/0x440 [bridge] __netif_receive_skb_core.constprop.0+0x298/0x1110 __netif_receive_skb_one_core+0x3d/0xa0 process_backlog+0xa0/0x140 __napi_poll+0x2c/0x170 net_rx_action+0x2c4/0x3a0 handle_softirqs+0xd0/0x270 do_softirq+0x3f/0x60
Fix this by replacing IS_ENABLED(IPV6) call with ipv6_mod_enabled() in the callers. This is in essence disabling NS/NA suppression when IPv6 is disabled.
--- net/bridge/br_device.c | 2 +- net/bridge/br_input.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
net/bridge/br_device.c +1 -1
@@ -74,7 +74,7 @@ netdev_tx_t br_dev_xmit(struct sk_buff *skb, struct net_device *dev) eth_hdr(skb)->h_proto == htons(ETH_P_RARP)) && br_opt_get(br, BROPT_NEIGH_SUPPRESS_ENABLED)) {br_do_proxy_suppress_arp (skb, br, vid,NULL ); - } else if (IS_ENABLED(CONFIG_IPV6) && + } else if (ipv6_mod_enabled() && skb->protocol == htons(ETH_P_IPV6) && br_opt_get(br, BROPT_NEIGH_SUPPRESS_ENABLED) && pskb_may_pull(skb, sizeof(struct ipv6hdr) +
net/bridge/br_input.c +1 -1
@@ -170,7 +170,7 @@ int br_handle_frame_finish(struct net *net, struct sock *sk, struct sk_buff *skb (skb->protocol == htons(ETH_P_ARP) || skb->protocol == htons(ETH_P_RARP))) {br_do_proxy_suppress_arp (skb, br, vid, p); - } else if (IS_ENABLED(CONFIG_IPV6) && + } else if (ipv6_mod_enabled() && skb->protocol == htons(ETH_P_IPV6) && br_opt_get(br, BROPT_NEIGH_SUPPRESS_ENABLED) && pskb_may_pull(skb, sizeof(struct ipv6hdr) +
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 294/311 net: vxlan: fix nd_tbl NULL dereference when IPv6 is disabled
In reply to Sasha LevinFrom: Fernando Fernandez Mancera <[email protected]>
[ Upstream commit 168ff39e4758897d2eee4756977d036d52884c7e ]
When booting with the 'ipv6.disable=1' parameter, the nd_tbl is never initialized because inet6_init() exits before ndisc_init() is called which initializes it. If an IPv6 packet is injected into the interface, route_shortcircuit() is called and a NULL pointer dereference happens on neigh_lookup().
BUG: kernel NULL pointer dereference, address: 0000000000000380 Oops: Oops: 0000 [#1] SMP NOPTI [...] RIP: 0010:neigh_lookup+0x20/0x270 [...] Call Trace: <TASK> vxlan_xmit+0x638/0x1ef0 [vxlan] dev_hard_start_xmit+0x9e/0x2e0 __dev_queue_xmit+0xbee/0x14e0 packet_sendmsg+0x116f/0x1930 __sys_sendto+0x1f5/0x200 __x64_sys_sendto+0x24/0x30 do_syscall_64+0x12f/0x1590 entry_SYSCALL_64_after_hwframe+0x76/0x7e
Fix this by adding an early check on route_shortcircuit() when protocol is ETH_P_IPV6. Note that ipv6_mod_enabled() cannot be used here because VXLAN can be built-in even when IPv6 is built as a module.
--- drivers/net/vxlan/vxlan_core.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/vxlan/vxlan_core.c +5 -0
@@ -2130,6 +2130,11 @@ static bool route_shortcircuit(struct net_device *dev, struct sk_buff *skb) {struct ipv6hdr *pip6; +/* check if nd_tbl is not initiliazed due to +* ipv6.disable=1 set during boot +*/ +if (!ipv6_stub->nd_tbl) +return false;if (!pskb_may_pull (skb,sizeof (struct ipv6hdr )))return false; pip6 =ipv6_hdr (skb);
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 295/311 net: ipv6: fix panic when IPv4 route references loopback IPv6 nexthop
In reply to Sasha LevinFrom: Jiayuan Chen <[email protected]>
[ Upstream commit 21ec92774d1536f71bdc90b0e3d052eff99cf093 ]
When a standalone IPv6 nexthop object is created with a loopback device (e.g., "ip -6 nexthop add id 100 dev lo"), fib6_nh_init() misclassifies it as a reject route. This is because nexthop objects have no destination prefix (fc_dst=::), causing fib6_is_reject() to match any loopback nexthop. The reject path skips fib_nh_common_init(), leaving nhc_pcpu_rth_output unallocated. If an IPv4 route later references this nexthop, __mkroute_output() dereferences NULL nhc_pcpu_rth_output and panics.
Simplify the check in fib6_nh_init() to only match explicit reject routes (RTF_REJECT) instead of using fib6_is_reject(). The loopback promotion heuristic in fib6_is_reject() is handled separately by ip6_route_info_create_nh(). After this change, the three cases behave as follows:
1. Explicit reject route ("ip -6 route add unreachable 2001:db8::/64"):
RTF_REJECT is set, enters reject path, skips fib_nh_common_init(). No behavior change.
2. Implicit loopback reject route ("ip -6 route add 2001:db8::/32 dev lo"):
RTF_REJECT is not set, takes normal path, fib_nh_common_init() is called. ip6_route_info_create_nh() still promotes it to reject afterward. nhc_pcpu_rth_output is allocated but unused, which is harmless.
3. Standalone nexthop object ("ip -6 nexthop add id 100 dev lo"):
RTF_REJECT is not set, takes normal path, fib_nh_common_init() is called. nhc_pcpu_rth_output is properly allocated, fixing the crash when IPv4 routes reference this nexthop.
--- net/ipv6/route.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
net/ipv6/route.c +3 -5
@@ -3584,7 +3584,6 @@ int fib6_nh_init(struct net *net, struct fib6_nh *fib6_nh,netdevice_tracker *dev_tracker = &fib6_nh->fib_nh_dev_tracker;struct net_device *dev =NULL ;struct inet6_dev *idev =NULL ; -int addr_type;int err; fib6_nh->fib_nh_family =AF_INET6 ;
@@ -3626,11 +3625,10 @@ int fib6_nh_init(struct net *net, struct fib6_nh *fib6_nh, fib6_nh->fib_nh_weight =1 ; -/* We cannot add true routes via loopback here, -* they would result in kernel looping; promote them to reject routes +/* Reset the nexthop device to the loopback device in case of reject +* routes. */ - addr_type =ipv6_addr_type (&cfg->fc_dst); -if (fib6_is_reject (cfg->fc_flags, dev, addr_type)) { +if (cfg->fc_flags &RTF_REJECT ) {/* hold loopback dev/idev if we haven't done so. */ if (dev != net->loopback_dev) {if (dev) {
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 296/311 net/sched: act_ife: Fix metalist update behavior
In reply to Sasha LevinFrom: Jamal Hadi Salim <[email protected]>
[ Upstream commit e2cedd400c3ec0302ffca2490e8751772906ac23 ]
Whenever an ife action replace changes the metalist, instead of replacing the old data on the metalist, the current ife code is appending the new metadata. Aside from being innapropriate behavior, this may lead to an unbounded addition of metadata to the metalist which might cause an out of bounds error when running the encode op:
[ 138.423369][ C1] ================================================================== [ 138.424317][ C1] BUG: KASAN: slab-out-of-bounds in ife_tlv_meta_encode (net/ife/ife.c:168) [ 138.424906][ C1] Write of size 4 at addr ffff8880077f4ffe by task ife_out_out_bou/255 [ 138.425778][ C1] CPU: 1 UID: 0 PID: 255 Comm: ife_out_out_bou Not tainted 7.0.0-rc1-00169-gfbdfa8da05b6 #624 PREEMPT(full) [ 138.425795][ C1] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 138.425800][ C1] Call Trace: [ 138.425804][ C1] <IRQ> [ 138.425808][ C1] dump_stack_lvl (lib/dump_stack.c:122) [ 138.425828][ C1] print_report (mm/kasan/report.c:379 mm/kasan/report.c:482) [ 138.425839][ C1] ? srso_alias_return_thunk (arch/x86/lib/retpoline.S:221) [ 138.425844][ C1] ? __virt_addr_valid (./arch/x86/include/asm/preempt.h:95 (discriminator 1) ./include/linux/rcupdate.h:975 (discriminator 1) ./include/linux/mmzone.h:2207 (discriminator 1) arch/x86/mm/physaddr.c:54 (discriminator 1)) [ 138.425853][ C1] ? ife_tlv_meta_encode (net/ife/ife.c:168) [ 138.425859][ C1] kasan_report (mm/kasan/report.c:221 mm/kasan/report.c:597) [ 138.425868][ C1] ? ife_tlv_meta_encode (net/ife/ife.c:168) [ 138.425878][ C1] kasan_check_range (mm/kasan/generic.c:186 (discriminator 1) mm/kasan/generic.c:200 (discriminator 1)) [ 138.425884][ C1] __asan_memset (mm/kasan/shadow.c:84 (discriminator 2)) [ 138.425889][ C1] ife_tlv_meta_encode (net/ife/ife.c:168) [ 138.425893][ C1] ? ife_tlv_meta_encode (net/ife/ife.c:171) [ 138.425898][ C1] ? srso_alias_return_thunk (arch/x86/lib/retpoline.S:221) [ 138.425903][ C1] ife_encode_meta_u16 (net/sched/act_ife.c:57) [ 138.425910][ C1] ? __pfx_do_raw_spin_lock (kernel/locking/spinlock_debug.c:114) [ 138.425916][ C1] ? __asan_memcpy (mm/kasan/shadow.c:105 (discriminator 3)) [ 138.425921][ C1] ? __pfx_ife_encode_meta_u16 (net/sched/act_ife.c:45) [ 138.425927][ C1] ? srso_alias_return_thunk (arch/x86/lib/retpoline.S:221) [ 138.425931][ C1] tcf_ife_act (net/sched/act_ife.c:847 net/sched/act_ife.c:879)
To solve this issue, fix the replace behavior by adding the metalist to the ife rcu data structure.
--- include/net/tc_act/tc_ife.h | 4 +- net/sched/act_ife.c | 93 ++++++++++++++++++------------------- 2 files changed, 45 insertions(+), 52 deletions(-)
include/net/tc_act/tc_ife.h +1 -3
@@ -13,15 +13,13 @@ struct tcf_ife_params {u8 eth_src[ETH_ALEN ];u16 eth_type;u16 flags; - +struct list_head metalist;struct rcu_head rcu; };struct tcf_ife_info {struct tc_action common;struct tcf_ife_params __rcu *params; -/* list of metaids allowed */ -struct list_head metalist; };#define to_ife (a) ((struct tcf_ife_info *)a)
net/sched/act_ife.c +44 -49
294 lines not on this page · raw message
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 297/311 xdp: use modulo operation to calculate XDP frag tailroom
In reply to Sasha LevinFrom: Larysa Zaremba <[email protected]>
[ Upstream commit 88b6b7f7b216108a09887b074395fa7b751880b1 ]
The current formula for calculating XDP tailroom in mbuf packets works only if each frag has its own page (if rxq->frag_size is PAGE_SIZE), this defeats the purpose of the parameter overall and without any indication leads to negative calculated tailroom on at least half of frags, if shared pages are used.
There are not many drivers that set rxq->frag_size. Among them:
* i40e and enetc always split page uniformly between frags, use shared pages
* ice uses page_pool frags via libeth, those are power-of-2 and uniformly distributed across page
* idpf has variable frag_size with XDP on, so current API is not applicable
* mlx5, mtk and mvneta use PAGE_SIZE or 0 as frag_size for page_pool
As for AF_XDP ZC, only ice, i40e and idpf declare frag_size for it. Modulo operation yields good results for aligned chunks, they are all power-of-2, between 2K and PAGE_SIZE. Formula without modulo fails when chunk_size is 2K. Buffers in unaligned mode are not distributed uniformly, so modulo operation would not work.
To accommodate unaligned buffers, we could define frag_size as data + tailroom, and hence do not subtract offset when calculating tailroom, but this would necessitate more changes in the drivers.
Define rxq->frag_size as an even portion of a page that fully belongs to a single frag. When calculating tailroom, locate the data start within such portion by performing a modulo operation on page offset.
--- net/core/filter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/core/filter.c +2 -1
@@ -4156,7 +4156,8 @@ static int bpf_xdp_frags_increase_tail(struct xdp_buff *xdp, int offset)if (!rxq->frag_size || rxq->frag_size > xdp->frame_sz)return -EOPNOTSUPP ; - tailroom = rxq->frag_size -skb_frag_size (frag) -skb_frag_off (frag); + tailroom = rxq->frag_size -skb_frag_size (frag) - +skb_frag_off (frag) % rxq->frag_size;if (unlikely (offset > tailroom))return -EINVAL ;
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 298/311 xsk: introduce helper to determine rxq->frag_size
In reply to Sasha LevinFrom: Larysa Zaremba <[email protected]>
[ Upstream commit 16394d80539937d348dd3b9ea32415c54e67a81b ]
rxq->frag_size is basically a step between consecutive strictly aligned frames. In ZC mode, chunk size fits exactly, but if chunks are unaligned, there is no safe way to determine accessible space to grow tailroom.
Report frag_size to be zero, if chunks are unaligned, chunk_size otherwise.
--- include/net/xdp_sock_drv.h | 10 ++++++++++ 1 file changed, 10 insertions(+)
include/net/xdp_sock_drv.h +10 -0
@@ -51,6 +51,11 @@ static inline u32 xsk_pool_get_rx_frame_size(struct xsk_buff_pool *pool)return xsk_pool_get_chunk_size (pool) -xsk_pool_get_headroom (pool); } +static inline u32 xsk_pool_get_rx_frag_step (struct xsk_buff_pool *pool) +{ +return pool->unaligned ?0 :xsk_pool_get_chunk_size (pool); +} +static inline void xsk_pool_set_rxq_info (struct xsk_buff_pool *pool,struct xdp_rxq_info *rxq) {
@@ -337,6 +342,11 @@ static inline u32 xsk_pool_get_rx_frame_size(struct xsk_buff_pool *pool)return 0 ; } +static inline u32 xsk_pool_get_rx_frag_step (struct xsk_buff_pool *pool) +{ +return 0 ; +} +static inline void xsk_pool_set_rxq_info (struct xsk_buff_pool *pool,struct xdp_rxq_info *rxq) {
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 299/311 ice: fix rxq info registering in mbuf packets
In reply to Sasha LevinFrom: Larysa Zaremba <[email protected]>
[ Upstream commit 02852b47c706772af795d3e28fca99fc9b923b2c ]
XDP RxQ info contains frag_size, which depends on the MTU. This makes the old way of registering RxQ info before calculating new buffer sizes invalid. Currently, it leads to frag_size being outdated, making it sometimes impossible to grow tailroom in a mbuf packet. E.g. fragments are actually 3K+, but frag size is still as if MTU was 1500.
Always register new XDP RxQ info after reconfiguring memory pools.
--- drivers/net/ethernet/intel/ice/ice_base.c | 26 ++++++-------------- drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 + drivers/net/ethernet/intel/ice/ice_txrx.c | 4 ++- drivers/net/ethernet/intel/ice/ice_xsk.c | 3 +++ 4 files changed, 14 insertions(+), 20 deletions(-)
drivers/net/ethernet/intel/ice/ice_base.c +7 -19
@@ -666,23 +666,12 @@ static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring)if (ring->vsi->type ==ICE_VSI_PF || ring->vsi->type ==ICE_VSI_SF || ring->vsi->type ==ICE_VSI_LB ) { -if (!xdp_rxq_info_is_reg (&ring->xdp_rxq)) { - err =__xdp_rxq_info_reg (&ring->xdp_rxq, ring->netdev, - ring->q_index, - ring->q_vector->napi.napi_id, - ring->rx_buf_len); -if (err) -return err; - } -ice_rx_xsk_pool (ring); err =ice_realloc_rx_xdp_bufs (ring, ring->xsk_pool);if (err)return err;if (ring->xsk_pool) { -xdp_rxq_info_unreg (&ring->xdp_rxq); - rx_buf_len =xsk_pool_get_rx_frame_size (ring->xsk_pool); err = __xdp_rxq_info_reg(&ring->xdp_rxq, ring->netdev,
@@ -705,14 +694,13 @@ static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring)if (err)return err; -if (!xdp_rxq_info_is_reg (&ring->xdp_rxq)) { - err =__xdp_rxq_info_reg (&ring->xdp_rxq, ring->netdev, - ring->q_index, - ring->q_vector->napi.napi_id, - ring->rx_buf_len); -if (err) - goto err_destroy_fq; - } + err =__xdp_rxq_info_reg (&ring->xdp_rxq, ring->netdev, + ring->q_index, + ring->q_vector->napi.napi_id, + ring->rx_buf_len); +if (err) + goto err_destroy_fq; +xdp_rxq_info_attach_page_pool (&ring->xdp_rxq, ring->pp); }
drivers/net/ethernet/intel/ice/ice_ethtool.c +1 -0
@@ -3332,6 +3332,7 @@ ice_set_ringparam(struct net_device *netdev, struct ethtool_ringparam *ring, rx_rings[i].cached_phctime = pf->ptp.cached_phc_time; rx_rings[i].desc =NULL ; rx_rings[i].xdp_buf =NULL ; + rx_rings[i].xdp_rxq = (struct xdp_rxq_info ){ };/* this is to allow wr32 to have something to write to * during early allocation of Rx buffers
drivers/net/ethernet/intel/ice/ice_txrx.c +3 -1
@@ -560,7 +560,9 @@ void ice_clean_rx_ring(struct ice_rx_ring *rx_ring) i =0 ; } -if (rx_ring->vsi->type ==ICE_VSI_PF && +if ((rx_ring->vsi->type ==ICE_VSI_PF || + rx_ring->vsi->type ==ICE_VSI_SF || + rx_ring->vsi->type ==ICE_VSI_LB ) &&xdp_rxq_info_is_reg (&rx_ring->xdp_rxq)) {xdp_rxq_info_detach_mem_model (&rx_ring->xdp_rxq);xdp_rxq_info_unreg (&rx_ring->xdp_rxq);
drivers/net/ethernet/intel/ice/ice_xsk.c +3 -0
@@ -900,6 +900,9 @@ void ice_xsk_clean_rx_ring(struct ice_rx_ring *rx_ring)u16 ntc = rx_ring->next_to_clean;u16 ntu = rx_ring->next_to_use; +if (xdp_rxq_info_is_reg (&rx_ring->xdp_rxq)) +xdp_rxq_info_unreg (&rx_ring->xdp_rxq); +while (ntc != ntu) {struct xdp_buff *xdp = *ice_xdp_buf (rx_ring, ntc);
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 300/311 ice: change XDP RxQ frag_size from DMA write length to xdp.frame_sz
In reply to Sasha LevinFrom: Larysa Zaremba <[email protected]>
[ Upstream commit e142dc4ef0f451b7ef99d09aaa84e9389af629d7 ]
The only user of frag_size field in XDP RxQ info is bpf_xdp_frags_increase_tail(). It clearly expects whole buff size instead of DMA write size. Different assumptions in ice driver configuration lead to negative tailroom.
This allows to trigger kernel panic, when using XDP_ADJUST_TAIL_GROW_MULTI_BUFF xskxceiver test and changing packet size to 6912 and the requested offset to a huge value, e.g. XSK_UMEM__MAX_FRAME_SIZE * 100.
Due to other quirks of the ZC configuration in ice, panic is not observed in ZC mode, but tailroom growing still fails when it should not.
Use fill queue buffer truesize instead of DMA write size in XDP RxQ info. Fix ZC mode too by using the new helper.
--- drivers/net/ethernet/intel/ice/ice_base.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/net/ethernet/intel/ice/ice_base.c +4 -5
@@ -661,7 +661,6 @@ static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring) {struct device *dev =ice_pf_to_dev (ring->vsi->back);u32 num_bufs =ICE_DESC_UNUSED (ring); -u32 rx_buf_len;int err; if (ring->vsi->type == ICE_VSI_PF || ring->vsi->type == ICE_VSI_SF ||
@@ -672,12 +671,12 @@ static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring)return err;if (ring->xsk_pool) { - rx_buf_len = -xsk_pool_get_rx_frame_size (ring->xsk_pool); +u32 frag_size = +xsk_pool_get_rx_frag_step (ring->xsk_pool); err =__xdp_rxq_info_reg (&ring->xdp_rxq, ring->netdev, ring->q_index, ring->q_vector->napi.napi_id, - rx_buf_len); + frag_size);if (err)return err; err = xdp_rxq_info_reg_mem_model(&ring->xdp_rxq,
@@ -697,7 +696,7 @@ static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring) err =__xdp_rxq_info_reg (&ring->xdp_rxq, ring->netdev, ring->q_index, ring->q_vector->napi.napi_id, - ring->rx_buf_len); + ring->truesize);if (err) goto err_destroy_fq;
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 301/311 i40e: fix registering XDP RxQ info
In reply to Sasha LevinFrom: Larysa Zaremba <[email protected]>
[ Upstream commit 8f497dc8a61429cc004720aa8e713743355d80cf ]
Current way of handling XDP RxQ info in i40e has a problem, where frag_size is not updated when xsk_buff_pool is detached or when MTU is changed, this leads to growing tail always failing for multi-buffer packets.
Couple XDP RxQ info registering with buffer allocations and unregistering with cleaning the ring.
--- drivers/net/ethernet/intel/i40e/i40e_main.c | 34 ++++++++++++--------- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 5 +-- 2 files changed, 22 insertions(+), 17 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +19 -15
@@ -3583,18 +3583,8 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring)if (ring->vsi->type !=I40E_VSI_MAIN ) goto skip; -if (!xdp_rxq_info_is_reg (&ring->xdp_rxq)) { - err =__xdp_rxq_info_reg (&ring->xdp_rxq, ring->netdev, - ring->queue_index, - ring->q_vector->napi.napi_id, - ring->rx_buf_len); -if (err) -return err; - } - ring->xsk_pool =i40e_xsk_pool (ring);if (ring->xsk_pool) { -xdp_rxq_info_unreg (&ring->xdp_rxq); ring->rx_buf_len =xsk_pool_get_rx_frame_size (ring->xsk_pool); err = __xdp_rxq_info_reg(&ring->xdp_rxq, ring->netdev, ring->queue_index,
@@ -3606,17 +3596,23 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring)MEM_TYPE_XSK_BUFF_POOL , NULL);if (err) -return err; + goto unreg_xdp;dev_info (&vsi->back->pdev->dev,"Registered XDP mem model MEM_TYPE_XSK_BUFF_POOL on Rx ring %d\n" , ring->queue_index); }else { + err =__xdp_rxq_info_reg (&ring->xdp_rxq, ring->netdev, + ring->queue_index, + ring->q_vector->napi.napi_id, + ring->rx_buf_len); +if (err) +return err; err =xdp_rxq_info_reg_mem_model (&ring->xdp_rxq,MEM_TYPE_PAGE_SHARED ,NULL );if (err) -return err; + goto unreg_xdp; } skip:
@@ -3654,7 +3650,8 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring)dev_info (&vsi->back->pdev->dev,"Failed to clear LAN Rx queue context on Rx ring %d (pf_q %d), error: %d\n" , ring->queue_index, pf_q, err); -return -ENOMEM ; + err = -ENOMEM ; + goto unreg_xdp; }/* set the context in the HMC */
@@ -3663,7 +3660,8 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring)dev_info (&vsi->back->pdev->dev,"Failed to set LAN Rx queue context on Rx ring %d (pf_q %d), error: %d\n" , ring->queue_index, pf_q, err); -return -ENOMEM ; + err = -ENOMEM ; + goto unreg_xdp; }/* configure Rx buffer alignment */
@@ -3671,7 +3669,8 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring)if (I40E_2K_TOO_SMALL_WITH_PADDING ) {dev_info (&vsi->back->pdev->dev,"2k Rx buffer is too small to fit standard MTU and skb_shared_info\n" ); -return -EOPNOTSUPP ; + err = -EOPNOTSUPP ; + goto unreg_xdp; }clear_ring_build_skb_enabled (ring); }else {
@@ -3701,6 +3700,11 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring) }return 0 ; +unreg_xdp: +if (ring->vsi->type ==I40E_VSI_MAIN ) +xdp_rxq_info_unreg (&ring->xdp_rxq); + +return err; }/**
drivers/net/ethernet/intel/i40e/i40e_txrx.c +3 -2
@@ -1470,6 +1470,9 @@ void i40e_clean_rx_ring(struct i40e_ring *rx_ring)if (!rx_ring->rx_bi)return ; +if (xdp_rxq_info_is_reg (&rx_ring->xdp_rxq)) +xdp_rxq_info_unreg (&rx_ring->xdp_rxq); +if (rx_ring->xsk_pool) {i40e_xsk_clean_rx_ring (rx_ring); goto skip_free;
@@ -1527,8 +1530,6 @@ void i40e_clean_rx_ring(struct i40e_ring *rx_ring)void i40e_free_rx_resources (struct i40e_ring *rx_ring) {i40e_clean_rx_ring (rx_ring); -if (rx_ring->vsi->type ==I40E_VSI_MAIN ) -xdp_rxq_info_unreg (&rx_ring->xdp_rxq); rx_ring->xdp_prog =NULL ;kfree (rx_ring->rx_bi); rx_ring->rx_bi =NULL ;
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 302/311 i40e: use xdp.frame_sz as XDP RxQ info frag_size
In reply to Sasha LevinFrom: Larysa Zaremba <[email protected]>
[ Upstream commit c69d22c6c46a1d792ba8af3d8d6356fdc0e6f538 ]
The only user of frag_size field in XDP RxQ info is bpf_xdp_frags_increase_tail(). It clearly expects whole buffer size instead of DMA write size. Different assumptions in i40e driver configuration lead to negative tailroom.
Set frag_size to the same value as frame_sz in shared pages mode, use new helper to set frag_size when AF_XDP ZC is active.
--- drivers/net/ethernet/intel/i40e/i40e_main.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +6 -3
@@ -3569,6 +3569,7 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring)u16 pf_q = vsi->base_queue + ring->queue_index;struct i40e_hw *hw = &vsi->back->hw;struct i40e_hmc_obj_rxq rx_ctx; +u32 xdp_frame_sz;int err =0 ;bool ok;
@@ -3578,6 +3579,7 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring)memset (&rx_ctx,0 ,sizeof (rx_ctx)); ring->rx_buf_len = vsi->rx_buf_len; + xdp_frame_sz =i40e_rx_pg_size (ring) /2 ;/* XDP RX-queue info only needed for RX rings exposed to XDP */ if (ring->vsi->type !=I40E_VSI_MAIN )
@@ -3585,11 +3587,12 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring) ring->xsk_pool =i40e_xsk_pool (ring);if (ring->xsk_pool) { + xdp_frame_sz =xsk_pool_get_rx_frag_step (ring->xsk_pool); ring->rx_buf_len =xsk_pool_get_rx_frame_size (ring->xsk_pool); err =__xdp_rxq_info_reg (&ring->xdp_rxq, ring->netdev, ring->queue_index, ring->q_vector->napi.napi_id, - ring->rx_buf_len); + xdp_frame_sz);if (err)return err; err = xdp_rxq_info_reg_mem_model(&ring->xdp_rxq,
@@ -3605,7 +3608,7 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring) err =__xdp_rxq_info_reg (&ring->xdp_rxq, ring->netdev, ring->queue_index, ring->q_vector->napi.napi_id, - ring->rx_buf_len); + xdp_frame_sz);if (err)return err; err = xdp_rxq_info_reg_mem_model(&ring->xdp_rxq,
@@ -3616,7 +3619,7 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring) } skip: -xdp_init_buff (&ring->xdp,i40e_rx_pg_size (ring) /2 , &ring->xdp_rxq); +xdp_init_buff (&ring->xdp, xdp_frame_sz, &ring->xdp_rxq); rx_ctx.dbuff =DIV_ROUND_UP (ring->rx_buf_len,BIT_ULL (I40E_RXQ_CTX_DBUFF_SHIFT ));
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 303/311 net: enetc: use truesize as XDP RxQ info frag_size
In reply to Sasha LevinFrom: Larysa Zaremba <[email protected]>
[ Upstream commit f8e18abf183dbd636a8725532c7f5aa58957de84 ]
The only user of frag_size field in XDP RxQ info is bpf_xdp_frags_increase_tail(). It clearly expects truesize instead of DMA write size. Different assumptions in enetc driver configuration lead to negative tailroom.
Set frag_size to the same value as frame_sz.
--- drivers/net/ethernet/freescale/enetc/enetc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/enetc/enetc.c +1 -1
@@ -3468,7 +3468,7 @@ static int enetc_int_vector_init(struct enetc_ndev_priv *priv, int i, priv->rx_ring[i] = bdr; err =__xdp_rxq_info_reg (&bdr->xdp.rxq, priv->ndev, i,0 , -ENETC_RXB_DMA_SIZE_XDP ); +ENETC_RXB_TRUESIZE );if (err) goto free_vector;
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 304/311 xdp: produce a warning when calculated tailroom is negative
In reply to Sasha LevinFrom: Larysa Zaremba <[email protected]>
[ Upstream commit 8821e857759be9db3cde337ad328b71fe5c8a55f ]
Many ethernet drivers report xdp Rx queue frag size as being the same as DMA write size. However, the only user of this field, namely bpf_xdp_frags_increase_tail(), clearly expects a truesize.
Such difference leads to unspecific memory corruption issues under certain circumstances, e.g. in ixgbevf maximum DMA write size is 3 KB, so when running xskxceiver's XDP_ADJUST_TAIL_GROW_MULTI_BUFF, 6K packet fully uses all DMA-writable space in 2 buffers. This would be fine, if only rxq->frag_size was properly set to 4K, but value of 3K results in a negative tailroom, because there is a non-zero page offset.
We are supposed to return -EINVAL and be done with it in such case, but due to tailroom being stored as an unsigned int, it is reported to be somewhere near UINT_MAX, resulting in a tail being grown, even if the requested offset is too much (it is around 2K in the abovementioned test). This later leads to all kinds of unspecific calltraces.
[ 7340.337579] xskxceiver[1440]: segfault at 1da718 ip 00007f4161aeac9d sp 00007f41615a6a00 error 6 [ 7340.338040] xskxceiver[1441]: segfault at 7f410000000b ip 00000000004042b5 sp 00007f415bffecf0 error 4 [ 7340.338179] in libc.so.6[61c9d,7f4161aaf000+160000] [ 7340.339230] in xskxceiver[42b5,400000+69000] [ 7340.340300] likely on CPU 6 (core 0, socket 6) [ 7340.340302] Code: ff ff 01 e9 f4 fe ff ff 0f 1f 44 00 00 4c 39 f0 74 73 31 c0 ba 01 00 00 00 f0 0f b1 17 0f 85 ba 00 00 00 49 8b 87 88 00 00 00 <4c> 89 70 08 eb cc 0f 1f 44 00 00 48 8d bd f0 fe ff ff 89 85 ec fe [ 7340.340888] likely on CPU 3 (core 0, socket 3) [ 7340.345088] Code: 00 00 00 ba 00 00 00 00 be 00 00 00 00 89 c7 e8 31 ca ff ff 89 45 ec 8b 45 ec 85 c0 78 07 b8 00 00 00 00 eb 46 e8 0b c8 ff ff <8b> 00 83 f8 69 74 24 e8 ff c7 ff ff 8b 00 83 f8 0b 74 18 e8 f3 c7 [ 7340.404334] Oops: general protection fault, probably for non-canonical address 0x6d255010bdffc: 0000 [#1] SMP NOPTI [ 7340.405972] CPU: 7 UID: 0 PID: 1439 Comm: xskxceiver Not tainted 6.19.0-rc1+ #21 PREEMPT(lazy) [ 7340.408006] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.17.0-5.fc42 04/01/2014 [ 7340.409716] RIP: 0010:lookup_swap_cgroup_id+0x44/0x80 [ 7340.410455] Code: 83 f8 1c 73 39 48 ba ff ff ff ff ff ff ff 03 48 8b 04 c5 20 55 fa bd 48 21 d1 48 89 ca 83 e1 01 48 d1 ea c1 e1 04 48 8d 04 90 <8b> 00 48 83 c4 10 d3 e8 c3 cc cc cc cc 31 c0 e9 98 b7 dd 00 48 89 [ 7340.412787] RSP: 0018:ffffcc5c04f7f6d0 EFLAGS: 00010202 [ 7340.413494] RAX: 0006d255010bdffc RBX: ffff891f477895a8 RCX: 0000000000000010 [ 7340.414431] RDX: 0001c17e3fffffff RSI: 00fa070000000000 RDI: 000382fc7fffffff [ 7340.415354] RBP: 00fa070000000000 R08: ffffcc5c04f7f8f8 R09: ffffcc5c04f7f7d0 [ 7340.416283] R10: ffff891f4c1a7000 R11: ffffcc5c04f7f9c8 R12: ffffcc5c04f7f7d0 [ 7340.417218] R13: 03ffffffffffffff R14: 00fa06fffffffe00 R15: ffff891f47789500 [ 7340.418229] FS: 0000000000000000(0000) GS:ffff891ffdfaa000(0000) knlGS:0000000000000000 [ 7340.419489] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 7340.420286] CR2: 00007f415bfffd58 CR3: 0000000103f03002 CR4: 0000000000772ef0 [ 7340.421237] PKRU: 55555554 [ 7340.421623] Call Trace: [ 7340.421987] <TASK> [ 7340.422309] ? softleaf_from_pte+0x77/0xa0 [ 7340.422855] swap_pte_batch+0xa7/0x290 [ 7340.423363] zap_nonpresent_ptes.constprop.0.isra.0+0xd1/0x270 [ 7340.424102] zap_pte_range+0x281/0x580 [ 7340.424607] zap_pmd_range.isra.0+0xc9/0x240 [ 7340.425177] unmap_page_range+0x24d/0x420 [ 7340.425714] unmap_vmas+0xa1/0x180 [ 7340.426185] exit_mmap+0xe1/0x3b0 [ 7340.426644] __mmput+0x41/0x150 [ 7340.427098] exit_mm+0xb1/0x110 [ 7340.427539] do_exit+0x1b2/0x460 [ 7340.427992] do_group_exit+0x2d/0xc0 [ 7340.428477] get_signal+0x79d/0x7e0 [ 7340.428957] arch_do_signal_or_restart+0x34/0x100 [ 7340.429571] exit_to_user_mode_loop+0x8e/0x4c0 [ 7340.430159] do_syscall_64+0x188/0x6b0 [ 7340.430672] ? __do_sys_clone3+0xd9/0x120 [ 7340.431212] ? switch_fpu_return+0x4e/0xd0 [ 7340.431761] ? arch_exit_to_user_mode_prepare.isra.0+0xa1/0xc0 [ 7340.432498] ? do_syscall_64+0xbb/0x6b0 [ 7340.433015] ? __handle_mm_fault+0x445/0x690 [ 7340.433582] ? count_memcg_events+0xd6/0x210 [ 7340.434151] ? handle_mm_fault+0x212/0x340 [ 7340.434697] ? do_user_addr_fault+0x2b4/0x7b0 [ 7340.435271] ? clear_bhb_loop+0x30/0x80 [ 7340.435788] ? clear_bhb_loop+0x30/0x80 [ 7340.436299] ? clear_bhb_loop+0x30/0x80 [ 7340.436812] ? clear_bhb_loop+0x30/0x80 [ 7340.437323] entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 7340.437973] RIP: 0033:0x7f4161b14169 [ 7340.438468] Code: Unable to access opcode bytes at 0x7f4161b1413f. [ 7340.439242] RSP: 002b:00007ffc6ebfa770 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca [ 7340.440173] RAX: fffffffffffffe00 RBX: 00000000000005a1 RCX: 00007f4161b14169 [ 7340.441061] RDX: 00000000000005a1 RSI: 0000000000000109 RDI: 00007f415bfff990 [ 7340.441943] RBP: 00007ffc6ebfa7a0 R08: 0000000000000000 R09: 00000000ffffffff [ 7340.442824] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 [ 7340.443707] R13: 0000000000000000 R14: 00007f415bfff990 R15: 00007f415bfff6c0 [ 7340.444586] </TASK> [ 7340.444922] Modules linked in: rfkill intel_rapl_msr intel_rapl_common intel_uncore_frequency_common skx_edac_common nfit libnvdimm kvm_intel vfat fat kvm snd_pcm irqbypass rapl iTCO_wdt snd_timer intel_pmc_bxt iTCO_vendor_support snd ixgbevf virtio_net soundcore i2c_i801 pcspkr libeth_xdp net_failover i2c_smbus lpc_ich failover libeth virtio_balloon joydev 9p fuse loop zram lz4hc_compress lz4_compress 9pnet_virtio 9pnet netfs ghash_clmulni_intel serio_raw qemu_fw_cfg [ 7340.449650] ---[ end trace 0000000000000000 ]---
The issue can be fixed in all in-tree drivers, but we cannot just trust OOT drivers to not do this. Therefore, make tailroom a signed int and produce a warning when it is negative to prevent such mistakes in the future.
--- net/core/filter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/core/filter.c +2 -1
@@ -4151,13 +4151,14 @@ static int bpf_xdp_frags_increase_tail(struct xdp_buff *xdp, int offset)struct skb_shared_info *sinfo =xdp_get_shared_info_from_buff (xdp);skb_frag_t *frag = &sinfo->frags[sinfo->nr_frags -1 ];struct xdp_rxq_info *rxq = xdp->rxq; -unsigned int tailroom; +int tailroom;if (!rxq->frag_size || rxq->frag_size > xdp->frame_sz)return -EOPNOTSUPP ; tailroom = rxq->frag_size -skb_frag_size (frag) -skb_frag_off (frag) % rxq->frag_size; +WARN_ON_ONCE (tailroom <0 );if (unlikely (offset > tailroom))return -EINVAL ;
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 305/311 accel: ethosu: Fix job submit error clean-up refcount underflows
In reply to Sasha LevinFrom: "Rob Herring (Arm)" <[email protected]>
[ Upstream commit 150bceb3e0a4a30950279d91ea0e8cc69a736742 ]
If the job submit fails before adding the job to the scheduler queue such as when the GEM buffer bounds checks fail, then doing a ethosu_job_put() results in a pm_runtime_put_autosuspend() without the corresponding pm_runtime_resume_and_get(). The dma_fence_put()'s are also unnecessary, but seem to be harmless.
Split the ethosu_job_cleanup() function into 2 parts for the before and after the job is queued.
--- drivers/accel/ethosu/ethosu_job.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-)
drivers/accel/ethosu/ethosu_job.c +18 -8
@@ -143,23 +143,29 @@ static int ethosu_job_push(struct ethosu_job *job)return ret; } +static void ethosu_job_err_cleanup (struct ethosu_job *job) +{ +unsigned int i; + +for (i =0 ; i < job->region_cnt; i++) +drm_gem_object_put (job->region_bo[i]); + +drm_gem_object_put (job->cmd_bo); + +kfree (job); +} +static void ethosu_job_cleanup (struct kref *ref) { struct ethosu_job *job = container_of(ref, struct ethosu_job, refcount); -unsigned int i;pm_runtime_put_autosuspend (job->dev->base.dev);dma_fence_put (job->done_fence);dma_fence_put (job->inference_done_fence); -for (i =0 ; i < job->region_cnt; i++) -drm_gem_object_put (job->region_bo[i]); - -drm_gem_object_put (job->cmd_bo); - -kfree (job); +ethosu_job_err_cleanup (job); }static void ethosu_job_put (struct ethosu_job *job)
@@ -454,12 +460,16 @@ static int ethosu_ioctl_submit_job(struct drm_device *dev, struct drm_file *file } } ret =ethosu_job_push (ejob); +if (!ret) { +ethosu_job_put (ejob); +return 0 ; + } out_cleanup_job:if (ret)drm_sched_job_cleanup (&ejob->base); out_put_job: -ethosu_job_put (ejob); +ethosu_job_err_cleanup (ejob);return ret; }
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 306/311 accel: ethosu: Fix NPU_OP_ELEMENTWISE validation with scalar
In reply to Sasha LevinFrom: "Rob Herring (Arm)" <[email protected]>
[ Upstream commit 838ae99f9a77a5724ee6d4e7b7b1eb079147f888 ]
The NPU_OP_ELEMENTWISE instruction uses a scalar value for IFM2 if the IFM2_BROADCAST "scalar" mode is set. It is a bit (7) on the u65 and part of a field (bits 3:0) on the u85. The driver was hardcoded to the u85.
--- drivers/accel/ethosu/ethosu_gem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/accel/ethosu/ethosu_gem.c +4 -1
@@ -417,7 +417,10 @@ static int ethosu_gem_cmdstream_copy_and_validate(struct drm_device *ddev,return ret;break ;case NPU_OP_ELEMENTWISE : - use_ifm2 = !((st.ifm2.broadcast ==8 ) || (param ==5 ) || + use_scale =ethosu_is_u65 (edev) ? + (st.ifm2.broadcast &0x80 ) : + (st.ifm2.broadcast ==8 ); + use_ifm2 = !(use_scale || (param ==5 ) || (param ==6 ) || (param ==7 ) || (param ==0x24 )); use_ifm = st.ifm.broadcast !=8 ; ret =calc_sizes_elemwise (ddev, info, cmd, &st, use_ifm, use_ifm2);
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 307/311 ata: libata-eh: Fix detection of deferred qc timeouts
In reply to Sasha LevinFrom: Guenter Roeck <[email protected]>
[ Upstream commit ee0e6e69a772d601e152e5368a1da25d656122a8 ]
If the ata_qc_for_each_raw() loop finishes without finding a matching SCSI command for any QC, the variable qc will hold a pointer to the last element examined, which has the tag i == ATA_MAX_QUEUE - 1. This qc can match the port deferred QC (ap->deferred_qc).
If that happens, the condition qc == ap->deferred_qc evaluates to true despite the loop not breaking with a match on the SCSI command for this QC. In that case, the error handler mistakenly intercepts a command that has not been issued yet and that has not timed out, and thus erroneously returning a timeout error.
Fix the problem by checking for i < ATA_MAX_QUEUE in addition to qc == ap->deferred_qc.
The problem was found by an experimental code review agent based on gemini-3.1-pro while reviewing backports into v6.18.y.
--- drivers/ata/libata-eh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/libata-eh.c +1 -1
@@ -647,7 +647,7 @@ void ata_scsi_cmd_error_handler(struct Scsi_Host *host, struct ata_port *ap,break ; } -if (qc == ap->deferred_qc) { +if (i <ATA_MAX_QUEUE && qc == ap->deferred_qc) {/* * This is a deferred command that timed out while * waiting for the command queue to drain. Since the qc
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 308/311 selftest/arm64: Fix sve2p1_sigill() to hwcap test
In reply to Sasha LevinFrom: Yifan Wu <[email protected]>
[ Upstream commit d87c828daa7ead9763416f75cc416496969cf1dc ]
The FEAT_SVE2p1 is indicated by ID_AA64ZFR0_EL1.SVEver. However, the BFADD requires the FEAT_SVE_B16B16, which is indicated by ID_AA64ZFR0_EL1.B16B16. This could cause the test to incorrectly fail on a CPU that supports FEAT_SVE2.1 but not FEAT_SVE_B16B16.
LD1Q Gather load quadwords which is decoded from SVE encodings and implied by FEAT_SVE2p1.
--- tools/testing/selftests/arm64/abi/hwcap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/arm64/abi/hwcap.c +2 -2
@@ -473,8 +473,8 @@ static void sve2_sigill(void)static void sve2p1_sigill (void ) { -/* BFADD Z0.H, Z0.H, Z0.H */ - asmvolatile (".inst 0x65000000" : : :"z0" ); +/* LD1Q {Z0.Q}, P0/Z, [Z0.D, X0] */ + asmvolatile (".inst 0xC400A000" : : :"z0" ); }static void sve2p2_sigill (void )
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 309/311 tracing: Add NULL pointer check to trigger_data_free()
In reply to Sasha LevinFrom: Guenter Roeck <[email protected]>
[ Upstream commit 457965c13f0837a289c9164b842d0860133f6274 ]
If trigger_data_alloc() fails and returns NULL, event_hist_trigger_parse() jumps to the out_free error path. While kfree() safely handles a NULL pointer, trigger_data_free() does not. This causes a NULL pointer dereference in trigger_data_free() when evaluating data->cmd_ops->set_filter.
Fix the problem by adding a NULL pointer check to trigger_data_free().
The problem was found by an experimental code review agent based on gemini-3.1-pro while reviewing backports into v6.18.y.
--- kernel/trace/trace_events_trigger.c | 3 +++ 1 file changed, 3 insertions(+)
kernel/trace/trace_events_trigger.c +3 -0
@@ -50,6 +50,9 @@ static int trigger_kthread_fn(void *ignore)void trigger_data_free (struct event_trigger_data *data) { +if (!data) +return ; +if (data->cmd_ops->set_filter) data->cmd_ops->set_filter (NULL , data,NULL );
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 310/311 bpf: collect only live registers in linked regs
In reply to Sasha LevinFrom: Eduard Zingerman <[email protected]>
[ Upstream commit 2658a1720a1944fbaeda937000ad2b3c3dfaf1bb ]
Fix an inconsistency between func_states_equal() and collect_linked_regs():
- regsafe() uses check_ids() to verify that cached and current states have identical register id mapping.
- func_states_equal() calls regsafe() only for registers computed as live by compute_live_registers().
- clean_live_states() is supposed to remove dead registers from cached states, but it can skip states belonging to an iterator-based loop.
- collect_linked_regs() collects all registers sharing the same id, ignoring the marks computed by compute_live_registers(). Linked registers are stored in the state's jump history.
- backtrack_insn() marks all linked registers for an instruction as precise whenever one of the linked registers is precise.
The above might lead to a scenario:
- There is an instruction I with register rY known to be dead at I.
- Instruction I is reached via two paths: first A, then B.
- On path A:
- There is an id link between registers rX and rY.
- Checkpoint C is created at I.
- Linked register set {rX, rY} is saved to the jump history.
- rX is marked as precise at I, causing both rX and rY to be marked precise at C.
- On path B:
- There is no id link between registers rX and rY, otherwise register states are sub-states of those in C.
- Because rY is dead at I, check_ids() returns true.
- Current state is considered equal to checkpoint C, propagate_precision() propagates spurious precision mark for register rY along the path B.
- Depending on a program, this might hit verifier_bug() in the backtrack_insn(), e.g. if rY ∈ [r1..r5]
and backtrack_insn() spots a function call.
The reproducer program is in the next patch. This was hit by sched_ext scx_lavd scheduler code.
Changes in tests:
- verifier_scalar_ids.c selftests need modification to preserve some registers as live for __msg() checks.
- exceptions_assert.c adjusted to match changes in the verifier log, R0 is dead after conditional instruction and thus does not get range.
- precise.c adjusted to match changes in the verifier log, register r9 is dead after comparison and it's range is not important for test.
--- kernel/bpf/verifier.c | 13 ++++- .../selftests/bpf/progs/exceptions_assert.c | 34 +++++------ .../selftests/bpf/progs/verifier_scalar_ids.c | 56 ++++++++++++++----- .../testing/selftests/bpf/verifier/precise.c | 8 +-- 4 files changed, 73 insertions(+), 38 deletions(-)
kernel/bpf/verifier.c +10 -3
@@ -16895,17 +16895,24 @@ static void __collect_linked_regs(struct linked_regs *reg_set, struct bpf_reg_st* in verifier state, save R in linked_regs if R->id == id. * If there are too many Rs sharing same id, reset id for leftover Rs. */ -static void collect_linked_regs (struct bpf_verifier_state *vstate,u32 id, +static void collect_linked_regs (struct bpf_verifier_env *env, +struct bpf_verifier_state *vstate, +u32 id,struct linked_regs *linked_regs) { +struct bpf_insn_aux_data *aux = env->insn_aux_data;struct bpf_func_state *func;struct bpf_reg_state *reg; +u16 live_regs;int i, j; id = id & ~BPF_ADD_CONST ;for (i = vstate->curframe; i >=0 ; i--) { + live_regs = aux[frame_insn_idx (vstate, i)].live_regs_before; func = vstate->frame[i];for (j =0 ; j <BPF_REG_FP ; j++) { +if (!(live_regs &BIT (j))) +continue ; reg = &func->regs[j];__collect_linked_regs (linked_regs, reg, id, i, j, true); }
@@ -17113,9 +17120,9 @@ static int check_cond_jmp_op(struct bpf_verifier_env *env,* if parent state is created. */ if (BPF_SRC (insn->code) ==BPF_X && src_reg->type ==SCALAR_VALUE && src_reg->id) -collect_linked_regs (this_branch, src_reg->id, &linked_regs); +collect_linked_regs (env, this_branch, src_reg->id, &linked_regs);if (dst_reg->type ==SCALAR_VALUE && dst_reg->id) -collect_linked_regs (this_branch, dst_reg->id, &linked_regs); +collect_linked_regs (env, this_branch, dst_reg->id, &linked_regs);if (linked_regs.cnt >1 ) { err =push_jmp_history (env, this_branch,0 ,linked_regs_pack (&linked_regs));if (err)
tools/testing/selftests/bpf/progs/exceptions_assert.c +17 -17
@@ -18,43 +18,43 @@return *(u64 *)num; \ } -__msg(": R0=0xffffffff80000000") +__msg("R{{.}}=0xffffffff80000000") check_assert(s64, ==, eq_int_min, INT_MIN); -__msg(": R0=0x7fffffff") +__msg("R{{.}}=0x7fffffff") check_assert(s64, ==, eq_int_max, INT_MAX); -__msg(": R0=0") +__msg("R{{.}}=0") check_assert(s64, ==, eq_zero, 0); -__msg(": R0=0x8000000000000000 R1=0x8000000000000000") +__msg("R{{.}}=0x8000000000000000") check_assert(s64, ==, eq_llong_min, LLONG_MIN); -__msg(": R0=0x7fffffffffffffff R1=0x7fffffffffffffff") +__msg("R{{.}}=0x7fffffffffffffff") check_assert(s64, ==, eq_llong_max, LLONG_MAX); -__msg(": R0=scalar(id=1,smax=0x7ffffffe)") +__msg("R{{.}}=scalar(id=1,smax=0x7ffffffe)") check_assert(s64, <, lt_pos, INT_MAX); -__msg(": R0=scalar(id=1,smax=-1,umin=0x8000000000000000,var_off=(0x8000000000000000; 0x7fffffffffffffff))") +__msg("R{{.}}=scalar(id=1,smax=-1,umin=0x8000000000000000,var_off=(0x8000000000000000; 0x7fffffffffffffff))") check_assert(s64, <, lt_zero, 0); -__msg(": R0=scalar(id=1,smax=0xffffffff7fffffff") +__msg("R{{.}}=scalar(id=1,smax=0xffffffff7fffffff") check_assert(s64, <, lt_neg, INT_MIN); -__msg(": R0=scalar(id=1,smax=0x7fffffff)") +__msg("R{{.}}=scalar(id=1,smax=0x7fffffff)") check_assert(s64, <=, le_pos, INT_MAX); -__msg(": R0=scalar(id=1,smax=0)") +__msg("R{{.}}=scalar(id=1,smax=0)") check_assert(s64, <=, le_zero, 0); -__msg(": R0=scalar(id=1,smax=0xffffffff80000000") +__msg("R{{.}}=scalar(id=1,smax=0xffffffff80000000") check_assert(s64, <=, le_neg, INT_MIN); -__msg(": R0=scalar(id=1,smin=umin=0x80000000,umax=0x7fffffffffffffff,var_off=(0x0; 0x7fffffffffffffff))") +__msg("R{{.}}=scalar(id=1,smin=umin=0x80000000,umax=0x7fffffffffffffff,var_off=(0x0; 0x7fffffffffffffff))") check_assert(s64, >, gt_pos, INT_MAX); -__msg(": R0=scalar(id=1,smin=umin=1,umax=0x7fffffffffffffff,var_off=(0x0; 0x7fffffffffffffff))") +__msg("R{{.}}=scalar(id=1,smin=umin=1,umax=0x7fffffffffffffff,var_off=(0x0; 0x7fffffffffffffff))") check_assert(s64, >, gt_zero, 0); -__msg(": R0=scalar(id=1,smin=0xffffffff80000001") +__msg("R{{.}}=scalar(id=1,smin=0xffffffff80000001") check_assert(s64, >, gt_neg, INT_MIN); -__msg(": R0=scalar(id=1,smin=umin=0x7fffffff,umax=0x7fffffffffffffff,var_off=(0x0; 0x7fffffffffffffff))") +__msg("R{{.}}=scalar(id=1,smin=umin=0x7fffffff,umax=0x7fffffffffffffff,var_off=(0x0; 0x7fffffffffffffff))") check_assert(s64, >=, ge_pos, INT_MAX); -__msg(": R0=scalar(id=1,smin=0,umax=0x7fffffffffffffff,var_off=(0x0; 0x7fffffffffffffff))") +__msg("R{{.}}=scalar(id=1,smin=0,umax=0x7fffffffffffffff,var_off=(0x0; 0x7fffffffffffffff))") check_assert(s64, >=, ge_zero, 0); -__msg(": R0=scalar(id=1,smin=0xffffffff80000000") +__msg("R{{.}}=scalar(id=1,smin=0xffffffff80000000") check_assert(s64, >=, ge_neg, INT_MIN);SEC ("?tc" )
tools/testing/selftests/bpf/progs/verifier_scalar_ids.c +42 -14
152 lines not on this page · raw message
tools/testing/selftests/bpf/verifier/precise.c +4 -4
@@ -44,9 +44,9 @@ mark_precise: frame0: regs=r2 stack= before 23\ mark_precise: frame0: regs=r2 stack= before 22\ mark_precise: frame0: regs=r2 stack= before 20\ - mark_precise: frame0: parent state regs=r2,r9 stack=:\ + mark_precise: frame0: parent state regs=r2 stack=:\ mark_precise: frame0: last_idx 19 first_idx 10\ - mark_precise: frame0: regs=r2,r9 stack= before 19\ + mark_precise: frame0: regs=r2 stack= before 19\ mark_precise: frame0: regs=r9 stack= before 18\ mark_precise: frame0: regs=r8,r9 stack= before 17\ mark_precise: frame0: regs=r0,r9 stack= before 15\
@@ -107,9 +107,9 @@ mark_precise: frame0: parent state regs=r2 stack=:\ mark_precise: frame0: last_idx 20 first_idx 20\ mark_precise: frame0: regs=r2 stack= before 20\ - mark_precise: frame0: parent state regs=r2,r9 stack=:\ + mark_precise: frame0: parent state regs=r2 stack=:\ mark_precise: frame0: last_idx 19 first_idx 17\ - mark_precise: frame0: regs=r2,r9 stack= before 19\ + mark_precise: frame0: regs=r2 stack= before 19\ mark_precise: frame0: regs=r9 stack= before 18\ mark_precise: frame0: regs=r8,r9 stack= before 17\ mark_precise: frame0: parent state regs= stack=:",
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 311/311 Linux 6.19.7-rc1
In reply to Sasha Levin--- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +2 -2
@@ -1,8 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 VERSION = 6 PATCHLEVEL = 19 -SUBLEVEL = 6 -EXTRAVERSION = +SUBLEVEL = 7 +EXTRAVERSION = -rc1 NAME = Baby Opossum Posse # *DOCUMENTATION*
Signature · 1 line
2.51.0
# Librecast Test Results
020/020 [ OK ] liblcrq
010/010 [ OK ] libmld
120/120 [ OK ] liblibrecast
CPU/kernel: Linux auntie 6.19.7-rc1-g2867504d9c53 #2 SMP PREEMPT_DYNAMIC Tue Mar 10 12:44:04 -00 2026 x86_64 AMD Ryzen 9 9950X 16-Core Processor AuthenticAMD GNU/Linux
Hi
no regressions here on x86_64 (Intel 11th Gen. CPU)
Thanks
Quoted 9 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
Quoted 8 lines
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.19.y
and the diffstat can be found below.Thanks,
Sasha
All tests passing for Tegra ...
Test results for stable-v6.19:
10 builds: 10 pass, 0 fail
28 boots: 28 pass, 0 fail
133 tests: 133 pass, 0 failLinux version: 6.19.7-rc1-g2867504d9c53
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra186-p3509-0000+p3636-0001, tegra194-p2972-0000,
tegra194-p3509-0000+p3668-0000, tegra20-ventana,
tegra210-p2371-2180, tegra210-p3450-0000,
tegra30-cardhu-a04Jon
Quoted 12 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6
Quoted 8 lines
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.19.y
and the diffstat can be found below.Thanks,
Sasha-------------
built and boot-tested the linux-stable-rc 6.19.7 kernel using QEMU.
The kernel built and booted successfully in a virtual environment on the tested architectures. No issues were observed during boot, and no regressions were found in the dmesg output.
Build details:
Architectures : arm64, x86_64
Kernel version: 6.19.7-rc1
Configuration : defconfig
Source : https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Commit : 2867504d9c53260444ef95c17adeebb724395237
Quoted 5 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Quoted 9 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
Quoted 8 lines
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.19.y
and the diffstat can be found below.Thanks,
Sasha
Tested rc1 against the Fedora build system (aarch64, ppc64le, s390x, x86_64), and boot tested x86_64. No regressions noted.
Quoted 11 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6
Quoted 8 lines
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.19.y
and the diffstat can be found below.Thanks,
Sasha-------------
perf fails to build the pmu-events for all of the freescale SoCs, I am not sure yet whether this is a build environment issue or a genuine perf build system failure:
cp: cannot stat 'pmu-events/arch/arm64/freescale/imx8mm/sys/metrics.json': No such file or directory
CC
/local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/util/maps.o
cp: cannot stat 'pmu-events/arch/arm64/freescale/imx8mm/sys/ddrc.json': No such file or directory
cp: cannot stat 'pmu-events/arch/arm64/freescale/imx94/sys/metrics.json': No such file or directory
cp: cannot stat 'pmu-events/arch/arm64/freescale/imx94/sys/ddrc.json': No such file or directory
CC
/local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/util/pstack.o
GEN
/local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
CC
/local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/util/session.o
make[5]: *** [pmu-events/Build:44: /local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/metrics.json] Error 1 make[5]: *** Waiting for unfinished jobs....
GEN
/local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
make[5]: *** [pmu-events/Build:44: /local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/ddrc.json] Error 1 make[5]: *** [pmu-events/Build:44: /local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/pmu-events/arch/arm64/freescale/imx94/sys/metrics.json] Error 1 make[5]: *** [pmu-events/Build:44: /local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/pmu-events/arch/arm64/freescale/imx94/sys/ddrc.json] Error 1
...
cp: cannot stat 'pmu-events/arch/arm64/freescale/imx8mm/sys/metrics.json': No such file or directory
make[5]: *** [pmu-events/Build:44: /local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/pmu-events/arch/arm64/freescale/imx8mm/sys/metrics.json] Error 1 make[4]: *** [Makefile.perf:770: /local/users/fainelli/buildroot/output/arm64/build/linux-custom/tools/perf/pmu-events/pmu-events-in.o] Error 2 make[4]: *** Waiting for unfinished jobs....
Signature · 1 line
Florian
Sasha Levin
maintainerQuoted 16 lines · Florian Fainelli
Quoted 15 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.19.y
and the diffstat can be found below.
Quoted 5 lines
Quoted 4 lines
Thanks,
Sasha-------------
perf fails to build the pmu-events for all of the freescale SoCs, I am not sure yet whether this is a build environment issue or a genuine perf build system failure:
Could you try building with a revert of b56111d7a464 ("perf jevents: Handle deleted JSONS in out of source builds") please?
Signature · 2 lines
Thanks, Sasha
Quoted 17 lines · Sasha Levin
Quoted 16 lines · Florian Fainelli
Quoted 15 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux- stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6 or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.19.y
and the diffstat can be found below.
Quoted 9 lines
Quoted 5 lines
Quoted 4 lines
Thanks,
Sasha-------------
perf fails to build the pmu-events for all of the freescale SoCs, I am not sure yet whether this is a build environment issue or a genuine perf build system failure:
Could you try building with a revert of
b56111d7a464("perf jevents: Handle deleted JSONS in out of source builds") please?
Yes that does resolve it, thanks!
Signature · 1 line
Florian
Sasha Levin
maintainerQuoted 23 lines · Florian Fainelli
Quoted 20 lines · Sasha Levin
Quoted 19 lines · Florian Fainelli
Quoted 18 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux- stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6 or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.19.y
and the diffstat can be found below.Thanks,
Sasha
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Quoted 1 line
-------------
perf fails to build the pmu-events for all of the freescale SoCs, I am not sure yet whether this is a build environment issue or a genuine perf build system failure:
Could you try building with a revert of
b56111d7a464("perf jevents: Handle deleted JSONS in out of source builds") please?Yes that does resolve it, thanks!
Awesome! Looking at the patch, it looks like it's a backport regression and upstream should work just fine?
Assuming it's the case, I can revert this commit after the current release cycle.
Signature · 2 lines
Thanks, Sasha
Quoted 8 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
Quoted 8 lines
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.19.y
and the diffstat can be found below.Thanks,
Sasha
Built and booted successfully on RISC-V RV64 (HiFive Unmatched).
Am 10.03.2026 um 12:05 schrieb Sasha Levin:
Quoted 5 lines
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Builds, boots and works on my 2-socket Ivy Bridge Xeon E5-2697 v2 server. No dmesg oddities or regressions found.
Beste Grüße,
Peter Schneider
Signature · 8 lines
Climb the mountain not to plant your flag, but to embrace the challenge, enjoy the air and behold the view. Climb it so you can see the world, not so the world can see you. -- David McCullough Jr. OpenPGP: 0xA3828BD796CCE11A8CADE8866E3A92C92C3FF244 Download: https://www.peters-netzplatz.de/download/pschneider1968_pub.asc https://keys.mailvelope.com/pks/lookup?op=get&[email protected] https://keys.mailvelope.com/pks/lookup?op=get&[email protected]
Hi Sasha
Quoted 10 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
Quoted 9 lines
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.19.y
and the diffstat can be found below.Thanks,
Sasha
6.19.7-rc1 tested.
Build successfully completed.
Boot successfully completed.
No dmesg regressions.
Video output normal.
Sound output normal.
Lenovo ThinkPad X1 Carbon Gen10(Intel i7-1260P(x86_64) arch linux)
[ 0.000000] Linux version 6.19.7-rc1rv-g2867504d9c53
(takeshi@ThinkPadX1Gen10J0764) (gcc (GCC) 15.2.1 20260209, GNU ld (GNU Binutils) 2.46) #1 SMP PREEMPT_DYNAMIC Wed Mar 11 11:06:57 JST 2026
Thanks
AMD Ryzen 5 5600 6-Core Processor:
https://www.inet.se/produkt/5304697/amd-ryzen-5-5600-3-5-ghz-35mb on a
https://www.gigabyte.com/Motherboard/B550-AORUS-ELITE-V2-rev-12
https://www.inet.se/produkt/1903406/gigabyte-b550-aorus-elite-v2
motherboard :)
running Arch Linux with the testing repos enabled:
https://archlinux.org/ https://archboot.com/
https://wiki.archlinux.org/title/Arch_Testing_Team
Den tis 10 mars 2026 kl 12:11 skrev Sasha Levin <[email protected]>:
Quoted 1,145 lines
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.19.y
and the diffstat can be found below.Thanks,
Sasha-------------
Pseudo-Shortlog of commits:Aaron Ma (1):
ice: recap the VSI and QoS info after rebuildAlain Volmat (1):
spi: stm32: fix missing pointer assignment in case of dma chainingAlban Bedel (1):
can: mcp251x: fix deadlock in error path ofmcp251x_openAlex Hung (2):
drm/amd/display: Use mpc.preblend flag to indicate 3D LUT drm/amd/display: Enable DEGAMMA and reject COLOR_PIPELINE+DEGAMMA_LUTAlexandre Courbot (1):
rust: kunit: fix warning when !CONFIG_PRINTKAlexey Charkov (1):
scsi: ufs: core: Fix RPMB region size detection for UFS 2.2Allison Henderson (1):
net/rds: Fix circular locking dependency inrds_tcp_tuneAlper Ak (1):
crypto: ccp - Fix use-after-free on error pathAndrew Cooper (1):
x86/fred: Correct speculative safety infred_extint()Andrew Lunn (1):
net: phy: register phyled_triggersduring probe to avoid AB-BA
deadlockAnkit Garg (1):
gve: fix incorrect buffer cleanup ingve_tx_clean_pending_packetsfor
QPLAriel Silver (1):
wifi: mac80211: bounds-checklink_idinieee80211_ml_reconfigurationBart Van Assche (5):
drm/amdgpu: Unlock a mutex before destroying it drm/amdgpu: Fix locking bugs in error paths
hwmon: (it87) Check theit87_lock()return value
wifi: cw1200: Fix locking in error paths
wifi: wlcore: Fix a locking bugBjorn Helgaas (1):
PCI: CorrectPCI_CAP_EXP_ENDPOINT_SIZEOF_V2valueBobby Eshleman (1):
net: devmem: use READ_ONCE/WRITE_ONCE onbinding->devBoris Faure (1):
ASoC: sdca: Fix missing regmap dependencies inKconfigBrad Spengler (1):
drm/vmwgfx: Fix invalidkref_putcallback invmw_bo_dirty_releaseBrian Vazquez (1):
idpf: change IRQ naming to match netdev and ethtool queue numberingCatalin Marinas (1):
arm64: gcs: Do not setPTE_SHAREDon GCS mappings ifFEAT_LPA2is
enabledChaitanya Kulkarni (1):
blktrace: fix __this_cpu_read/write in preemptible contextCharles Haithcock (1):
i2c: i801: Revert "i2c: i801: replaceacpi_lockwith I2C bus lock"Charles Keepax (1):
ASoC: SDCA: Add allocation failure check for Entity nameChen Ni (2):
drm/imx: parallel-display: check return value ofdevm_drm_bridge_add()
inimx_pd_probe()
drm/bridge: synopsys: dw-dp: Check return value of
devm_drm_bridge_add()indw_dp_bind()Chintan Vankar (1):
net: ethernet: ti: am65-cpsw-nuss/cpsw-ale: Fix multicast entry
handling in ALE tableChristian Brauner (1):
namespace: fix proc mount iterationChristoph Böhmwalder (1):
drbd: fix null-pointer dereference on local read errorChristoph Hellwig (2):
zloop: advertise a volatile write cache
zloop: check for spurious options passed to removeConor Dooley (1):
pinctrl: generic: move function to amlogic-am4 driverCorey Minyard (1):
ipmi: Fix use-after-free and list corruption on sender errorDan Carpenter (1):
accel: ethosu: Fix shift overflow incmd_to_addr()Daniel Hodges (1):
wifi: libertas: fix use-after-free inlbs_free_adapter()Daniel J Blueman (1):
gpio: shared: fix memory leaksDanielle Ratson (1):
bridge: Check relevant per-VLAN options in VLAN range groupingDaniil Dulov (1):
wifi: cfg80211: cancelrfkill_blockwork inwiphy_unregister()Danilo Krummrich (1):
clk: scu/imx8qxp: do not register driver inprobe()Darrick J. Wong (1):
xfs: fixxfs_grouprelease bug inxfs_dax_notify_dev_failureDave Jiang (2):
cxl: Movedevm_cxl_add_nvdimm_bridge()to cxl_pmem.ko
cxl: Fix race ofnvdimm_busobject when creating nvdimm objectsDavid Carlier (1):
sched_ext: FixSCX_EFLAG_INITIALIZEDbeing a no-op flagDavid Howells (1):
netfs: Fix unbuffered/DIO writes to dispatch subrequests in strict
sequenceDavid Laight (1):
uaccess: Fixscoped_user_read_access()for 'pointer to const'David Thomson (1):
xen/acpi-processor: fix_CSTdetection using undersized evaluation
bufferDavide Caratti (1):
net/sched: ets: fix divide by zero in the offload pathDavidlohr Bueso (1):
cxl/mbox: validate payload size before accessing contents in
cxl_payload_from_user_allowed()Deepanshu Kartikey (1):
mm: thp: deny THP for files on anonymous inodesEduard Zingerman (1):
bpf: collect only live registers in linked regsEric Biggers (1):
ksmbd: Compare MACs in constant timeEric Dumazet (5):
net: annotate data-races around sk->sk_{data_ready,write_space}
inet: annotate data-races aroundisk->inet_num
indirect_call_wrapper: do not reevaluate function pointer
tcp:secure_seq: add back ports to TS offset
net_sched:sch_fq: clear q->band_pkt_count[] infq_reset()Ethan Tidmore (2):
drm/tiny: sharp-memory: fix pointer error dereference
xfs: Fix error pointer dereferenceFelix Gu (7):
drm/logicvc: Fix device node reference leak in
logicvc_drm_config_parse()
regulator: fp9931: Fix PM runtime reference leak infp9931_hwmon_read() regulator: bq257xx: Fix device node reference leak in bq257xx_reg_dt_parse_gpio() pinctrl: pinconf-generic: Fix memory leak in pinconf_generic_parse_dt_config() pinctrl: meson: amlogic-a4: Fix device node reference leak in aml_dt_node_to_map_pinmux()pinctrl: cirrus: cs42l43: Fix double-put in
cs42l43_pin_probe()
regulator: mt6363: Fix incorrect and redundant IRQ disposal in probeFernando Fernandez Mancera (2):
net: bridge: fixnd_tblNULL dereference when IPv6 is disabled
net: vxlan: fixnd_tblNULL dereference when IPv6 is disabledFlorian Eckert (2):
pinctrl: equilibrium: renameirq_chipfunction callbacks
pinctrl: equilibrium: fix warning trace on loadFlorian Westphal (1):
netfilter:nft_set_pipapo: split gc into unlink and reclaim phaseFrancesco Lavra (1):
drm/solomon: Fix page start when updating rectangle in page addressing
modeFuad Tabba (3):
KVM: arm64: Hide S1POE from guests when not supported by the host
KVM: arm64: Fix ID register initialization for non-protected pKVM
guests
bpf, arm64: Force 8-byte alignment for JIT buffer to prevent atomic
tearingGeoffrey D. Bennett (3):
ALSA: scarlett2: Fix DSP filter control array handling
ALSA: usb-audio: RemoveVALIDATE_RATESquirk for Focusrite devices
ALSA: usb-audio: AddQUIRK_FLAG_SKIP_IFACE_SETUPGerd Rausch (1):
time/jiffies: Fix sysctl file error on configurations whereUSER_HZ<
HZGreg Kroah-Hartman (12):
nfc: pn533: properly drop the usb interface reference on disconnect
net: usb: kaweth: validate USB endpoints
net: usb: kalmia: validate USB endpoints
net: usb: pegasus: validate USB endpoints
can:ems_usb:ems_usb_read_bulk_callback(): check the proper length of
a message
can: usb: f81604: correctly anchor the urb in the read bulk callback
can: ucan: Fix infinite loop from zero-length messages
can: usb:etas_es58x: correctly anchor the urb in the read bulk
callback
can: usb: f81604: handle short interrupt urb messages properly
can: usb: f81604: handle bulk write errors properly
HID: AddHID_CLAIMED_INPUTguards inraw_eventcallbacks missing them Revert "netfilter:nft_set_rbtree: validate open interval overlap"Guenter Roeck (5):
hwmon: (macsmc) Fix regressions in Apple Silicon SMC hwmon driver
hwmon: (macsmc) Fix overflows, underflows, and sign extension
dpaa2-switch: Fix interrupt storm after receiving badif_idin IRQ
handler
ata: libata-eh: Fix detection of deferred qc timeouts
tracing: Add NULL pointer check totrigger_data_free()Hao Yu (1):
hwmon: (aht10) Fix initialization commands for AHT20Haocheng Yu (1):
perf/core: Fix refcount bug and potential UAF inperf_mmapHarishankar Vishwanathan (1):
bpf: Introducetnum_stepto step through tnum's membersHarry Yoo (1):
mm/slab: pass__GFP_NOWARNtorefill_sheaf()if fallback is availableHeiko Carstens (2):
s390/idle: Fix cpu idle exit cpu time accounting s390/vtime: Fix virtual timer forwardingHeitor Alves de Siqueira (1):
Bluetooth: purge error queues in socket destructorsHenrique Carvalho (1):
smb: client: fixcifs_pick_channelwhen channels are equally loadedHou Wenlong (1):
x86/bug: Handle__WARN_printf()trap inearly_fixup_exception()Ian Forbes (1):
drm/vmwgfx: Return the correct value invmw_translate_ptrfunctionsIan Ray (2):
HID: multitouch: new classMT_CLS_EGALAX_P80H84
net: nfc: nci: Fix zero-length proprietary notificationsIngo Molnar (3):
sched/fair: Renamecfs_rq::avg_loadtocfs_rq::sum_weightsched/fair: Renamecfs_rq::avg_vruntimeto ::sum_w_vruntime, and
helper functions
sched/fair: Introduce and use thevruntime_cmp()andvruntime_op()
wrappers for wrapped-signed aritmeticsIoana Ciornei (1):
irqchip/ls-extirq: Fixdevm_of_iomap()error checkJakub Kicinski (6):
tcp: give up on strongersk_rcvbufchecks (for now)
ipv6: fix NULL pointer deref inip6_rt_get_dev_rcu()
nfc: nci: free skb onnci_transceiveearly error paths
nfc: nci: complete pending data exchange on device close
nfc: nci: clearNCI_DATA_EXCHANGEbefore calling completion callback
nfc: rawsock: canceltx_workbefore socket teardownJamal Hadi Salim (1):
net/sched:act_ife: Fix metalist update behaviorJan Stancek (1):
x86/boot: Handle relativeCONFIG_EFI_SBAT_FILEfile pathsJann Horn (1):
eventpoll: Fix integer overflow inep_loop_check_proc()Jason Gunthorpe (3):
IB/mthca: Add missedmthca_unmap_user_db()formthca_create_srq()RDMA/irdma: Fix kernel stack leak inirdma_create_user_ah()RDMA/ionic: Fix kernel stack leak inionic_create_cq()Jens Axboe (2):
io_uring/cmd_net: useREAD_ONCE()for ->addr3 read
media: dvb-core: fix wrong reinitialization of ringbuffer on reopenJiayuan Chen (5):
bpf: Fix race in cpumap onPREEMPT_RT
bpf: Fix race in devmap onPREEMPT_RT
atm: lec: fix null-ptr-deref inlec_arp_clear_vccsbpf/bonding: reject vlan+srcmacxmit_hash_policychange when XDP is
loaded
net: ipv6: fix panic when IPv4 route references loopback IPv6 nexthopJohannes Berg (1):
wifi: radiotap: reject radiotap with unknown bitsJonathan Cavitt (1):
drm/client: Do not destroy NULL modesJonathan Teh (1):
platform/x86:thinkpad_acpi: Fix errors reading battery thresholdsJuhyung Park (2):
ALSA: hda/realtek: fix model name typo for Samsung Galaxy Book Flex(NT950QCG-X716) ALSA: hda/realtek: add quirk for Samsung Galaxy Book Flex (NT950QCT-A38A)Julian Orth (1):
drm/syncobj: Fix handle <-> fd ioctls with dirty stackJun Seo (1):
ALSA: usb-audio: Use correct version for UAC3 header validationJunxiao Bi (1):
scsi: core: Fix refcount leak fortagset_refcntJuri Lelli (1):
sched/deadline: Fix missingENQUEUE_REPLENISHduring PI de-boostingJustin Tee (1):
nvmet-fcloop: Check remoteportport_statebefore calling done callbackKeith Busch (1):
nvme-multipath: fix leak ontry_module_getfailureKhushit Shah (1):
KVM: x86: Add x2APIC "features" to control EOI broadcast suppressionKim Phillips (1):
x86/sev: Allow IBPB-on-Entry feature for SNP guestsKohei Enju (2):
bpf: Fix stack-out-of-bounds write in devmap
iavf: fixnetdev->max_mtuto respect actual hardware limitKoichiro Den (1):
net: sched: avoidqdisc_reset_all_tx_gt()vs dequeue race for lockless
qdiscsKuen-Han Tsai (3):
usb: gadget:u_ether: addgether_optsfor config caching
usb: gadget:u_ether: Add auto-cleanup helper for freeingnet_device
usb: gadget:f_ncm: alignnet_devicelifecycle with bind/unbindKuniyuki Iwashima (2):
nfsd: Fix cred ref leak innfsd_nl_threads_set_doit().
udp: Unhash auto-bound connected sk from 4-tuple hash table when
disconnected.Kurt Borja (2):
platform/x86: alienware-wmi-wmax: Add G-Mode support to m18 laptops platform/x86: dell-wmi: Add audio/mic mute key codesLang Xu (1):
bpf: Fix a UAF issue inbpf_trampoline_link_cgroup_shimLars Ellenberg (1):
drbd: fix "LOGIC BUG" indrbd_al_begin_io_nonblock()Larysa Zaremba (9):
ice: fix adding AQ LLDP filter for VF
xdp: use modulo operation to calculate XDP frag tailroom
xsk: introduce helper to determinerxq->frag_size
ice: fix rxq info registering in mbuf packets
ice: change XDP RxQfrag_sizefrom DMA write length to xdp.frame_sz
i40e: fix registering XDP RxQ info
i40e: use xdp.frame_sz as XDP RxQ infofrag_size
net: enetc: use truesize as XDP RxQ infofrag_size
xdp: produce a warning when calculated tailroom is negativeLi Li (1):
idpf: increment completion queuenext_to_cleanin sw marker wait
routineLijo Lazar (1):
drm/amdgpu: Fix error handling in slot resetLizhi Hou (11):
accel/amdxdna: Remove buffer size check when creating command BO accel/amdxdna: Switch to always use chained command accel/amdxdna: Fix crash when destroying a suspended hardware context accel/amdxdna: Fix dead lock for suspend and resume accel/amdxdna: Fix suspend failure after enabling turbo mode accel/amdxdna: Fix command hang on suspended hardware context accel/amdxdna: Fix out-of-bounds memset in command slot handling accel/amdxdna: Prevent ubuf size overflow
accel/amdxdna: Validate command buffer payload count accel/amdxdna: Fill invalid payload for failed command accel/amdxdna: Fix NULL pointer dereference ofmgmt_channLorenzo Bianconi (4):
wifi: mt76: mt7996: Fix possible oob access inmt7996_mac_write_txwi_80211() wifi: mt76: mt7925: Fix possible oob access in mt7925_mac_write_txwi_80211() wifi: mt76: Fix possible oob access in mt76_connac2_mac_write_txwi_80211()net: ethernet:
mtk_eth_soc: Reset prog ptr toold_progin case of
error inmtk_xdp_setup()MD Danish Anwar (1):
net: ti: icssg-prueth: Fix ping failure after offload mode setup when
link speed is not 1GMario Limonciello (2):
accel/amdxdna: Reduce log noise during process termination platform/x86: hp-bioscfg: Support allocations of larger dataMariusz Skamra (1):
Bluetooth: Fix CIS host feature conditionMark Harmstone (6):
btrfs: fix error message order of parameters in
btrfs_delete_delayed_dir_index()
btrfs: fix incorrect key offset in error message in
check_dev_extent_item()
btrfs: fix objectid value in error message incheck_extent_data_ref()
btrfs: fix warning inscrub_verify_one_metadata()
btrfs: print correct subvol num if active swapfile prevents deletion
btrfs: fix compat mask in error messages inbtrfs_check_features()Mathias Krause (1):
scsi: lpfc: Properly set WC for DPP mappingMathieu Desnoyers (1):
rseq: Clarify rseq registrationrseq_sizebound check commentMatt Roper (1):
drm/xe/wa: Steer RMW of MCR registers while building default LRCMatthew Brost (1):
drm/xe: Do not preempt fence signaling CS instructionsMatthieu Baerts (NGI0) (4):
mptcp: pm: avoid sendingRM_ADDRover same subflow
mptcp: pm: in-kernel: always mark signal+subflow endp as used
selftests: mptcp: join: checkRM_ADDRnot sent over same subflow
selftests: mptcp: join: check removing signal+subflow endpMaulik Shah (1):
pinctrl: qcom: qcs615: Add missing dual edge GPIO IRQ errata flagMichal Schmidt (1):
ice: fix crash in ethtool offline loopback testMichal Swiatkowski (1):
libie: don't unroll if fwlog isn't supportedMieczyslaw Nalewaj (1):
net: dsa: realtek: rtl8365mb: fixrtl8365mb_phy_ocp_writereturn valueMike Rapoport (Microsoft) (1):
x86/efi: defer freeing of boot services memoryMing Lei (2):
nvme: fix admin queue leak on controller reset
block: use trylock to avoid lockdep circular dependency in sysfsMiquel Sabaté Solà (1):
btrfs: free pages on error inbtrfs_uring_read_extent()Miroslav Lichvar (1):
timekeeping: Fix timex status validation for auxiliary clocksNam Cao (1):
irqchip/sifive-plic: Fix frozen interrupt due to affinity settingNamhyung Kim (1):
perf/core: Fix invalid wait context inctx_sched_in()Natalie Vock (1):
drm/amd/display: UseGFP_ATOMICindc_create_stream_for_sinkNathan Chancellor (2):
kbuild: Split .modinfo out fromELF_DETAILS
kbuild: Leave objtool binary around with 'make clean'Nikhil P. Rao (2):
xsk: Fix fragment node deletion to prevent buffer leak
xsk: Fix zero-copyAF_XDPfragment dropNiklas Cassel (3):
PCI: dwc: ep: Refresh MSI Message Address cache on change
PCI: dwc: ep: Flush MSI-X write before unmapping its ATU entry
ata: libata: cancel pending work after clearingdeferred_qcOliver Hartkopp (2):
can: bcm: fix locking forbcm_opruntime updates
can:dummy_can:dummy_can_init(): fix packet statisticsOlivier Sobrie (1):
hwmon: (max6639) fix inverted polarityOvidiu Panait (4):
net: stmmac: Fix error handling in VLAN add and delete paths
net: stmmac: Improve double VLAN handling
net: stmmac: Fix VLAN HW state restore
net: stmmac: Defer VLAN HW configuration when interface is downPablo Neira Ayuso (2):
netfilter:nf_tables: unconditionally bumpset->nelemsbefore
insertion
netfilter:nf_tables: clone set on flush onlyPanagiotis Foliadis (2):
ALSA: hda/intel: increase defaultbdl_pos_adjfor Nvidia controllers
ALSA: hda/realtek: Add quirk for Acer Aspire V3-572GPaolo Abeni (1):
selftests: mptcp: more stablesimult_flowstestsPaul Chaignon (1):
bpf: Improve bounds when tnum has a single possible valuePaulo Alcantara (2):
smb: client: fix broken multichannel with krb5+signing
smb: client: fix oops due to uninitialised var insmb2_unlink()Peter Wang (1):
scsi: ufs: core: Move link recovery for hibern8 exit failure to
wl_resumePeter Zijlstra (9):
x86/cfi: Fix CFI rewrite for odd alignments
sched/fair: Fixzero_vruntimetracking
sched/fair: Only set slice protection at pick time sched/fair: Fix lag clamp
perf: Fix__perf_event_overflow()vsperf_remove_from_context()race x86/numa: Store extra copy ofnuma_nodes_parsed
x86/topo: Addtopology_num_nodes_per_package()
x86/topo: Replacex86_has_numa_in_package
x86/topo: Fix SNC topology messPetr Pavlu (1):
module: Remove duplicate freeing of lockdep classesPhillip Lougher (1):
Squashfs: check metadata block offset is within rangePrithvi Tambewagh (1):
scsi: target: Fix recursive locking in__configfs_open_file()Qing Wang (1):
tracing: FixWARN_ONintracing_buffers_mmap_closeQuentin Schulz (2):
accel/rocket: fix unwinding in error path inrocket_core_initaccel/rocket: fix unwinding in error path inrocket_probeRaju Rangoju (2):
amd-xgbe: fixMAC_TCR_SSregister width for 2.5G and 10M speeds
amd-xgbe: fix sleep while atomic on suspend/resumeRichard Fitzgerald (1):
ALSA: hda: cs35l56: Fix signedness error incs35l56_hda_posture_put()Rob Herring (Arm) (2):
accel: ethosu: Fix job submit error clean-up refcount underflows
accel: ethosu: FixNPU_OP_ELEMENTWISEvalidation with scalarRong Zhang (1):
ALSA: doc: usb-audio: Add doc forQUIRK_FLAG_SKIP_IFACE_SETUPRussell King (Oracle) (1):
net: stmmac: remove support forlpi_intr_oSalomon Dushimirimana (1):
scsi: pm8001: Fix use-after-free inpm8001_queue_command()Sasha Levin (1):
Linux 6.19.7-rc1Sebastian Andrzej Siewior (1):
net: Provide aPREEMPT_RTspecific check fornetdev_queue::_xmit_lockSebastian Krzyszkowiak (1):
wifi: rsi: Don't default to-EOPNOTSUPPinrsi_mac80211_configShuicheng Lin (2):
drm/xe/configfs: Freectx_restore_mid_bbin release drm/xe/reg_sr: Fix leak onxa_storefailureShuvam Pandey (1):
kunit: tool: copy caller args inrun_kernelto prevent mutationSimon Ser (1):
drm/fourcc: fix plane order for 10/12/16-bit YCbCr formatsSreedevi Joshi (1):
idpf: Fix flow rule delete failure due to invalid validationSrinivas Pandruvada (1):
cpufreq:intel_pstate: Fix crash during turbo disableSun Jian (1):
selftests/harness: orderTEST_FandXFAIL_ADDconstructorsSungwoo Kim (1):
nvme: fix memory allocation innvme_pr_read_keys()T.J. Mercier (1):
selftests/bpf: Fix OOB read indmabuf_collectorTakashi Iwai (4):
ALSA: usb-audio: Cap the packet size pre-calculations
ALSA: usb-audio: Use inclusive terms
ALSA: usb: qcom: Correct parameter comment for
uaudio_transfer_buffer_setup()
ASoC: SDCA: Fix comments forsdca_irq_request()Thomas Gleixner (2):
debugobject: Make it work with deferred page initialization - again
i40e: Fix preempt count leak in napi poll tracepointThomas Weißschuh (1):
ARM: clean up thememset64()C wrapperThorsten Blum (2):
platform/x86: dell-wmi-sysman: Don't hex dump plaintext password data
smb: client: Don't log plaintext credentials incifs_set_cifscredsTianci Cao (1):
bpf: Add bitwise tracking forBPF_ENDTom Lendacky (1):
x86/boot/sev: Move SEV decompressor variables into the .data sectionTomasz Lis (1):
drm/xe/queue: Call fini on exec queue creation failTomasz Pakuła (1):
HID: pidff: Fix condition effect bit clearingTvrtko Ursulin (1):
drm/amdgpu/userq: Do not allow userspace to trivially triger kernel
warningsVahagn Vardanian (1):
wifi: mac80211: fix NULL pointer dereference inmesh_rx_csa_frame()Vasily Gorbik (1):
s390/kexec: Disable stack protector ins390_reset_system()Vimlesh Kumar (4):
octeon_ep: Relocate counter updates before NAPI
octeon_ep: avoid compiler and IQ/OQ reordering
octeon_ep_vf: Relocate counter updates before NAPI
octeon_ep_vf: avoid compiler and IQ/OQ reorderingVitaly Lifshits (1):
e1000e: clearDPG_ENafter reset to avoid autonomous power-gatingVivek Behera (2):
igb: Fix trigger of incorrect irq inigb_xsk_wakeup
igc: Fix trigger of incorrect irq inigc_xsk_wakeupfunctionWaiman Long (2):
cgroup/cpuset: Fix incorrect change toeffective_xcpusin
partition_xcpus_del()
cgroup/cpuset: Fix incorrect use ofcpuset_update_tasks_cpumask()in
update_cpumasks_hier()Wang Tao (1):
sched/eevdf: Updatese->vprotinreweight_entity()Werner Sembach (1):
HID: multitouch: Keep latency normal on deactivate for reactivation
gestureWill Deacon (2):
arm64: io: Renameioremap_prot()to__ioremap_prot()
arm64: io: Extract user memory type inioremap_prot()Yifan Wu (1):
selftest/arm64: Fixsve2p1_sigill()to hwcap testYujie Liu (1):
drm/sched: Fix kernel-doc warning fordrm_sched_job_done()Yung Chih Su (1):
net: ipv4: fix ARM64 alignment fault in multipath hash seedZhang Heng (2):
ALSA: hda/realtek: Add quirk for HP Pavilion 15-eh1xxx to enable mute
LED
ALSA: hda/realtek: add quirk for Acer Nitro ANV15-51ZhangGuoDong (2):
smb/client: fix buffer size forsmb311_posix_qinfoinsmb2_compound_op() smb/client: fix buffer size for smb311_posix_qinfo in SMB311_posix_query_info()Zhanjun Dong (1):
drm/xe/gsc: Fix GSC proxy cleanup on early initialization failureZide Chen (1):
perf/x86/intel/uncore: Add per-scheduler IMC CAS count eventsZilin Guan (1):
ice: Fix memory leak inice_set_ringparam()Documentation/sound/alsa-configuration.rst | 4 + Documentation/virt/kvm/api.rst | 28 ++- Makefile | 12 +- arch/alpha/kernel/vmlinux.lds.S | 1 + arch/arc/kernel/vmlinux.lds.S | 1 + arch/arm/boot/compressed/vmlinux.lds.S | 1 + arch/arm/include/asm/string.h | 14 +- arch/arm/kernel/vmlinux-xip.lds.S | 1 + arch/arm/kernel/vmlinux.lds.S | 1 + arch/arm64/include/asm/io.h | 26 +- arch/arm64/include/asm/pgtable-prot.h | 3 - arch/arm64/kernel/acpi.c | 2 +- arch/arm64/kernel/vmlinux.lds.S | 1 + arch/arm64/kvm/hyp/nvhe/pkvm.c | 35 ++- arch/arm64/kvm/sys_regs.c | 3 + arch/arm64/mm/ioremap.c | 6 +- arch/arm64/mm/mmap.c | 8 +- arch/arm64/net/bpf_jit_comp.c | 2 +- arch/csky/kernel/vmlinux.lds.S | 1 + arch/hexagon/kernel/vmlinux.lds.S | 1 + arch/loongarch/kernel/vmlinux.lds.S | 1 + arch/m68k/kernel/vmlinux-nommu.lds | 1 + arch/m68k/kernel/vmlinux-std.lds | 1 + arch/m68k/kernel/vmlinux-sun3.lds | 1 + arch/mips/kernel/vmlinux.lds.S | 1 + arch/nios2/kernel/vmlinux.lds.S | 1 + arch/openrisc/kernel/vmlinux.lds.S | 1 + arch/parisc/boot/compressed/vmlinux.lds.S | 1 + arch/parisc/kernel/vmlinux.lds.S | 1 + arch/powerpc/kernel/vmlinux.lds.S | 1 + arch/riscv/kernel/vmlinux.lds.S | 1 + arch/s390/include/asm/idle.h | 1 + arch/s390/kernel/idle.c | 13 +- arch/s390/kernel/ipl.c | 2 +- arch/s390/kernel/irq.c | 10 +- arch/s390/kernel/vmlinux.lds.S | 1 + arch/s390/kernel/vtime.c | 18 +- arch/sh/kernel/vmlinux.lds.S | 1 + arch/sparc/kernel/vmlinux.lds.S | 1 + arch/um/kernel/dyn.lds.S | 1 + arch/um/kernel/uml.lds.S | 1 + arch/x86/boot/compressed/Makefile | 1 + arch/x86/boot/compressed/sev.c | 9 +- arch/x86/boot/compressed/vmlinux.lds.S | 2 +- arch/x86/boot/startup/sev-shared.c | 2 +- arch/x86/coco/sev/core.c | 1 + arch/x86/entry/entry_fred.c | 5 +- arch/x86/events/intel/uncore_snbep.c | 28 ++- arch/x86/include/asm/cfi.h | 12 +- arch/x86/include/asm/efi.h | 2 +- arch/x86/include/asm/kvm_host.h | 7 + arch/x86/include/asm/linkage.h | 4 +- arch/x86/include/asm/msr-index.h | 5 +- arch/x86/include/asm/numa.h | 6 + arch/x86/include/asm/topology.h | 6 + arch/x86/include/asm/traps.h | 2 + arch/x86/include/uapi/asm/kvm.h | 6 +- arch/x86/kernel/alternative.c | 29 ++- arch/x86/kernel/cpu/common.c | 3 + arch/x86/kernel/cpu/topology.c | 13 +- arch/x86/kernel/smpboot.c | 201 ++++++++++----- arch/x86/kernel/traps.c | 2 +- arch/x86/kernel/vmlinux.lds.S | 1 + arch/x86/kvm/ioapic.c | 2 +- arch/x86/kvm/lapic.c | 76 +++++- arch/x86/kvm/lapic.h | 2 + arch/x86/kvm/x86.c | 21 +- arch/x86/mm/extable.c | 7 +- arch/x86/mm/numa.c | 8 + arch/x86/mm/srat.c | 2 + arch/x86/net/bpf_jit_comp.c | 13 +- arch/x86/platform/efi/efi.c | 2 +- arch/x86/platform/efi/quirks.c | 55 +++- block/blk-sysfs.c | 8 +- block/elevator.c | 12 +- drivers/accel/amdxdna/aie2_ctx.c | 55 ++-- drivers/accel/amdxdna/aie2_message.c | 36 ++- drivers/accel/amdxdna/aie2_pci.c | 23 +- drivers/accel/amdxdna/aie2_pci.h | 1 + drivers/accel/amdxdna/aie2_pm.c | 2 +- drivers/accel/amdxdna/amdxdna_ctx.c | 51 +++- drivers/accel/amdxdna/amdxdna_ctx.h | 3 + drivers/accel/amdxdna/amdxdna_gem.c | 38 +-- drivers/accel/amdxdna/amdxdna_pm.c | 2 + drivers/accel/amdxdna/amdxdna_pm.h | 11 + drivers/accel/amdxdna/amdxdna_ubuf.c | 6 +- drivers/accel/ethosu/ethosu_gem.c | 7 +- drivers/accel/ethosu/ethosu_job.c | 26 +- drivers/accel/rocket/rocket_core.c | 7 +- drivers/accel/rocket/rocket_drv.c | 15 +- drivers/ata/libata-eh.c | 3 +- drivers/ata/libata-scsi.c | 1 + drivers/block/drbd/drbd_actlog.c | 53 ++-- drivers/block/drbd/drbd_interval.h | 5 +- drivers/block/drbd/drbd_req.c | 3 +- drivers/block/zloop.c | 31 ++- drivers/char/ipmi/ipmi_msghandler.c | 11 +- drivers/clk/imx/clk-imx8qxp.c | 24 +- drivers/clk/imx/clk-scu.c | 12 +- drivers/clk/imx/clk-scu.h | 2 + drivers/cpufreq/intel_pstate.c | 10 +- drivers/crypto/ccp/sev-dev-tsm.c | 2 +- drivers/cxl/core/mbox.c | 11 +- drivers/cxl/core/pmem.c | 42 +++- drivers/cxl/cxl.h | 7 + drivers/cxl/pmem.c | 22 +- drivers/firmware/efi/mokvar-table.c | 2 +- drivers/gpio/gpiolib-shared.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 +- drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c | 12 +- .../gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 8 +- .../amd/display/amdgpu_dm/amdgpu_dm_color.c | 6 +- .../amd/display/amdgpu_dm/amdgpu_dm_colorop.c | 3 +- .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 16 +- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 8 + .../gpu/drm/amd/display/dc/core/dc_stream.c | 2 +- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 4 +- drivers/gpu/drm/drm_client_modeset.c | 3 +- drivers/gpu/drm/drm_syncobj.c | 4 +- drivers/gpu/drm/imx/ipuv3/parallel-display.c | 4 +- drivers/gpu/drm/logicvc/logicvc_drm.c | 4 +- drivers/gpu/drm/scheduler/sched_main.c | 1 + drivers/gpu/drm/solomon/ssd130x.c | 6 +- drivers/gpu/drm/tiny/sharp-memory.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c | 9 +- drivers/gpu/drm/xe/regs/xe_engine_regs.h | 6 + drivers/gpu/drm/xe/xe_configfs.c | 1 + drivers/gpu/drm/xe/xe_exec_queue.c | 23 +- drivers/gpu/drm/xe/xe_gsc_proxy.c | 43 +++- drivers/gpu/drm/xe/xe_gsc_types.h | 2 + drivers/gpu/drm/xe/xe_gt.c | 66 ++++- drivers/gpu/drm/xe/xe_lrc.h | 3 +- drivers/gpu/drm/xe/xe_reg_sr.c | 4 +- drivers/gpu/drm/xe/xe_ring_ops.c | 9 + drivers/hid/hid-cmedia.c | 2 +- drivers/hid/hid-creative-sb0540.c | 2 +- drivers/hid/hid-multitouch.c | 43 +++- drivers/hid/hid-zydacron.c | 2 +- drivers/hid/usbhid/hid-pidff.c | 11 +- drivers/hwmon/aht10.c | 6 +- drivers/hwmon/it87.c | 5 +- drivers/hwmon/macsmc-hwmon.c | 53 ++-- drivers/hwmon/max6639.c | 2 +- drivers/i2c/busses/i2c-i801.c | 14 +- .../infiniband/hw/ionic/ionic_controlpath.c | 2 +- drivers/infiniband/hw/irdma/verbs.c | 2 +- drivers/infiniband/hw/mthca/mthca_provider.c | 5 +- drivers/irqchip/irq-ls-extirq.c | 6 +- drivers/irqchip/irq-sifive-plic.c | 7 +- drivers/media/dvb-core/dmxdev.c | 4 +- drivers/net/bonding/bond_main.c | 9 +- drivers/net/bonding/bond_options.c | 2 + drivers/net/can/dummy_can.c | 1 + drivers/net/can/spi/mcp251x.c | 15 +- drivers/net/can/usb/ems_usb.c | 7 +- drivers/net/can/usb/etas_es58x/es58x_core.c | 8 +- drivers/net/can/usb/f81604.c | 45 +++- drivers/net/can/usb/ucan.c | 2 +- drivers/net/dsa/realtek/rtl8365mb.c | 2 +- drivers/net/ethernet/amd/xgbe/xgbe-common.h | 2 +- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 10 - drivers/net/ethernet/amd/xgbe/xgbe-main.c | 1 - drivers/net/ethernet/amd/xgbe/xgbe.h | 3 - .../ethernet/freescale/dpaa2/dpaa2-switch.c | 3 +- drivers/net/ethernet/freescale/enetc/enetc.c | 2 +- drivers/net/ethernet/google/gve/gve_tx_dqo.c | 56 ++--- drivers/net/ethernet/intel/e1000e/defines.h | 1 + drivers/net/ethernet/intel/e1000e/ich8lan.c | 9 + drivers/net/ethernet/intel/i40e/i40e_main.c | 41 +-- drivers/net/ethernet/intel/i40e/i40e_trace.h | 2 +- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 5 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 17 +- drivers/net/ethernet/intel/ice/ice.h | 1 + drivers/net/ethernet/intel/ice/ice_base.c | 38 ++- drivers/net/ethernet/intel/ice/ice_common.c | 2 +- drivers/net/ethernet/intel/ice/ice_ethtool.c | 16 +- drivers/net/ethernet/intel/ice/ice_idc.c | 44 +++- drivers/net/ethernet/intel/ice/ice_lib.c | 15 +- drivers/net/ethernet/intel/ice/ice_main.c | 7 +- drivers/net/ethernet/intel/ice/ice_txrx.c | 4 +- drivers/net/ethernet/intel/ice/ice_xsk.c | 3 + .../net/ethernet/intel/idpf/idpf_ethtool.c | 3 - drivers/net/ethernet/intel/idpf/idpf_txrx.c | 8 +- drivers/net/ethernet/intel/igb/igb_xsk.c | 38 ++- drivers/net/ethernet/intel/igc/igc_main.c | 34 ++- drivers/net/ethernet/intel/igc/igc_ptp.c | 3 +- drivers/net/ethernet/intel/libie/fwlog.c | 4 + .../ethernet/marvell/octeon_ep/octep_main.c | 40 ++- .../net/ethernet/marvell/octeon_ep/octep_rx.c | 27 +- .../marvell/octeon_ep_vf/octep_vf_main.c | 38 ++- .../marvell/octeon_ep_vf/octep_vf_rx.c | 28 ++- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 15 +- drivers/net/ethernet/stmicro/stmmac/common.h | 1 - .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 4 - .../ethernet/stmicro/stmmac/dwmac-loongson.c | 7 - drivers/net/ethernet/stmicro/stmmac/stmmac.h | 3 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 89 +++---- .../ethernet/stmicro/stmmac/stmmac_platform.c | 8 - .../net/ethernet/stmicro/stmmac/stmmac_vlan.c | 60 ++--- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +- drivers/net/ethernet/ti/cpsw_ale.c | 9 +- drivers/net/ethernet/ti/icssg/icssg_prueth.c | 8 + drivers/net/phy/phy_device.c | 25 +- drivers/net/usb/kalmia.c | 7 + drivers/net/usb/kaweth.c | 13 + drivers/net/usb/pegasus.c | 13 +- drivers/net/vxlan/vxlan_core.c | 5 + drivers/net/wireless/marvell/libertas/main.c | 4 +- .../wireless/mediatek/mt76/mt76_connac_mac.c | 1 + .../net/wireless/mediatek/mt76/mt7925/mac.c | 1 + .../net/wireless/mediatek/mt76/mt7996/mac.c | 1 + drivers/net/wireless/rsi/rsi_91x_mac80211.c | 2 +- drivers/net/wireless/st/cw1200/pm.c | 2 + drivers/net/wireless/ti/wlcore/main.c | 4 +- drivers/nfc/pn533/usb.c | 1 + drivers/nvme/host/core.c | 7 + drivers/nvme/host/multipath.c | 12 +- drivers/nvme/host/pr.c | 4 +- drivers/nvme/target/fcloop.c | 15 +- .../pci/controller/dwc/pcie-designware-ep.c | 25 +- drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 5 +- drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 70 +++++- drivers/pinctrl/pinconf-generic.c | 73 +----- drivers/pinctrl/pinctrl-equilibrium.c | 31 ++- drivers/pinctrl/qcom/pinctrl-qcs615.c | 1 + .../platform/x86/dell/alienware-wmi-wmax.c | 2 +- drivers/platform/x86/dell/dell-wmi-base.c | 6 + .../dell-wmi-sysman/passwordattr-interface.c | 1 - .../x86/hp/hp-bioscfg/enum-attributes.c | 9 +- drivers/platform/x86/lenovo/thinkpad_acpi.c | 6 +- drivers/regulator/bq257xx-regulator.c | 3 +- drivers/regulator/fp9931.c | 7 +- drivers/regulator/mt6363-regulator.c | 4 +- drivers/scsi/lpfc/lpfc_init.c | 2 + drivers/scsi/lpfc/lpfc_sli.c | 36 ++- drivers/scsi/lpfc/lpfc_sli4.h | 3 + drivers/scsi/pm8001/pm8001_sas.c | 5 +- drivers/scsi/scsi_scan.c | 1 + drivers/spi/spi-stm32.c | 3 + drivers/target/target_core_configfs.c | 15 +- drivers/ufs/core/ufshcd.c | 38 ++- drivers/usb/gadget/function/f_ncm.c | 128 +++++----- drivers/usb/gadget/function/u_ether.c | 45 ++++ drivers/usb/gadget/function/u_ether.h | 30 +++ .../usb/gadget/function/u_ether_configfs.h | 176 +++++++++++++ drivers/usb/gadget/function/u_ncm.h | 4 +- drivers/xen/xen-acpi-processor.c | 7 +- fs/btrfs/delayed-inode.c | 2 +- fs/btrfs/disk-io.c | 6 +- fs/btrfs/inode.c | 2 +- fs/btrfs/ioctl.c | 7 +- fs/btrfs/scrub.c | 2 +- fs/btrfs/tree-checker.c | 4 +- fs/eventpoll.c | 5 +- fs/namespace.c | 20 +- fs/netfs/direct_write.c | 228 +++++++++++++++-- fs/netfs/internal.h | 4 +- fs/netfs/write_collect.c | 21 -- fs/netfs/write_issue.c | 41 +-- fs/nfsd/nfsctl.c | 2 +- fs/smb/client/connect.c | 1 - fs/smb/client/smb2inode.c | 8 +- fs/smb/client/smb2pdu.c | 24 +- fs/smb/client/transport.c | 21 +- fs/smb/server/Kconfig | 1 + fs/smb/server/auth.c | 4 +- fs/smb/server/smb2pdu.c | 5 +- fs/squashfs/cache.c | 3 + fs/xfs/scrub/orphanage.c | 7 +- fs/xfs/xfs_notify_failure.c | 4 +- include/asm-generic/vmlinux.lds.h | 4 +- include/linux/indirect_call_wrapper.h | 18 +- include/linux/netdevice.h | 27 +- include/linux/pinctrl/pinconf-generic.h | 5 - include/linux/ring_buffer.h | 1 + include/linux/sched.h | 1 + include/linux/stmmac.h | 1 - include/linux/tnum.h | 8 + include/linux/uaccess.h | 54 ++-- include/net/bonding.h | 1 + include/net/inet6_hashtables.h | 2 +- include/net/inet_hashtables.h | 2 +- include/net/ip.h | 2 +- include/net/ip_fib.h | 2 +- include/net/netfilter/nf_tables.h | 11 +- include/net/sch_generic.h | 10 + include/net/secure_seq.h | 45 +++- include/net/tc_act/tc_ife.h | 4 +- include/net/tcp.h | 6 +- include/net/xdp_sock_drv.h | 16 +- include/trace/events/netfs.h | 4 +- include/uapi/drm/drm_fourcc.h | 12 +- include/uapi/linux/pci_regs.h | 2 +- io_uring/cmd_net.c | 2 +- kernel/bpf/cpumap.c | 17 +- kernel/bpf/devmap.c | 47 +++- kernel/bpf/tnum.c | 72 ++++++ kernel/bpf/trampoline.c | 4 +- kernel/bpf/verifier.c | 103 +++++++- kernel/cgroup/cpuset.c | 4 +- kernel/events/core.c | 83 ++++-- kernel/module/main.c | 6 - kernel/rseq.c | 5 +- kernel/sched/ext_internal.h | 2 +- kernel/sched/fair.c | 238 +++++++++++++----- kernel/sched/sched.h | 4 +- kernel/sched/syscalls.c | 30 +++ kernel/time/jiffies.c | 2 - kernel/time/timekeeping.c | 6 +- kernel/trace/blktrace.c | 3 +- kernel/trace/ring_buffer.c | 21 ++ kernel/trace/trace.c | 13 + kernel/trace/trace_events_trigger.c | 3 + lib/Kconfig.debug | 1 + lib/debugobjects.c | 19 +- mm/huge_memory.c | 3 + mm/slub.c | 13 +- net/atm/lec.c | 26 +- net/bluetooth/hci_sock.c | 1 + net/bluetooth/hci_sync.c | 2 +- net/bluetooth/iso.c | 1 + net/bluetooth/l2cap_sock.c | 1 + net/bluetooth/sco.c | 1 + net/bridge/br_device.c | 2 +- net/bridge/br_input.c | 2 +- net/bridge/br_private.h | 10 + net/bridge/br_vlan_options.c | 26 +- net/can/bcm.c | 1 + net/core/dev.c | 7 +- net/core/devmem.c | 6 +- net/core/filter.c | 6 +- net/core/netpoll.c | 2 +- net/core/secure_seq.c | 80 +++--- net/core/skmsg.c | 14 +- net/ipv4/inet_hashtables.c | 8 +- net/ipv4/syncookies.c | 11 +- net/ipv4/sysctl_net_ipv4.c | 5 +- net/ipv4/tcp.c | 4 +- net/ipv4/tcp_bpf.c | 2 +- net/ipv4/tcp_diag.c | 2 +- net/ipv4/tcp_input.c | 38 ++- net/ipv4/tcp_ipv4.c | 37 ++- net/ipv4/tcp_minisocks.c | 2 +- net/ipv4/udp.c | 27 +- net/ipv4/udp_bpf.c | 2 +- net/ipv6/inet6_hashtables.c | 3 +- net/ipv6/route.c | 11 +- net/ipv6/syncookies.c | 11 +- net/ipv6/tcp_ipv6.c | 37 ++- net/mac80211/mesh.c | 3 + net/mac80211/mlme.c | 3 + net/mptcp/pm.c | 55 +++- net/mptcp/pm_kernel.c | 9 + net/netfilter/nf_tables_api.c | 66 +++-- net/netfilter/nft_set_hash.c | 1 + net/netfilter/nft_set_pipapo.c | 62 ++++- net/netfilter/nft_set_pipapo.h | 2 + net/netfilter/nft_set_rbtree.c | 79 ++---- net/nfc/nci/core.c | 30 ++- net/nfc/nci/data.c | 12 +- net/nfc/rawsock.c | 11 + net/rds/tcp.c | 14 +- net/sched/act_ife.c | 93 ++++--- net/sched/sch_ets.c | 12 +- net/sched/sch_fq.c | 1 + net/unix/af_unix.c | 8 +- net/wireless/core.c | 1 + net/wireless/radiotap.c | 4 +- net/xdp/xsk.c | 26 +- rust/kernel/kunit.rs | 8 + sound/hda/codecs/realtek/alc269.c | 13 +- sound/hda/codecs/side-codecs/cs35l56_hda.c | 2 +- sound/hda/controllers/intel.c | 2 + sound/soc/sdca/Kconfig | 2 + sound/soc/sdca/sdca_functions.c | 5 +- sound/soc/sdca/sdca_interrupts.c | 4 +- sound/usb/endpoint.c | 9 +- sound/usb/mixer_scarlett2.c | 10 +- sound/usb/qcom/qc_audio_offload.c | 2 +- sound/usb/quirks.c | 3 +- sound/usb/stream.c | 3 + sound/usb/usbaudio.h | 6 + sound/usb/validate.c | 2 +- tools/objtool/Makefile | 8 +- tools/testing/kunit/kunit_kernel.py | 6 +- tools/testing/kunit/kunit_tool_test.py | 26 ++ tools/testing/selftests/arm64/abi/hwcap.c | 4 +- .../testing/selftests/bpf/progs/dmabuf_iter.c | 2 +- .../selftests/bpf/progs/exceptions_assert.c | 34 +-- .../selftests/bpf/progs/verifier_scalar_ids.c | 56 +++-- .../testing/selftests/bpf/verifier/precise.c | 8 +- tools/testing/selftests/kselftest_harness.h | 7 +- .../testing/selftests/net/mptcp/mptcp_join.sh | 49 ++++ .../selftests/net/mptcp/simult_flows.sh | 11 +- 396 files changed, 4121 insertions(+), 1792 deletions(-)--
2.51.0
Quoted 9 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
Quoted 9 lines
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.19.y
and the diffstat can be found below.Thanks,
Sasha
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Quoted 8 lines · Sasha Levin
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
Quoted 8 lines
The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/rawdiff/?id=linux-6.19.y&id2=v6.19.6or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.19.y
and the diffstat can be found below.Thanks,
Sasha
Tested on my amd64 DIY home NAS. Working well, no regressions observed.
Signature · 1 line
-Barry K. Nathan <[email protected]>
Quoted 8 lines · On Tue, 10 Mar 2026 07:05:54 -0400 Sasha Levin <[email protected]> wrote:
This is the start of the stable review cycle for the 6.19.7 release. There are 311 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 12 11:04:16 AM UTC 2026. Anything received after that time might be too late.
Boot-tested under QEMU for Rust x86_64, arm64 and riscv64; built-tested for loongarch64:
Thanks!
Cheers,
Miguel