serdev: Refine several error or debug messages
Subsystems (2)
PATCH v3 1/1 serdev: Refine several error or debug messages
From: Zijun Hu <[email protected]>
Refine several dev_err() and dev_dbg() messages to solve:
// hardcoded device namedev_dbg(dev, "...dev_name_str...")
// repeated device name since dev_dbg() also prints it as prefix dev_err(dev, "...%s...", dev_name(dev))
// not concise as dev_err(dev, "...%d...", err)dev_err(dev, "...%pe...", ERR_PTR(err))
---
For messages printed by dev_err() and dev_dbg(), this patch series is
to remove hardcoded or repeated device name.
---
Changes in v3:
- Squash both patches as Rob's comments
- Simplify error code printing as Jiri's comments
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Add one more patch to remove repeated device name pointed out by Greg
- Link to v1: https://lore.kernel.org/r/[email protected]
--- drivers/tty/serdev/core.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/tty/serdev/core.c +3 -5
@@ -118,12 +118,11 @@ int serdev_device_add(struct serdev_device *serdev) err =device_add (&serdev->dev);if (err <0 ) { -dev_err (&serdev->dev,"Can't add %s, status %pe\n" , -dev_name (&serdev->dev),ERR_PTR (err)); +dev_err (&serdev->dev,"Failed to add serdev: %d\n" , err); goto err_clear_serdev; } -dev_dbg (&serdev->dev,"device %s registered\n" ,dev_name (&serdev->dev)); +dev_dbg (&serdev->dev,"serdev registered successfully\n" );return 0 ;
@@ -783,8 +782,7 @@ int serdev_controller_add(struct serdev_controller *ctrl) goto err_rpm_disable; } -dev_dbg (&ctrl->dev,"serdev%d registered: dev:%p\n" , - ctrl->nr, &ctrl->dev); +dev_dbg (&ctrl->dev,"serdev controller registered: dev:%p\n" , &ctrl->dev);return 0 ; err_rpm_disable:
---
base-commit: 9d7a0577c9db35c4cc52db90bc415ea248446472
change-id: 20250422-fix_serdev-9da04229081b
Best regards,
Signature · 1 line
Zijun Hu <[email protected]>
Quoted 7 lines · Zijun Hu
From: Zijun Hu <[email protected]>
Refine several
dev_err()anddev_dbg()messages to solve:// hardcoded device name
dev_dbg(dev, "...dev_name_str...")
Quoted 7 lines
// repeated device name since
dev_dbg()also prints it as prefixdev_err(dev, "...%s...", dev_name(dev))// not concise as
dev_err(dev, "...%d...", err)dev_err(dev, "...%pe...", ERR_PTR(err))Signed-off-by Zijun Hu <[email protected]>
This LGTM.
Signature · 2 lines
js suse labs