arm64: Support ARM64_VA_BITS=52 when setting ARCH_MMAP_RND_BITS_MAX
PATCH 1/1 arm64: Support ARM64_VA_BITS=52 when setting ARCH_MMAP_RND_BITS_MAX
When the 52-bit virtual addressing was enabled the select like ARCH_MMAP_RND_BITS_MAX logic was never updated to account for it. Because of that the rnd max bits would be set to the default value of 18 when ARM64_VA_BITS=52.
Fix this by setting ARCH_MMAP_RND_BITS_MAX to the same value that would be used if 48-bit addressing was used. That's because the 52-bit addressing is used only if the caller provides a hint to mmap, with a fallback to 48-bit addressing.
--- arch/arm64/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/Kconfig +3 -3
@@ -332,9 +332,9 @@ config ARCH_MMAP_RND_BITS_MAX default 24 if ARM64_VA_BITS=39 default 27 if ARM64_VA_BITS=42 default 30 if ARM64_VA_BITS=47 - default 29 if ARM64_VA_BITS=48 && ARM64_64K_PAGES - default 31 if ARM64_VA_BITS=48 && ARM64_16K_PAGES - default 33 if ARM64_VA_BITS=48 + default 29 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_64K_PAGES + default 31 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_16K_PAGES + default 33 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) default 14 if ARM64_64K_PAGES default 16 if ARM64_16K_PAGES default 18
Signature · 1 line
2.49.0.504.g3bcea36a83-goog
Quoted 8 lines · Kornel Dulęba
When the 52-bit virtual addressing was enabled the select like
ARCH_MMAP_RND_BITS_MAXlogic was never updated to account for it. Because of that the rnd max bits would be set to the default value of 18 when ARM64_VA_BITS=52.
Fix this by settingARCH_MMAP_RND_BITS_MAXto the same value that would be used if 48-bit addressing was used. That's because the 52-bit addressing is used only if the caller provides a hint to mmap, with a fallback to 48-bit addressing.
Why should ARCH_MMAP_RND_BITS_MAX value be same for both 48 bits and 52 bits VA in case the user does request for 52 bit VA via mmap() hint and the HW supports it ?
Quoted 24 lines
Fixes b6d00d47e81a ("arm64: mm: Introduce 52-bit Kernel VAs")Signed-off-by Kornel Dulęba <[email protected]>--- arch/arm64/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm64/Kconfig +3
-3@@ -332,9 +332,9 @@ config ARCH_MMAP_RND_BITS_MAX default 24 if ARM64_VA_BITS=39 default 27 if ARM64_VA_BITS=42 default 30 if ARM64_VA_BITS=47 - default 29 if ARM64_VA_BITS=48 && ARM64_64K_PAGES - default 31 if ARM64_VA_BITS=48 && ARM64_16K_PAGES - default 33 if ARM64_VA_BITS=48 + default 29 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_64K_PAGES + default 31 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_16K_PAGES + default 33 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) default 14 if ARM64_64K_PAGES default 16 if ARM64_16K_PAGES default 18
Quoted 13 lines · Anshuman Khandual
Quoted 8 lines · Kornel Dulęba
When the 52-bit virtual addressing was enabled the select like
ARCH_MMAP_RND_BITS_MAXlogic was never updated to account for it. Because of that the rnd max bits would be set to the default value of 18 when ARM64_VA_BITS=52.
Fix this by settingARCH_MMAP_RND_BITS_MAXto the same value that would be used if 48-bit addressing was used. That's because the 52-bit addressing is used only if the caller provides a hint to mmap, with a fallback to 48-bit addressing.
Quoted 3 lines
Why should
ARCH_MMAP_RND_BITS_MAXvalue be same for both 48 bits and 52 bits VA in case the user does request for 52 bit VA viammap()hint and the HW supports it ?
Two reasons really.
1. The whole behavior is controlled through a global knob - /proc/sys/vm/mmap_rnd_bits. ARCH_MMAP_RND_BITS_MAX is used as an upper bound for the value that can be set to that knob.
So we have a single setting for all processes. Some might want 52 bit addressing, others will stick with 48.
2. Quoting the documentation for this knob:
"""mmap_rnd_bits
This value can be used to select the number of bits to use to determine the random offset to the base address of vma regions resulting from mmap allocations on architectures which support tuning address space randomization. This value will be bounded by the architecture’s minimum and maximum supported values.
"""
I suppose that it's legal for some calls to mmap from the same process to request a 52 bit VA, while other calls will want only 48 bits. Because of that the random offset can't be larger than what would work for the 48 bit case.
Quoted 25 lines
Quoted 25 lines
Fixes b6d00d47e81a ("arm64: mm: Introduce 52-bit Kernel VAs")Signed-off-by Kornel Dulęba <[email protected]>--- arch/arm64/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm64/Kconfig +3
-3@@ -332,9 +332,9 @@ config ARCH_MMAP_RND_BITS_MAX default 24 if ARM64_VA_BITS=39 default 27 if ARM64_VA_BITS=42 default 30 if ARM64_VA_BITS=47 - default 29 if ARM64_VA_BITS=48 && ARM64_64K_PAGES - default 31 if ARM64_VA_BITS=48 && ARM64_16K_PAGES - default 33 if ARM64_VA_BITS=48 + default 29 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_64K_PAGES + default 31 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_16K_PAGES + default 33 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) default 14 if ARM64_64K_PAGES default 16 if ARM64_16K_PAGES default 18
Quoted 37 lines · Kornel Dulęba
Quoted 13 lines · Anshuman Khandual
Quoted 8 lines · Kornel Dulęba
When the 52-bit virtual addressing was enabled the select like
ARCH_MMAP_RND_BITS_MAXlogic was never updated to account for it. Because of that the rnd max bits would be set to the default value of 18 when ARM64_VA_BITS=52.
Fix this by settingARCH_MMAP_RND_BITS_MAXto the same value that would be used if 48-bit addressing was used. That's because the 52-bit addressing is used only if the caller provides a hint to mmap, with a fallback to 48-bit addressing.Quoted 3 lines
Why should
ARCH_MMAP_RND_BITS_MAXvalue be same for both 48 bits and 52 bits VA in case the user does request for 52 bit VA viammap()hint and the HW supports it ?Two reasons really.
1. The whole behavior is controlled through a global knob -/proc/sys/vm/mmap_rnd_bits.ARCH_MMAP_RND_BITS_MAXis used as an upper bound for the value that can be set to that knob.
So we have a single setting for all processes. Some might want 52 bit addressing, others will stick with 48.
2. Quoting the documentation for this knob:"""
mmap_rnd_bits
This value can be used to select the number of bits to use to determine the random offset to the base address of vma regions resulting from mmap allocations on architectures which support tuning address space randomization. This value will be bounded by the architecture’s minimum and maximum supported values.
"""
Quoted 4 lines
I suppose that it's legal for some calls to mmap from the same process to request a 52 bit VA, while other calls will want only 48 bits. Because of that the random offset can't be larger than what would work for the 48 bit case.
Hi,
Do you have any further comments?
Regards
Kornel
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Fixes b6d00d47e81a ("arm64: mm: Introduce 52-bit Kernel VAs")Signed-off-by Kornel Dulęba <[email protected]>--- arch/arm64/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm64/Kconfig +3
-3@@ -332,9 +332,9 @@ config ARCH_MMAP_RND_BITS_MAX default 24 if ARM64_VA_BITS=39 default 27 if ARM64_VA_BITS=42 default 30 if ARM64_VA_BITS=47 - default 29 if ARM64_VA_BITS=48 && ARM64_64K_PAGES - default 31 if ARM64_VA_BITS=48 && ARM64_16K_PAGES - default 33 if ARM64_VA_BITS=48 + default 29 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_64K_PAGES + default 31 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_16K_PAGES + default 33 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) default 14 if ARM64_64K_PAGES default 16 if ARM64_16K_PAGES default 18
Anshuman Khandual
Reviewed-byQuoted 36 lines · Kornel Dulęba
Quoted 13 lines · Anshuman Khandual
Quoted 8 lines · Kornel Dulęba
When the 52-bit virtual addressing was enabled the select like
ARCH_MMAP_RND_BITS_MAXlogic was never updated to account for it. Because of that the rnd max bits would be set to the default value of 18 when ARM64_VA_BITS=52.
Fix this by settingARCH_MMAP_RND_BITS_MAXto the same value that would be used if 48-bit addressing was used. That's because the 52-bit addressing is used only if the caller provides a hint to mmap, with a fallback to 48-bit addressing.Quoted 3 lines
Why should
ARCH_MMAP_RND_BITS_MAXvalue be same for both 48 bits and 52 bits VA in case the user does request for 52 bit VA viammap()hint and the HW supports it ?Two reasons really.
1. The whole behavior is controlled through a global knob -/proc/sys/vm/mmap_rnd_bits.ARCH_MMAP_RND_BITS_MAXis used as an upper bound for the value that can be set to that knob.
So we have a single setting for all processes. Some might want 52 bit addressing, others will stick with 48.
2. Quoting the documentation for this knob:"""
mmap_rnd_bits
This value can be used to select the number of bits to use to determine the random offset to the base address of vma regions resulting from mmap allocations on architectures which support tuning address space randomization. This value will be bounded by the architecture’s minimum and maximum supported values.
"""
Quoted 4 lines
I suppose that it's legal for some calls to mmap from the same process to request a 52 bit VA, while other calls will want only 48 bits. Because of that the random offset can't be larger than what would work for the 48 bit case.
Agreed but should not this rationale also be added in the commit message as well ?
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Fixes b6d00d47e81a ("arm64: mm: Introduce 52-bit Kernel VAs")
Correct commit to be attributed for this fix.
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Signed-off-by Kornel Dulęba <[email protected]>--- arch/arm64/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm64/Kconfig +0
-1@@ -332,9 +332,9 @@ config ARCH_MMAP_RND_BITS_MAX default 24 if ARM64_VA_BITS=39 default 27 if ARM64_VA_BITS=42 default 30 if ARM64_VA_BITS=47 - default 29 if ARM64_VA_BITS=48 && ARM64_64K_PAGES
Quoted 8 lines
Quoted 8 lines
arch/arm64/Kconfig config ARCH_MMAP_RND_BITS_MAX · line 340
Quoted 8 lines
arch/arm64/Kconfig +3
-2- default 31 if ARM64_VA_BITS=48 && ARM64_16K_PAGES - default 33 if ARM64_VA_BITS=48 + default 29 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_64K_PAGES + default 31 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_16K_PAGES + default 33 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) default 14 if ARM64_64K_PAGES default 16 if ARM64_16K_PAGES default 18
Otherwise LGTM.
Quoted 40 lines · Anshuman Khandual
Quoted 36 lines · Kornel Dulęba
Quoted 13 lines · Anshuman Khandual
Quoted 8 lines · Kornel Dulęba
When the 52-bit virtual addressing was enabled the select like
ARCH_MMAP_RND_BITS_MAXlogic was never updated to account for it. Because of that the rnd max bits would be set to the default value of 18 when ARM64_VA_BITS=52.
Fix this by settingARCH_MMAP_RND_BITS_MAXto the same value that would be used if 48-bit addressing was used. That's because the 52-bit addressing is used only if the caller provides a hint to mmap, with a fallback to 48-bit addressing.Quoted 3 lines
Why should
ARCH_MMAP_RND_BITS_MAXvalue be same for both 48 bits and 52 bits VA in case the user does request for 52 bit VA viammap()hint and the HW supports it ?Two reasons really.
1. The whole behavior is controlled through a global knob -/proc/sys/vm/mmap_rnd_bits.ARCH_MMAP_RND_BITS_MAXis used as an upper bound for the value that can be set to that knob.
So we have a single setting for all processes. Some might want 52 bit addressing, others will stick with 48.
2. Quoting the documentation for this knob:"""
mmap_rnd_bits
This value can be used to select the number of bits to use to determine the random offset to the base address of vma regions resulting from mmap allocations on architectures which support tuning address space randomization. This value will be bounded by the architecture’s minimum and maximum supported values.
"""
Quoted 7 lines
Quoted 4 lines
I suppose that it's legal for some calls to mmap from the same process to request a 52 bit VA, while other calls will want only 48 bits. Because of that the random offset can't be larger than what would work for the 48 bit case.
Agreed but should not this rationale also be added in the commit message as well ?
Sure, I will update this in v2.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Fixes b6d00d47e81a ("arm64: mm: Introduce 52-bit Kernel VAs")Correct commit to be attributed for this fix.
What commit would you like me to point at? I selected b6d00d47e81a, because it introduced "ARM64_VA_BITS=52".
Looking at git blame, ARCH_MMAP_RND_BITS_MAX logic was introduced back in 2016 in 8f0d3aa9de57 ("arm64: mm: support ARCH_MMAP_RND_BITS"), which is before "ARM64_VA_BITS=52" was a thing.
I suppose that there's also 3cb7e662a930 ("arm64: Kconfig: Fix indentation and add comments"), but that's just some whitespace adjustments.
Quoted 28 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Signed-off-by Kornel Dulęba <[email protected]>--- arch/arm64/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm64/Kconfig +0
-1@@ -332,9 +332,9 @@ config ARCH_MMAP_RND_BITS_MAX default 24 if ARM64_VA_BITS=39 default 27 if ARM64_VA_BITS=42 default 30 if ARM64_VA_BITS=47 - default 29 if ARM64_VA_BITS=48 && ARM64_64K_PAGESQuoted 8 lines
Quoted 8 lines
arch/arm64/Kconfig config ARCH_MMAP_RND_BITS_MAX · line 340
Quoted 8 lines
arch/arm64/Kconfig +3
-2- default 31 if ARM64_VA_BITS=48 && ARM64_16K_PAGES - default 33 if ARM64_VA_BITS=48 + default 29 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_64K_PAGES + default 31 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_16K_PAGES + default 33 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) default 14 if ARM64_64K_PAGES default 16 if ARM64_16K_PAGES default 18Otherwise LGTM.
Reviewed-by Anshuman Khandual <[email protected]>
Quoted 60 lines · Kornel Dulęba
Quoted 40 lines · Anshuman Khandual
Quoted 36 lines · Kornel Dulęba
Quoted 13 lines · Anshuman Khandual
Quoted 8 lines · Kornel Dulęba
When the 52-bit virtual addressing was enabled the select like
ARCH_MMAP_RND_BITS_MAXlogic was never updated to account for it. Because of that the rnd max bits would be set to the default value of 18 when ARM64_VA_BITS=52.
Fix this by settingARCH_MMAP_RND_BITS_MAXto the same value that would be used if 48-bit addressing was used. That's because the 52-bit addressing is used only if the caller provides a hint to mmap, with a fallback to 48-bit addressing.Quoted 3 lines
Why should
ARCH_MMAP_RND_BITS_MAXvalue be same for both 48 bits and 52 bits VA in case the user does request for 52 bit VA viammap()hint and the HW supports it ?Two reasons really.
1. The whole behavior is controlled through a global knob -/proc/sys/vm/mmap_rnd_bits.ARCH_MMAP_RND_BITS_MAXis used as an upper bound for the value that can be set to that knob.
So we have a single setting for all processes. Some might want 52 bit addressing, others will stick with 48.
2. Quoting the documentation for this knob:"""
mmap_rnd_bits
This value can be used to select the number of bits to use to determine the random offset to the base address of vma regions resulting from mmap allocations on architectures which support tuning address space randomization. This value will be bounded by the architecture’s minimum and maximum supported values.
"""Quoted 7 lines
Quoted 4 lines
I suppose that it's legal for some calls to mmap from the same process to request a 52 bit VA, while other calls will want only 48 bits. Because of that the random offset can't be larger than what would work for the 48 bit case.
Agreed but should not this rationale also be added in the commit message as well ?
Sure, I will update this in v2.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Fixes b6d00d47e81a ("arm64: mm: Introduce 52-bit Kernel VAs")Correct commit to be attributed for this fix.
Quoted 8 lines
What commit would you like me to point at? I selected
b6d00d47e81a, because it introduced "ARM64_VA_BITS=52".
Looking at git blame,ARCH_MMAP_RND_BITS_MAXlogic was introduced back in 2016 in8f0d3aa9de57("arm64: mm: supportARCH_MMAP_RND_BITS"), which is before "ARM64_VA_BITS=52" was a thing.
I suppose that there's also3cb7e662a930("arm64:Kconfig: Fix indentation and add comments"), but that's just some whitespace adjustments.
It was just a statement confirming that the commit ID chosen here in this patch is the right one indeed. Apologies for the confusion.
Quoted 29 lines
Quoted 29 lines
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Signed-off-by Kornel Dulęba <[email protected]>--- arch/arm64/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm64/Kconfig +0
-1@@ -332,9 +332,9 @@ config ARCH_MMAP_RND_BITS_MAX default 24 if ARM64_VA_BITS=39 default 27 if ARM64_VA_BITS=42 default 30 if ARM64_VA_BITS=47 - default 29 if ARM64_VA_BITS=48 && ARM64_64K_PAGESQuoted 8 lines
Quoted 8 lines
arch/arm64/Kconfig config ARCH_MMAP_RND_BITS_MAX · line 340
Quoted 8 lines
arch/arm64/Kconfig +3
-2- default 31 if ARM64_VA_BITS=48 && ARM64_16K_PAGES - default 33 if ARM64_VA_BITS=48 + default 29 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_64K_PAGES + default 31 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) && ARM64_16K_PAGES + default 33 if (ARM64_VA_BITS=48 || ARM64_VA_BITS=52) default 14 if ARM64_64K_PAGES default 16 if ARM64_16K_PAGES default 18Otherwise LGTM.
Reviewed-by Anshuman Khandual <[email protected]>