Skip to contentSkip to conversation

tools headers: Synchronize linux/build_bug.h with the kernel sources

PATCH New Arnaldo Carvalho de Melo 1 participant 1 message Mar 22

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tools headers: Synchronize linux/build_bug.h with the kernel sources

tldr; Just FYI, I'm carrying this on the perf tools tree.

Full explanation:

There used to be no copies, with tools/ code using kernel headers directly. From time to time tools/perf/ broke due to legitimate kernel hacking. At some point Linus complained about such direct usage. Then we adopted the current model.

See further details at:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/include/uapi/README

To pick up the changes in:

6ffd853b0b10e1e2 ("build_bug.h: correct function parameters names in kernel-doc")

That just add some comments, addressing this perf tools build warning:

Warning: Kernel ABI header differences:
diff -u tools/include/linux/build_bug.h include/linux/build_bug.h

Please take a look at tools/include/uapi/README for further info on this synchronization process.

Cc Andrew Morton <[email protected]>
Cc Ian Rogers <[email protected]>
Cc Randy Dunlap <[email protected]>

---

v2: Fix summary typo and update the tools copy, not the original, as spotted by Ian Rogers.

---
 tools/include/linux/build_bug.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tools/include/linux/build_bug.h +3 -1
index ab2aa97bd8ce441d..406923bd4846c37f 100644
@@ -32,7 +32,8 @@
 /**
  * BUILD_BUG_ON_MSG - break compile if a condition is true & emit supplied
  *		      error message.
- * @condition: the condition which the compiler should know is false.
+ * @cond: the condition which the compiler should know is false.
+ * @msg: build-time error message
  *
  * See BUILD_BUG_ON for description.
  */
@@ -60,6 +61,7 @@
 
 /**
  * static_assert - check integer constant expression at build time
+ * @expr: expression to be checked
  *
  * static_assert() is a wrapper for the C11 _Static_assert, with a
  * little macro magic to make the message optional (defaulting to the
Signature · 1 line
2.53.0