Skip to contentSkip to conversation

linux-next: build failure after merge of the fs-next tree

PATCH Mark Brown 3 participants 3 messages Mar 27 – Mar 28

Subsystems (2)
Linux-next tree exFAT file system
lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

Hi all,

After merging the fs-next tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/fs/exfat/file.c: In function 'exfat_file_mmap_prepare':
/tmp/next/build/fs/exfat/file.c:842:13: error: implicit declaration of function 'vma_desc_test_flags'; did you mean 'vma_desc_set_flags'? [-Wimplicit-function-declaration]

  842 |         if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
      |             ^~~~~~~~~~~~~~~~~~~ vma_desc_set_flags

Caused by commit

9b373eacd6e6c4 (exfat: add iomap buffered I/O support)

from the exfat tree interacting with

2c3b5ea7028fa (mm: reintroduce vma_desc_test() as a singular flag test)

from one of the mm trees. I have applied a fixup which I can carry as needed.

From c4935dbc4b15a9119616ac73b17eff29a7e2ec87 Mon Sep 17 00:00:00 2001
From: Mark Brown <[email protected]>
Date: Fri, 27 Mar 2026 19:08:13 +0000
Subject: [PATCH] exfat: Fix up merge with mm

/tmp/next/build/fs/exfat/file.c: In function 'exfat_file_mmap_prepare':
/tmp/next/build/fs/exfat/file.c:842:13: error: implicit declaration of function 'vma_desc_test_flags'; did you mean 'vma_desc_set_flags'? [-Wimplicit-function-declaration]

  842 |         if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
      |             ^~~~~~~~~~~~~~~~~~~ vma_desc_set_flags
Signed-off-by Mark Brown <[email protected]>
---
 fs/exfat/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/exfat/file.c +1 -1
index 9a30c32b3a0526..82db5ebaaad7b7 100644
@@ -839,7 +839,7 @@ static int exfat_file_mmap_prepare(struct vm_area_desc *desc)
 	if (unlikely(exfat_forced_shutdown(file_inode(desc->file)->i_sb)))
 		return -EIO;
 
-	if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
+	if (vma_desc_test(desc, VMA_WRITE_BIT)) {
 		struct inode *inode = file_inode(file);
 		loff_t from, to;
 		int err;
Signature · 1 line
2.47.3
#1 lore raw
Quoted 45 lines · Mark Brown

Hi all,

After merging the fs-next tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/fs/exfat/file.c: In function 'exfat_file_mmap_prepare':
/tmp/next/build/fs/exfat/file.c:842:13: error: implicit declaration of function 'vma_desc_test_flags'; did you mean 'vma_desc_set_flags'? [-Wimplicit-function-declaration]

  842 |         if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
      |             ^~~~~~~~~~~~~~~~~~~ vma_desc_set_flags

Caused by commit

9b373eacd6e6c4 (exfat: add iomap buffered I/O support)

from the exfat tree interacting with

2c3b5ea7028fa (mm: reintroduce vma_desc_test() as a singular flag test)

from one of the mm trees. I have applied a fixup which I can carry as needed.

From c4935dbc4b15a9119616ac73b17eff29a7e2ec87 Mon Sep 17 00:00:00 2001
From: Mark Brown <[email protected]>
Date: Fri, 27 Mar 2026 19:08:13 +0000
Subject: [PATCH] exfat: Fix up merge with mm

/tmp/next/build/fs/exfat/file.c: In function 'exfat_file_mmap_prepare':
/tmp/next/build/fs/exfat/file.c:842:13: error: implicit declaration of function 'vma_desc_test_flags'; did you mean 'vma_desc_set_flags'? [-Wimplicit-function-declaration]

  842 |         if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
      |             ^~~~~~~~~~~~~~~~~~~ vma_desc_set_flags
Signed-off-by Mark Brown <[email protected]>
---
 fs/exfat/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/exfat/file.c +0 -0
index 9a30c32b3a0526..82db5ebaaad7b7 100644

fs/exfat/file.c static int exfat_file_mmap_prepare(struct vm_area_desc *desc) · line 842

Quoted 5 lines
fs/exfat/file.c +1 -1
@@ -839,7 +839,7 @@ static int exfat_file_mmap_prepare(struct vm_area_desc *desc)
 	if (unlikely(exfat_forced_shutdown(file_inode(desc->file)->i_sb)))
 		return -EIO;
 
-	if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
+	if (vma_desc_test(desc, VMA_WRITE_BIT)) {

LGTM, Cheers!

Quoted 6 lines
fs/exfat/file.c +0 -1
 		struct inode *inode = file_inode(file);
 		loff_t from, to;
 		int err;
--

2.47.3

maintainer
#2 lore raw
In reply to Mark Brown

fs/exfat/file.c static int exfat_file_mmap_prepare(struct vm_area_desc *desc) · line 845

Quoted 13 lines
fs/exfat/file.c +1 -1
index 9a30c32b3a0526..82db5ebaaad7b7 100644
@@ -839,7 +839,7 @@ static int exfat_file_mmap_prepare(struct vm_area_desc *desc)
        if (unlikely(exfat_forced_shutdown(file_inode(desc->file)->i_sb)))
                return -EIO;
 
-       if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
+       if (vma_desc_test(desc, VMA_WRITE_BIT)) {
                struct inode *inode = file_inode(file);
                loff_t from, to;
                int err;

Looks good to me:)
Thank you, Mark!

Quoted 3 lines

--
2.47.3