Skip to contentSkip to conversation

2.5.14+ ALSA OSS emulation

PATCH Bob_Tracy 2 participants 2 messages May 20, 2002 Sound

lore
Share & tools
lore

Bob_Tracy

author
#0 lore raw

In the 2.5.14 patchset, the following change was made in linux/sound/core/Config.in:

-bool ' OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND +dep_bool ' OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND

This breaks the OSS API emulation for people building their ALSA sound drivers as modules (CONFIG_SND == "m"). The following patch applied against the 2.5.16 kernel accomplishes what I think the author intended:

sound/core/Config.in renamed from sound/core/Config.in.orig +3 -1
@@ -13,7 +13,9 @@
 if [ "$CONFIG_SND_SEQUENCER" != "n" ]; then
   dep_tristate '  Sequencer dummy client' CONFIG_SND_SEQ_DUMMY $CONFIG_SND_SEQUENCER
 fi
-dep_bool '  OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
+if [ "$CONFIG_SND" != "n" ]; then
+  bool '  OSS API emulation' CONFIG_SND_OSSEMUL
+fi
 if [ "$CONFIG_SND_OSSEMUL" = "y" ]; then
   dep_tristate '    OSS Mixer API' CONFIG_SND_MIXER_OSS $CONFIG_SND
   dep_tristate '    OSS PCM API' CONFIG_SND_PCM_OSS $CONFIG_SND

Please apply.

Signature · 4 lines
-----------------------------------------------------------------------
Bob Tracy                   WTO + WIPO = DMCA? http://www.anti-dmca.org
[email protected]
-----------------------------------------------------------------------
#1 lore raw

In article <[email protected]>,

Quoted 9 lines · Bob_Tracy

In the 2.5.14 patchset, the following change was made in linux/sound/core/Config.in:

(quoted diff) +1 -1
-bool '  OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
+dep_bool '  OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND

This breaks the OSS API emulation for people building their ALSA sound drivers as modules (CONFIG_SND == "m"). The following patch applied against the 2.5.16 kernel accomplishes what I think the author intended:

Good catch.

However, the simpler fix is to use "dep_mbool", which exists exactly for this reason.

Linus