smb: client: Improve unlocking of a mutex in cifs_get_swn_reg()
Subsystems (3)
PATCH 1/1 smb: client: Improve unlocking of a mutex in cifs_get_swn_reg()
From: Markus Elfring <[email protected]>
Date: Tue, 7 Oct 2025 17:45:28 +0200
Use two additional labels so that another bit of common code can be better reused at the end of this function implementation.
Signed-off-by Markus Elfring <[email protected]>
--- fs/smb/client/cifs_swn.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
fs/smb/client/cifs_swn.c +6 -7
@@ -313,17 +313,15 @@ static struct cifs_swn_reg *cifs_get_swn_reg(struct cifs_tcon *tcon) reg =cifs_find_swn_reg (tcon);if (!IS_ERR (reg)) {kref_get (®->ref_count); -mutex_unlock (&cifs_swnreg_idr_mutex); -return reg; + goto unlock; }else if (PTR_ERR (reg) != -EEXIST ) { -mutex_unlock (&cifs_swnreg_idr_mutex); -return reg; + goto unlock; } reg =kmalloc (sizeof (struct cifs_swn_reg ),GFP_ATOMIC );if (reg ==NULL ) { -mutex_unlock (&cifs_swnreg_idr_mutex); -return ERR_PTR (-ENOMEM ); + ret = -ENOMEM ; + goto fail_unlock; }kref_init (®->ref_count);
@@ -354,7 +352,7 @@ static struct cifs_swn_reg *cifs_get_swn_reg(struct cifs_tcon *tcon) reg->ip_notify = (tcon->capabilities &SMB2_SHARE_CAP_SCALEOUT ); reg->tcon = tcon; - +unlock:mutex_unlock (&cifs_swnreg_idr_mutex);return reg;
@@ -365,6 +363,7 @@ static struct cifs_swn_reg *cifs_get_swn_reg(struct cifs_tcon *tcon)idr_remove (&cifs_swnreg_idr, reg->id); fail:kfree (reg); +fail_unlock:mutex_unlock (&cifs_swnreg_idr_mutex);return ERR_PTR (ret); }
Signature · 1 line
2.51.0