Skip to contentSkip to conversation

dt-bindings: mediatek: vcodec: Add the platform compatible to schema

PATCH In review Irui Wang 3 participants 4 messages Oct 1, 2022 – Oct 6, 2022

Subsystems (4)
lore
Share & tools
lore

Irui Wang

author
#0 lore raw

PATCH 1/1 dt-bindings: mediatek: vcodec: Add the platform compatible to schema

There are venc node warnings when running dtbs_check, the clock-names was unexpected, missing properties '#address-cells' and '#size-cells'. Add the corresponding platform compatible to schema.

---
 .../bindings/media/mediatek,vcodec-encoder.yaml      | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +11 -1
index 32aee09aea33..0f2ea8d9a10c 100644
@@ -67,6 +67,12 @@ properties:
   power-domains:
     maxItems: 1
 
+  "#address-cells":
+    const: 2
+
+  "#size-cells":
+    const: 2
+
 required:
   - compatible
   - reg
@@ -84,7 +90,9 @@ allOf:
           contains:
             enum:
               - mediatek,mt8183-vcodec-enc
+              - mediatek,mt8188-vcodec-enc
               - mediatek,mt8192-vcodec-enc
+              - mediatek,mt8195-vcodec-enc
 
     then:
       required:
@@ -107,7 +115,9 @@ allOf:
         compatible:
           enum:
             - mediatek,mt8173-vcodec-enc
+            - mediatek,mt8188-vcodec-enc
             - mediatek,mt8192-vcodec-enc
+            - mediatek,mt8195-vcodec-enc
 
     then:
       properties:
@@ -118,7 +128,7 @@ allOf:
         clock-names:
           items:
             - const: venc_sel
-    else:  # for vp8 hw decoder
+    else:  # for vp8 hw encoder
       properties:
         clock:
           items:
Signature · 1 line
2.18.0
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Irui Wang

There are venc node warnings when running dtbs_check, the clock-names was unexpected, missing properties '#address-cells' and '#size-cells'. Add the corresponding platform compatible to schema.

---
 .../bindings/media/mediatek,vcodec-encoder.yaml      | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Best regards,
Krzysztof

maintainer
#2 lore raw
In reply to Irui Wang
Quoted 9 lines · Irui Wang

There are venc node warnings when running dtbs_check, the clock-names was unexpected, missing properties '#address-cells' and '#size-cells'. Add the corresponding platform compatible to schema.

---
 .../bindings/media/mediatek,vcodec-encoder.yaml      | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/

vcodec@17020000: clock-names:0: 'venc_sel' was expected

	arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dtb
	arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dtb
	arch/arm64/boot/dts/mediatek/mt8192-evb.dtb
author
#3 lore raw

Dear Rob,

Thanks for your reviewing.

Quoted 18 lines · Rob Herring
Quoted 6 lines · Irui Wang

There are venc node warnings when running dtbs_check, the clock- names
was unexpected, missing properties '#address-cells' and '#size- cells'.
Add the corresponding platform compatible to schema.

Quoted 6 lines
---
 .../bindings/media/mediatek,vcodec-encoder.yaml      | 12
+++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.

Quoted 5 lines

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/

Yes, it's not a new warning, the 'clock-names' in mt8192.dtsi was already unexpected without the patch's schema, we will fix it in the future patch.

Thanks
Best Regards

Quoted 7 lines

vcodec@17020000: clock-names:0: 'venc_sel' was expected

	arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dtb
	arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dtb
	arch/arm64/boot/dts/mediatek/mt8192-evb.dtb