Skip to contentSkip to conversation

platform/x86/intel/pmt: Ignore uninitialized entries

PATCH In review David E. Box 3 participants 3 messages Apr 13, 2023 – Apr 17, 2023

Subsystems (2)
lore
Share & tools
lore

David E. Box

author maintainer
#0 lore raw

PATCH 1/1 platform/x86/intel/pmt: Ignore uninitialized entries

On Intel Xeon, unused PMT regions will have uninitialized discovery headers containing all 0xF. Instead of returning an error, just skip the region.

---
 drivers/platform/x86/intel/pmt/telemetry.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/pmt/telemetry.c +1 -1
index 71cdef42084a..39cbc87cc28a 100644
@@ -78,7 +78,7 @@ static int pmt_telem_header_decode(struct intel_pmt_entry *entry,
 	 * reserved for future use. They have zero size. Do not fail
 	 * probe for these. Just ignore them.
 	 */
-	if (header->size == 0)
+	if (header->size == 0 || header->access_type == 0xF)
 		return 1;
 
 	return 0;

base-commit: 5b309e80f457ebb41770e0122766825a78cfc11b
prerequisite-patch-id: a3bf21940fa02eb2f3adb4bd2d3a93df14df077a

Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · David E. Box

On Intel Xeon, unused PMT regions will have uninitialized discovery headers containing all 0xF. Instead of returning an error, just skip the region.

---
 drivers/platform/x86/intel/pmt/telemetry.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/pmt/telemetry.c +0 -0
index 71cdef42084a..39cbc87cc28a 100644

drivers/platform/x86/intel/pmt/telemetry.c static int pmt_telem_header_decode(struct intel_pmt_entry *entry, · line 84

Quoted 8 lines
drivers/platform/x86/intel/pmt/telemetry.c +1 -1
@@ -78,7 +78,7 @@ static int pmt_telem_header_decode(struct intel_pmt_entry *entry,
 	 * reserved for future use. They have zero size. Do not fail
 	 * probe for these. Just ignore them.
 	 */
-	if (header->size == 0)
+	if (header->size == 0 || header->access_type == 0xF)
 		return 1;
 
 	return 0;
Signature · 1 line
 i.
#2 lore raw

Hi,

Quoted 22 lines · Ilpo Järvinen
Quoted 20 lines · David E. Box

On Intel Xeon, unused PMT regions will have uninitialized discovery headers containing all 0xF. Instead of returning an error, just skip the region.

---
 drivers/platform/x86/intel/pmt/telemetry.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/pmt/telemetry.c +1 -1
index 71cdef42084a..39cbc87cc28a 100644
@@ -78,7 +78,7 @@ static int pmt_telem_header_decode(struct intel_pmt_entry *entry,
 	 * reserved for future use. They have zero size. Do not fail
 	 * probe for these. Just ignore them.
 	 */
-	if (header->size == 0)
+	if (header->size == 0 || header->access_type == 0xF)
 		return 1;
 
Quoted 3 lines

drivers/platform/x86/intel/pmt/telemetry.c static int pmt_telem_header_decode(struct intel_pmt_entry *entry, · line 84

Quoted 1 line
drivers/platform/x86/intel/pmt/telemetry.c +0 -0
 	return 0;

Thank you both for the patch + review, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans