media: dvb: remove spaces before '['
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 media: dvb: remove spaces before '['
Remove spaces to clear checkpatch errors.
ERROR: space prohibited before open square bracket '['
--- drivers/media/dvb-frontends/tda826x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/dvb-frontends/tda826x.c +1 -1
@@ -38,7 +38,7 @@ static int tda826x_sleep(struct dvb_frontend *fe) { struct tda826x_priv *priv = fe->tuner_priv; int ret; - u8 buf [] = { 0x00, 0x8d }; + u8 buf[] = { 0x00, 0x8d }; struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf
= buf, .len = 2 };
dprintk("%s:\n", __func__);
@@ -65,7 +65,7 @@ static int tda826x_set_params(struct dvb_frontend *fe)
u32 div;
u32 ksyms;
u32 bandwidth;
- u8 buf [11];
+ u8 buf[11];
struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf = buf, .len = 11 };
dprintk("%s:\n", __func__);
@@ -130,7 +130,7 @@ static const struct dvb_tuner_ops tda826x_tuner_ops = {
struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr,
struct i2c_adapter *i2c, int has_loopthrough)
{
struct tda826x_priv *priv = NULL;
- u8 b1 [] = { 0, 0 };
+ u8 b1[] = { 0, 0 };
struct i2c_msg msg[2] = {
{ .addr = addr, .flags = 0, .buf = NULL, .len = 0 },
{ .addr = addr, .flags = I2C_M_RD, .buf = b1, .len = 2 }Hi Ran Sun,
Quoted 14 lines · On 14/07/2023 10:06, [email protected] wrote:
Remove spaces to clear checkpatch errors.
ERROR: space prohibited before open square bracket '['
Signed-off-by Ran Sun <[email protected]>---
drivers/media/dvb-frontends/tda826x.c | 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)drivers/media/dvb-frontends/tda826x.c +0
-0
drivers/media/dvb-frontends/tda826x.c static int tda826x_sleep(struct dvb_frontend *fe) · line 41
Quoted 5 lines
drivers/media/dvb-frontends/tda826x.c +1
-1@@ -38,7 +38,7 @@ static int tda826x_sleep(struct dvb_frontend *fe) { struct tda826x_priv *priv = fe->tuner_priv; int ret; - u8 buf [] = { 0x00, 0x8d }; + u8 buf[] = { 0x00, 0x8d };
This patch is corrupt: TABs have been replaced by spaces.
It's not just this patch, but all 7 patches you posted to linux-media.
Also, please mention the name of the driver you fixed in the subject.
So: "media: dvb: tda826x: remove space before '['".
Regards,
Hans
Quoted 21 lines
drivers/media/dvb-frontends/tda826x.c +2
-2struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf = buf, .len = 2 }; dprintk("%s:\n", __func__);@@ -65,7 +65,7 @@ static int tda826x_set_params(struct dvb_frontend *fe) u32 div; u32 ksyms; u32 bandwidth; - u8 buf [11]; + u8 buf[11]; struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf = buf, .len = 11 }; dprintk("%s:\n", __func__);@@ -130,7 +130,7 @@ static const struct dvb_tuner_ops tda826x_tuner_ops = { struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr, struct i2c_adapter *i2c, int has_loopthrough) { struct tda826x_priv *priv = NULL; - u8 b1 [] = { 0, 0 }; + u8 b1[] = { 0, 0 }; struct i2c_msg msg[2] = { { .addr = addr, .flags = 0, .buf = NULL, .len = 0 }, { .addr = addr, .flags = I2C_M_RD, .buf = b1, .len = 2 }