docs: pdfdocs: Fix typo in CJK-language specific font settings
PATCH 1/1 docs: pdfdocs: Fix typo in CJK-language specific font settings
There were typos in the fallback definitions of dummy LaTeX macros for systems without CJK fonts.
They cause build errors in "make pdfdocs" on such systems. Fix them.
---
Hi Jon,
I thought I had tested the v4 patch on a container image without any CJK fonts, but apparently I had not.
These typos affect "make pdfdocs" of all the English documents as well.
So, if this doesn't make the initial pull request for v5.15, please consider sending it as an urgent pull request during -rc stages of v5.15.
Apologies for the lack of test on my side.
Thanks, Akira
--
Documentation/conf.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/conf.py +2 -2
@@ -463,8 +463,8 @@ latex_elements['preamble'] += ''' \\newcommand{\\kerneldocEndTC}{} \\newcommand{\\kerneldocBeginKR}{} \\newcommand{\\kerneldocEndKR}{} - \\newcommand{\\kerneldocBeginSC}{} - \\newcommand{\\kerneldocEndKR}{} + \\newcommand{\\kerneldocBeginJP}{} + \\newcommand{\\kerneldocEndJP}{} } '''
Signature · 1 line
2.17.1
Hi Jon, [most CCs dropped]
Just a reminder in case you have missed this fix.
Quoted 10 lines · Akira Yokosawa
There were typos in the fallback definitions of dummy LaTeX macros for systems without CJK fonts.
They cause build errors in "make pdfdocs" on such systems. Fix them.Fixes e291ff6f5a03 ("docs: pdfdocs: Add CJK-language-specific font settings")Signed-off-by Akira Yokosawa <[email protected]>---
Hi Jon,
Quoted 8 lines
I thought I had tested the v4 patch on a container image without any CJK fonts, but apparently I had not.
These typos affect "make pdfdocs" of all the English documents as well.
So, if this doesn't make the initial pull request for v5.15, please consider sending it as an urgent pull request during -rc stages of v5.15.
I think this regression fix should go to v5.15.
What do you think?
Thanks, Akira
Quoted 24 lines
Apologies for the lack of test on my side.
Thanks, Akira
--Documentation/conf.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Documentation/conf.py +2
-2@@ -463,8 +463,8 @@ latex_elements['preamble'] += ''' \\newcommand{\\kerneldocEndTC}{} \\newcommand{\\kerneldocBeginKR}{} \\newcommand{\\kerneldocEndKR}{} - \\newcommand{\\kerneldocBeginSC}{} - \\newcommand{\\kerneldocEndKR}{} + \\newcommand{\\kerneldocBeginJP}{} + \\newcommand{\\kerneldocEndJP}{} } '''
Jonathan Corbet
maintainerQuoted 3 lines · Akira Yokosawa
Hi Jon, [most CCs dropped]
Just a reminder in case you have missed this fix.
Interesting, I'm not quite sure how that fell through the cracks. Applied now, it'll go upstream shortly.
Thanks,
jon