Skip to contentSkip to conversation

rdma/nes: set assume_alligned_header bit

PATCH Superseded Faisal Latif 2 participants 3 messages Feb 19, 2010 1 message not in the archive InfiniBand

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rdma/nes: set assume_alligned_header bit

set assume bit alligned bit in qp context as recommended by hardware group.

---
 drivers/infiniband/hw/nes/nes_verbs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/infiniband/hw/nes/nes_verbs.c +1 -0
index 64d3136..dba659a 100644
@@ -1325,6 +1325,7 @@ static struct ib_qp *nes_create_qp(struct ib_pd *ibpd,
 			nesqp->nesqp_context->ird_ord_sizes = cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM |
 					((((u32)nesadapter->max_irrq_wr) <<
 					NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) & NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK));
+			nesqp->nesqp_context->ird_ord_sizes |= cpu_to_le32(NES_QPCONTEXT_ORDIRD_AAH);
 			if (disable_mpa_crc) {
 				nes_debug(NES_DBG_QP, "Disabling MPA crc checking due to module option.\n");
 				nesqp->nesqp_context->ird_ord_sizes |= cpu_to_le32(NES_QPCONTEXT_ORDIRD_RNMC);
Signature · 6 lines
1.6.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw

drivers/infiniband/hw/nes/nes_verbs.c static struct ib_qp *nes_create_qp(struct ib_pd *ibpd, · line 1328

Quoted 4 lines
drivers/infiniband/hw/nes/nes_verbs.c +1 -0
 			nesqp->nesqp_context->ird_ord_sizes = cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM |
 					((((u32)nesadapter->max_irrq_wr) <<
 					NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) & NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK));
+			nesqp->nesqp_context->ird_ord_sizes |= cpu_to_le32(NES_QPCONTEXT_ORDIRD_AAH);

I think I would just combine this into the existing assignment (which could also probably be formatted better but I'm not worrying about this), and write the whole thing as:

nesqp->nesqp_context->ird_ord_sizes = cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM |
NES_QPCONTEXT_ORDIRD_AAH | ((((u32)nesadapter->max_irrq_wr) << NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) & NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK));

Signature · 7 lines
Roland Dreier  <[email protected]>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): ada3a0w7wmi.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org

#3 lore raw

That will be fine.

Thanks
Faisal

Quoted 24 lines

-----Original Message-----
From: Roland Dreier [mailto:[email protected]]
Sent: Friday, February 19, 2010 3:18 PM
To: Latif, Faisal
Cc: [email protected]
Subject: Re: [PATCH] rdma/nes: set assume_alligned_header bit

Quoted 1 line

nesqp->nesqp_context->ird_ord_sizes =

cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM |

Review

Quoted 2 lines
(quoted diff) +0 -0
 					((((u32)nesadapter->max_irrq_wr) <<
 					NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) &

NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK));

Review

Quoted 1 line
(quoted diff) +1 -0
+			nesqp->nesqp_context->ird_ord_sizes |=

cpu_to_le32(NES_QPCONTEXT_ORDIRD_AAH);

I think I would just combine this into the existing assignment (which could also probably be formatted better but I'm not worrying about this), and write the whole thing as:

			nesqp->nesqp_context->ird_ord_sizes =
cpu_to_le32(NES_QPCONTEXT_ORDIRD_ALSMM |
					NES_QPCONTEXT_ORDIRD_AAH |
					((((u32)nesadapter->max_irrq_wr) <<
					NES_QPCONTEXT_ORDIRD_IRDSIZE_SHIFT) &
Quoted 6 lines

NES_QPCONTEXT_ORDIRD_IRDSIZE_MASK));

--
Roland Dreier <[email protected]> For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html