ivtv: don't recompile needlessly
PATCH 1/1 ivtv: don't recompile needlessly
Driver prints 3l33t banner including kernel version. Could we _please_ never do this in future.
Signed-off-by Alexey Dobriyan <[email protected]>
---
drivers/media/video/ivtv/ivtv-driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/video/ivtv/ivtv-driver.c +1 -2
@@ -56,7 +56,6 @@#include "ivtv-gpio.h" #include "ivtv-yuv.h" -#include <linux/vermagic.h> #include <media/tveeprom.h> #include <media/v4l2-chip-ident.h>
@@ -1315,7 +1314,7 @@ static struct pci_driver ivtv_pci_driver = {static int module_start (void ) {printk (KERN_INFO "ivtv: ==================== START INIT IVTV ====================\n" ); -printk (KERN_INFO "ivtv: version %s (" VERMAGIC_STRING ") loading\n" ,IVTV_VERSION ); +printk (KERN_INFO "ivtv: version %s loading\n" ,IVTV_VERSION );memset (ivtv_cards,0 ,sizeof (ivtv_cards));
Quoted 2 lines
Driver prints 3l33t banner including kernel version. Could we _please_ never do this in future.
Thanks for reporting this. This was a leftover from when the driver was standalone. I've merged this patch in my repository and will push it upstream.
Regards,
Hans
Quoted 30 lines
Signed-off-by Alexey Dobriyan <[email protected]>---
drivers/media/video/ivtv/ivtv-driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/media/video/ivtv/ivtv-driver.c +1
-2@@ -56,7 +56,6 @@#include "ivtv-gpio.h" #include "ivtv-yuv.h" -#include <linux/vermagic.h> #include <media/tveeprom.h> #include <media/v4l2-chip-ident.h> @@ -1315,7 +1314,7 @@ static struct pci_driver ivtv_pci_driver = {static int module_start (void ) {printk (KERN_INFO "ivtv: ==================== START INIT IVTV ====================\n"); -printk (KERN_INFO "ivtv: version %s (" VERMAGIC_STRING ") loading\n" , IVTV_VERSION); +printk (KERN_INFO "ivtv: version %s loading\n" ,IVTV_VERSION );
memset(ivtv_cards, 0, sizeof(ivtv_cards));
Quoted 1 line
printk(KERN_INFO "ivtv: ==================== START INIT IVTV ====================\n");
This also looks pretty useless and way too garish given the fact that it contains no information not already given by the next line printed.