ipath - core device driver
A message that is not in the archive (sent off-list or not yet received): [email protected]
Review
Quoted 8 lines
(quoted diff) +8
-0+ /* setup the chip-specific functions, as early as possible. */ + switch (ent->device) { + case PCI_DEVICE_ID_INFINIPATH_HT: + ipath_init_ht400_funcs(dd); + break; + case PCI_DEVICE_ID_INFINIPATH_PE800: + ipath_init_pe800_funcs(dd); + break;
What happens if ht400 or pe800 support is not built? How does this link?
- R.
Review
Quoted 2 lines
(quoted diff) +2
-0+ if (dd->ipath_unit >= atomic_read(&ipath_max)) + atomic_set(&ipath_max, dd->ipath_unit + 1);
If this is the way you use ipath_max, why is it an atomic variable? I can't find any uses of ipath_max that don't look racy if the only thing protecting it is the fact that it's an atomic_t, and if it has some other protection, then I don't think it needs to be atomic.
- R.