IB/qib: fix RDMA write with immediate
PATCH 1/1 IB/qib: fix RDMA write with immediate
The immediate word for RDMA_WRITE_ONLY_WITH_IMMEDIATE was being
extracted from the wrong location in the header.
Thanks to Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> for finding this.
---
drivers/infiniband/hw/qib/qib_rc.c | 5 ++++- drivers/infiniband/hw/qib/qib_uc.c | 6 ++++-- 2 files changed, 8 insertions(+), 3 deletions(-)
drivers/infiniband/hw/qib/qib_rc.c +4 -1
@@ -2068,7 +2068,10 @@ send_last: goto nack_op_err;if (!ret) goto rnr_nak; - goto send_last_imm; + wc.ex.imm_data = ohdr->u.rc.imm_data; + hdrsize +=4 ; + wc.wc_flags =IB_WC_WITH_IMM ; + goto send_last;case OP (RDMA_READ_REQUEST ): {struct qib_ack_entry *e;
drivers/infiniband/hw/qib/qib_uc.c +4 -2
@@ -457,8 +457,10 @@ rdma_first: }if (opcode ==OP (RDMA_WRITE_ONLY )) goto rdma_last; -else if (opcode ==OP (RDMA_WRITE_ONLY_WITH_IMMEDIATE )) +if (opcode ==OP (RDMA_WRITE_ONLY_WITH_IMMEDIATE )) { + wc.ex.imm_data = ohdr->u.rc.imm_data; goto rdma_last_imm; + }/* FALLTHROUGH */ case OP (RDMA_WRITE_MIDDLE ):/* Check for invalid length PMTU or posted rwqe len. */
@@ -471,8 +473,8 @@ rdma_first:break ;case OP (RDMA_WRITE_LAST_WITH_IMMEDIATE ): -rdma_last_imm: wc.ex.imm_data = ohdr->u.imm_data; +rdma_last_imm: hdrsize +=4 ; wc.wc_flags =IB_WC_WITH_IMM ;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20101023001021.30700.54337.stgit-/[email protected]
thanks, applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html