RDMA/ucm: BKL is not needed for ib_ucm_open()
PATCH 1/1 RDMA/ucm: BKL is not needed for ib_ucm_open()
Remove explicit cycle_kernel_lock() call and document why the code is safe.
Signed-off-by Roland Dreier <[email protected]>
---
And merge this too...
drivers/infiniband/core/ucm.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-)
drivers/infiniband/core/ucm.c +8 -2
@@ -43,7 +43,6 @@#include <linux/cdev.h> #include <linux/idr.h> #include <linux/mutex.h> -#include <linux/smp_lock.h> #include <asm/uaccess.h>
@@ -1154,11 +1153,18 @@ static unsigned int ib_ucm_poll(struct file *filp,return mask; } +/* +* ib_ucm_open() does not need the BKL: +* +* - no global state is referred to; +* - there is no ioctl method to race against; +* - no further module initialization is required for open to work +* after the device is registered. +*/ static int ib_ucm_open (struct inode *inode,struct file *filp) {struct ib_ucm_file *file; -cycle_kernel_lock (); file =kmalloc (sizeof (*file),GFP_KERNEL );if (!file)return -ENOMEM ;
Signature · 1 line
1.5.6.2