nes: bug in phy_lock usage?
It seems that ce6e74f2 ("RDMA/nes: Make nesadapter->phy_lock usage consistent") maybe introduced a locking bug. sparse warns:
drivers/infiniband/hw/nes/nes_hw.c:2642:9: warning: context imbalance in 'nes_process_mac_intr' - different lock contexts for basic block
And indeed in nes_process_mac_intr(), you do
spin_lock_irqsave(&nesadapter->phy_lock, flags);
at the very beginning, but then the unlock only happens inside
if (nesadapter->mac_sw_state[mac_number] != NES_MAC_SW_IDLE) {or inside
if (mac_status & (NES_MAC_INT_LINK_STAT_CHG | NES_MAC_INT_XGMII_EXT)) {so it seems it is possible to return from this function with the lock held.
- R.
Signature · 6 lines
Roland Dreier <[email protected]> || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html