Drivers: hv: Select CONFIG_SYSFB only if EFI is enabled
PATCH 1/1 Drivers: hv: Select CONFIG_SYSFB only if EFI is enabled
From: Michael Kelley <[email protected]>
Commit 96959283a58d ("Drivers: hv: Always select CONFIG_SYSFB for Hyper-V guests") selects CONFIG_SYSFB for Hyper-V guests so that screen_info is available to the VMBus driver to get the location of the framebuffer in Generation 2 VMs. However, if CONFIG_HYPERV is enabled but CONFIG_EFI is not, a kernel link error results in ARM64 builds because screen_info is provided by the EFI firmware interface. While configuring an ARM64 Hyper-V guest without EFI isn't useful since EFI is required to boot, the configuration is still possible and the link error should be prevented.
Fix this by making the selection of CONFIG_SYSFB conditional on CONFIG_EFI being defined. For Generation 1 VMs on x86/x64, which don't use EFI, the additional condition is OK because such VMs get the framebuffer information via a mechanism that doesn't use screen_info.
--- drivers/hv/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hv/Kconfig +1 -1
@@ -9,7 +9,7 @@ config HYPERV select PARAVIRT select X86_HV_CALLBACK_VECTOR if X86 select OF_EARLY_FLATTREE if OF - select SYSFB if !HYPERV_VTL_MODE + select SYSFB if EFI && !HYPERV_VTL_MODE help Select this option to run Linux as a Hyper-V client operating system.
Signature · 1 line
2.25.1
kernel test robot
build botFYI: kernel test robot notices the stable kernel rule is not satisfied.
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1
Rule: add the tag "Cc: [email protected]" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH 1/1] Drivers: hv: Select CONFIG_SYSFB only if EFI is enabled
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
From: [email protected] <[email protected]> Sent: Friday, June 13, 2025 4:01 PM
Quoted 18 lines
Commit
96959283a58d("Drivers: hv: Always selectCONFIG_SYSFBfor Hyper-V guests") selectsCONFIG_SYSFBfor Hyper-V guests so thatscreen_infois available to the VMBus driver to get the location of the framebuffer in Generation 2 VMs. However, ifCONFIG_HYPERVis enabled butCONFIG_EFIis not, a kernel link error results in ARM64 builds becausescreen_infois provided by the EFI firmware interface. While configuring an ARM64 Hyper-V guest without EFI isn't useful since EFI is required to boot, the configuration is still possible and the link error should be prevented.Fix this by making the selection of
CONFIG_SYSFBconditional onCONFIG_EFIbeing defined. For Generation 1 VMs on x86/x64, which don't use EFI, the additional condition is OK because such VMs get the framebuffer information via a mechanism that doesn't usescreen_info.
Quoted 3 lines
Fixes 96959283a58d ("Drivers: hv: Always select CONFIG_SYSFB for Hyper-V guests")Reported-by Arnd Bergmann <[email protected]>
Arnd -- Can you give a "Reviewed-by:" or "Acked-by:" for this fix? It needs to get into linux-next and then into Linus' tree before we get too late in the 6.16 release cycle.
Michael
Quoted 23 lines
Reported-by kernel test robot <[email protected]>Signed-off-by Michael Kelley <[email protected]>--- drivers/hv/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hv/Kconfig +1
-2@@ -9,7 +9,7 @@ config HYPERV select PARAVIRT select X86_HV_CALLBACK_VECTOR if X86 select OF_EARLY_FLATTREE if OF - select SYSFB if !HYPERV_VTL_MODE + select SYSFB if EFI && !HYPERV_VTL_MODE help Select this option to run Linux as a Hyper-V client operating system. --2.25.1
Quoted 13 lines · On 6/13/2025 4:00 PM, [email protected] wrote:
From: Michael Kelley <[email protected]>
Commit
96959283a58d("Drivers: hv: Always selectCONFIG_SYSFBfor Hyper-V guests") selectsCONFIG_SYSFBfor Hyper-V guests so thatscreen_infois available to the VMBus driver to get the location of the framebuffer in Generation 2 VMs. However, ifCONFIG_HYPERVis enabled butCONFIG_EFIis not, a kernel link error results in ARM64 builds becausescreen_infois provided by the EFI firmware interface. While configuring an ARM64 Hyper-V guest without EFI isn't useful since EFI is required to boot, the configuration is still possible and the link error should be prevented.
Quoted 6 lines
Fix this by making the selection of
CONFIG_SYSFBconditional onCONFIG_EFIbeing defined. For Generation 1 VMs on x86/x64, which don't use EFI, the additional condition is OK because such VMs get the framebuffer information via a mechanism that doesn't usescreen_info.
[...]
LGTM.
Signature · 2 lines
Thank you, Roman
Quoted 19 lines · On Fri, Jun 13, 2025 at 04:00:59PM -0700, [email protected] wrote:
From: Michael Kelley <[email protected]>
Commit
96959283a58d("Drivers: hv: Always selectCONFIG_SYSFBfor Hyper-V guests") selectsCONFIG_SYSFBfor Hyper-V guests so thatscreen_infois available to the VMBus driver to get the location of the framebuffer in Generation 2 VMs. However, ifCONFIG_HYPERVis enabled butCONFIG_EFIis not, a kernel link error results in ARM64 builds becausescreen_infois provided by the EFI firmware interface. While configuring an ARM64 Hyper-V guest without EFI isn't useful since EFI is required to boot, the configuration is still possible and the link error should be prevented.Fix this by making the selection of
CONFIG_SYSFBconditional onCONFIG_EFIbeing defined. For Generation 1 VMs on x86/x64, which don't use EFI, the additional condition is OK because such VMs get the framebuffer information via a mechanism that doesn't usescreen_info.
Quoted 6 lines
Fixes 96959283a58d ("Drivers: hv: Always select CONFIG_SYSFB for Hyper-V guests")Reported-by Arnd Bergmann <[email protected]>Reported-by kernel test robot <[email protected]>Signed-off-by Michael Kelley <[email protected]>
Applied to hyperv-fixes. Thanks!