Skip to contentSkip to conversation

pec: Convert to the new API

PATCH New Petr Vorel 2 participants 2 messages Mar 30, 2021 – Apr 12, 2021

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH v2 1/1 pec: Convert to the new API

From: Joerg Vehlow <[email protected]>

---
Hi Joerg,

few fixes for this commit:
* event_generator uses SAFE_EXECVP() instead of SAFE_EXECV()
* use ROD for event_generator (it checks startup failure for us)
* remove bashism (SIGINT => INT), use #!/bin/sh
* remove useless exit 0
* add local
* few minor reword

It also expects tst_safe_macros: Add SAFE_EXECVP() patch [1].

Kind regards,
Petr

[1] https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/

 runtest/connectors                            |   2 +-
 testcases/kernel/connectors/Makefile          |   2 -
 testcases/kernel/connectors/connector_test.sh |   9 --
 testcases/kernel/connectors/pec/Makefile      |   2 +-
 testcases/kernel/connectors/pec/README        |  48 --------
 testcases/kernel/connectors/pec/cn_pec.sh     |  66 +++++++++++
 .../kernel/connectors/pec/event_generator.c   |  71 ++++++------
 .../kernel/connectors/pec/pec_listener.c      |  52 ++++-----
 testcases/kernel/connectors/pec/run_pec_test  | 107 ------------------
 9 files changed, 121 insertions(+), 238 deletions(-)
 delete mode 100644 testcases/kernel/connectors/connector_test.sh
 delete mode 100644 testcases/kernel/connectors/pec/README
 create mode 100755 testcases/kernel/connectors/pec/cn_pec.sh
 delete mode 100755 testcases/kernel/connectors/pec/run_pec_test
runtest/connectors +1 -1
index 6153a98e6..2c7aed474 100644
@@ -1,2 +1,2 @@
 #DESCRIPTION:Netlink Connector tests
-Connectors connector_test.sh
+cn_pec_sh cn_pec.sh
testcases/kernel/connectors/Makefile +0 -2
index 04d8a4b91..5f668f419 100644
@@ -24,6 +24,4 @@ top_srcdir		?= ../../..
 
 include $(top_srcdir)/include/mk/env_pre.mk
 
-INSTALL_TARGETS		:= connector_test.sh
-
 include $(top_srcdir)/include/mk/generic_trunk_target.mk
testcases/kernel/connectors/connector_test.sh deleted +0 -9
deleted file mode 100644
index f92e10b85..000000000
@@ -1,9 +0,0 @@
-#!/bin/sh
-
-if [ ! -f /proc/net/connector ];then
-	echo "Connectors 0 CONF : system doesn't support execution of the test"
-	exit 32
-fi
-
-$LTPROOT/testcases/bin/run_pec_test
-
testcases/kernel/connectors/pec/Makefile +1 -1
index fa0aa6828..d9a7f104e 100644
@@ -24,6 +24,6 @@ top_srcdir		?= ../../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 
-INSTALL_TARGETS		:= run_pec_test
+INSTALL_TARGETS		:= cn_pec.sh
 
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/connectors/pec/README deleted +0 -48

48 lines not on this page · raw message

testcases/kernel/connectors/pec/cn_pec.sh new file +66 -0

66 lines not on this page · raw message

testcases/kernel/connectors/pec/event_generator.c +33 -38

145 lines not on this page · raw message

testcases/kernel/connectors/pec/pec_listener.c +20 -32

91 lines not on this page · raw message

testcases/kernel/connectors/pec/run_pec_test deleted +0 -107

107 lines not on this page · raw message

Signature · 1 line
2.30.2
#1 lore raw

PATCH v2 1/1 pec: Convert to the new API

Hi Petr,

Quoted 16 lines · Petr Vorel

From: Joerg Vehlow <[email protected]>

---
Hi Joerg,

few fixes for this commit:
* event_generator uses SAFE_EXECVP() instead of SAFE_EXECV()
* use ROD for event_generator (it checks startup failure for us)
* remove bashism (SIGINT => INT), use #!/bin/sh
* remove useless exit 0
* add local
* few minor reword

Quoted 6 lines

It also expects tst_safe_macros: Add SAFE_EXECVP() patch [1].

Kind regards,
Petr

[1] https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/

sorry for the long delay, I was on vacation.
I'll catch up with this in the next few days.

J?rg