Skip to contentSkip to conversation

arm: dts: k3-j721s2*: Enable OSPI1 with 32-bit address mappings for R5 SPL

PATCH Dutta, Anurag 2 participants 2 messages Jan 22 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 14 lines · Udit

Thanks Anurag

Quoted 10 lines · Anurag Dutta

The R5 SPL requires 32-bit address mappings for OSPI1(QSPI) access. Override the OSPI1 node with appropriate 32-bit register ranges to enable proper address translation on the 32-bit R5 core, while preserving 64-bit mappings for A72 cores. While at it, remove the disabled status override for ospi1 node to support booting from qspi.

---
Test logs : https://gist.github.com/anuragdutta731/b65f63f22c69317d714b65a201438cbc

Quoted 6 lines

Could you check, for below error in logs

jedec_spi_nor flash@0: Software reset enable failed: -524

If this needs some parameter tuning in QSPI node or something to look at driver itself.

Hi Udit
This warning seems to be expected. In file : drivers/mtd/spi/spi-nor-core.c, In function spi_nor_soft_reset(), we can see that spi_nor_setup_op() is being invoked with SNOR_PROTO_8_8_8_DTR as default. However, ours being QSPI(1 1 4) it fails to enable software reset for qspi. This can be confirmed from ospi nor logs :
https://gist.github.com/anuragdutta731/cc30688b596ee063178e6c47947146c0

We do not see the jedec_spi_nor flash@0: Software reset enable failed: -524 warning.

Also, the spi_nor_soft_reset() description clearly mentions that :
The soft reset is executed in Octal DTR mode.

Regards
Anurag

Quoted 34 lines
Quoted 34 lines

  arch/arm/dts/k3-j721s2-common-proc-board-u-boot.dtsi | 4 ---- arch/arm/dts/k3-j721s2-r5.dtsi                       | 5 +++++

  2 files changed, 5 insertions(+), 4 deletions(-)
arch/arm/dts/k3-j721s2-common-proc-board-u-boot.dtsi +0 -3
index 54eb9b4072c..8d51fea72b8 100644
@@ -107,10 +107,6 @@
       };
   };
   -&ospi1 {
-    status = "disabled";
-};
-
   &usbss0 {
       bootph-all;
   };
arch/arm/dts/k3-j721s2-r5.dtsi +4 -0
index c1c12e217d2..f3f7dbd86c1 100644
@@ -90,6 +90,11 @@
                 <0x0 0x50000000 0x0 0x8000000>;
   };
   +&ospi1 {
+        reg = <0x0 0x47050000 0x0 0x100>,
+              <0x0 0x58000000 0x0 0x8000000>;
+};
+
   &fss {
       /* fss node has 64 bit address regions mapped to it and since the ospi
        * nodes is being override, override the fss node ranges as well
Reviewed-by
#3 lore raw
Quoted 29 lines · Anurag
Quoted 14 lines · Udit

Thanks Anurag

Quoted 10 lines · Anurag Dutta

The R5 SPL requires 32-bit address mappings for OSPI1(QSPI) access. Override the OSPI1 node with appropriate 32-bit register ranges to enable proper address translation on the 32-bit R5 core, while preserving 64-bit mappings for A72 cores. While at it, remove the disabled status override for ospi1 node to support booting from qspi.

---
Test logs : https://gist.github.com/anuragdutta731/b65f63f22c69317d714b65a201438cbc

Quoted 6 lines

Could you check, for below error in logs

jedec_spi_nor flash@0: Software reset enable failed: -524

If this needs some parameter tuning in QSPI node or something to look at driver itself.

Hi Udit
This warning seems to be expected. In file : drivers/mtd/spi/spi-nor-core.c, In function spi_nor_soft_reset(), we can see that spi_nor_setup_op() is being invoked with SNOR_PROTO_8_8_8_DTR as default. However, ours being QSPI(1 1 4) it fails to enable software reset for qspi. This can be confirmed from ospi nor logs :
https://gist.github.com/anuragdutta731/cc30688b596ee063178e6c47947146c0

Quoted 3 lines

We do not see the jedec_spi_nor flash@0: Software reset enable failed:
-524 warning.

Fair, then please fix driver not to call this reset, in case of QSPI.

For this patch

Quoted 40 lines

Also, the spi_nor_soft_reset() description clearly mentions that :
The soft reset is executed in Octal DTR mode.

Regards
Anurag

Quoted 34 lines
Quoted 34 lines

  arch/arm/dts/k3-j721s2-common-proc-board-u-boot.dtsi | 4 ---- arch/arm/dts/k3-j721s2-r5.dtsi                       | 5 +++++

  2 files changed, 5 insertions(+), 4 deletions(-)
arch/arm/dts/k3-j721s2-common-proc-board-u-boot.dtsi +0 -3
index 54eb9b4072c..8d51fea72b8 100644
@@ -107,10 +107,6 @@
       };
   };
   -&ospi1 {
-    status = "disabled";
-};
-
   &usbss0 {
       bootph-all;
   };
arch/arm/dts/k3-j721s2-r5.dtsi +4 -0
index c1c12e217d2..f3f7dbd86c1 100644
@@ -90,6 +90,11 @@
                 <0x0 0x50000000 0x0 0x8000000>;
   };
   +&ospi1 {
+        reg = <0x0 0x47050000 0x0 0x100>,
+              <0x0 0x58000000 0x0 0x8000000>;
+};
+
   &fss {
       /* fss node has 64 bit address regions mapped to it and since the ospi
        * nodes is being override, override the fss node ranges as well