Skip to contentSkip to conversation

staging: media: atomisp: fix indentation to use tabs instead of spaces

PATCH In review Michael Ugrin 4 participants 8 messages Apr 11 – Apr 13 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: media: atomisp: fix indentation to use tabs instead of spaces

Fix whitespace issue where a continuation line used spaces instead of tabs for indentation.

---
 .../staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c +1 -1
index b411ca2f415e0..966d4efb200c5 100644
@@ -1257,7 +1257,7 @@ ia_css_debug_pipe_graph_dump_stage(
 					p--;
 				/* Last comma found, copy till that comma */
 				strscpy(enable_info1, ei,
-                                        p > sizeof(enable_info1) ? sizeof(enable_info1) : p);
+					p > sizeof(enable_info1) ? sizeof(enable_info1) : p);
 
 				ei += p + 1;
 				l = strlen(ei);
Signature · 1 line
2.43.0

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hello,

The static job failure on this series was a CI infrastructure issue. The SSH tunnel to the GCE runner VM dropped mid-build ("connection reset by peer"), and the job ended with "Job failed (system failure)." The smatch build was compiling successfully when the connection died.

All other jobs passed with success.

Could the static job be retried?

Thank you!
- Michael

#3 lore raw
In reply to Michael Ugrin
Quoted 13 lines · Michael Ugrin

Fix whitespace issue where a continuation line used spaces instead of tabs for indentation.

---
 .../staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c +0 -0
index b411ca2f415e0..966d4efb200c5 100644

drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c ia_css_debug_pipe_graph_dump_stage( · line 1260

Quoted 5 lines
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c +1 -1
@@ -1257,7 +1257,7 @@ ia_css_debug_pipe_graph_dump_stage(
 					p--;
 				/* Last comma found, copy till that comma */
 				strscpy(enable_info1, ei,
-                                        p > sizeof(enable_info1) ? sizeof(enable_info1) : p);
+					p > sizeof(enable_info1) ? sizeof(enable_info1) : p);

Better to use:

	strscpy(enable_info1, ei, umin(p, sizeof(enable_info1)));

Same for the other strscpy() calls as well.

regards,
dan carpenter

#4 lore raw
Quoted 22 lines · On Sat, 11 Apr 2026 13:51:35 +0300 Dan Carpenter <[email protected]> wrote:
Quoted 13 lines · Michael Ugrin

Fix whitespace issue where a continuation line used spaces instead of tabs for indentation.

---
 .../staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c +0 -0
index b411ca2f415e0..966d4efb200c5 100644

drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c ia_css_debug_pipe_graph_dump_stage( · line 1260

Quoted 5 lines
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c +1 -1
@@ -1257,7 +1257,7 @@ ia_css_debug_pipe_graph_dump_stage(
 					p--;
 				/* Last comma found, copy till that comma */
 				strscpy(enable_info1, ei,
-                                        p > sizeof(enable_info1) ? sizeof(enable_info1) : p);
+					p > sizeof(enable_info1) ? sizeof(enable_info1) : p);  

Better to use:

Quoted 3 lines
	strscpy(enable_info1, ei, umin(p, sizeof(enable_info1)));

Same for the other strscpy() calls as well.

Or refactor that code so it doesn't use 600+ bytes of stack and lots of scanning of long strings.

From a quick scan it seems to be generating a string of xxx,yyy, with the ',' replaced by '\n' to avoid anything longer than 25 characters and at most three lines. I'm sure you could write and use a function that lets you have a lot of lines like:

	offset = add_flag(info, offset, bi->enable.reduced_pipe, "rp");

Oh, and none of your char_enable_info[] arrays are guaranteed to be aligned either.
So all the snprint and strscpy calls into different buffers are pointless.

David

Quoted 5 lines

regards,
dan carpenter

#5 lore raw

Thanks for the review, Dan and David.

I'll work on a v2,replacing the ternary with umin() for that strscpy call and the other strscpy calls in the function.

The larger refactor to eliminate the stack buffers and build the output incrementally sounds like a great improvement. I'm a new contributor and that's beyond my scope for this patch, but I'd like to come back and tackle it as a separate effort once I'm more comfortable with the codebase.

Thanks again for the guidance.

- Michael

Quoted 50 lines · David Laight
Quoted 22 lines · On Sat, 11 Apr 2026 13:51:35 +0300 Dan Carpenter <[email protected]> wrote:
Quoted 13 lines · Michael Ugrin

Fix whitespace issue where a continuation line used spaces instead of tabs for indentation.

---
 .../staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c +0 -0
index b411ca2f415e0..966d4efb200c5 100644

drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c ia_css_debug_pipe_graph_dump_stage( · line 1260

Quoted 5 lines
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c +1 -1
@@ -1257,7 +1257,7 @@ ia_css_debug_pipe_graph_dump_stage(
                                    p--;
                            /* Last comma found, copy till that comma */
                            strscpy(enable_info1, ei,
-                                        p > sizeof(enable_info1) ? sizeof(enable_info1) : p);
+                                   p > sizeof(enable_info1) ? sizeof(enable_info1) : p);

Better to use:

Quoted 3 lines
      strscpy(enable_info1, ei, umin(p, sizeof(enable_info1)));

Same for the other strscpy() calls as well.

Or refactor that code so it doesn't use 600+ bytes of stack and lots of scanning of long strings.

From a quick scan it seems to be generating a string of xxx,yyy, with the ',' replaced by '\n' to avoid anything longer than 25 characters and at most three lines. I'm sure you could write and use a function that lets you have a lot of lines like:

        offset = add_flag(info, offset, bi->enable.reduced_pipe, "rp");

Oh, and none of your char_enable_info[] arrays are guaranteed to be aligned either.
So all the snprint and strscpy calls into different buffers are pointless.

David

Quoted 5 lines

regards,
dan carpenter

#6 lore raw
Quoted 5 lines · Michael Ugrin

Thanks for the review, Dan and David.

I'll work on a v2,replacing the ternary with umin() for that strscpy call and the other strscpy calls in the function.

Why not simply min()? Wouldn't it work (if type of p is aligned accordingly)?

Note, we prefer the (more) real patches, id est what David suggested seems to me more useful to this driver to have in the long term.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#7 lore raw

PATCH v2 1/1 staging: media: atomisp: use umin() for strscpy size arguments

In reply to Michael Ugrin

Replace open-coded ternary min expressions with umin() in strscpy() calls, as suggested by Dan Carpenter.

---
 .../atomisp/pci/runtime/debug/src/ia_css_debug.c      | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c +4 -7
index b411ca2f415e0..60bb10dac5891 100644
@@ -1256,8 +1256,7 @@ ia_css_debug_pipe_graph_dump_stage(
 				while (ei[p] != ',')
 					p--;
 				/* Last comma found, copy till that comma */
-				strscpy(enable_info1, ei,
-                                        p > sizeof(enable_info1) ? sizeof(enable_info1) : p);
+				strscpy(enable_info1, ei, umin(p, sizeof(enable_info1)));
 
 				ei += p + 1;
 				l = strlen(ei);
@@ -1268,8 +1267,7 @@ ia_css_debug_pipe_graph_dump_stage(
 					 * it is not guaranteed dword aligned
 					 */
 
-					strscpy(enable_info2, ei,
-						l > sizeof(enable_info2) ? sizeof(enable_info2) : l);
+					strscpy(enable_info2, ei, umin(l, sizeof(enable_info2)));
 
 					snprintf(enable_info, sizeof(enable_info), "%s\\n%s",
 						 enable_info1, enable_info2);
@@ -1280,8 +1278,7 @@ ia_css_debug_pipe_graph_dump_stage(
 					while (ei[p] != ',')
 						p--;
 
-					strscpy(enable_info2, ei,
-						p > sizeof(enable_info2) ? sizeof(enable_info2) : p);
+					strscpy(enable_info2, ei, umin(p, sizeof(enable_info2)));
 
 					ei += p + 1;
 					l = strlen(ei);
@@ -1303,7 +1300,7 @@ ia_css_debug_pipe_graph_dump_stage(
 						while (ei[p] != ',')
 							p--;
 						strscpy(enable_info3, ei,
-							p > sizeof(enable_info3) ? sizeof(enable_info3) : p);
+							umin(p, sizeof(enable_info3)));
 						ei += p + 1;
 						strscpy(enable_info3, ei,
 							sizeof(enable_info3));
Signature · 1 line
2.43.0