Skip to contentSkip to conversation

arm64: tegra: Tegra234 UART updates

PATCH Applied Vedant Deshpande 3 participants 6 messages Jul 11, 2024 – Aug 27, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover arm64: tegra: Tegra234 UART updates

Changes since V1
- Added patch "Add DMA properties for Tegra234 UARTA"

Vedant Deshpande (2):
arm64: tegra: Add DMA properties for Tegra234 UARTA
arm64: tegra: enable same UARTs for Orin NX/Nano

 .../nvidia/tegra234-p3768-0000+p3767-0000.dts   | 17 -----------------
 .../dts/nvidia/tegra234-p3768-0000+p3767.dtsi   | 14 ++++++++++++++
 arch/arm64/boot/dts/nvidia/tegra234.dtsi        |  2 ++
 3 files changed, 16 insertions(+), 17 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/2 arm64: tegra: Add DMA properties for Tegra234 UARTA

Adding the missing dmas and dma-names properties which are required for UARTA when using with the Tegra HSUART driver.

---
 arch/arm64/boot/dts/nvidia/tegra234.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234.dtsi +2 -0
index f2e2d8d6845b..ce7d4e172300 100644
@@ -2763,6 +2763,8 @@ uarta: serial@3100000 {
 			interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&bpmp TEGRA234_CLK_UARTA>;
 			resets = <&bpmp TEGRA234_RESET_UARTA>;
+			dmas = <&gpcdma 8>, <&gpcdma 8>;
+			dma-names = "rx", "tx";
 			status = "disabled";
 		};
 
Signature · 1 line
2.25.1
maintainer Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] arm64: tegra: Add DMA properties for Tegra234 UARTA

Quoted 13 lines · Vedant Deshpande

Adding the missing dmas and dma-names properties which are required for UARTA when using with the Tegra HSUART driver.

---
  arch/arm64/boot/dts/nvidia/tegra234.dtsi | 2 ++
  1 file changed, 2 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234.dtsi +0 -0
index f2e2d8d6845b..ce7d4e172300 100644

arch/arm64/boot/dts/nvidia/tegra234.dtsi uarta: serial@3100000 { · line 2770

Quoted 8 lines
arch/arm64/boot/dts/nvidia/tegra234.dtsi +2 -0
@@ -2763,6 +2763,8 @@ uarta: serial@3100000 {
  			interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
  			clocks = <&bpmp TEGRA234_CLK_UARTA>;
  			resets = <&bpmp TEGRA234_RESET_UARTA>;
+			dmas = <&gpcdma 8>, <&gpcdma 8>;
+			dma-names = "rx", "tx";
  			status = "disabled";
  		};
 

Thanks!
Jon

Signature · 1 line
nvpublic
#3 lore raw

PATCH v2 2/2 arm64: tegra: enable same UARTs for Orin NX/Nano

In reply to Vedant Deshpande

This patch ensures that Orin NX and Orin Nano enable an identical set of serial ports. UARTA/UARTE will be enabled by adding respective nodes to the board dtsi file.

---
 .../nvidia/tegra234-p3768-0000+p3767-0000.dts   | 17 -----------------
 .../dts/nvidia/tegra234-p3768-0000+p3767.dtsi   | 14 ++++++++++++++
 2 files changed, 14 insertions(+), 17 deletions(-)
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts +0 -17
index 82a59e33c46c..5dc974bb360c 100644
@@ -7,24 +7,7 @@ / {
 	compatible = "nvidia,p3768-0000+p3767-0000", "nvidia,p3767-0000", "nvidia,tegra234";
 	model = "NVIDIA Jetson Orin NX Engineering Reference Developer Kit";
 
-	aliases {
-		serial1 = &uarta;
-		serial2 = &uarte;
-	};
-
 	bus@0 {
-		serial@3100000 {
-			compatible = "nvidia,tegra194-hsuart";
-			reset-names = "serial";
-			status = "okay";
-		};
-
-		serial@3140000 {
-			compatible = "nvidia,tegra194-hsuart";
-			reset-names = "serial";
-			status = "okay";
-		};
-
 		hda@3510000 {
 			nvidia,model = "NVIDIA Jetson Orin NX HDA";
 		};
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi +14 -0
index 6d64a24fa251..81d4f4f12ab1 100644
@@ -9,6 +9,8 @@ / {
 
 	aliases {
 		serial0 = &tcu;
+		serial1 = &uarta;
+		serial2 = &uarte;
 	};
 
 	chosen {
@@ -16,6 +18,18 @@ chosen {
 	};
 
 	bus@0 {
+		serial@3100000 {
+			compatible = "nvidia,tegra194-hsuart";
+			reset-names = "serial";
+			status = "okay";
+		};
+
+		serial@3140000 {
+			compatible = "nvidia,tegra194-hsuart";
+			reset-names = "serial";
+			status = "okay";
+		};
+
 		i2c@3160000 {
 			status = "okay";
 
Signature · 1 line
2.25.1
maintainer Reviewed-by on v2 2/2
#4 lore raw

Re: [PATCH v2 2/2] arm64: tegra: enable same UARTs for Orin NX/Nano

Quoted 61 lines · Vedant Deshpande

This patch ensures that Orin NX and Orin Nano enable an identical set of serial ports. UARTA/UARTE will be enabled by adding respective nodes to the board dtsi file.

---
  .../nvidia/tegra234-p3768-0000+p3767-0000.dts   | 17 -----------------
  .../dts/nvidia/tegra234-p3768-0000+p3767.dtsi   | 14 ++++++++++++++
  2 files changed, 14 insertions(+), 17 deletions(-)
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts +0 -17
index 82a59e33c46c..5dc974bb360c 100644
@@ -7,24 +7,7 @@ / {
  	compatible = "nvidia,p3768-0000+p3767-0000", "nvidia,p3767-0000", "nvidia,tegra234";
  	model = "NVIDIA Jetson Orin NX Engineering Reference Developer Kit";
 
-	aliases {
-		serial1 = &uarta;
-		serial2 = &uarte;
-	};
-
  	bus@0 {
-		serial@3100000 {
-			compatible = "nvidia,tegra194-hsuart";
-			reset-names = "serial";
-			status = "okay";
-		};
-
-		serial@3140000 {
-			compatible = "nvidia,tegra194-hsuart";
-			reset-names = "serial";
-			status = "okay";
-		};
-
  		hda@3510000 {
  			nvidia,model = "NVIDIA Jetson Orin NX HDA";
  		};
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi +7 -0
index 6d64a24fa251..81d4f4f12ab1 100644
@@ -9,6 +9,8 @@ / {
 
  	aliases {
  		serial0 = &tcu;
+		serial1 = &uarta;
+		serial2 = &uarte;
  	};
 
  	chosen {
@@ -16,6 +18,18 @@ chosen {
  	};
 
  	bus@0 {
+		serial@3100000 {
+			compatible = "nvidia,tegra194-hsuart";
+			reset-names = "serial";
+			status = "okay";
+		};

arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi chosen { · line 35

Quoted 10 lines
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi +7 -0
+
+		serial@3140000 {
+			compatible = "nvidia,tegra194-hsuart";
+			reset-names = "serial";
+			status = "okay";
+		};
+
  		i2c@3160000 {
  			status = "okay";
 

Thanks!
Jon

Signature · 1 line
nvpublic
#5 lore raw
In reply to Vedant Deshpande

From: Thierry Reding <[email protected]>

Quoted 8 lines · Vedant Deshpande

Changes since V1
- Added patch "Add DMA properties for Tegra234 UARTA"

Vedant Deshpande (2):
arm64: tegra: Add DMA properties for Tegra234 UARTA
arm64: tegra: enable same UARTs for Orin NX/Nano

[...]

Applied, thanks!

[1/2] arm64: tegra: Add DMA properties for Tegra234 UARTA

      commit: 7ac0be7a4cd708dd5139e68597c816fa4ce22a88
[2/2] arm64: tegra: enable same UARTs for Orin NX/Nano
      commit: 92331cc63ce378546368c8a58c4d8cbb044d1f70

Best regards,

Signature · 1 line
Thierry Reding <[email protected]>