drm/tests: modeset: Add drm connector atomic_[duplicate/destroy]_state
Subsystems (2)
PATCH v2 1/1 drm/tests: modeset: Add drm connector atomic_[duplicate/destroy]_state
Commit 66671944e176 ("drm/tests: helpers: Add atomic helpers") added the atomic state path, so adding the drm connector atomic_[duplicate/destroy]_state is also necessary.
WARNING: CPU: 0 PID: 96 at drivers/gpu/drm/drm_connector.c:234 drm_connector_init_only+0x934/0xee0 Call trace: drm_connector_init_only+0x934/0xee0 (P) drmm_connector_init+0xe0/0x1b0 drm_client_modeset_test_init+0x290/0x534 kunit_try_run_case+0x110/0x3b4 kunit_generic_run_threadfn_adapter+0x80/0xec kthread+0x3b8/0x6c0 ret_from_fork+0x10/0x20
---
v1: https://patchew.org/linux/[email protected]/
v2: compared with v1, add Fixes tag
drivers/gpu/drm/tests/drm_client_modeset_test.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/tests/drm_client_modeset_test.c +4 -0
@@ -12,6 +12,7 @@#include <drm/drm_modes.h> #include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_probe_helper.h> +#include <drm/drm_atomic_state_helper.h> struct drm_client_modeset_test_priv {struct drm_device *drm;
@@ -48,6 +49,9 @@ static const struct drm_connector_helper_funcs drm_client_modeset_connector_help };static const struct drm_connector_funcs drm_client_modeset_connector_funcs = { + .reset = drm_atomic_helper_connector_reset, + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, };static int drm_client_modeset_test_init (struct kunit *test)
Signature · 1 line
2.43.0
Hi Xiaolei,
Quoted 40 lines · Xiaolei Wang
Commit
66671944e176("drm/tests: helpers: Add atomic helpers") added the atomic state path, so adding the drm connector atomic_[duplicate/destroy]_state is also necessary.WARNING: CPU: 0 PID: 96 at drivers/gpu/drm/drm_connector.c:234 drm_connector_init_only+0x934/0xee0 Call trace: drm_connector_init_only+0x934/0xee0 (P) drmm_connector_init+0xe0/0x1b0 drm_client_modeset_test_init+0x290/0x534 kunit_try_run_case+0x110/0x3b4 kunit_generic_run_threadfn_adapter+0x80/0xec kthread+0x3b8/0x6c0 ret_from_fork+0x10/0x20Fixes 66671944e176 ("drm/tests: helpers: Add atomic helpers")Signed-off-by Xiaolei Wang <[email protected]>Reviewed-by Maxime Ripard <[email protected]>Reviewed-by Dmitry Baryshkov <[email protected]>---
v1: https://patchew.org/linux/[email protected]/
v2: compared with v1, add Fixes tag
drivers/gpu/drm/tests/drm_client_modeset_test.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/tests/drm_client_modeset_test.c +1
-0@@ -12,6 +12,7 @@#include <drm/drm_modes.h> #include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_probe_helper.h> +#include <drm/drm_atomic_state_helper.h> struct drm_client_modeset_test_priv {struct drm_device *drm;
drivers/gpu/drm/tests/drm_client_modeset_test.c static const struct drm_connector_helper_funcs drm_client_modeset_connector_help · line 57
Quoted 9 lines
drivers/gpu/drm/tests/drm_client_modeset_test.c +3
-0@@ -48,6 +49,9 @@ static const struct drm_connector_helper_funcs drm_client_modeset_connector_help };static const struct drm_connector_funcs drm_client_modeset_connector_funcs = { + .reset = drm_atomic_helper_connector_reset, + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, };static int drm_client_modeset_test_init (struct kunit *test)
Thanks,
Alex
Quoted 58 lines · Alexandre Ghiti
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.Hi Xiaolei,
Quoted 51 lines · Xiaolei Wang
Commit
66671944e176("drm/tests: helpers: Add atomic helpers") added the atomic state path, so adding the drm connector atomic_[duplicate/destroy]_state is also necessary.WARNING: CPU: 0 PID: 96 at drivers/gpu/drm/drm_connector.c:234 drm_connector_init_only+0x934/0xee0 Call trace: drm_connector_init_only+0x934/0xee0 (P) drmm_connector_init+0xe0/0x1b0 drm_client_modeset_test_init+0x290/0x534 kunit_try_run_case+0x110/0x3b4 kunit_generic_run_threadfn_adapter+0x80/0xec kthread+0x3b8/0x6c0 ret_from_fork+0x10/0x20Fixes 66671944e176 ("drm/tests: helpers: Add atomic helpers")Signed-off-by Xiaolei Wang <[email protected]>Reviewed-by Maxime Ripard <[email protected]>Reviewed-by Dmitry Baryshkov <[email protected]>---
v1: https://patchew.org/linux/[email protected]/
v2: compared with v1, add Fixes tag
drivers/gpu/drm/tests/drm_client_modeset_test.c| 4 ++++1 file changed, 4 insertions(+)drivers/gpu/drm/tests/drm_client_modeset_test.c +1
-0@@ -12,6 +12,7 @@ #include <drm/drm_modes.h> #include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_probe_helper.h> +#include <drm/drm_atomic_state_helper.h> struct drm_client_modeset_test_priv { struct drm_device *drm;@@ -48,6 +49,9 @@ static const struct drm_connector_helper_funcs
drm_client_modeset_connector_help
};static const struct
drm_connector_funcsdrm_client_modeset_connector_funcs= { + .reset =drm_atomic_helper_connector_reset, + .atomic_duplicate_state =drm_atomic_helper_connector_duplicate_state,
+ .atomic_destroy_state =drm_atomic_helper_connector_destroy_state,
};
Quoted 2 lines
Quoted 1 line
static int
drm_client_modeset_test_init(struct kunit *test)
Humble ping...
thanks
xiaolei
Quoted 7 lines
Tested-by Alexandre Ghiti <[email protected]>Thanks,
Alex