scsi: ufs: set device as active power mode after resetting device
Subsystems (2)
PATCH 1/1 scsi: ufs: set device as active power mode after resetting device
Currently ufshcd driver assumes that bInitPowerMode parameter is not changed by any vendors thus device power mode can be set as "Active" during initialization.
According to UFS JEDEC specification, device power mode shall be "Active" after HW Reset is triggered if the bInitPowerMode parameter in Device Descriptor is default value.
By above description, we can set device power mode as "Active" after device reset is triggered by vendor's callback. With this change, the link startup performance can be improved in some cases by not setting link_startup_again as true in ufshcd_link_startup().
--- drivers/scsi/ufs/ufshcd.c | 13 ------------- drivers/scsi/ufs/ufshcd.h | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 13 deletions(-)
drivers/scsi/ufs/ufshcd.c +0 -13
@@ -171,19 +171,6 @@ enum {#define ufshcd_clear_eh_in_progress (h) \ ((h)->eh_flags &= ~UFSHCD_EH_IN_PROGRESS) -#define ufshcd_set_ufs_dev_active (h) \ - ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) -#define ufshcd_set_ufs_dev_sleep (h) \ - ((h)->curr_dev_pwr_mode = UFS_SLEEP_PWR_MODE) -#define ufshcd_set_ufs_dev_poweroff (h) \ - ((h)->curr_dev_pwr_mode = UFS_POWERDOWN_PWR_MODE) -#define ufshcd_is_ufs_dev_active (h) \ - ((h)->curr_dev_pwr_mode == UFS_ACTIVE_PWR_MODE) -#define ufshcd_is_ufs_dev_sleep (h) \ - ((h)->curr_dev_pwr_mode == UFS_SLEEP_PWR_MODE) -#define ufshcd_is_ufs_dev_poweroff (h) \ - ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) -struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { {UFS_ACTIVE_PWR_MODE ,UIC_LINK_ACTIVE_STATE }, {UFS_ACTIVE_PWR_MODE ,UIC_LINK_HIBERN8_STATE },
drivers/scsi/ufs/ufshcd.h +14 -0
@@ -129,6 +129,19 @@ enum uic_link_state {#define ufshcd_set_link_hibern8 (hba) ((hba)->uic_link_state = \ UIC_LINK_HIBERN8_STATE) +#define ufshcd_set_ufs_dev_active (h) \ + ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) +#define ufshcd_set_ufs_dev_sleep (h) \ + ((h)->curr_dev_pwr_mode = UFS_SLEEP_PWR_MODE) +#define ufshcd_set_ufs_dev_poweroff (h) \ + ((h)->curr_dev_pwr_mode = UFS_POWERDOWN_PWR_MODE) +#define ufshcd_is_ufs_dev_active (h) \ + ((h)->curr_dev_pwr_mode == UFS_ACTIVE_PWR_MODE) +#define ufshcd_is_ufs_dev_sleep (h) \ + ((h)->curr_dev_pwr_mode == UFS_SLEEP_PWR_MODE) +#define ufshcd_is_ufs_dev_poweroff (h) \ + ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) +/* * UFS Power management levels. * Each level is in increasing order of power savings.
@@ -1091,6 +1104,7 @@ static inline void ufshcd_vops_device_reset(struct ufs_hba *hba) {if (hba->vops && hba->vops->device_reset) { hba->vops->device_reset (hba); +ufshcd_set_ufs_dev_active (hba);ufshcd_update_reg_hist (&hba->ufs_stats.dev_reset,0 ); } }
Signature · 1 line
2.18.0
Quoted 75 lines · Stanley Chu
Currently ufshcd driver assumes that bInitPowerMode parameter is not changed by any vendors thus device power mode can be set as "Active" during initialization.
According to UFS JEDEC specification, device power mode shall be "Active" after HW Reset is triggered if the bInitPowerMode parameter in Device Descriptor is default value.
By above description, we can set device power mode as "Active" after device reset is triggered by vendor's callback. With this change, the link startup performance can be improved in some cases by not setting
link_startup_againas true inufshcd_link_startup().Signed-off-by Stanley Chu <[email protected]>--- drivers/scsi/ufs/ufshcd.c | 13 ------------- drivers/scsi/ufs/ufshcd.h | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 13 deletions(-)drivers/scsi/ufs/ufshcd.c +0
-13@@ -171,19 +171,6 @@ enum {#define ufshcd_clear_eh_in_progress (h) \ ((h)->eh_flags &= ~UFSHCD_EH_IN_PROGRESS) -#define ufshcd_set_ufs_dev_active (h) \ - ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) -#define ufshcd_set_ufs_dev_sleep (h) \ - ((h)->curr_dev_pwr_mode = UFS_SLEEP_PWR_MODE) -#define ufshcd_set_ufs_dev_poweroff (h) \ - ((h)->curr_dev_pwr_mode = UFS_POWERDOWN_PWR_MODE) -#define ufshcd_is_ufs_dev_active (h) \ - ((h)->curr_dev_pwr_mode == UFS_ACTIVE_PWR_MODE) -#define ufshcd_is_ufs_dev_sleep (h) \ - ((h)->curr_dev_pwr_mode == UFS_SLEEP_PWR_MODE) -#define ufshcd_is_ufs_dev_poweroff (h) \ - ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) -struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { {UFS_ACTIVE_PWR_MODE ,UIC_LINK_ACTIVE_STATE }, {UFS_ACTIVE_PWR_MODE ,UIC_LINK_HIBERN8_STATE },drivers/scsi/ufs/ufshcd.h +14
-0@@ -129,6 +129,19 @@ enum uic_link_state {#define ufshcd_set_link_hibern8 (hba) ((hba)->uic_link_state = \ UIC_LINK_HIBERN8_STATE) +#define ufshcd_set_ufs_dev_active (h) \ + ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) +#define ufshcd_set_ufs_dev_sleep (h) \ + ((h)->curr_dev_pwr_mode = UFS_SLEEP_PWR_MODE) +#define ufshcd_set_ufs_dev_poweroff (h) \ + ((h)->curr_dev_pwr_mode = UFS_POWERDOWN_PWR_MODE) +#define ufshcd_is_ufs_dev_active (h) \ + ((h)->curr_dev_pwr_mode == UFS_ACTIVE_PWR_MODE) +#define ufshcd_is_ufs_dev_sleep (h) \ + ((h)->curr_dev_pwr_mode == UFS_SLEEP_PWR_MODE) +#define ufshcd_is_ufs_dev_poweroff (h) \ + ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) +/* * UFS Power management levels. * Each level is in increasing order of power savings. @@ -1091,6 +1104,7 @@ static inline void ufshcd_vops_device_reset(struct ufs_hba *hba) {if (hba->vops && hba->vops->device_reset) { hba->vops->device_reset (hba); +ufshcd_set_ufs_dev_active (hba);ufshcd_update_reg_hist (&hba->ufs_stats.dev_reset,0 ); }
Quoted 1 line
}
Hi Stanley,
Quoted 71 lines · Can Guo
Quoted 70 lines · Stanley Chu
Currently ufshcd driver assumes that bInitPowerMode parameter is not changed by any vendors thus device power mode can be set as "Active" during initialization.
According to UFS JEDEC specification, device power mode shall be "Active" after HW Reset is triggered if the bInitPowerMode parameter in Device Descriptor is default value.
By above description, we can set device power mode as "Active" after device reset is triggered by vendor's callback. With this change, the link startup performance can be improved in some cases by not setting
link_startup_againas true inufshcd_link_startup().Signed-off-by Stanley Chu <[email protected]>--- drivers/scsi/ufs/ufshcd.c | 13 ------------- drivers/scsi/ufs/ufshcd.h | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 13 deletions(-)drivers/scsi/ufs/ufshcd.c +0
-13@@ -171,19 +171,6 @@ enum {#define ufshcd_clear_eh_in_progress (h) \ ((h)->eh_flags &= ~UFSHCD_EH_IN_PROGRESS) -#define ufshcd_set_ufs_dev_active (h) \ - ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) -#define ufshcd_set_ufs_dev_sleep (h) \ - ((h)->curr_dev_pwr_mode = UFS_SLEEP_PWR_MODE) -#define ufshcd_set_ufs_dev_poweroff (h) \ - ((h)->curr_dev_pwr_mode = UFS_POWERDOWN_PWR_MODE) -#define ufshcd_is_ufs_dev_active (h) \ - ((h)->curr_dev_pwr_mode == UFS_ACTIVE_PWR_MODE) -#define ufshcd_is_ufs_dev_sleep (h) \ - ((h)->curr_dev_pwr_mode == UFS_SLEEP_PWR_MODE) -#define ufshcd_is_ufs_dev_poweroff (h) \ - ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) -struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { {UFS_ACTIVE_PWR_MODE ,UIC_LINK_ACTIVE_STATE }, {UFS_ACTIVE_PWR_MODE ,UIC_LINK_HIBERN8_STATE },drivers/scsi/ufs/ufshcd.h +13
-0@@ -129,6 +129,19 @@ enum uic_link_state {#define ufshcd_set_link_hibern8 (hba) ((hba)->uic_link_state = \ UIC_LINK_HIBERN8_STATE) +#define ufshcd_set_ufs_dev_active (h) \ + ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) +#define ufshcd_set_ufs_dev_sleep (h) \ + ((h)->curr_dev_pwr_mode = UFS_SLEEP_PWR_MODE) +#define ufshcd_set_ufs_dev_poweroff (h) \ + ((h)->curr_dev_pwr_mode = UFS_POWERDOWN_PWR_MODE) +#define ufshcd_is_ufs_dev_active (h) \ + ((h)->curr_dev_pwr_mode == UFS_ACTIVE_PWR_MODE) +#define ufshcd_is_ufs_dev_sleep (h) \ + ((h)->curr_dev_pwr_mode == UFS_SLEEP_PWR_MODE) +#define ufshcd_is_ufs_dev_poweroff (h) \ + ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) +/* * UFS Power management levels. * Each level is in increasing order of power savings. @@ -1091,6 +1104,7 @@ static inline void ufshcd_vops_device_reset(struct ufs_hba *hba) {
Quoted 8 lines
Quoted 6 lines
drivers/scsi/ufs/ufshcd.h +1
-0if (hba->vops && hba->vops->device_reset) { hba->vops->device_reset (hba); +ufshcd_set_ufs_dev_active (hba);ufshcd_update_reg_hist (&hba->ufs_stats.dev_reset,0 ); }}
Reviewed-by Can Guo <[email protected]>
I guess what you also want my patch -
"scsi: ufs: full reinit upon resume if link was off"
Please help review it, thanks.
Best regard,
Can Guo.
Hi,
Quoted 8 lines · Stanley Chu
Currently ufshcd driver assumes that bInitPowerMode parameter is not changed by any vendors thus device power mode can be set as "Active" during initialization.
According to UFS JEDEC specification, device power mode shall be "Active" after HW Reset is triggered if the bInitPowerMode parameter in Device Descriptor is default value.
Quoted 7 lines
By above description, we can set device power mode as "Active" after device reset is triggered by vendor's callback. With this change, the link startup performance can be improved in some cases by not setting
link_startup_againas true inufshcd_link_startup().Signed-off-by Stanley Chu <[email protected]>---
Quoted 61 lines
drivers/scsi/ufs/ufshcd.c | 13 ------------- drivers/scsi/ufs/ufshcd.h | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 13 deletions(-)drivers/scsi/ufs/ufshcd.c +0
-13@@ -171,19 +171,6 @@ enum {#define ufshcd_clear_eh_in_progress (h) \ ((h)->eh_flags &= ~UFSHCD_EH_IN_PROGRESS) -#define ufshcd_set_ufs_dev_active (h) \ - ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) -#define ufshcd_set_ufs_dev_sleep (h) \ - ((h)->curr_dev_pwr_mode = UFS_SLEEP_PWR_MODE) -#define ufshcd_set_ufs_dev_poweroff (h) \ - ((h)->curr_dev_pwr_mode = UFS_POWERDOWN_PWR_MODE) -#define ufshcd_is_ufs_dev_active (h) \ - ((h)->curr_dev_pwr_mode == UFS_ACTIVE_PWR_MODE) -#define ufshcd_is_ufs_dev_sleep (h) \ - ((h)->curr_dev_pwr_mode == UFS_SLEEP_PWR_MODE) -#define ufshcd_is_ufs_dev_poweroff (h) \ - ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) -struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { {UFS_ACTIVE_PWR_MODE ,UIC_LINK_ACTIVE_STATE }, {UFS_ACTIVE_PWR_MODE ,UIC_LINK_HIBERN8_STATE },drivers/scsi/ufs/ufshcd.h +14
-0@@ -129,6 +129,19 @@ enum uic_link_state {#define ufshcd_set_link_hibern8 (hba) ((hba)->uic_link_state = \ UIC_LINK_HIBERN8_STATE) +#define ufshcd_set_ufs_dev_active (h) \ + ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) +#define ufshcd_set_ufs_dev_sleep (h) \ + ((h)->curr_dev_pwr_mode = UFS_SLEEP_PWR_MODE) +#define ufshcd_set_ufs_dev_poweroff (h) \ + ((h)->curr_dev_pwr_mode = UFS_POWERDOWN_PWR_MODE) +#define ufshcd_is_ufs_dev_active (h) \ + ((h)->curr_dev_pwr_mode == UFS_ACTIVE_PWR_MODE) +#define ufshcd_is_ufs_dev_sleep (h) \ + ((h)->curr_dev_pwr_mode == UFS_SLEEP_PWR_MODE) +#define ufshcd_is_ufs_dev_poweroff (h) \ + ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) +/* * UFS Power management levels. * Each level is in increasing order of power savings. @@ -1091,6 +1104,7 @@ static inline void ufshcd_vops_device_reset(struct ufs_hba *hba) {if (hba->vops && hba->vops->device_reset) { hba->vops->device_reset (hba); +ufshcd_set_ufs_dev_active (hba);ufshcd_update_reg_hist (&hba->ufs_stats.dev_reset,0 ); } }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project
Martin K. Petersen
AppliedStanley,
Quoted 3 lines
Currently ufshcd driver assumes that bInitPowerMode parameter is not changed by any vendors thus device power mode can be set as "Active" during initialization.
Applied to 5.7/scsi-queue, thanks!
Signature · 6 lines
Martin K. Petersen Oracle Linux Engineering _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel