Skip to contentSkip to conversation

generic/050: handle f2fs as nojournal filesystem

PATCH In review Jan Prusakowski 4 participants 6 messages Apr 10 – Apr 17

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/050: handle f2fs as nojournal filesystem

F2FS uses a checkpoint mechanism for metadata consistency rather than a traditional journal. Roll-forward recovery is only needed if there are fsync'd files since the last checkpoint.

In this test case, files are created without fsync, so there is no roll-forward data to replay during mount.

Therefore, F2FS does not need to write to the device to recover, and successfully mounts on the read-only block device. Thus, it should be treated as nojournal in this case.

---
 tests/generic/050 | 12 ++++++++++++
 1 file changed, 12 insertions(+)
tests/generic/050 +12 -0
index 3bc37175..3a641a65 100755
@@ -46,6 +46,18 @@ elif [ "$FSTYP" = "btrfs" ]; then
 	# So for this test case, btrfs will not get any dirty log tree thus
 	# it can be treated as "nojournal".
 	features="nojournal"
+elif [ "$FSTYP" = "f2fs" ]; then
+	# F2FS uses a checkpoint mechanism for metadata consistency rather than a
+	# traditional journal. Roll-forward recovery is only needed if there are
+	# fsync'd files since the last checkpoint.
+	#
+	# In this test case, files are created without fsync, so there is no
+	# roll-forward data to replay during mount.
+	#
+	# Therefore, F2FS does not need to write to the device to recover, and
+	# successfully mounts on the read-only block device. Thus, it should be
+	# treated as "nojournal" in this case.
+	features="nojournal"
 fi
 _link_out_file "$features"
 
Signature · 1 line
2.53.0.1213.gd9a14994de-goog
#1 lore raw
Quoted 10 lines · Jan Prusakowski

F2FS uses a checkpoint mechanism for metadata consistency rather than a traditional journal. Roll-forward recovery is only needed if there are fsync'd files since the last checkpoint.

In this test case, files are created without fsync, so there is no roll-forward data to replay during mount.

Therefore, F2FS does not need to write to the device to recover, and successfully mounts on the read-only block device. Thus, it should be treated as nojournal in this case.

This looks ok, but I always wonder if we want an opt-in for this "journaling" behavior and/or define it clear in common/.

#2 lore raw
Quoted 8 lines · Christoph Hellwig
Quoted 7 lines · Jan Prusakowski

F2FS uses a checkpoint mechanism for metadata consistency rather than a traditional journal. Roll-forward recovery is only needed if there are fsync'd files since the last checkpoint.

In this test case, files are created without fsync, so there is no roll-forward data to replay during mount.

Quoted 6 lines
Quoted 3 lines

Therefore, F2FS does not need to write to the device to recover, and successfully mounts on the read-only block device. Thus, it should be treated as nojournal in this case.

This looks ok, but I always wonder if we want an opt-in for this "journaling" behavior and/or define it clear in common/.

_has_traditional_journal ? _has_journal_replay ? :-D

#3 lore raw
Quoted 8 lines · Zorro Lang
Quoted 6 lines
Quoted 3 lines

Therefore, F2FS does not need to write to the device to recover, and successfully mounts on the read-only block device. Thus, it should be treated as nojournal in this case.

This looks ok, but I always wonder if we want an opt-in for this "journaling" behavior and/or define it clear in common/.

_has_traditional_journal ? _has_journal_replay ? :-D

Good question. We already have _has_metadata_journaling, which is used in this test and in _require_metadata_journaling. Unfortunately no one has bother to describe what behavior it is supposed to guard.

From looking at the _require_metadata_journaling users, it really seems to be about providing file system consistency after crash. So maybe _has_metadata_journaling, should be renamed to this effect?

Now in generic/050 the check patched here is used to select the golden output. When I wrote the test originally (I can't even remember that), it was a XFS-specific test, and Jan then later tested it to add this _has_metadata_journaling check, which also needed further btrfs workarounds. AFAICS it is all about failing the mount if log recovery is required, but the underlying block device is read-only. So maybe name it after that?

Reviewed-by on v1 1/1
#4 lore raw
In reply to Jan Prusakowski
Quoted 26 lines · Jan Prusakowski

F2FS uses a checkpoint mechanism for metadata consistency rather than a traditional journal. Roll-forward recovery is only needed if there are fsync'd files since the last checkpoint.

In this test case, files are created without fsync, so there is no roll-forward data to replay during mount.

Therefore, F2FS does not need to write to the device to recover, and successfully mounts on the read-only block device. Thus, it should be treated as nojournal in this case.

---
 tests/generic/050 | 12 ++++++++++++
 1 file changed, 12 insertions(+)
tests/generic/050 +2 -0
index 3bc37175..3a641a65 100755
@@ -46,6 +46,18 @@ elif [ "$FSTYP" = "btrfs" ]; then
 	# So for this test case, btrfs will not get any dirty log tree thus
 	# it can be treated as "nojournal".
 	features="nojournal"
+elif [ "$FSTYP" = "f2fs" ]; then
+	# F2FS uses a checkpoint mechanism for metadata consistency rather than a

tests/generic/050 elif [ "$FSTYP" = "btrfs" ]; then · line 60

Quoted 10 lines
tests/generic/050 +10 -0
+	# traditional journal. Roll-forward recovery is only needed if there are
+	# fsync'd files since the last checkpoint.
+	#
+	# In this test case, files are created without fsync, so there is no
+	# roll-forward data to replay during mount.
+	#
+	# Therefore, F2FS does not need to write to the device to recover, and
+	# successfully mounts on the read-only block device. Thus, it should be
+	# treated as "nojournal" in this case.
+	features="nojournal"

OK, so f2fs is similar with what btrfs does in this case.

Quoted 7 lines
tests/generic/050 +0 -0
 fi
 _link_out_file "$features"
 
Signature · 1 line
2.53.0.1213.gd9a14994de-goog
Reviewed-by on v1 1/1
#5 lore raw
In reply to Jan Prusakowski
Quoted 4 lines · On 4/10/26 13:18, Jan Prusakowski via Linux-f2fs-devel wrote:

F2FS uses a checkpoint mechanism for metadata consistency rather than a traditional journal. Roll-forward recovery is only needed if there are fsync'd files since the last checkpoint.

Quoted 8 lines

In this test case, files are created without fsync, so there is no roll-forward data to replay during mount.

Therefore, F2FS does not need to write to the device to recover, and successfully mounts on the read-only block device. Thus, it should be treated as nojournal in this case.

Thanks,