iio: buffer: fix warning in requesting threaded irq
PATCH 1/1 iio: buffer: fix warning in requesting threaded irq
IRQF_ONESHOT is for threaded IRQ. If there is no threaded IRQ handler, this flag should not be set.
This change fixes a warning during booting with kernel v7.0-rc3:
WARNING: kernel/irq/manage.c:1502 at __setup_irq+0x1639/0x2510, CPU#3: iio-sensor-prox/974 Call Trace: request_threaded_irq+0x2c7/0x490 iio_trigger_attach_poll_func+0x353/0x6b0 __iio_update_buffers+0x2420/0x2c70 enable_store+0x183/0x270 dev_attr_store+0x5e/0x90 sysfs_kf_write+0x1e8/0x290 kernfs_fop_write_iter+0x406/0x5f0 vfs_write+0x71c/0xea0
v3: remove unneeded log in git message
v2: use ternary and drop temp variable
--- drivers/iio/buffer/industrialio-triggered-buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/buffer/industrialio-triggered-buffer.c +1 -1
@@ -64,7 +64,7 @@ int iio_triggered_buffer_setup_ext(struct iio_dev *indio_dev, indio_dev->pollfunc = iio_alloc_pollfunc(h, thread, - IRQF_ONESHOT, + thread ? IRQF_ONESHOT : 0, indio_dev, "%s_consumer%d", indio_dev->name,
Signature · 1 line
2.43.0
Quoted 5 lines · Junxiao Chang
IRQF_ONESHOTis for threaded IRQ. If there is no threaded IRQ handler, this flag should not be set.This change fixes a warning during booting with kernel v7.0-rc3:
Quoted 11 lines
WARNING: kernel/irq/manage.c:1502 at __setup_irq+0x1639/0x2510, CPU#3: iio-sensor-prox/974 Call Trace: request_threaded_irq+0x2c7/0x490 iio_trigger_attach_poll_func+0x353/0x6b0 __iio_update_buffers+0x2420/0x2c70 enable_store+0x183/0x270 dev_attr_store+0x5e/0x90 sysfs_kf_write+0x1e8/0x290 kernfs_fop_write_iter+0x406/0x5f0 vfs_write+0x71c/0xea0
These 3 lines do not bring much value.
Quoted 1 line
v3: remove unneeded log in git message
No, it's still there.
Quoted 1 line
v2: use ternary and drop temp variable
Also the changelog is still noise part of the commit message.
Whatever, I leave it to Jonathan who usually tweaks the patches whilst applying.
...
What it worth is to add a summary of the driver (and platform, if available) in use.
Signature · 2 lines
With Best Regards, Andy Shevchenko