Skip to contentSkip to conversation

thermal: k3_j72xx_bandgap: Fix the debug print message

PATCH Applied Keerthy 3 participants 5 messages Oct 10, 2022 – Dec 9, 2022 Thermal

lore
Share & tools
lore

Keerthy

author
#0 lore raw

PATCH 1/1 thermal: k3_j72xx_bandgap: Fix the debug print message

The debug print message to check the workaround applicability is inverted. Fix the same.

Fixes ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support")
---
 drivers/thermal/k3_j72xx_bandgap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/k3_j72xx_bandgap.c +1 -1
index 16b6bcf1bf4f..c073b1023bbe 100644
@@ -439,7 +439,7 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev)
 		workaround_needed = false;
 
 	dev_dbg(bgp->dev, "Work around %sneeded\n",
-		workaround_needed ? "not " : "");
+		workaround_needed ? "" : "not ");
 
 	if (!workaround_needed)
 		init_table(5, ref_table, golden_factors);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 7 lines · Keerthy

The debug print message to check the workaround applicability is inverted. Fix the same.

Fixes ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support")

---

Applied, thanks

BTW, Kheerty, if you have time is it possible to convert the k3_bandgap.c with the pre-computed factors like the k3_j72xx_bandgap.c, so both can be merged ?

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
author
#2 lore raw
Quoted 4 lines · Daniel Lezcano
Quoted 3 lines · Keerthy

The debug print message to check the workaround applicability is inverted. Fix the same.

Quoted 8 lines
Quoted 4 lines
Fixes ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support")

---

Applied, thanks

BTW, Kheerty, if you have time is it possible to convert the k3_bandgap.c with the pre-computed factors like the k3_j72xx_bandgap.c, so both can be merged ?

Okay. I will try that out in a couple of weeks time.

Thanks,
Keerthy

Quoted 4 lines
#3 lore raw
Quoted 12 lines · KEERTHY
Quoted 9 lines · Daniel Lezcano
Quoted 7 lines · Keerthy

The debug print message to check the workaround applicability is inverted. Fix the same.

Fixes ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support")

---

Quoted 5 lines
Quoted 3 lines

Applied, thanks

BTW, Kheerty, if you have time is it possible to convert the k3_bandgap.c with the pre-computed factors like the k3_j72xx_bandgap.c, so both can be merged ?

Okay. I will try that out in a couple of weeks time.

Great, thanks!

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
merge bot Applied
#4 lore raw

[thermal: thermal/next] thermal/drivers/k3_j72xx_bandgap: Fix the debug print message

In reply to Keerthy
The following commit has been merged into the thermal/next branch of thermal:

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     94f26962392cac2f467744c11bf2aec9ea199cc9
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//94f26962392cac2f467744c11bf2aec9ea199cc9
Author:        Keerthy <[email protected]>
AuthorDate:    Mon, 10 Oct 2022 09:11:26 +05:30
Committer:     Daniel Lezcano <[email protected]>
CommitterDate: Thu, 08 Dec 2022 14:30:43 +01:00

thermal/drivers/k3_j72xx_bandgap: Fix the debug print message

The debug print message to check the workaround applicability is inverted. Fix the same.

Fixes ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support")
---
 drivers/thermal/k3_j72xx_bandgap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/k3_j72xx_bandgap.c +1 -1
index 16b6bcf..c073b10 100644
@@ -439,7 +439,7 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev)
 		workaround_needed = false;
 
 	dev_dbg(bgp->dev, "Work around %sneeded\n",
-		workaround_needed ? "not " : "");
+		workaround_needed ? "" : "not ");
 
 	if (!workaround_needed)
 		init_table(5, ref_table, golden_factors);