Skip to contentSkip to conversation

block: unalign call_single_data in struct request

PATCH New Jens Axboe 1 participant 1 message Dec 20, 2017 Block layer

lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 block: unalign call_single_data in struct request

A previous change blindly added massive alignment to the call_single_data structure in struct request. This ballooned it in size from 296 to 320 bytes on my setup, for no valid reason at all.

Use the unaligned struct __call_single_data variant instead.

Fixes 966a967116e69 ("smp: Avoid using two cache lines for struct call_single_data")

---

include/linux/blkdev.h +1 -1
index 100d0df38026..0ce8a372d506 100644
@@ -135,7 +135,7 @@ typedef __u32 __bitwise req_flags_t;
 struct request {
 	struct list_head queuelist;
 	union {
-		call_single_data_t csd;
+		struct __call_single_data csd;
 		u64 fifo_time;
 	};
 
Signature · 1 line
Jens Axboe