Skip to contentSkip to conversation

drm/i915: use DDC_ADDR instead of hard-coding it

PATCH In review Matt Turner 2 participants 2 messages Sep 23, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: use DDC_ADDR instead of hard-coding it

---
 drivers/gpu/drm/i915/intel_modes.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_modes.c +3 -2
index 3b26a3b..ab534be 100644
@@ -27,6 +27,7 @@
 #include <linux/i2c.h>
 #include <linux/fb.h>
 #include "drmP.h"
+#include "drm_edid.h"
 #include "intel_drv.h"
 #include "i915_drv.h"
 
@@ -41,13 +42,13 @@ bool intel_ddc_probe(struct intel_encoder *intel_encoder, int ddc_bus)
 	u8 buf[2];
 	struct i2c_msg msgs[] = {
 		{
-			.addr = 0x50,
+			.addr = DDC_ADDR,
 			.flags = 0,
 			.len = 1,
 			.buf = out_buf,
 		},
 		{
-			.addr = 0x50,
+			.addr = DDC_ADDR,
 			.flags = I2C_M_RD,
 			.len = 1,
 			.buf = buf,
Signature · 1 line
1.7.3.4
#1 lore raw
Quoted 1 line · Matt Turner

We should just make intel_ddc_probe() a wrapper around drm_probe_ddc(). -Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre