perf dwarf-regs: Fix off by one in __get_dwarf_regnum_for_perf_regnum_csky()
Subsystems (3)
PATCH 1/1 perf dwarf-regs: Fix off by one in __get_dwarf_regnum_for_perf_regnum_csky()
Change the > comparison >= to prevent an out of bounds access of the dwarf_csky_regnumsp[] array.
Fixes 8cac4013b0c2 ("perf dwarf-regs: Add csky perf to dwarf register number mapping functions")
Signed-off-by Dan Carpenter <[email protected]>
---
--- tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c +1 -1
@@ -118,7 +118,7 @@ int __get_dwarf_regnum_for_perf_regnum_csky(int perf_regnum, unsigned int flags)if (flags &EF_CSKY_ABIV2 ) idx++; -if (perf_regnum <0 || perf_regnum > (int )ARRAY_SIZE (dwarf_csky_regnums) || +if (perf_regnum <0 || perf_regnum >= (int )ARRAY_SIZE (dwarf_csky_regnums) || dwarf_csky_regnums[perf_regnum][idx] ==0 )return -ENOENT ;
Signature · 1 line
2.53.0
Quoted 15 lines · Dan Carpenter
Change the > comparison >= to prevent an out of bounds access of the dwarf_csky_regnumsp[] array.
Fixes 8cac4013b0c2 ("perf dwarf-regs: Add csky perf to dwarf register number mapping functions")Signed-off-by Dan Carpenter <[email protected]>---
--- tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c +0
-0
tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c int __get_dwarf_regnum_for_perf_regnum_csky(int perf_regnum, unsigned int flags) · line 124
Quoted 8 lines
tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c +1
-1@@ -118,7 +118,7 @@ int __get_dwarf_regnum_for_perf_regnum_csky(int perf_regnum, unsigned int flags)if (flags &EF_CSKY_ABIV2 ) idx++; -if (perf_regnum <0 || perf_regnum > (int )ARRAY_SIZE (dwarf_csky_regnums) || +if (perf_regnum <0 || perf_regnum >= (int )ARRAY_SIZE (dwarf_csky_regnums) || dwarf_csky_regnums[perf_regnum][idx] ==0 )return -ENOENT ;
Reviewed-by James Clark <[email protected]>