scsi: fnic: fix missing dma mapping error in `fnic_send_frame()`
Subsystems (2)
PATCH 1/1 scsi: fnic: fix missing dma mapping error in `fnic_send_frame()`
dma_map_XXX() can fail and should be tested for errors with dma_mapping_error().
Fixes a63e78eb2b0f ("scsi: fnic: Add support for fabric based solicited requests and responses")
Signed-off-by Thomas Fourier <[email protected]>
--- drivers/scsi/fnic/fnic_fcs.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/scsi/fnic/fnic_fcs.c +2 -0
@@ -636,6 +636,8 @@ static int fnic_send_frame(struct fnic *fnic, void *frame, int frame_len)unsigned long flags; pa =dma_map_single (&fnic->pdev->dev, frame, frame_len,DMA_TO_DEVICE ); +if (dma_mapping_error (&fnic->pdev->dev, pa)) +return -ENOMEM ; if ((fnic_fc_trace_set_data(fnic->fnic_num, FNIC_FC_SEND | 0x80, (char *) frame,
Signature · 1 line
2.43.0
Quoted 24 lines · Thomas Fourier
dma_map_XXX()can fail and should be tested for errors withdma_mapping_error().Fixes a63e78eb2b0f ("scsi: fnic: Add support for fabric based solicited requests and responses")Signed-off-by Thomas Fourier <[email protected]>---
drivers/scsi/fnic/fnic_fcs.c| 2 ++1 file changed, 2 insertions(+)drivers/scsi/fnic/fnic_fcs.c +2
-1@@ -636,6 +636,8 @@ static int fnic_send_frame(struct fnic *fnic, void *frame, int frame_len)unsigned long flags; pa =dma_map_single (&fnic->pdev->dev, frame, frame_len,DMA_TO_DEVICE ); +if (dma_mapping_error (&fnic->pdev->dev, pa)) +return -ENOMEM ; if ((fnic_fc_trace_set_data(fnic->fnic_num, FNIC_FC_SEND | 0x80, (char *) frame, --
Quoted 3 lines
2.43.0
Looks good to me.
Reviewed-by Karan Tilak Kumar <[email protected]>
Regards,
Karan
Reviewed-by John Menghini <[email protected]>
Martin, can we get this merged into 6.16/scsi-fixes as well?
/John
Quoted 22 lines · Thomas Fourier
dma_map_XXX()can fail and should be tested for errors withdma_mapping_error().Fixes a63e78eb2b0f ("scsi: fnic: Add support for fabric based solicited requests and responses")Signed-off-by Thomas Fourier <[email protected]>--- drivers/scsi/fnic/fnic_fcs.c | 2 ++ 1 file changed, 2 insertions(+)drivers/scsi/fnic/fnic_fcs.c +2
-0@@ -636,6 +636,8 @@ static int fnic_send_frame(struct fnic *fnic, void *frame, int frame_len)unsigned long flags; pa =dma_map_single (&fnic->pdev->dev, frame, frame_len,DMA_TO_DEVICE ); +if (dma_mapping_error (&fnic->pdev->dev, pa)) +return -ENOMEM ; if ((fnic_fc_trace_set_data(fnic->fnic_num, FNIC_FC_SEND | 0x80, (char *) frame,
Martin K. Petersen
AppliedQuoted 4 lines · Thomas Fourier
dma_map_XXX()can fail and should be tested for errors withdma_mapping_error().
Applied to 6.16/scsi-fixes, thanks!
[1/1] scsi: fnic: fix missing dma mapping error in fnic_send_frame()
https://git.kernel.org/mkp/scsi/c/85d6fbc47c30
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering