ASoC: tegra: fix build regression 32 bit kernels
Subsystems (3)
PATCH 1/1 ASoC: tegra: fix build regression 32 bit kernels
From: Arnd Bergmann <[email protected]>
Compile-testing this driver for 32-bit causes a build failure:
x86_64-linux-ld: sound/soc/tegra/tegra210_mixer.o: in function `tegra210_mixer_configure_gain':
tegra210_mixer.c:(.text+0x709): undefined reference to `__udivdi3'
As the driver is only actually used on 64-bit Tegra210, rework the division to use the div_u64() helper that avoids the libgcc call.
--- sound/soc/tegra/tegra210_mixer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/tegra/tegra210_mixer.c +2 -2
@@ -157,8 +157,8 @@ static int tegra210_mixer_configure_gain(struct snd_soc_component *cmpnt,if (i ==DURATION_N3_ID ) val = mixer->duration[id];else if (i ==DURATION_INV_N3_ID ) - val = (u32)(BIT_ULL (31 +TEGRA210_MIXER_PRESCALAR ) / - mixer->duration[id]); + val =div_u64 (BIT_ULL (31 +TEGRA210_MIXER_PRESCALAR ), + mixer->duration[id]);else val = gain_params.duration[i]; }
Signature · 1 line
2.39.5
Quoted 9 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Compile-testing this driver for 32-bit causes a build failure:
x86_64-linux-ld:
sound/soc/tegra/tegra210_mixer.o: in function `tegra210_mixer_configure_gain':
tegra210_mixer.c:(.text+0x709): undefined reference to `__udivdi3'As the driver is only actually used on 64-bit Tegra210, rework the division to use the
div_u64()helper that avoids the libgcc call.
To be pedantic: the driver is also used on subsequent generations, but your argument of it only ever being used on 64-bit systems is correct, so:
Mark Brown
maintainerQuoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Compile-testing this driver for 32-bit causes a build failure:
x86_64-linux-ld:
sound/soc/tegra/tegra210_mixer.o: in function `tegra210_mixer_configure_gain':
tegra210_mixer.c:(.text+0x709): undefined reference to `__udivdi3'
Someone already sent this.
Quoted 9 lines · Mark Brown
Quoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Compile-testing this driver for 32-bit causes a build failure:
x86_64-linux-ld:
sound/soc/tegra/tegra210_mixer.o: in function `tegra210_mixer_configure_gain':
tegra210_mixer.c:(.text+0x709): undefined reference to `__udivdi3'Someone already sent this.
Indeed. Acked that one too.
Thierry