Skip to contentSkip to conversation

rockchip: puma-rk3399/ringneck-px30: make closer to Jaguar/Tiger defconfigs

PATCH In review Quentin Schulz 2 participants 5 messages Jun 12, 2024 – Jun 14, 2024

lore
Share & tools
lore
#0 lore raw

cover rockchip: puma-rk3399/ringneck-px30: make closer to Jaguar/Tiger defconfigs

To ease maintenance, limit test scenarios and variations, let's enable a few things:
- full bootstd
- a handful of CLI commands like gpio, squashfs, erofs, pmic, regulator, and the likes.

This also disables support for non-Linux OSes as Linux is the primary target, we may revisit this in the future if necessary.

Also disables support for zImage on Puma since those aren't supported on Aarch64, one is supposed to use Image.gz (or any other supported compression format) with booti instead.

---
Quentin Schulz (2):
rockchip: ringneck-px30: get closer to other Theobroma defconfigs
rockchip: puma-rk3399: get closer to other Theobroma defconfigs

 configs/puma-rk3399_defconfig   |  9 ++++++++-
 configs/ringneck-px30_defconfig | 16 +++++++++++-----
 2 files changed, 19 insertions(+), 6 deletions(-)

---
base-commit: 787eaa9c8df2660c748358eb689de916f991e22e
change-id: 20240612-ringneck-bootd-ea9126a0e108

Best regards,

Signature · 1 line
Quentin Schulz <[email protected]>
#1 lore raw

PATCH 1/2 rockchip: ringneck-px30: get closer to other Theobroma defconfigs

From: Quentin Schulz <[email protected]>

RK3588 Jaguar and Tiger, and RK3399 Puma use standard boot with the full feature set, so let's do that as well for PX30 Ringneck.

Disable support for unused OSes as Linux is the primary target.

Enable a bunch of commands:
- boot/bootd
- erofs
- gpio
- iminfo
- imxtract
- itest
- pmic
- regulator
- sleep
- squashfs

that could be useful and are also found in Jaguar and Tiger defconfigs.

---
 configs/ringneck-px30_defconfig | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)
configs/ringneck-px30_defconfig +11 -5
index dedf35d4347..a0c1fec0951 100644
@@ -20,6 +20,7 @@ CONFIG_DEBUG_UART=y
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_SPL_LOAD_FIT=y
+CONFIG_BOOTSTD_FULL=y
 CONFIG_DEFAULT_FDT_FILE="rockchip/px30-ringneck-haikou.dtb"
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
@@ -34,12 +35,15 @@ CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x200
 CONFIG_SPL_ATF=y
 # CONFIG_TPL_FRAMEWORK is not set
 # CONFIG_TPL_SYS_MALLOC_SIMPLE is not set
-# CONFIG_CMD_BOOTD is not set
+# CONFIG_BOOTM_NETBSD is not set
+# CONFIG_BOOTM_PLAN9 is not set
+# CONFIG_BOOTM_RTEMS is not set
+# CONFIG_CMD_VBE is not set
+# CONFIG_BOOTM_VXWORKS is not set
 # CONFIG_CMD_ELF is not set
-# CONFIG_CMD_IMI is not set
-# CONFIG_CMD_XIMG is not set
 # CONFIG_CMD_LZMADEC is not set
 # CONFIG_CMD_UNZIP is not set
+CONFIG_CMD_GPIO=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_I2C=y
 # CONFIG_CMD_LOADB is not set
@@ -47,9 +51,11 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
 CONFIG_CMD_USB_MASS_STORAGE=y
-# CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_SLEEP is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
+CONFIG_CMD_EROFS=y
+CONFIG_CMD_SQUASHFS=y
 # CONFIG_SPL_DOS_PARTITION is not set
 # CONFIG_ISO_PARTITION is not set
 CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64
Signature · 1 line
2.45.2
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] rockchip: ringneck-px30: get closer to other Theobroma defconfigs

Quoted 19 lines · Quentin Schulz

From: Quentin Schulz <[email protected]>

RK3588 Jaguar and Tiger, and RK3399 Puma use standard boot with the full feature set, so let's do that as well for PX30 Ringneck.

Disable support for unused OSes as Linux is the primary target.

Enable a bunch of commands:
- boot/bootd
- erofs
- gpio
- iminfo
- imxtract
- itest
- pmic
- regulator
- sleep
- squashfs

Quoted 3 lines

that could be useful and are also found in Jaguar and Tiger defconfigs.

Thanks,
- Kever

Quoted 50 lines
---
  configs/ringneck-px30_defconfig | 16 +++++++++++-----
  1 file changed, 11 insertions(+), 5 deletions(-)
configs/ringneck-px30_defconfig +11 -5
index dedf35d4347..a0c1fec0951 100644
@@ -20,6 +20,7 @@ CONFIG_DEBUG_UART=y
  CONFIG_FIT=y
  CONFIG_FIT_VERBOSE=y
  CONFIG_SPL_LOAD_FIT=y
+CONFIG_BOOTSTD_FULL=y
  CONFIG_DEFAULT_FDT_FILE="rockchip/px30-ringneck-haikou.dtb"
  # CONFIG_DISPLAY_CPUINFO is not set
  CONFIG_DISPLAY_BOARDINFO_LATE=y
@@ -34,12 +35,15 @@ CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x200
  CONFIG_SPL_ATF=y
  # CONFIG_TPL_FRAMEWORK is not set
  # CONFIG_TPL_SYS_MALLOC_SIMPLE is not set
-# CONFIG_CMD_BOOTD is not set
+# CONFIG_BOOTM_NETBSD is not set
+# CONFIG_BOOTM_PLAN9 is not set
+# CONFIG_BOOTM_RTEMS is not set
+# CONFIG_CMD_VBE is not set
+# CONFIG_BOOTM_VXWORKS is not set
  # CONFIG_CMD_ELF is not set
-# CONFIG_CMD_IMI is not set
-# CONFIG_CMD_XIMG is not set
  # CONFIG_CMD_LZMADEC is not set
  # CONFIG_CMD_UNZIP is not set
+CONFIG_CMD_GPIO=y
  CONFIG_CMD_GPT=y
  CONFIG_CMD_I2C=y
  # CONFIG_CMD_LOADB is not set
@@ -47,9 +51,11 @@ CONFIG_CMD_I2C=y
  CONFIG_CMD_MMC=y
  CONFIG_CMD_USB=y
  CONFIG_CMD_USB_MASS_STORAGE=y
-# CONFIG_CMD_ITEST is not set
  # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_SLEEP is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
+CONFIG_CMD_EROFS=y
+CONFIG_CMD_SQUASHFS=y
  # CONFIG_SPL_DOS_PARTITION is not set
  # CONFIG_ISO_PARTITION is not set
  CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64
#3 lore raw

PATCH 2/2 rockchip: puma-rk3399: get closer to other Theobroma defconfigs

In reply to Quentin Schulz

From: Quentin Schulz <[email protected]>

Disable support for unused OSes as Linux is the primary target.

Disable support for bootz as zImage isn't a format compatible with Aarch64 machines so it should never be attempted to be booted.

Enable a bunch of commands:
- erofs
- gpio
- squashfs

that could be useful and are also found in Jaguar and Tiger defconfigs.

---
 configs/puma-rk3399_defconfig | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
configs/puma-rk3399_defconfig +8 -1
index 34a0b575991..3196b5e24b1 100644
@@ -29,7 +29,12 @@ CONFIG_SPL_I2C=y
 CONFIG_SPL_POWER=y
 CONFIG_SPL_SPI_LOAD=y
 CONFIG_TPL=y
-CONFIG_CMD_BOOTZ=y
+# CONFIG_BOOTM_NETBSD is not set
+# CONFIG_BOOTM_PLAN9 is not set
+# CONFIG_BOOTM_RTEMS is not set
+# CONFIG_CMD_VBE is not set
+# CONFIG_BOOTM_VXWORKS is not set
+CONFIG_CMD_GPIO=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
@@ -41,6 +46,8 @@ CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y
 CONFIG_CMD_PMIC=y
 CONFIG_CMD_REGULATOR=y
+CONFIG_CMD_EROFS=y
+CONFIG_CMD_SQUASHFS=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_SPL_REMOVE_PROPS="interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
 CONFIG_ENV_OVERWRITE=y
Signature · 1 line
2.45.2
Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] rockchip: puma-rk3399: get closer to other Theobroma defconfigs

Quoted 7 lines · Quentin Schulz

From: Quentin Schulz <[email protected]>

Disable support for unused OSes as Linux is the primary target.

Disable support for bootz as zImage isn't a format compatible with Aarch64 machines so it should never be attempted to be booted.

Quoted 8 lines

Enable a bunch of commands:
- erofs
- gpio
- squashfs

that could be useful and are also found in Jaguar and Tiger defconfigs.

Thanks,
- Kever

Quoted 32 lines
---
  configs/puma-rk3399_defconfig | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)
configs/puma-rk3399_defconfig +8 -1
index 34a0b575991..3196b5e24b1 100644
@@ -29,7 +29,12 @@ CONFIG_SPL_I2C=y
  CONFIG_SPL_POWER=y
  CONFIG_SPL_SPI_LOAD=y
  CONFIG_TPL=y
-CONFIG_CMD_BOOTZ=y
+# CONFIG_BOOTM_NETBSD is not set
+# CONFIG_BOOTM_PLAN9 is not set
+# CONFIG_BOOTM_RTEMS is not set
+# CONFIG_CMD_VBE is not set
+# CONFIG_BOOTM_VXWORKS is not set
+CONFIG_CMD_GPIO=y
  CONFIG_CMD_GPT=y
  CONFIG_CMD_I2C=y
  CONFIG_CMD_MMC=y
@@ -41,6 +46,8 @@ CONFIG_CMD_CACHE=y
  CONFIG_CMD_TIME=y
  CONFIG_CMD_PMIC=y
  CONFIG_CMD_REGULATOR=y
+CONFIG_CMD_EROFS=y
+CONFIG_CMD_SQUASHFS=y
  CONFIG_SPL_OF_CONTROL=y
  CONFIG_OF_SPL_REMOVE_PROPS="interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
  CONFIG_ENV_OVERWRITE=y