bitfield: add FIELD_GET_SIGNED()
Subsystems (9)
v2 cover bitfield: add FIELD_GET_SIGNED()
The bitfields are designed in assumption that fields contain unsigned integer values, thus extracting the values from the field implies zero-extending.
Some drivers need to sign-extend their fields, and currently do it like:
dc_re += sign_extend32(FIELD_GET(0xfff000, tmp), 11); dc_im += sign_extend32(FIELD_GET(0xfff, tmp), 11);
It's error-prone because it relies on user to provide the correct index of the most significant bit and proper 32 vs 64 function flavor.
Thus, introduce a FIELD_GET_SIGNED(). With the new API, the above snippet turns into the more convenient:
dc_re += FIELD_GET_SIGNED(0xfff000, tmp); dc_im += FIELD_GET_SIGNED(0xfff, tmp);
It compiles (on x86_64) into just a couple instructions: shl and sar. When the mask includes MSB, the '<< __builtin_clzll(mask)' part becomes a NOP, and the compiler only emits a single sar:
long long foo(long long reg)
{
10: f3 0f 1e fa endbr64
return FIELD_GET_SIGNED(GENMASK_ULL(63, 60), reg);
14: 48 89 f8 mov %rdi,%rax
17: 48 c1 f8 3c sar $0x3c,%rax
}32-bit code generation is equally well. On arm32:
long long foo(long long reg)
{
return FIELD_GET_SIGNED(0x00f00000ULL, reg);
}generates:
foo(long long):
lsls r1, r0, #8
asrs r0, r1, #28
asrs r1, r1, #31
bx lrImmutable branch:
https://github.com/norov/linux/pull/new/fgsv2
v1: https://lore.kernel.org/all/[email protected]/
v2:
- more examples of the new API and code generation (Andy, David);
- fix #7 FIELD_GET() / FIELD_GET_SIGNED() typo (Ping-Ke);
- re-indent the macro (Andy, Peter);
Yury Norov (9):
bitfield: add FIELD_GET_SIGNED()
x86/extable: switch to using FIELD_GET_SIGNED()
iio: intel_dc_ti_adc: switch to using FIELD_GET_SIGNED()
iio: magnetometer: yas530: switch to using FIELD_GET_SIGNED()
iio: pressure: bmp280: switch to using FIELD_GET_SIGNED()
iio: mcp9600: switch to using FIELD_GET_SIGNED()
wifi: rtw89: switch to using FIELD_GET_SIGNED()
rtc: rv3032: switch to using FIELD_GET_SIGNED()
ptp: switch to using FIELD_GET_SIGNED()
arch/x86/include/asm/extable_fixup_types.h | 13 ++++--------- arch/x86/mm/extable.c | 2 +- drivers/iio/adc/intel_dc_ti_adc.c | 4 ++-- drivers/iio/magnetometer/yamaha-yas530.c | 12 ++++++------ drivers/iio/pressure/bmp280-core.c | 2 +- drivers/iio/temperature/mcp9600.c | 2 +- .../net/wireless/realtek/rtw89/rtw8852a_rfk.c | 4 ++-- .../net/wireless/realtek/rtw89/rtw8852b_common.c | 4 ++-- .../net/wireless/realtek/rtw89/rtw8852b_rfk.c | 4 ++-- drivers/net/wireless/realtek/rtw89/rtw8852c.c | 4 ++-- drivers/ptp/ptp_fc3.c | 4 ++-- drivers/rtc/rtc-rv3032.c | 2 +- include/linux/bitfield.h | 16 ++++++++++++++++ 13 files changed, 42 insertions(+), 31 deletions(-)
Signature · 1 line
2.51.0
PATCH v2 1/9 bitfield: add FIELD_GET_SIGNED()
The bitfields are designed in assumption that fields contain unsigned integer values, thus extracting the values from the field implies zero-extending.
Some drivers need to sign-extend their fields, and currently do it like:
dc_re += sign_extend32(FIELD_GET(0xfff000, tmp), 11); dc_im += sign_extend32(FIELD_GET(0xfff, tmp), 11);
It's error-prone because it relies on user to provide the correct index of the most significant bit and proper 32 vs 64 function flavor.
Thus, introduce a FIELD_GET_SIGNED(). With the new API, the above snippet turns into the more convenient:
dc_re += FIELD_GET_SIGNED(0xfff000, tmp); dc_im += FIELD_GET_SIGNED(0xfff, tmp);
It compiles (on x86_64) into just a couple instructions: shl and sar. When the mask includes MSB, the '<< __builtin_clzll(mask)' part becomes a NOP, and the compiler only emits a single sar:
long long foo(long long reg)
{
10: f3 0f 1e fa endbr64
return FIELD_GET_SIGNED(GENMASK_ULL(63, 60), reg);
14: 48 89 f8 mov %rdi,%rax
17: 48 c1 f8 3c sar $0x3c,%rax
}32-bit code generation is equally well. On arm32:
long long foo(long long reg)
{
return FIELD_GET_SIGNED(0x00f00000ULL, reg);
}generates:
foo(long long):
lsls r1, r0, #8
asrs r0, r1, #28
asrs r1, r1, #31
bx lr--- include/linux/bitfield.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
include/linux/bitfield.h +16 -0
@@ -178,6 +178,22 @@__FIELD_GET (_mask, _reg,"FIELD_GET: " ); \ }) +/** +* FIELD_GET_SIGNED() - extract a signed bitfield element +* @mask: shifted mask defining the field's length and position +* @reg: value of entire bitfield +* +* Returns the sign-extended field specified by @_mask from the +* bitfield passed in as @_reg by masking and shifting it down. +*/ +#define FIELD_GET_SIGNED (mask, reg) \ + ({ \ + __BF_FIELD_CHECK(mask, reg, 0U, "FIELD_GET_SIGNED: "); \ + ((__signed_scalar_typeof(mask)) \ + (((long long)(reg) << __builtin_clzll(mask)) >> \ + (__builtin_clzll(mask) + __builtin_ctzll(mask)))); \ + }) +/** * FIELD_MODIFY() - modify a bitfield element * @_mask: shifted mask defining the field's length and position
Signature · 1 line
2.51.0
PATCH v2 2/9 x86/extable: switch to using FIELD_GET_SIGNED()
In reply to Yury NorovThe EX_DATA register is laid out such that EX_DATA_IMM occupied MSB. It's done to make sure that FIELD_GET() will sign-extend the IMM field during extraction.
To enforce that, all EX_DATA masks are made signed integers. This works, but relies on the particular implementation of FIELD_GET(), i.e. masking then shifting, not vice versa; and the particular placement of the fields in the register.
Switch to using the dedicated FIELD_GET_SIGNED(), and relax those limitations.
--- arch/x86/include/asm/extable_fixup_types.h | 13 ++++--------- arch/x86/mm/extable.c | 2 +- 2 files changed, 5 insertions(+), 10 deletions(-)
arch/x86/include/asm/extable_fixup_types.h +4 -9
@@ -2,15 +2,10 @@#ifndef _ASM_X86_EXTABLE_FIXUP_TYPES_H#define _ASM_X86_EXTABLE_FIXUP_TYPES_H -/* -* Our IMM is signed, as such it must live at the top end of the word. Also, -* since C99 hex constants are of ambiguous type, force cast the mask to 'int' -* so that FIELD_GET() will DTRT and sign extend the value when it extracts it. -*/ -#define EX_DATA_TYPE_MASK ((int)0x000000FF) -#define EX_DATA_REG_MASK ((int)0x00000F00) -#define EX_DATA_FLAG_MASK ((int)0x0000F000) -#define EX_DATA_IMM_MASK ((int)0xFFFF0000) +#define EX_DATA_TYPE_MASK (0x000000FF) +#define EX_DATA_REG_MASK (0x00000F00) +#define EX_DATA_FLAG_MASK (0x0000F000) +#define EX_DATA_IMM_MASK (0xFFFF0000)#define EX_DATA_REG_SHIFT 8#define EX_DATA_FLAG_SHIFT 12
arch/x86/mm/extable.c +1 -1
@@ -322,7 +322,7 @@ int fixup_exception(struct pt_regs *regs, int trapnr, unsigned long error_code, type =FIELD_GET (EX_DATA_TYPE_MASK , e->data); reg =FIELD_GET (EX_DATA_REG_MASK , e->data); - imm =FIELD_GET (EX_DATA_IMM_MASK , e->data); + imm =FIELD_GET_SIGNED (EX_DATA_IMM_MASK , e->data);switch (type) {case EX_TYPE_DEFAULT :
Signature · 1 line
2.51.0
Re: [PATCH v2 2/9] x86/extable: switch to using FIELD_GET_SIGNED()
Quoted 9 lines · Yury Norov
The
EX_DATAregister is laid out such thatEX_DATA_IMMoccupied MSB. It's done to make sure thatFIELD_GET()will sign-extend the IMM field during extraction.To enforce that, all
EX_DATAmasks are made signed integers. This works, but relies on the particular implementation ofFIELD_GET(), i.e. masking then shifting, not vice versa; and the particular placement of the fields in the register.
Quoted 4 lines
Switch to using the dedicated
FIELD_GET_SIGNED(), and relax those limitations.Signed-off-by Yury Norov <[email protected]>
Quoted 45 lines
--- arch/x86/include/asm/extable_fixup_types.h | 13 ++++--------- arch/x86/mm/extable.c | 2 +- 2 files changed, 5 insertions(+), 10 deletions(-)arch/x86/include/asm/extable_fixup_types.h +4
-9@@ -2,15 +2,10 @@#ifndef _ASM_X86_EXTABLE_FIXUP_TYPES_H#define _ASM_X86_EXTABLE_FIXUP_TYPES_H -/* -* Our IMM is signed, as such it must live at the top end of the word. Also, -* since C99 hex constants are of ambiguous type, force cast the mask to 'int' -* so that FIELD_GET() will DTRT and sign extend the value when it extracts it. -*/ -#define EX_DATA_TYPE_MASK ((int)0x000000FF) -#define EX_DATA_REG_MASK ((int)0x00000F00) -#define EX_DATA_FLAG_MASK ((int)0x0000F000) -#define EX_DATA_IMM_MASK ((int)0xFFFF0000) +#define EX_DATA_TYPE_MASK (0x000000FF) +#define EX_DATA_REG_MASK (0x00000F00) +#define EX_DATA_FLAG_MASK (0x0000F000) +#define EX_DATA_IMM_MASK (0xFFFF0000)#define EX_DATA_REG_SHIFT 8#define EX_DATA_FLAG_SHIFT 12arch/x86/mm/extable.c +1
-1@@ -322,7 +322,7 @@ int fixup_exception(struct pt_regs *regs, int trapnr, unsigned long error_code, type =FIELD_GET (EX_DATA_TYPE_MASK , e->data); reg =FIELD_GET (EX_DATA_REG_MASK , e->data); - imm =FIELD_GET (EX_DATA_IMM_MASK , e->data); + imm =FIELD_GET_SIGNED (EX_DATA_IMM_MASK , e->data);switch (type) {case EX_TYPE_DEFAULT :Signature · 1 line
2.51.0
Re: [PATCH v2 2/9] x86/extable: switch to using FIELD_GET_SIGNED()
Quoted 10 lines · Peter Zijlstra
Quoted 9 lines · Yury Norov
The
EX_DATAregister is laid out such thatEX_DATA_IMMoccupied MSB. It's done to make sure thatFIELD_GET()will sign-extend the IMM field during extraction.To enforce that, all
EX_DATAmasks are made signed integers. This works, but relies on the particular implementation ofFIELD_GET(), i.e. masking then shifting, not vice versa; and the particular placement of the fields in the register.
Quoted 6 lines
Quoted 4 lines
Switch to using the dedicated
FIELD_GET_SIGNED(), and relax those limitations.Signed-off-by Yury Norov <[email protected]>
Alright, thanks Peter and everyone. Now that all the patches except #9 are reviewed, I'm taking the series into bitmap-for-next.
Thanks,
Yury
PATCH v2 3/9 iio: intel_dc_ti_adc: switch to using FIELD_GET_SIGNED()
In reply to Yury NorovSwitch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't provide the fields length explicitly.
--- drivers/iio/adc/intel_dc_ti_adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/intel_dc_ti_adc.c +2 -2
@@ -290,8 +290,8 @@ static int dc_ti_adc_probe(struct platform_device *pdev)if (ret)return ret; - info->vbat_zse =sign_extend32 (FIELD_GET (DC_TI_VBAT_ZSE , val),3 ); - info->vbat_ge =sign_extend32 (FIELD_GET (DC_TI_VBAT_GE , val),3 ); + info->vbat_zse =FIELD_GET_SIGNED (DC_TI_VBAT_ZSE , val); + info->vbat_ge =FIELD_GET_SIGNED (DC_TI_VBAT_GE , val);dev_dbg (dev,"vbat-zse %d vbat-ge %d\n" , info->vbat_zse, info->vbat_ge);
Signature · 1 line
2.51.0
PATCH v2 4/9 iio: magnetometer: yas530: switch to using FIELD_GET_SIGNED()
In reply to Yury NorovSwitch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly.
--- drivers/iio/magnetometer/yamaha-yas530.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/iio/magnetometer/yamaha-yas530.c +6 -6
@@ -859,9 +859,9 @@ static int yas530_get_calibration_data(struct yas5xx *yas5xx) c->f[0 ] =FIELD_GET (GENMASK (22 ,21 ), val); c->f[1 ] =FIELD_GET (GENMASK (14 ,13 ), val); c->f[2 ] =FIELD_GET (GENMASK (6 ,5 ), val); - c->r[0 ] =sign_extend32 (FIELD_GET (GENMASK (28 ,23 ), val),5 ); - c->r[1 ] =sign_extend32 (FIELD_GET (GENMASK (20 ,15 ), val),5 ); - c->r[2 ] =sign_extend32 (FIELD_GET (GENMASK (12 ,7 ), val),5 ); + c->r[0 ] =FIELD_GET_SIGNED (GENMASK (28 ,23 ), val); + c->r[1 ] =FIELD_GET_SIGNED (GENMASK (20 ,15 ), val); + c->r[2 ] =FIELD_GET_SIGNED (GENMASK (12 ,7 ), val);return 0 ; }
@@ -914,9 +914,9 @@ static int yas532_get_calibration_data(struct yas5xx *yas5xx) c->f[0 ] =FIELD_GET (GENMASK (24 ,23 ), val); c->f[1 ] =FIELD_GET (GENMASK (16 ,15 ), val); c->f[2 ] =FIELD_GET (GENMASK (8 ,7 ), val); - c->r[0 ] =sign_extend32 (FIELD_GET (GENMASK (30 ,25 ), val),5 ); - c->r[1 ] =sign_extend32 (FIELD_GET (GENMASK (22 ,17 ), val),5 ); - c->r[2 ] =sign_extend32 (FIELD_GET (GENMASK (14 ,7 ), val),5 ); + c->r[0 ] =FIELD_GET_SIGNED (GENMASK (30 ,25 ), val); + c->r[1 ] =FIELD_GET_SIGNED (GENMASK (22 ,17 ), val); + c->r[2 ] =FIELD_GET_SIGNED (GENMASK (14 ,7 ), val);return 0 ; }
Signature · 1 line
2.51.0
PATCH v2 5/9 iio: pressure: bmp280: switch to using FIELD_GET_SIGNED()
In reply to Yury NorovSwitch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly.
--- drivers/iio/pressure/bmp280-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/pressure/bmp280-core.c +1 -1
@@ -392,7 +392,7 @@ static int bme280_read_calib(struct bmp280_data *data) h4_lower =FIELD_GET (BME280_COMP_H4_MASK_LOW , tmp_1); calib->H4 =sign_extend32 (h4_upper | h4_lower,11 ); tmp_3 =get_unaligned_le16 (&data->bme280_humid_cal_buf[H5 ]); - calib->H5 =sign_extend32 (FIELD_GET (BME280_COMP_H5_MASK , tmp_3),11 ); + calib->H5 =FIELD_GET_SIGNED (BME280_COMP_H5_MASK , tmp_3); calib->H6 = data->bme280_humid_cal_buf[H6 ];return 0 ;
Signature · 1 line
2.51.0
PATCH v2 6/9 iio: mcp9600: switch to using FIELD_GET_SIGNED()
In reply to Yury NorovSwitch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly.
--- drivers/iio/temperature/mcp9600.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/temperature/mcp9600.c +1 -1
@@ -297,7 +297,7 @@ static int mcp9600_read_thresh(struct iio_dev *indio_dev,* Temperature is stored in two’s complement format in * bits(15:2), LSB is 0.25 degree celsius. */ - *val =sign_extend32 (FIELD_GET (MCP9600_ALERT_LIMIT_MASK , ret),13 ); + *val =FIELD_GET_SIGNED (MCP9600_ALERT_LIMIT_MASK , ret); *val2 =4 ;return IIO_VAL_FRACTIONAL ;case IIO_EV_INFO_HYSTERESIS :
Signature · 1 line
2.51.0
PATCH v2 7/9 wifi: rtw89: switch to using FIELD_GET_SIGNED()
In reply to Yury NorovSwitch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly.
--- drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c | 4 ++-- drivers/net/wireless/realtek/rtw89/rtw8852b_common.c | 4 ++-- drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c | 4 ++-- drivers/net/wireless/realtek/rtw89/rtw8852c.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-)
drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c +2 -2
@@ -334,8 +334,8 @@ static void _check_addc(struct rtw89_dev *rtwdev, enum rtw89_rf_path path)for (i =0 ; i <ADDC_T_AVG ; i++) { tmp =rtw89_phy_read32_mask (rtwdev,R_DBG32_D ,MASKDWORD ); - dc_re +=sign_extend32 (FIELD_GET (0xfff000 , tmp),11 ); - dc_im +=sign_extend32 (FIELD_GET (0xfff , tmp),11 ); + dc_re +=FIELD_GET_SIGNED (0xfff000 , tmp); + dc_im +=FIELD_GET_SIGNED (0xfff , tmp); } dc_re /=ADDC_T_AVG ;
drivers/net/wireless/realtek/rtw89/rtw8852b_common.c +2 -2
@@ -206,9 +206,9 @@ static void rtw8852bx_efuse_parsing_tssi(struct rtw89_dev *rtwdev,static bool _decode_efuse_gain (u8 data,s8 *high,s8 *low) {if (high) - *high =sign_extend32 (FIELD_GET (GENMASK (7 ,4 ), data),3 ); + *high =FIELD_GET_SIGNED (GENMASK (7 ,4 ), data);if (low) - *low =sign_extend32 (FIELD_GET (GENMASK (3 ,0 ), data),3 ); + *low =FIELD_GET_SIGNED (GENMASK (3 ,0 ), data);return data !=0xff ; }
drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c +2 -2
@@ -497,8 +497,8 @@ static void _check_addc(struct rtw89_dev *rtwdev, enum rtw89_rf_path path)for (i =0 ; i <ADDC_T_AVG ; i++) { tmp =rtw89_phy_read32_mask (rtwdev,R_DBG32_D ,MASKDWORD ); - dc_re +=sign_extend32 (FIELD_GET (0xfff000 , tmp),11 ); - dc_im +=sign_extend32 (FIELD_GET (0xfff , tmp),11 ); + dc_re +=FIELD_GET_SIGNED (0xfff000 , tmp); + dc_im +=FIELD_GET_SIGNED (0xfff , tmp); } dc_re /=ADDC_T_AVG ;
drivers/net/wireless/realtek/rtw89/rtw8852c.c +2 -2
@@ -517,9 +517,9 @@ static void rtw8852c_efuse_parsing_tssi(struct rtw89_dev *rtwdev,static bool _decode_efuse_gain (u8 data,s8 *high,s8 *low) {if (high) - *high =sign_extend32 (FIELD_GET (GENMASK (7 ,4 ), data),3 ); + *high =FIELD_GET_SIGNED (GENMASK (7 ,4 ), data);if (low) - *low =sign_extend32 (FIELD_GET (GENMASK (3 ,0 ), data),3 ); + *low =FIELD_GET_SIGNED (GENMASK (3 ,0 ), data);return data !=0xff ; }
Signature · 1 line
2.51.0
Re: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED()
Quoted 2 lines · Yury Norov
Switch from sign_extend32(FIELD_GET()) to the dedicated
FIELD_GET_SIGNED()and don't calculate the fields length explicitly.
...
drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c static void _check_addc(struct rtw89_dev *rtwdev, enum rtw89_rf_path path) · line 338
Quoted 6 lines
drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c +2
-2for (i =0 ; i <ADDC_T_AVG ; i++) { tmp =rtw89_phy_read32_mask (rtwdev,R_DBG32_D ,MASKDWORD ); - dc_re +=sign_extend32 (FIELD_GET (0xfff000 , tmp),11 ); - dc_im +=sign_extend32 (FIELD_GET (0xfff , tmp),11 ); + dc_re +=FIELD_GET_SIGNED (0xfff000 , tmp); + dc_im +=FIELD_GET_SIGNED (0xfff , tmp);
In the same driver the GENMASK() is being used, why not doing it here while at it?
Quoted 1 line
}
...
drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c static void _check_addc(struct rtw89_dev *rtwdev, enum rtw89_rf_path path) · line 339
Quoted 7 lines
drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c +2
-2for (i =0 ; i <ADDC_T_AVG ; i++) { tmp =rtw89_phy_read32_mask (rtwdev,R_DBG32_D ,MASKDWORD ); - dc_re +=sign_extend32 (FIELD_GET (0xfff000 , tmp),11 ); - dc_im +=sign_extend32 (FIELD_GET (0xfff , tmp),11 ); + dc_re +=FIELD_GET_SIGNED (0xfff000 , tmp); + dc_im +=FIELD_GET_SIGNED (0xfff , tmp); }
Ditto, and it even looks like the same piece repeating twice in different compilation units of the same driver...
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED()
Quoted 6 lines · On Tue, 28 Apr 2026 10:10:22 +0300 Andy Shevchenko…
Quoted 2 lines · Yury Norov
Switch from sign_extend32(FIELD_GET()) to the dedicated
FIELD_GET_SIGNED()and don't calculate the fields length explicitly....
Quoted 8 lines
drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c static void _check_addc(struct rtw89_dev *rtwdev, enum rtw89_rf_path path) · line 338
Quoted 6 lines
drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c +2
-2for (i =0 ; i <ADDC_T_AVG ; i++) { tmp =rtw89_phy_read32_mask (rtwdev,R_DBG32_D ,MASKDWORD ); - dc_re +=sign_extend32 (FIELD_GET (0xfff000 , tmp),11 ); - dc_im +=sign_extend32 (FIELD_GET (0xfff , tmp),11 ); + dc_re +=FIELD_GET_SIGNED (0xfff000 , tmp); + dc_im +=FIELD_GET_SIGNED (0xfff , tmp);In the same driver the
GENMASK()is being used, why not doing it here while at it?
To me those bit masks look more readable than the GENMASK() calls would be.
David
Quoted 16 lines
Quoted 2 lines
}
...
drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c static void _check_addc(struct rtw89_dev *rtwdev, enum rtw89_rf_path path) · line 339
Quoted 7 lines
drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c +2
-2for (i =0 ; i <ADDC_T_AVG ; i++) { tmp =rtw89_phy_read32_mask (rtwdev,R_DBG32_D ,MASKDWORD ); - dc_re +=sign_extend32 (FIELD_GET (0xfff000 , tmp),11 ); - dc_im +=sign_extend32 (FIELD_GET (0xfff , tmp),11 ); + dc_re +=FIELD_GET_SIGNED (0xfff000 , tmp); + dc_im +=FIELD_GET_SIGNED (0xfff , tmp); }Ditto, and it even looks like the same piece repeating twice in different compilation units of the same driver...
Ping-Ke Shih
maintainerRE: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED()
Quoted 17 lines · David Laight
Quoted 13 lines · On Tue, 28 Apr 2026 10:10:22 +0300 Andy Shevchenko…
Quoted 2 lines · Yury Norov
Switch from sign_extend32(FIELD_GET()) to the dedicated
FIELD_GET_SIGNED()and don't calculate the fields length explicitly....
Quoted 6 lines
for (i = 0; i < ADDC_T_AVG; i++) { tmp = rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD);drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c +2
-2- dc_re +=sign_extend32 (FIELD_GET (0xfff000 , tmp),11 ); - dc_im +=sign_extend32 (FIELD_GET (0xfff , tmp),11 ); + dc_re +=FIELD_GET_SIGNED (0xfff000 , tmp); + dc_im +=FIELD_GET_SIGNED (0xfff , tmp);
Quoted 3 lines
Quoted 1 line
In the same driver the
GENMASK()is being used, why not doing it here while at it?To me those bit masks look more readable than the
GENMASK()calls would be.
Either way is fine to me. As we rewrite these into rtw89, using GENMASK() can be easier to check if vendor driver defines the masks correctly, no overlap.
Ping-Ke
RE: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED()
In reply to Yury NorovQuoted 4 lines · Yury Norov
Switch from sign_extend32(FIELD_GET()) to the dedicated
FIELD_GET_SIGNED()and don't calculate the fields length explicitly.Signed-off-by Yury Norov <[email protected]>
PATCH v2 8/9 rtc: rv3032: switch to using FIELD_GET_SIGNED()
In reply to Yury NorovSwitch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly.
--- drivers/rtc/rtc-rv3032.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-rv3032.c +1 -1
@@ -376,7 +376,7 @@ static int rv3032_read_offset(struct device *dev, long *offset)if (ret <0 )return ret; - steps =sign_extend32 (FIELD_GET (RV3032_OFFSET_MSK , value),5 ); + steps =FIELD_GET_SIGNED (RV3032_OFFSET_MSK , value); *offset =DIV_ROUND_CLOSEST (steps *OFFSET_STEP_PPT ,1000 );
Signature · 1 line
2.51.0
Re: [PATCH v2 8/9] rtc: rv3032: switch to using FIELD_GET_SIGNED()
Quoted 4 lines · Yury Norov
Switch from sign_extend32(FIELD_GET()) to the dedicated
FIELD_GET_SIGNED()and don't calculate the fields length explicitly.Signed-off-by Yury Norov <[email protected]>
Quoted 20 lines
--- drivers/rtc/rtc-rv3032.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/rtc/rtc-rv3032.c +1
-1@@ -376,7 +376,7 @@ static int rv3032_read_offset(struct device *dev, long *offset)if (ret <0 )return ret; - steps =sign_extend32 (FIELD_GET (RV3032_OFFSET_MSK , value),5 ); + steps =FIELD_GET_SIGNED (RV3032_OFFSET_MSK , value); *offset =DIV_ROUND_CLOSEST (steps *OFFSET_STEP_PPT ,1000 );Signature · 1 line
2.51.0
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 9/9 ptp: switch to using FIELD_GET_SIGNED()
In reply to Yury NorovSwitch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly.
--- drivers/ptp/ptp_fc3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ptp/ptp_fc3.c +2 -2
@@ -55,8 +55,8 @@ static s64 tdc_meas2offset(struct idtfc3 *idtfc3, u64 meas_read) {s64 coarse, fine; - fine =sign_extend64 (FIELD_GET (FINE_MEAS_MASK , meas_read),12 ); - coarse =sign_extend64 (FIELD_GET (COARSE_MEAS_MASK , meas_read), (39 -13 )); + fine =FIELD_GET_SIGNED (FINE_MEAS_MASK , meas_read); + coarse =FIELD_GET_SIGNED (COARSE_MEAS_MASK , meas_read); fine =div64_s64 (fine *NSEC_PER_SEC , idtfc3->tdc_apll_freq *62LL ); coarse =div64_s64 (coarse *NSEC_PER_SEC , idtfc3->time_ref_freq);
Signature · 1 line
2.51.0