selftests: fix timestamping Makefile
Subsystems (3)
PATCH 1/1 selftests: fix timestamping Makefile
The clean target in the makefile conflicts with the generic kselftests lib.mk, and fails to properly remove the compiled test programs.
Remove the redundant rule, the TEST_GEN_FILES will be already removed by the CLEAN macro in lib.mk.
---
* Changes since v1: as per review comments
tools/testing/selftests/networking/timestamping/Makefile | 3 --- 1 file changed, 3 deletions(-)
tools/testing/selftests/networking/timestamping/Makefile +0 -3
@@ -9,6 +9,3 @@ all: $(TEST_PROGS) top_srcdir = ../../../../.. KSFT_KHDR_INSTALL := 1 include ../../lib.mk - -clean: - rm -fr $(TEST_GEN_FILES)
Signature · 1 line
2.17.1
Quoted 21 lines · Deepa Dinamani
The clean target in the makefile conflicts with the generic kselftests lib.mk, and fails to properly remove the compiled test programs.
Remove the redundant rule, the
TEST_GEN_FILESwill be already removed by the CLEAN macro in lib.mk.Signed-off-by Deepa Dinamani <deepa.kernel at gmail.com>---
* Changes since v1: as per review comments
tools/testing/selftests/networking/timestamping/Makefile | 3 --- 1 file changed, 3 deletions(-)tools/testing/selftests/networking/timestamping/Makefile +0
-0
tools/testing/selftests/networking/timestamping/Makefile all: $(TEST_PROGS) · line 14
Quoted 6 lines
tools/testing/selftests/networking/timestamping/Makefile +0
-3@@ -9,6 +9,3 @@ all: $(TEST_PROGS) top_srcdir = ../../../../.. KSFT_KHDR_INSTALL := 1 include ../../lib.mk - -clean: - rm -fr $(TEST_GEN_FILES)
Thanks for the patch.
thanks,
-- Shuah
From: Deepa Dinamani <deepa.kernel at gmail.com>
Date: Wed, 13 Feb 2019 09:09:13 -0800
Quoted 8 lines
The clean target in the makefile conflicts with the generic kselftests lib.mk, and fails to properly remove the compiled test programs.
Remove the redundant rule, the
TEST_GEN_FILESwill be already removed by the CLEAN macro in lib.mk.Signed-off-by Deepa Dinamani <deepa.kernel at gmail.com>
Applied, thank you.