Skip to contentSkip to conversation

media: pci: ipu3-cio2: Obtain remote pad from endpoint

PATCH In review Sakari Ailus 3 participants 7 messages May 15, 2023 – Jun 8, 2023

Subsystems (2)
lore
Share & tools
lore

Sakari Ailus

author maintainer
#0 lore raw

PATCH v3 1/1 media: pci: ipu3-cio2: Obtain remote pad from endpoint

Use the endpoint fwnode to find out the remote pad, instead of using the first source pad found. Also improve error messages.

---
Oh well. Hopefully this is final then.

since v2:
- Use remote fwnode for finding the remote pad, not local.

 drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 28 ++++++++-----------
 1 file changed, 12 insertions(+), 16 deletions(-)
drivers/media/pci/intel/ipu3/ipu3-cio2-main.c +12 -16
index 39a8022eec396..2743ecc9b8e4b 100644
@@ -1418,31 +1418,27 @@ static int cio2_notifier_complete(struct v4l2_async_notifier *notifier)
 	struct sensor_async_subdev *s_asd;
 	struct v4l2_async_connection *asd;
 	struct cio2_queue *q;
-	unsigned int pad;
 	int ret;
 
 	list_for_each_entry(asd, &cio2->notifier.done_list, asc_entry) {
 		s_asd = to_sensor_asd(asd);
 		q = &cio2->queue[s_asd->csi2.port];
 
-		for (pad = 0; pad < q->sensor->entity.num_pads; pad++)
-			if (q->sensor->entity.pads[pad].flags &
-						MEDIA_PAD_FL_SOURCE)
-				break;
-
-		if (pad == q->sensor->entity.num_pads) {
-			dev_err(dev, "failed to find src pad for %s\n",
-				q->sensor->name);
-			return -ENXIO;
+		ret = media_entity_get_fwnode_pad(&q->sensor->entity,
+						  s_asd->asd.match.fwnode,
+						  MEDIA_PAD_FL_SOURCE);
+		if (ret < 0) {
+			dev_err(dev, "no pad for endpoint %pfw (%d)\n",
+				s_asd->asd.match.fwnode, ret);
+			return ret;
 		}
 
-		ret = media_create_pad_link(
-				&q->sensor->entity, pad,
-				&q->subdev.entity, CIO2_PAD_SINK,
-				0);
+		ret = media_create_pad_link(&q->sensor->entity, ret,
+					    &q->subdev.entity, CIO2_PAD_SINK,
+					    0);
 		if (ret) {
-			dev_err(dev, "failed to create link for %s\n",
-				q->sensor->name);
+			dev_err(dev, "failed to create link for %s (endpoint %pfw, error %d)\n",
+				q->sensor->name, s_asd->asd.match.fwnode, ret);
 			return ret;
 		}
 	}
Signature · 1 line
2.30.2
Reviewed-by on v3 1/1
#1 lore raw
Quoted 62 lines · Sakari Ailus

Use the endpoint fwnode to find out the remote pad, instead of using the first source pad found. Also improve error messages.

---
Oh well. Hopefully this is final then.

since v2:
- Use remote fwnode for finding the remote pad, not local.

 drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 28 ++++++++-----------
 1 file changed, 12 insertions(+), 16 deletions(-)
drivers/media/pci/intel/ipu3/ipu3-cio2-main.c +12 -16
index 39a8022eec396..2743ecc9b8e4b 100644
@@ -1418,31 +1418,27 @@ static int cio2_notifier_complete(struct v4l2_async_notifier *notifier)
 	struct sensor_async_subdev *s_asd;
 	struct v4l2_async_connection *asd;
 	struct cio2_queue *q;
-	unsigned int pad;
 	int ret;
 
 	list_for_each_entry(asd, &cio2->notifier.done_list, asc_entry) {
 		s_asd = to_sensor_asd(asd);
 		q = &cio2->queue[s_asd->csi2.port];
 
-		for (pad = 0; pad < q->sensor->entity.num_pads; pad++)
-			if (q->sensor->entity.pads[pad].flags &
-						MEDIA_PAD_FL_SOURCE)
-				break;
-
-		if (pad == q->sensor->entity.num_pads) {
-			dev_err(dev, "failed to find src pad for %s\n",
-				q->sensor->name);
-			return -ENXIO;
+		ret = media_entity_get_fwnode_pad(&q->sensor->entity,
+						  s_asd->asd.match.fwnode,
+						  MEDIA_PAD_FL_SOURCE);
+		if (ret < 0) {
+			dev_err(dev, "no pad for endpoint %pfw (%d)\n",
+				s_asd->asd.match.fwnode, ret);
+			return ret;
 		}
 
-		ret = media_create_pad_link(
-				&q->sensor->entity, pad,
-				&q->subdev.entity, CIO2_PAD_SINK,
-				0);
+		ret = media_create_pad_link(&q->sensor->entity, ret,
+					    &q->subdev.entity, CIO2_PAD_SINK,
+					    0);
 		if (ret) {
-			dev_err(dev, "failed to create link for %s\n",
-				q->sensor->name);
+			dev_err(dev, "failed to create link for %s (endpoint %pfw, error %d)\n",
+				q->sensor->name, s_asd->asd.match.fwnode, ret);
 			return ret;
 		}
 	}
Signature · 2 lines
Best regards,
Bingbu Cao
#2 lore raw
In reply to Sakari Ailus

Hi Sakari,

Thank you for the patch.

Quoted 2 lines · Sakari Ailus

Use the endpoint fwnode to find out the remote pad, instead of using the first source pad found. Also improve error messages.

The commit message should explain *why*. Once I know why, I'll review the patch :-)

Quoted 58 lines

---
Oh well. Hopefully this is final then.

since v2:
- Use remote fwnode for finding the remote pad, not local.

 drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 28 ++++++++-----------
 1 file changed, 12 insertions(+), 16 deletions(-)
drivers/media/pci/intel/ipu3/ipu3-cio2-main.c +12 -16
index 39a8022eec396..2743ecc9b8e4b 100644
@@ -1418,31 +1418,27 @@ static int cio2_notifier_complete(struct v4l2_async_notifier *notifier)
 	struct sensor_async_subdev *s_asd;
 	struct v4l2_async_connection *asd;
 	struct cio2_queue *q;
-	unsigned int pad;
 	int ret;
 
 	list_for_each_entry(asd, &cio2->notifier.done_list, asc_entry) {
 		s_asd = to_sensor_asd(asd);
 		q = &cio2->queue[s_asd->csi2.port];
 
-		for (pad = 0; pad < q->sensor->entity.num_pads; pad++)
-			if (q->sensor->entity.pads[pad].flags &
-						MEDIA_PAD_FL_SOURCE)
-				break;
-
-		if (pad == q->sensor->entity.num_pads) {
-			dev_err(dev, "failed to find src pad for %s\n",
-				q->sensor->name);
-			return -ENXIO;
+		ret = media_entity_get_fwnode_pad(&q->sensor->entity,
+						  s_asd->asd.match.fwnode,
+						  MEDIA_PAD_FL_SOURCE);
+		if (ret < 0) {
+			dev_err(dev, "no pad for endpoint %pfw (%d)\n",
+				s_asd->asd.match.fwnode, ret);
+			return ret;
 		}
 
-		ret = media_create_pad_link(
-				&q->sensor->entity, pad,
-				&q->subdev.entity, CIO2_PAD_SINK,
-				0);
+		ret = media_create_pad_link(&q->sensor->entity, ret,
+					    &q->subdev.entity, CIO2_PAD_SINK,
+					    0);
 		if (ret) {
-			dev_err(dev, "failed to create link for %s\n",
-				q->sensor->name);
+			dev_err(dev, "failed to create link for %s (endpoint %pfw, error %d)\n",
+				q->sensor->name, s_asd->asd.match.fwnode, ret);
 			return ret;
 		}
 	}
Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#3 lore raw

Hi Laurent,

Quoted 10 lines · Laurent Pinchart

Hi Sakari,

Thank you for the patch.

Quoted 2 lines · Sakari Ailus

Use the endpoint fwnode to find out the remote pad, instead of using the first source pad found. Also improve error messages.

The commit message should explain *why*. Once I know why, I'll review the patch :-)

I thought it'd be trivial. :-)

Using framework functions instead of open coding this in drivers, and using the pad related to the endpoint fwnode instead of just the first pad found.

I'll add this to the commit message.

Signature · 1 line
Sakari Ailus
#4 lore raw

Hi Sakari,

Quoted 9 lines · Sakari Ailus
Quoted 6 lines · Laurent Pinchart
Quoted 2 lines · Sakari Ailus

Use the endpoint fwnode to find out the remote pad, instead of using the first source pad found. Also improve error messages.

The commit message should explain *why*. Once I know why, I'll review the patch :-)

I thought it'd be trivial. :-)

It may appear trivial as a patch author, but reviewers don't have the context, so they shouldn't be expected to guess the intent.

Quoted 4 lines

Using framework functions instead of open coding this in drivers, and using the pad related to the endpoint fwnode instead of just the first pad found.

I'll add this to the commit message.

Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#5 lore raw

Hi Laurent,

Quoted 8 lines · Laurent Pinchart

Hi Sakari,

Quoted 5 lines · Sakari Ailus
Quoted 4 lines · Laurent Pinchart
Quoted 2 lines · Sakari Ailus

Use the endpoint fwnode to find out the remote pad, instead of using the first source pad found. Also improve error messages.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

The commit message should explain *why*. Once I know why, I'll review the patch :-)

I thought it'd be trivial. :-)

It may appear trivial as a patch author, but reviewers don't have the context, so they shouldn't be expected to guess the intent.

This is actually already in the stage tree. Let's see what we decide to do with that one.

Signature · 1 line
Sakari Ailus
author maintainer
#6 lore raw
In reply to Sakari Ailus
Quoted 14 lines · Sakari Ailus

Hi Laurent,

Quoted 10 lines · Laurent Pinchart

Hi Sakari,

Thank you for the patch.

Quoted 2 lines · Sakari Ailus

Use the endpoint fwnode to find out the remote pad, instead of using the first source pad found. Also improve error messages.

The commit message should explain *why*. Once I know why, I'll review the patch :-)

Quoted 6 lines

I thought it'd be trivial. :-)

Using framework functions instead of open coding this in drivers, and using the pad related to the endpoint fwnode instead of just the first pad found.

I'll add this to the commit message.

Actually this is already in the media tree, let's see what we end up doing with it.

Signature · 1 line
Sakari Ailus