hsi_char: Delete an error message for a failed memory allocation in hsc_probe()

PATCH New SF Markus Elfring 1 participant 1 message Feb 2, 2018

Subsystems (2)

Kernel janitors HSI

lore

Share & tools

lore

SF Markus Elfring

author

2018-02-02 20:25 UTC #0 lore raw

PATCH 1/1 hsi_char: Delete an error message for a failed memory allocation in hsc_probe()

From: Markus Elfring <[email protected]>
Date: Fri, 2 Feb 2018 21:21:12 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by Markus Elfring <[email protected]>

---
 drivers/hsi/clients/hsi_char.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

drivers/hsi/clients/hsi_char.c +2 -3

index cf9c2a332ad8..9d2a6d64dfb8 100644
@@ -697,10 +697,9 @@ static int hsc_probe(struct device *dev)
 	int i;
 
 	cl_data = kzalloc(sizeof(*cl_data), GFP_KERNEL);
-	if (!cl_data) {
-		dev_err(dev, "Could not allocate hsc_client_data\n");
+	if (!cl_data)
 		return -ENOMEM;
-	}
+
 	hsc_baseminor = HSC_BASEMINOR(hsi_id(cl), hsi_port_id(cl));
 	if (!hsc_major) {
 		ret = alloc_chrdev_region(&hsc_dev, hsc_baseminor,

Signature · 1 line

2.16.1