crypto: iaa - Use cpumask_weight() when rebalancing
Subsystems (2)
PATCH 1/1 crypto: iaa - Use cpumask_weight() when rebalancing
If some cpus are offlined, or if the node mask is smaller than expected, the 'nonexistent cpu' warning in rebalance_wq_table() may be erroneously triggered.
Use cpumask_weight() to make sure we only iterate over the exact number of cpus in the mask.
Also use num_possible_cpus() instead of num_online_cpus() to make sure all slots in the wq table are initialized.
--- drivers/crypto/intel/iaa/iaa_crypto_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/intel/iaa/iaa_crypto_main.c +2 -2
@@ -922,7 +922,7 @@ static void rebalance_wq_table(void)for_each_node_with_cpus (node) { node_cpus =cpumask_of_node (node); -for (cpu =0 ; cpu < nr_cpus_per_node; cpu++) { +for (cpu =0 ; cpu <cpumask_weight (node_cpus); cpu++) {int node_cpu =cpumask_nth (cpu, node_cpus);if (WARN_ON (node_cpu >= nr_cpu_ids)) {
@@ -2005,7 +2005,7 @@ static int __init iaa_crypto_init_module(void)int ret =0 ;int node; - nr_cpus =num_online_cpus (); + nr_cpus =num_possible_cpus ();for_each_node_with_cpus (node) nr_nodes++;if (!nr_nodes) {
Signature · 1 line
2.38.1
Herbert Xu
maintainerQuoted 7 lines · Tom Zanussi
If some cpus are offlined, or if the node mask is smaller than expected, the 'nonexistent cpu' warning in
rebalance_wq_table()may be erroneously triggered.Use
cpumask_weight()to make sure we only iterate over the exact number of cpus in the mask.
Quoted 7 lines
Also use
num_possible_cpus()instead ofnum_online_cpus()to make sure all slots in the wq table are initialized.Signed-off-by Tom Zanussi <[email protected]>--- drivers/crypto/intel/iaa/iaa_crypto_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt