os-release: Add CPE_NAME
PATCH v2 1/1 os-release: Add CPE_NAME
Its time we add the CPE_NAME to os-release.
The vendor field is hardcoded to "openembedded" as it is the base framework. We will use "DISTRO" to identify which variation of openembedded is being used.
---
V2]
Add CPE_DISTRO
Improve usage text.
--- meta/recipes-core/os-release/os-release.bb | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
meta/recipes-core/os-release/os-release.bb +17 -0
@@ -16,6 +16,7 @@ do_configure[noexec] = "1" # HOME_URL SUPPORT_URL BUG_REPORT_URL OS_RELEASE_FIELDS = "\ ID ID_LIKE NAME VERSION VERSION_ID VERSION_CODENAME PRETTY_NAME \ + CPE_NAME \ " OS_RELEASE_UNQUOTED_FIELDS = "ID VERSION_ID VARIANT_ID"
@@ -25,6 +26,22 @@ VERSION = "${DISTRO_VERSION}${@' (%s)' % DISTRO_CODENAME if 'DISTRO_CODENAME' in VERSION_ID = "${DISTRO_VERSION}" VERSION_CODENAME = "${DISTRO_CODENAME}" PRETTY_NAME = "${DISTRO_NAME} ${VERSION}" + +""" +The vendor field is hardcoded to "openembedded" deliberately. We'd +advise developers leave it as this value to clearly identify the +underlying build environment from which the OS was constructed. We +understand people will want to identify themselves as the people who +built the image, we'd suggest using the DISTRO element to do this, so +that is customisable. +This end result combines to mean systems can be traced back to both who +built them and which system was used, which is ultimately the goal of +the CPE. +""" + +CPE_DISTRO ??= "${DISTRO}" +CPE_NAME="cpe:/o:openembedded:${CPE_DISTRO}:${VERSION_ID}" + BUILD_ID ?= "${DATETIME}" BUILD_ID[vardepsexclude] = "DATETIME"
Signature · 1 line
2.25.1
Quoted 41 lines · Armin Kuster
Its time we add the
CPE_NAMEto os-release.The vendor field is hardcoded to "openembedded" as it is the base framework. We will use "DISTRO" to identify which variation of openembedded is being used.
Signed-off-by Armin Kuster <[email protected]>---
V2]
AddCPE_DISTRO
Improve usage text.--- meta/recipes-core/os-release/os-release.bb | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)meta/recipes-core/os-release/os-release.bb +10
-0@@ -16,6 +16,7 @@ do_configure[noexec] = "1" # HOME_URL SUPPORT_URL BUG_REPORT_URL OS_RELEASE_FIELDS = "\ ID ID_LIKE NAME VERSION VERSION_ID VERSION_CODENAME PRETTY_NAME \ + CPE_NAME \ " OS_RELEASE_UNQUOTED_FIELDS = "ID VERSION_ID VARIANT_ID"@@ -25,6 +26,22 @@ VERSION = "${DISTRO_VERSION}${@' (%s)' % DISTRO_CODENAME if 'DISTRO_CODENAME' in VERSION_ID = "${DISTRO_VERSION}" VERSION_CODENAME = "${DISTRO_CODENAME}" PRETTY_NAME = "${DISTRO_NAME} ${VERSION}" + +""" +The vendor field is hardcoded to "openembedded" deliberately. We'd +advise developers leave it as this value to clearly identify the +underlying build environment from which the OS was constructed. We +understand people will want to identify themselves as the people who +built the image, we'd suggest using the DISTRO element to do this, so +that is customisable. +This end result combines to mean systems can be traced back to both who
meta/recipes-core/os-release/os-release.bb VERSION = "${DISTRO_VERSION}${@' (%s)' % DISTRO_CODENAME if 'DISTRO_CODENAME' in · line 47
Quoted 10 lines
meta/recipes-core/os-release/os-release.bb +7
-0+built them and which system was used, which is ultimately the goal of +the CPE. +""" + +CPE_DISTRO ??= "${DISTRO}" +CPE_NAME="cpe:/o:openembedded:${CPE_DISTRO}:${VERSION_ID}" + BUILD_ID ?= "${DATETIME}" BUILD_ID[vardepsexclude] = "DATETIME"
That looks like a parsing error to me? How did you test this? :)
(needs # at the start of comment lines)
Cheers,
Richard
Quoted 45 lines · Richard Purdie
Quoted 44 lines · Armin Kuster
Its time we add the
CPE_NAMEto os-release.The vendor field is hardcoded to "openembedded" as it is the base framework. We will use "DISTRO" to identify which variation of openembedded is being used.
Signed-off-by Armin Kuster <[email protected]>---
V2]
AddCPE_DISTRO
Improve usage text.--- meta/recipes-core/os-release/os-release.bb | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)meta/recipes-core/os-release/os-release.bb +13
-0@@ -16,6 +16,7 @@ do_configure[noexec] = "1" # HOME_URL SUPPORT_URL BUG_REPORT_URL OS_RELEASE_FIELDS = "\ ID ID_LIKE NAME VERSION VERSION_ID VERSION_CODENAME PRETTY_NAME \ + CPE_NAME \ " OS_RELEASE_UNQUOTED_FIELDS = "ID VERSION_ID VARIANT_ID"@@ -25,6 +26,22 @@ VERSION = "${DISTRO_VERSION}${@' (%s)' % DISTRO_CODENAME if 'DISTRO_CODENAME' in VERSION_ID = "${DISTRO_VERSION}" VERSION_CODENAME = "${DISTRO_CODENAME}" PRETTY_NAME = "${DISTRO_NAME} ${VERSION}" + +""" +The vendor field is hardcoded to "openembedded" deliberately. We'd +advise developers leave it as this value to clearly identify the +underlying build environment from which the OS was constructed. We +understand people will want to identify themselves as the people who +built the image, we'd suggest using the DISTRO element to do this, so +that is customisable. +This end result combines to mean systems can be traced back to both who +built them and which system was used, which is ultimately the goal of +the CPE. +"""
Quoted 8 lines
meta/recipes-core/os-release/os-release.bb VERSION = "${DISTRO_VERSION}${@' (%s)' % DISTRO_CODENAME if 'DISTRO_CODENAME' in · line 47
Quoted 7 lines
meta/recipes-core/os-release/os-release.bb +4
-0+ +CPE_DISTRO ??= "${DISTRO}" +CPE_NAME="cpe:/o:openembedded:${CPE_DISTRO}:${VERSION_ID}" + BUILD_ID ?= "${DATETIME}" BUILD_ID[vardepsexclude] = "DATETIME"That looks like a parsing error to me? How did you test this? :)
Looks like I didn't. Can't blame Monday for this, maybe just old age?
v3 shortly.
-armin
Quoted 9 lines
(needs # at the start of comment lines)
Cheers,
Richard