cmd: clk: Handle ENODEV from clk_get_rate
PATCH v2 1/1 cmd: clk: Handle ENODEV from clk_get_rate
clk_get_rate may return -ENODEV if the clock isn't valid.
Also, make all the error cases go through a single path.
Signed-off-by Ismael Luceno <[email protected]>
---
CC Matthias Brugger <[email protected]>
Notes:
Changes since v1:
- Added further explanation to the commit message.
cmd/clk.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-)
cmd/clk.c +13 -10
@@ -26,20 +26,23 @@ int __weak soc_clk_dump(void) uclass_foreach_dev(dev, uc) {memset (&clk,0 ,sizeof (clk)); ret =device_probe (dev); -if (ret) { -printf ("%-30.30s : ? Hz\n" , dev->name); -continue ; - } +if (ret) + goto noclk; ret =clk_request (dev, &clk); -if (ret) { -printf ("%-30.30s : ? Hz\n" , dev->name); -continue ; - } - -printf ("%-30.30s : %lu Hz\n" , dev->name,clk_get_rate (&clk)); +if (ret) + goto noclk; +ulong rate =clk_get_rate (&clk);clk_free (&clk); + +if (rate == -ENODEV ) + goto noclk; + +printf ("%-30.30s : %lu Hz\n" , dev->name, rate); +continue ; + noclk: +printf ("%-30.30s : ? Hz\n" , dev->name); }return 0 ;
Signature · 1 line
2.19.1
PATCH v2 1/1 cmd: clk: Handle ENODEV from clk_get_rate
Quoted 4 lines · Ismael Luceno Cortes
clk_get_ratemay return-ENODEVif the clock isn't valid.Also, make all the error cases go through a single path.
Not sure if that is applied systematically to u-boot, but might be good to mention the commit you fix with that, as printing -ENODEV as clock frequency is a bug:
Fixes ff8eee0330 ("cmd: clk: Add trivial implementation of clock dump for DM")
Other then that:
Reviewed-by Matthias Brugger <[email protected]>
Quoted 52 lines
Signed-off-by Ismael Luceno <[email protected]>---
CC Matthias Brugger <[email protected]>Notes:
Changes since v1:- Added further explanation to the commit message.
cmd/clk.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-)cmd/clk.c +13
-10@@ -26,20 +26,23 @@ int __weak soc_clk_dump(void) uclass_foreach_dev(dev, uc) {memset (&clk,0 ,sizeof (clk)); ret =device_probe (dev); -if (ret) { -printf ("%-30.30s : ? Hz\n" , dev->name); -continue ; - } +if (ret) + goto noclk; ret =clk_request (dev, &clk); -if (ret) { -printf ("%-30.30s : ? Hz\n" , dev->name); -continue ; - } - -printf ("%-30.30s : %lu Hz\n" , dev->name,clk_get_rate (&clk)); +if (ret) + goto noclk; +ulong rate =clk_get_rate (&clk);clk_free (&clk); + +if (rate == -ENODEV ) + goto noclk; + +printf ("%-30.30s : %lu Hz\n" , dev->name, rate); +continue ; + noclk: +printf ("%-30.30s : ? Hz\n" , dev->name); }return 0 ;