staging : rtl8712: correct the code style for comparison to NULL
PATCH v2 1/1 staging : rtl8712: correct the code style for comparison to NULL
The coding style (!bar) is more common than (bar == NULL). Reported by checkpatch.pl.
---
Changes in v2:
- correct the subject line
- correct the commit message
drivers/staging/rtl8712/rtl871x_recv.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8712/rtl871x_recv.h +5 -5
@@ -136,7 +136,7 @@ int recv_func(struct _adapter *padapter, void *pcontext);static inline u8 *get_rxmem (union recv_frame *precvframe) {/* always return rx_head... */ -if (precvframe ==NULL ) +if (!precvframe)return NULL ;return precvframe->u.hdr.rx_head; }
@@ -144,7 +144,7 @@ static inline u8 *get_rxmem(union recv_frame *precvframe)static inline u8 *get_recvframe_data (union recv_frame *precvframe) {/* always return rx_data */ -if (precvframe ==NULL ) +if (!precvframe)return NULL ;return precvframe->u.hdr.rx_data; }
@@ -154,7 +154,7 @@ static inline u8 *recvframe_pull(union recv_frame *precvframe, sint sz)/* used for extract sz bytes from rx_data, update rx_data and return * the updated rx_data to the caller */ -if (precvframe ==NULL ) +if (!precvframe)return NULL ; precvframe->u.hdr.rx_data += sz;if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) {
@@ -171,7 +171,7 @@ static inline u8 *recvframe_put(union recv_frame *precvframe, sint sz)* return the updated rx_tail to the caller * after putting, rx_tail must be still larger than rx_end. */ -if (precvframe ==NULL ) +if (!precvframe)return NULL ; precvframe->u.hdr.rx_tail += sz;if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) {
@@ -189,7 +189,7 @@ static inline u8 *recvframe_pull_tail(union recv_frame *precvframe, sint sz)* updated rx_end to the caller * after pulling, rx_end must be still larger than rx_data. */ -if (precvframe ==NULL ) +if (!precvframe)return NULL ; precvframe->u.hdr.rx_tail -= sz;if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) {
Signature · 1 line
2.25.1
In the subject line, there should not a space before the colon.
Thanks for improving the subjects and messages otherwise.
julia
Quoted 69 lines · Elena Afanasova
The coding style (!bar) is more common than (bar == NULL). Reported by checkpatch.pl.
Signed-off-by Elena Afanasova <[email protected]>---
Changes in v2:
- correct the subject line
- correct the commit messagedrivers/staging/rtl8712/rtl871x_recv.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/staging/rtl8712/rtl871x_recv.h +5
-6@@ -136,7 +136,7 @@ int recv_func(struct _adapter *padapter, void *pcontext);static inline u8 *get_rxmem (union recv_frame *precvframe) {/* always return rx_head... */ -if (precvframe ==NULL ) +if (!precvframe)return NULL ;return precvframe->u.hdr.rx_head; }@@ -144,7 +144,7 @@ static inline u8 *get_rxmem(union recv_frame *precvframe)static inline u8 *get_recvframe_data (union recv_frame *precvframe) {/* always return rx_data */ -if (precvframe ==NULL ) +if (!precvframe)return NULL ;return precvframe->u.hdr.rx_data; }@@ -154,7 +154,7 @@ static inline u8 *recvframe_pull(union recv_frame *precvframe, sint sz)/* used for extract sz bytes from rx_data, update rx_data and return * the updated rx_data to the caller */ -if (precvframe ==NULL ) +if (!precvframe)return NULL ; precvframe->u.hdr.rx_data += sz;if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) {@@ -171,7 +171,7 @@ static inline u8 *recvframe_put(union recv_frame *precvframe, sint sz)* return the updated rx_tail to the caller * after putting, rx_tail must be still larger than rx_end. */ -if (precvframe ==NULL ) +if (!precvframe)return NULL ; precvframe->u.hdr.rx_tail += sz;if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) {@@ -189,7 +189,7 @@ static inline u8 *recvframe_pull_tail(union recv_frame *precvframe, sint sz)* updated rx_end to the caller * after pulling, rx_end must be still larger than rx_data. */ -if (precvframe ==NULL ) +if (!precvframe)return NULL ; precvframe->u.hdr.rx_tail -= sz;if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) { --2.25.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/afff1ded817cb27631f87146ae198e2915ad61fe.camel%40gmail.com.