Skip to contentSkip to conversation

Revert "tmpfs: don't enable large folios if not supported"

PATCH In review Baolin Wang 7 participants 13 messages Apr 23 – May 12

Subsystems (2)
lore
Share & tools
lore

Baolin Wang

author reviewer
#0 lore raw

PATCH 1/1 Revert "tmpfs: don't enable large folios if not supported"

This reverts commit 5a90c155defa684f3a21f68c3f8e40c056e6114c.

Currently, when shmem mounts are initialized, they only use 'sbinfo->huge' to determine whether the shmem mount supports large folios. However, for anonymous shmem, whether it supports large folios can be dynamically configured via sysfs interfaces, so setting or not setting mapping_set_large_folios() during initialization cannot accurately reflect whether anonymous shmem actually supports large folios, which has already caused some confusion[1].

Moreover, for tmpfs mounts, relying on 'sbinfo->huge' cannot keep the mapping_set_large_folios() setting consistent across all mappings in the entire tmpfs mount. In other words, under the same tmpfs mount, after remount, we might end up with some mappings supporting large folios (calling mapping_set_large_folios()) while others don't.

After some investigation, I found that the write performance regression addressed by commit 5a90c155defa has already been fixed by the following commit 665575cff098b ("filemap: move prefaulting out of hot write path"). See the following test data:

Base:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.0 GB/s ) dd if=/dev/zero of=/mnt/tmpfs/test bs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

Base + revert 5a90c155defa:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/testbs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

The data is basically consistent with minor fluctuation noise. So we can now safely revert commit 5a90c155defa to set mapping_set_large_folios() for all shmem mounts unconditionally.

[1] https://lore.kernel.org/all/[email protected]/

---
Note: for more investigation and test data, see:
https://lore.kernel.org/all/[email protected]/
Thanks Kefeng for confirming the performance issue.

---
 mm/shmem.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
mm/shmem.c +1 -4
index 4ecefe02881d..dafbea53b22d 100644
@@ -3087,10 +3087,7 @@ static struct inode *__shmem_get_inode(struct mnt_idmap *idmap,
 	cache_no_acl(inode);
 	if (sbinfo->noswap)
 		mapping_set_unevictable(inode->i_mapping);
-
-	/* Don't consider 'deny' for emergencies and 'force' for testing */
-	if (sbinfo->huge)
-		mapping_set_large_folios(inode->i_mapping);
+	mapping_set_large_folios(inode->i_mapping);
 
 	switch (mode & S_IFMT) {
 	default:
Signature · 1 line
2.47.3
Acked-by on v1 1/1
#1 lore raw
Quoted 39 lines · Baolin Wang

This reverts commit 5a90c155defa684f3a21f68c3f8e40c056e6114c.

Currently, when shmem mounts are initialized, they only use 'sbinfo->huge' to determine whether the shmem mount supports large folios. However, for anonymous shmem, whether it supports large folios can be dynamically configured via sysfs interfaces, so setting or not setting mapping_set_large_folios() during initialization cannot accurately reflect whether anonymous shmem actually supports large folios, which has already caused some confusion[1].

Moreover, for tmpfs mounts, relying on 'sbinfo->huge' cannot keep the mapping_set_large_folios() setting consistent across all mappings in the entire tmpfs mount. In other words, under the same tmpfs mount, after remount, we might end up with some mappings supporting large folios (calling mapping_set_large_folios()) while others don't.

After some investigation, I found that the write performance regression addressed by commit 5a90c155defa has already been fixed by the following commit 665575cff098b ("filemap: move prefaulting out of hot write path"). See the following test data:

Base:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.0 GB/s ) dd if=/dev/zero of=/mnt/tmpfs/test bs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

Base + revert 5a90c155defa:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/testbs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

The data is basically consistent with minor fluctuation noise. So we can now safely revert commit 5a90c155defa to set mapping_set_large_folios() for all shmem mounts unconditionally.

[1] https://lore.kernel.org/all/[email protected]/

Quoted 9 lines

---
Note: for more investigation and test data, see:
https://lore.kernel.org/all/[email protected]/
Thanks Kefeng for confirming the performance issue.

---
 mm/shmem.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Thank you for the investigation and explanation.

Best Regards,
Yan, Zi

#2 lore raw
In reply to Baolin Wang
Quoted 40 lines · Baolin Wang

This reverts commit 5a90c155defa684f3a21f68c3f8e40c056e6114c.

Currently, when shmem mounts are initialized, they only use 'sbinfo->huge' to determine whether the shmem mount supports large folios. However, for anonymous shmem, whether it supports large folios can be dynamically configured via sysfs interfaces, so setting or not setting mapping_set_large_folios() during initialization cannot accurately reflect whether anonymous shmem actually supports large folios, which has already caused some confusion[1].

Moreover, for tmpfs mounts, relying on 'sbinfo->huge' cannot keep the mapping_set_large_folios() setting consistent across all mappings in the entire tmpfs mount. In other words, under the same tmpfs mount, after remount, we might end up with some mappings supporting large folios (calling mapping_set_large_folios()) while others don't.

After some investigation, I found that the write performance regression addressed by commit 5a90c155defa has already been fixed by the following commit 665575cff098b ("filemap: move prefaulting out of hot write path"). See the following test data:

Base:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.0 GB/s ) dd if=/dev/zero of=/mnt/tmpfs/test bs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

Base + revert 5a90c155defa:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/testbs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

The data is basically consistent with minor fluctuation noise. So we can now safely revert commit 5a90c155defa to set mapping_set_large_folios() for all shmem mounts unconditionally.

Quoted 6 lines

[1] https://lore.kernel.org/all/[email protected]/

---
Note: for more investigation and test data, see:
https://lore.kernel.org/all/[email protected]/
Thanks Kefeng for confirming the performance issue.

LGTM, Reviewed-by: Kefeng Wang <[email protected]>

Quoted 20 lines
---
  mm/shmem.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
mm/shmem.c +1 -4
index 4ecefe02881d..dafbea53b22d 100644
@@ -3087,10 +3087,7 @@ static struct inode *__shmem_get_inode(struct mnt_idmap *idmap,
  	cache_no_acl(inode);
  	if (sbinfo->noswap)
  		mapping_set_unevictable(inode->i_mapping);
-
-	/* Don't consider 'deny' for emergencies and 'force' for testing */
-	if (sbinfo->huge)
-		mapping_set_large_folios(inode->i_mapping);
+	mapping_set_large_folios(inode->i_mapping);
 
  	switch (mode & S_IFMT) {
  	default:
Reviewed-by on v1 1/1
#3 lore raw
In reply to Baolin Wang
Quoted 38 lines · Baolin Wang

This reverts commit 5a90c155defa684f3a21f68c3f8e40c056e6114c.

Currently, when shmem mounts are initialized, they only use 'sbinfo->huge' to determine whether the shmem mount supports large folios. However, for anonymous shmem, whether it supports large folios can be dynamically configured via sysfs interfaces, so setting or not setting mapping_set_large_folios() during initialization cannot accurately reflect whether anonymous shmem actually supports large folios, which has already caused some confusion[1].

Moreover, for tmpfs mounts, relying on 'sbinfo->huge' cannot keep the mapping_set_large_folios() setting consistent across all mappings in the entire tmpfs mount. In other words, under the same tmpfs mount, after remount, we might end up with some mappings supporting large folios (calling mapping_set_large_folios()) while others don't.

After some investigation, I found that the write performance regression addressed by commit 5a90c155defa has already been fixed by the following commit 665575cff098b ("filemap: move prefaulting out of hot write path"). See the following test data:

Base:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.0 GB/s ) dd if=/dev/zero of=/mnt/tmpfs/test bs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

Base + revert 5a90c155defa:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/testbs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

The data is basically consistent with minor fluctuation noise. So we can now safely revert commit 5a90c155defa to set mapping_set_large_folios() for all shmem mounts unconditionally.

Quoted 7 lines

[1] https://lore.kernel.org/all/[email protected]/

---
Note: for more investigation and test data, see:
https://lore.kernel.org/all/[email protected]/
Thanks Kefeng for confirming the performance issue.
---

Thanks for tackling this!

Acked-by on v1 1/1
#4 lore raw
In reply to Baolin Wang
Quoted 38 lines · Baolin Wang

This reverts commit 5a90c155defa684f3a21f68c3f8e40c056e6114c.

Currently, when shmem mounts are initialized, they only use 'sbinfo->huge' to determine whether the shmem mount supports large folios. However, for anonymous shmem, whether it supports large folios can be dynamically configured via sysfs interfaces, so setting or not setting mapping_set_large_folios() during initialization cannot accurately reflect whether anonymous shmem actually supports large folios, which has already caused some confusion[1].

Moreover, for tmpfs mounts, relying on 'sbinfo->huge' cannot keep the mapping_set_large_folios() setting consistent across all mappings in the entire tmpfs mount. In other words, under the same tmpfs mount, after remount, we might end up with some mappings supporting large folios (calling mapping_set_large_folios()) while others don't.

After some investigation, I found that the write performance regression addressed by commit 5a90c155defa has already been fixed by the following commit 665575cff098b ("filemap: move prefaulting out of hot write path"). See the following test data:

Base:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.0 GB/s ) dd if=/dev/zero of=/mnt/tmpfs/test bs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

Base + revert 5a90c155defa:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/testbs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

The data is basically consistent with minor fluctuation noise. So we can now safely revert commit 5a90c155defa to set mapping_set_large_folios() for all shmem mounts unconditionally.

Quoted 5 lines

[1] https://lore.kernel.org/all/[email protected]/

---
Note: for more investigation and test data, see:
https://lore.kernel.org/all/[email protected]/

Maybe add that as

above?

Signature · 3 lines
Cheers,

David
author reviewer
#5 lore raw
Quoted 46 lines · David Hildenbrand (Arm)
Quoted 38 lines · Baolin Wang

This reverts commit 5a90c155defa684f3a21f68c3f8e40c056e6114c.

Currently, when shmem mounts are initialized, they only use 'sbinfo->huge' to determine whether the shmem mount supports large folios. However, for anonymous shmem, whether it supports large folios can be dynamically configured via sysfs interfaces, so setting or not setting mapping_set_large_folios() during initialization cannot accurately reflect whether anonymous shmem actually supports large folios, which has already caused some confusion[1].

Moreover, for tmpfs mounts, relying on 'sbinfo->huge' cannot keep the mapping_set_large_folios() setting consistent across all mappings in the entire tmpfs mount. In other words, under the same tmpfs mount, after remount, we might end up with some mappings supporting large folios (calling mapping_set_large_folios()) while others don't.

After some investigation, I found that the write performance regression addressed by commit 5a90c155defa has already been fixed by the following commit 665575cff098b ("filemap: move prefaulting out of hot write path"). See the following test data:

Base:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.0 GB/s ) dd if=/dev/zero of=/mnt/tmpfs/test bs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

Base + revert 5a90c155defa:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/testbs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

The data is basically consistent with minor fluctuation noise. So we can now safely revert commit 5a90c155defa to set mapping_set_large_folios() for all shmem mounts unconditionally.

Quoted 5 lines

[1] https://lore.kernel.org/all/[email protected]/

---
Note: for more investigation and test data, see:
https://lore.kernel.org/all/[email protected]/

Quoted 5 lines

Maybe add that as

above?

Sure. And I noticed that Andrew has already helped add this link. Thanks Andrew!

Quoted 1 line

Thanks.

Acked-by on v1 1/1
#6 lore raw
In reply to Baolin Wang
Quoted 34 lines · Baolin Wang

This reverts commit 5a90c155defa684f3a21f68c3f8e40c056e6114c.

Currently, when shmem mounts are initialized, they only use 'sbinfo->huge' to determine whether the shmem mount supports large folios. However, for anonymous shmem, whether it supports large folios can be dynamically configured via sysfs interfaces, so setting or not setting mapping_set_large_folios() during initialization cannot accurately reflect whether anonymous shmem actually supports large folios, which has already caused some confusion[1].

Moreover, for tmpfs mounts, relying on 'sbinfo->huge' cannot keep the mapping_set_large_folios() setting consistent across all mappings in the entire tmpfs mount. In other words, under the same tmpfs mount, after remount, we might end up with some mappings supporting large folios (calling mapping_set_large_folios()) while others don't.

After some investigation, I found that the write performance regression addressed by commit 5a90c155defa has already been fixed by the following commit 665575cff098b ("filemap: move prefaulting out of hot write path"). See the following test data:

Base:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.0 GB/s ) dd if=/dev/zero of=/mnt/tmpfs/test bs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

Base + revert 5a90c155defa:
dd if=/dev/zero of=/mnt/tmpfs/test bs=400K count=10485 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=800K count=5242 (3.3 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=1600K count=2621 (3.2 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=2200K count=1906 (3.1 GB/s) dd if=/dev/zero of=/mnt/tmpfs/testbs=3000K count=1398 (3.0 GB/s) dd if=/dev/zero of=/mnt/tmpfs/test bs=4500K count=932 (3.1 GB/s)

Quoted 6 lines

The data is basically consistent with minor fluctuation noise. So we can now safely revert commit 5a90c155defa to set mapping_set_large_folios() for all shmem mounts unconditionally.

[1] https://lore.kernel.org/all/[email protected]/

As David asked, should we have a Fixes tag? What about cc: stable?

Cheers, Lorenzo

Quoted 27 lines

---
Note: for more investigation and test data, see:
https://lore.kernel.org/all/[email protected]/
Thanks Kefeng for confirming the performance issue.

---
 mm/shmem.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
mm/shmem.c +1 -5
index 4ecefe02881d..dafbea53b22d 100644
@@ -3087,10 +3087,7 @@ static struct inode *__shmem_get_inode(struct mnt_idmap *idmap,
 	cache_no_acl(inode);
 	if (sbinfo->noswap)
 		mapping_set_unevictable(inode->i_mapping);
-
-	/* Don't consider 'deny' for emergencies and 'force' for testing */
-	if (sbinfo->huge)
-		mapping_set_large_folios(inode->i_mapping);
+	mapping_set_large_folios(inode->i_mapping);
 
 	switch (mode & S_IFMT) {
 	default:
--

2.47.3

author reviewer
#8 lore raw
Quoted 4 lines · Lorenzo Stoakes
Quoted 3 lines · Lorenzo Stoakes

As David asked, should we have a Fixes tag? What about cc: stable?

Sure. But this fix tag depends on the commit 665575cff098b, so the fixes tag should be:

Fixes 5a90c155defa ("tmpfs: don't enable large folios if not supported")

Depends-on: 665575cff098b ("filemap: move prefaulting out of hot write path").

I don't think we need to cc stable, as it doesn't appear to cause any serious issues currently.

#9 lore raw
Quoted 6 lines · Baolin Wang
Quoted 3 lines · Lorenzo Stoakes
Quoted 2 lines · Lorenzo Stoakes
Quoted 8 lines
Quoted 1 line
Quoted 1 line

As David asked, should we have a Fixes tag? What about cc: stable?

Sure. But this fix tag depends on the commit 665575cff098b, so the fixes tag should be:

Fixes 5a90c155defa ("tmpfs: don't enable large folios if not supported")

Depends-on: 665575cff098b ("filemap: move prefaulting out of hot write path").

Oh is Depends-on a tag? Wasn't aware of it :>)

Quoted 3 lines

I don't think we need to cc stable, as it doesn't appear to cause any serious issues currently.

Ack ok!

Cheers, Lorenzo

maintainer
#10 lore raw
Quoted 9 lines · On Mon, 11 May 2026 13:03:04 +0100 Lorenzo Stoakes <[email protected]> wrote:
Quoted 8 lines · Baolin Wang
Quoted 4 lines · Lorenzo Stoakes
Quoted 3 lines · Lorenzo Stoakes

As David asked, should we have a Fixes tag? What about cc: stable?

Quoted 8 lines
Quoted 6 lines

Sure. But this fix tag depends on the commit 665575cff098b, so the fixes tag should be:

Fixes 5a90c155defa ("tmpfs: don't enable large folios if not supported")

Depends-on: 665575cff098b ("filemap: move prefaulting out of hot write path").

Oh is Depends-on a tag? Wasn't aware of it :>)

It is not.

hp2:/usr/src/25> grep -ri Depends-on Documentation | wc -l 0

But it is!

hp2:/usr/src/25> grep -ri Depends-on ../gitlog | wc -l 156

I actually removed it because a) various tools whine at me and b) we didn't cc:stable anyway.

Please let's not add new metadata without having told others what that metadata means?

"Fixes:" should be sufficient. I interpret Fixes: as "apply this to any kernel which contains <that>". Is more needed?

author reviewer
#11 lore raw
Quoted 25 lines · Andrew Morton
Quoted 9 lines · On Mon, 11 May 2026 13:03:04 +0100 Lorenzo Stoakes <[email protected]> wrote:
Quoted 8 lines · Baolin Wang
Quoted 4 lines · Lorenzo Stoakes
Quoted 3 lines · Lorenzo Stoakes

As David asked, should we have a Fixes tag? What about cc: stable?

Quoted 8 lines
Quoted 6 lines

Sure. But this fix tag depends on the commit 665575cff098b, so the fixes tag should be:

Fixes 5a90c155defa ("tmpfs: don't enable large folios if not supported")

Depends-on: 665575cff098b ("filemap: move prefaulting out of hot write path").

Oh is Depends-on a tag? Wasn't aware of it :>)

It is not.

hp2:/usr/src/25> grep -ri Depends-on Documentation | wc -l 0

Quoted 7 lines

But it is!

hp2:/usr/src/25> grep -ri Depends-on ../gitlog | wc -l 156

I actually removed it because a) various tools whine at me and b) we didn't cc:stable anyway.

Okay, I remember I've seen that tag :)

Quoted 6 lines

Please let's not add new metadata without having told others what that metadata means?

"Fixes:" should be sufficient. I interpret Fixes: as "apply this to any kernel which contains <that>". Is more needed?

My concern is that if someone backports this patch to an older kernel version without also backporting commit 665575cff098b, it would cause a performance regression.

Is there a good way to mark this kind of dependency on another patch? But I've already described this potential dependency in the commit message, so I'm fine with just adding the "Fixes:" tag.

maintainer
#12 lore raw
Quoted 4 lines · On Tue, 12 May 2026 08:55:05 +0800 Baolin Wang <[email protected]>…
Quoted 4 lines

Please let's not add new metadata without having told others what that metadata means?

Quoted 8 lines
Quoted 2 lines

"Fixes:" should be sufficient. I interpret Fixes: as "apply this to any kernel which contains <that>". Is more needed?

My concern is that if someone backports this patch to an older kernel version without also backporting commit 665575cff098b, it would cause a performance regression.

Is there a good way to mark this kind of dependency on another patch?

Not that I know of. Has someone sent 665575cff098b to -stable maintainers and asked them to treat it as Fixes: 5a90c155defa?

Quoted 2 lines

But I've already described this potential dependency in the commit message, so I'm fine with just adding the "Fixes:" tag.

Yeah, I guess the supporting text will help clear confusion.

But you're right - our tooling should be able to express such things.