Skip to contentSkip to conversation

man/man2/seccomp.2: Fix signal.h type conflict with glibc in seccomp.2

PATCH In review ChaseKnowlden 2 participants 2 messages May 20 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore

ChaseKnowlden

author
#0 lore raw

PATCH 1/1 man/man2/seccomp.2: Fix signal.h type conflict with glibc in seccomp.2

Signed-off-by ChaseKnowlden <[email protected]>
---
 man/man2/seccomp.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man/man2/seccomp.2 +1 -1
index e469f3997..8b8f2fc61 100644
@@ -16,7 +16,7 @@ Standard C library
 .BR "#include <linux/seccomp.h>" "  /* Definition of " SECCOMP_* " constants */"
 .BR "#include <linux/filter.h>" "   /* Definition of " "struct sock_fprog" " */"
 .BR "#include <linux/audit.h>" "    /* Definition of " AUDIT_* " constants */"
-.BR "#include <linux/signal.h>" "   /* Definition of " SIG* " constants */"
+.BR "#include <signal.h>" "   /* Definition of " SIG* " constants */"
 .BR "#include <sys/ptrace.h>" "     /* Definition of " PTRACE_* " constants */"
 .\" Kees Cook noted: Anything that uses SECCOMP_RET_TRACE returns will
 .\"                  need <sys/ptrace.h>
Signature · 1 line
2.54.0
maintainer
#1 lore raw

Hi ChaseKnowlden,

Quoted 1 line

Subject: Re: [PATCH] man/man2/seccomp.2: Fix signal.h type conflict with glibc in seccomp.2

Quoted 1 line · ChaseKnowlden
Signed-off-by ChaseKnowlden <[email protected]>

You should say something more in the commit message. What type conflict do you have? Why is this fix correct? It would be good to link to other sources that confirm this, and/or CC glibc.

Quoted 9 lines
---
 man/man2/seccomp.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man/man2/seccomp.2 +0 -0
index e469f3997..8b8f2fc61 100644

man/man2/seccomp.2 Standard C library · line 19

Quoted 5 lines
man/man2/seccomp.2 +1 -1
@@ -16,7 +16,7 @@ Standard C library
 .BR "#include <linux/seccomp.h>" "  /* Definition of " SECCOMP_* " constants */"
 .BR "#include <linux/filter.h>" "   /* Definition of " "struct sock_fprog" " */"
 .BR "#include <linux/audit.h>" "    /* Definition of " AUDIT_* " constants */"
-.BR "#include <linux/signal.h>" "   /* Definition of " SIG* " constants */"
+.BR "#include <signal.h>" "   /* Definition of " SIG* " constants */"

Please keep the alignment of the comments.

Have a lovely night!
Alex

Quoted 7 lines
man/man2/seccomp.2 +0 -0
 .BR "#include <sys/ptrace.h>" "     /* Definition of " PTRACE_* " constants */"
 .\" Kees Cook noted: Anything that uses SECCOMP_RET_TRACE returns will
 .\"                  need <sys/ptrace.h>
Signature · 1 line
2.54.0
Signature · 1 line
<https://www.alejandro-colomar.es>