Skip to contentSkip to conversation

afs: Fix error code in afs_extract_vl_addrs()

PATCH New Dan Carpenter 1 participant 1 message May 11

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 afs: Fix error code in afs_extract_vl_addrs()

The error codes on these paths are only set on the first iteration through the loop. Set the correct error code on every iteration.

Fixes 0a5143f2f89c ("afs: Implement VL server rotation")
---
 fs/afs/vl_list.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/afs/vl_list.c +3 -1
index 3e4966915ea4..003889cf0f18 100644
@@ -92,7 +92,7 @@ static struct afs_addr_list *afs_extract_vl_addrs(struct afs_net *net,
 {
 	struct afs_addr_list *alist;
 	const u8 *b = *_b;
-	int ret = -EINVAL;
+	int ret;
 
 	alist = afs_alloc_addrlist(nr_addrs);
 	if (!alist)
@@ -110,6 +110,7 @@ static struct afs_addr_list *afs_extract_vl_addrs(struct afs_net *net,
 		case DNS_ADDRESS_IS_IPV4:
 			if (end - b < 4) {
 				_leave(" = -EINVAL [short inet]");
+				ret = -EINVAL;
 				goto error;
 			}
 			memcpy(x, b, 4);
@@ -122,6 +123,7 @@ static struct afs_addr_list *afs_extract_vl_addrs(struct afs_net *net,
 		case DNS_ADDRESS_IS_IPV6:
 			if (end - b < 16) {
 				_leave(" = -EINVAL [short inet6]");
+				ret = -EINVAL;
 				goto error;
 			}
 			memcpy(x, b, 16);
Signature · 1 line
2.53.0