Skip to contentSkip to conversation

iio: frequency: adrf6780: replace usleep_range() with fsleep()

PATCH In review Stepan Ionichev 3 participants 3 messages May 11

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: frequency: adrf6780: replace usleep_range() with fsleep()

The ADRF6780 datasheet (Rev. D, page 23, ADC section) says:
"Wait approximately 200 us for the ADC to be ready."

fsleep(200) expands to the same usleep_range(200, 250). Use the flexible sleep helper, which picks the right primitive for the given microsecond delay.

Replace the generic "Recommended delay for the ADC to be ready" comment with the datasheet reference so the "why" of the wait is visible at the call site.

No functional change.

---
 drivers/iio/frequency/adrf6780.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/iio/frequency/adrf6780.c +5 -2
index 257fd31a0..9911b5273 100644
@@ -188,8 +188,11 @@ static int adrf6780_read_adc_raw(struct adrf6780_state *st, unsigned int *read_v
 	if (ret)
 		goto exit;
 
-	/* Recommended delay for the ADC to be ready*/
-	usleep_range(200, 250);
+	/*
+	 * Per ADRF6780 datasheet (Rev. D, page 23, ADC section),
+	 * wait approximately 200 us for the ADC to be ready.
+	 */
+	fsleep(200);
 
 	ret = __adrf6780_spi_read(st, ADRF6780_REG_ADC_OUTPUT, read_val);
 	if (ret)
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Stepan Ionichev

The ADRF6780 datasheet (Rev. D, page 23, ADC section) says:
"Wait approximately 200 us for the ADC to be ready."

fsleep(200) expands to the same usleep_range(200, 250). Use the flexible sleep helper, which picks the right primitive for the given microsecond delay.

Replace the generic "Recommended delay for the ADC to be ready" comment with the datasheet reference so the "why" of the wait is visible at the call site.

Quoted 6 lines

No functional change.

---
 drivers/iio/frequency/adrf6780.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

This seems fine to me.

Signature · 3 lines
Kind regards

CJD
Reviewed-by on v1 1/1
#2 lore raw
In reply to Stepan Ionichev
Quoted 7 lines · Stepan Ionichev

The ADRF6780 datasheet (Rev. D, page 23, ADC section) says:
"Wait approximately 200 us for the ADC to be ready."

fsleep(200) expands to the same usleep_range(200, 250). Use the flexible sleep helper, which picks the right primitive for the given microsecond delay.

Quoted 5 lines

Replace the generic "Recommended delay for the ADC to be ready" comment with the datasheet reference so the "why" of the wait is visible at the call site.

No functional change.

In this case the commit message is fine.

Signature · 2 lines
With Best Regards,
Andy Shevchenko