clk: hisilicon: allow COMPILE_TEST builds
PATCH 1/1 clk: hisilicon: allow COMPILE_TEST builds
The HiSilicon clock symbols already depend on ARCH_HISI or COMPILE_TEST, but the parent clock Makefile only descends into the hisilicon directory when ARCH_HISI is enabled.
Add a hidden family gate selected by the HiSilicon clock and reset symbols, default it for ARCH_HISI, and use it for the parent Makefile descent. This keeps existing platform builds unchanged while allowing compile-test coverage.
Tested with:
make LLVM=1 ARCH=loongarch drivers/clk/hisilicon/
--- drivers/clk/Makefile | 2 +- drivers/clk/hisilicon/Kconfig | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-)
drivers/clk/Makefile +1 -1
@@ -120,7 +120,7 @@ obj-y += bcm/ obj-$(CONFIG_ARCH_BERLIN) += berlin/ obj-$(CONFIG_COMMON_CLK_DAVINCI) += davinci/ obj-$(CONFIG_COMMON_CLK_ESWIN) += eswin/ -obj-$(CONFIG_ARCH_HISI) += hisilicon/ +obj-$(CONFIG_COMMON_CLK_HISI) += hisilicon/ obj-y += imgtec/ obj-y += imx/ obj-y += ingenic/
drivers/clk/hisilicon/Kconfig +14 -0
@@ -1,8 +1,13 @@ # SPDX-License-Identifier: GPL-2.0-only +config COMMON_CLK_HISI + bool + default ARCH_HISI + config COMMON_CLK_HI3516CV300 tristate "HI3516CV300 Clock Driver" depends on ARCH_HISI || COMPILE_TEST select RESET_HISI + select COMMON_CLK_HISI default ARCH_HISI help Build the clock driver for hi3516cv300.
@@ -11,6 +16,7 @@ config COMMON_CLK_HI3519 tristate "Hi3519 Clock Driver" depends on ARCH_HISI || COMPILE_TEST select RESET_HISI + select COMMON_CLK_HISI default ARCH_HISI help Build the clock driver for hi3519.
@@ -19,6 +25,7 @@ config COMMON_CLK_HI3559A bool "Hi3559A Clock Driver" depends on ARCH_HISI || COMPILE_TEST select RESET_HISI + select COMMON_CLK_HISI default ARCH_HISI help Build the clock driver for hi3559a.
@@ -26,6 +33,7 @@ config COMMON_CLK_HI3559A config COMMON_CLK_HI3660 bool "Hi3660 Clock Driver" depends on ARCH_HISI || COMPILE_TEST + select COMMON_CLK_HISI default ARCH_HISI help Build the clock driver for hi3660.
@@ -33,6 +41,7 @@ config COMMON_CLK_HI3660 config COMMON_CLK_HI3670 bool "Hi3670 Clock Driver" depends on ARCH_HISI || COMPILE_TEST + select COMMON_CLK_HISI default ARCH_HISI help Build the clock driver for hi3670.
@@ -41,6 +50,7 @@ config COMMON_CLK_HI3798CV200 tristate "Hi3798CV200 Clock Driver" depends on ARCH_HISI || COMPILE_TEST select RESET_HISI + select COMMON_CLK_HISI default ARCH_HISI help Build the clock driver for hi3798cv200.
@@ -48,6 +58,7 @@ config COMMON_CLK_HI3798CV200 config COMMON_CLK_HI6220 bool "Hi6220 Clock Driver" depends on ARCH_HISI || COMPILE_TEST + select COMMON_CLK_HISI default ARCH_HISI help Build the Hisilicon Hi6220 clock driver based on the common clock framework.
@@ -55,6 +66,7 @@ config COMMON_CLK_HI6220 config RESET_HISI bool "HiSilicon Reset Controller Driver" depends on ARCH_HISI || COMPILE_TEST + select COMMON_CLK_HISI select RESET_CONTROLLER help Build reset controller driver for HiSilicon device chipsets.
@@ -63,6 +75,7 @@ config STUB_CLK_HI6220 bool "Hi6220 Stub Clock Driver" if EXPERT depends on (COMMON_CLK_HI6220 || COMPILE_TEST) depends on MAILBOX + select COMMON_CLK_HISI default COMMON_CLK_HI6220 help Build the Hisilicon Hi6220 stub clock driver.
@@ -71,6 +84,7 @@ config STUB_CLK_HI3660 bool "Hi3660 Stub Clock Driver" if EXPERT depends on (COMMON_CLK_HI3660 || COMPILE_TEST) depends on MAILBOX + select COMMON_CLK_HISI default COMMON_CLK_HI3660 help Build the Hisilicon Hi3660 stub clock driver.
Signature · 1 line
2.54.0
Quoted 9 lines · Rosen Penev
The HiSilicon clock symbols already depend on
ARCH_HISIorCOMPILE_TEST, but the parent clockMakefileonly descends into the hisilicon directory whenARCH_HISIis enabled.Add a hidden family gate selected by the HiSilicon clock and reset symbols, default it for
ARCH_HISI, and use it for the parentMakefiledescent. This keeps existing platform builds unchanged while allowing compile-test coverage.
Quoted 5 lines
Tested with:
make LLVM=1 ARCH=loongarchdrivers/clk/hisilicon/Assisted-by Codex:GPT-5.5Signed-off-by Rosen Penev <[email protected]>
Quoted 11 lines · Brian Masney
Quoted 9 lines · Rosen Penev
The HiSilicon clock symbols already depend on
ARCH_HISIorCOMPILE_TEST, but the parent clockMakefileonly descends into the hisilicon directory whenARCH_HISIis enabled.Add a hidden family gate selected by the HiSilicon clock and reset symbols, default it for
ARCH_HISI, and use it for the parentMakefiledescent. This keeps existing platform builds unchanged while allowing compile-test coverage.
Quoted 7 lines
Quoted 5 lines
Tested with:
make LLVM=1 ARCH=loongarchdrivers/clk/hisilicon/Assisted-by Codex:GPT-5.5Signed-off-by Rosen Penev <[email protected]>Reviewed-by Brian Masney <[email protected]>
Should I resend?
Quoted 1 line
Hi Rosen,
Quoted 12 lines · Rosen Penev
Quoted 11 lines · Brian Masney
Quoted 9 lines · Rosen Penev
The HiSilicon clock symbols already depend on
ARCH_HISIorCOMPILE_TEST, but the parent clockMakefileonly descends into the hisilicon directory whenARCH_HISIis enabled.Add a hidden family gate selected by the HiSilicon clock and reset symbols, default it for
ARCH_HISI, and use it for the parentMakefiledescent. This keeps existing platform builds unchanged while allowing compile-test coverage.
Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
Tested with:
make LLVM=1 ARCH=loongarchdrivers/clk/hisilicon/Assisted-by Codex:GPT-5.5Signed-off-by Rosen Penev <[email protected]>Reviewed-by Brian Masney <[email protected]>Should I resend?
Yes, it missed the last merge window, and I submitted it to Stephen on June 29th via this git pull:
https://lore.kernel.org/linux-clk/[email protected]/T/#u
Let's see what he says. Hopefully you won't have to resend.
Brian