staging: media: atomisp: remove stale "Generated code" comments
Subsystems (4)
A message that is not in the archive (sent off-list or not yet received): 20260512-atomisp-remove-generated-comment-v3-1-97930e4e1ca8.ref@yahoo.pl
PATCH v3 1/1 staging: media: atomisp: remove stale "Generated code" comments
Remove the "Generated code: do not edit or commmit." comments and the resulting double blank lines from five files. This code is coupled with legacy firmware and will never be re-generated, so the comment is misleading and should be dropped entirely rather than having its typo fixed.
--- drivers/staging/media/atomisp/pci/ia_css_isp_configs.c | 2 -- drivers/staging/media/atomisp/pci/ia_css_isp_params.c | 1 - drivers/staging/media/atomisp/pci/ia_css_isp_params.h | 2 -- drivers/staging/media/atomisp/pci/ia_css_isp_states.c | 1 - drivers/staging/media/atomisp/pci/ia_css_isp_states.h | 1 - 5 files changed, 7 deletions(-)
drivers/staging/media/atomisp/pci/ia_css_isp_configs.c +0 -2
@@ -4,8 +4,6 @@* Copyright (c) 2015, Intel Corporation. */ -/* Generated code: do not edit or commmit. */ -#define IA_CSS_INCLUDE_CONFIGURATIONS #include "ia_css_pipeline.h" #include "ia_css_isp_configs.h"
drivers/staging/media/atomisp/pci/ia_css_isp_params.c +0 -1
@@ -48,7 +48,6 @@#include "isp/kernels/eed1_8/ia_css_eed1_8.host.h" #include "isp/kernels/bnlm/ia_css_bnlm.host.h" #include "isp/kernels/conversion/conversion_1.0/ia_css_conversion.host.h" -/* Generated code: do not edit or commmit. */ #include "ia_css_pipeline.h" #include "ia_css_isp_params.h"
drivers/staging/media/atomisp/pci/ia_css_isp_params.h +0 -2
@@ -4,8 +4,6 @@* Copyright (c) 2015, Intel Corporation. */ -/* Generated code: do not edit or commmit. */ -#ifndef _IA_CSS_ISP_PARAM_H#define _IA_CSS_ISP_PARAM_H
drivers/staging/media/atomisp/pci/ia_css_isp_states.c +0 -1
@@ -3,7 +3,6 @@* Support for Intel Camera Imaging ISP subsystem. * Copyright (c) 2015, Intel Corporation. */ -/* Generated code: do not edit or commmit. */ #include "ia_css_pipeline.h" #include "ia_css_isp_states.h"
drivers/staging/media/atomisp/pci/ia_css_isp_states.h +0 -1
@@ -15,7 +15,6 @@#include "isp/kernels/ynr/ynr_1.0/ia_css_ynr.host.h" #include "isp/kernels/dpc2/ia_css_dpc2.host.h" #include "isp/kernels/eed1_8/ia_css_eed1_8.host.h" -/* Generated code: do not edit or commmit. */ #ifndef _IA_CSS_ISP_STATE_H#define _IA_CSS_ISP_STATE_H
---
base-commit: 6abf0b2df0b1c2205a4c0591425e6461afa62edb
change-id: 20260512-atomisp-remove-generated-comment-0f6912dc8cb8
Best regards,
Signature · 1 line
Tomasz Unger <[email protected]>
Quoted 7 lines · Tomasz Unger
Remove the "Generated code: do not edit or commmit." comments and the resulting double blank lines from five files. This code is coupled with legacy firmware and will never be re-generated, so the comment is misleading and should be dropped entirely rather than having its typo fixed.
Suggested-by Dan Carpenter <[email protected]>
Seems like a flashing tag. I dunno what Dan suggested here, but please, double check that tags reflect the reality.
Code wise LGTM,
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Tomasz Unger
Remove the "Generated code: do not edit or commmit." comments and the resulting double blank lines from five files. This code is coupled with legacy firmware and will never be re-generated, so the comment is misleading and should be dropped entirely rather than having its typo fixed.
Suggested-by Dan Carpenter <[email protected]>
I didn't really suggest it. I just pointed out that you need to delete the blank line following it so the right way to do this would be to put a little note under the ---
Quoted 2 lines
Signed-off-by Tomasz Unger <[email protected]>---
^^^
cut off line, here.
v3: remove trailing blank lines (as noted by Dan Carpenter)
Although I'm also happy to boost my tag count so I don't really mind being credited either.
regards,
dan carpenter