media: v4l2-common: Add helper function media_bus_fmt_to_csi2_(bpp|dt)()
Subsystems (2)
Frank Li
maintainerPATCH v4 1/1 media: v4l2-common: Add helper function media_bus_fmt_to_csi2_(bpp|dt)()
Add helper function media_bus_fmt_to_csi2_bpp() to get media bus fmt's bpp to reduce codes such as
static const struct imx7_csi_pixfmt pixel_formats[] = {
{
.fourcc = V4L2_PIX_FMT_UYVY,
.codes = IMX_BUS_FMTS(
MEDIA_BUS_FMT_UYVY8_2X8,
MEDIA_BUS_FMT_UYVY8_1X16
),
.yuv = true,
.bpp = 16,
},
.....bpp can be removed from pixel_formats with this helper function.
CSI2 data type is defined by MIPI Camera Serial Interface 2 Spec Ver4.1. See section 9.4.
Add helper function media_bus_fmt_to_csi2_dt() to convert media bus fmt to MIPI defined data type and avoid below duplicated static array in each CSI2 drivers.
{
.code = MEDIA_BUS_FMT_UYVY8_1X16,
.data_type = MIPI_CSI2_DT_YUV422_8B,
}Only add known map for dt type. Need update media_bus_fmt_info when new mapping used.
---
Change in v4
- add space after }
- fix bpps value when m_nXk (m.n*k)
- add comments about bpp defination. only convert from suffix of MEDIA_BUS_FMT_*
- move struct media_bus_fmt_info to c file
- change field name fmt to code
There are some open at
https://lore.kernel.org/linux-media/[email protected]/.
this version just fix known review comments.
Change in v3:
- squash two help function patch to one.
- use media_bus_fmt_info to do map.
--- drivers/media/v4l2-core/v4l2-common.c | 178 ++++++++++++++++++++++++++ include/media/mipi-csi2.h | 26 ++++ 2 files changed, 204 insertions(+)
drivers/media/v4l2-core/v4l2-common.c +178 -0
@@ -46,6 +46,7 @@#include <linux/uaccess.h> #include <asm/io.h> #include <asm/div64.h> +#include <media/mipi-csi2.h> #include <media/v4l2-common.h> #include <media/v4l2-device.h> #include <media/v4l2-ctrls.h>
@@ -806,3 +807,180 @@ struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id,return clk_hw->clk; }EXPORT_SYMBOL_GPL (__devm_v4l2_sensor_clk_get); + +/** +* struct media_bus_fmt_info - information about a media bus format +* @code: media bus format identifier (MEDIA_BUS_FMT_*) +* @dt: data type define in MIPI spec (MIPI_CSI2_DT *) +* @bpp: bit width per pixel, which is suffix from MEDIA_BUS_FMT_*, no pad. no +* compressed data. +*/ +struct media_bus_fmt_info { +u32 code; +u8 dt; +u8 bpp; +}; + +static const struct media_bus_fmt_info media_bus_fmt_info[] = { + { .code =MEDIA_BUS_FMT_RGB444_1X12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB565_1X16 , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_BGR565_2X8_BE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_BGR565_2X8_LE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB565_2X8_BE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB565_2X8_LE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB666_1X18 , .bpp =18 }, + { .code =MEDIA_BUS_FMT_RGB666_2X9_BE , .bpp =18 }, + { .code =MEDIA_BUS_FMT_BGR666_1X18 , .bpp =18 }, + { .code =MEDIA_BUS_FMT_RBG888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB666_1X24_CPADHI , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_BGR666_1X24_CPADHI , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB565_1X24_CPADHI , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB666_1X7X3_SPWG , .bpp =21 }, + { .code =MEDIA_BUS_FMT_BGR888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_BGR888_3X8 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_GBR888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_2X12_BE , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_2X12_LE , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_3X8 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_3X8_DELTA , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_1X7X4_SPWG , .bpp =28 }, + { .code =MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA , .bpp =28 }, + { .code =MEDIA_BUS_FMT_RGB666_1X30_CPADLO , .bpp =30 }, + { .code =MEDIA_BUS_FMT_RGB888_1X30_CPADLO , .bpp =30 }, + { .code =MEDIA_BUS_FMT_ARGB8888_1X32 , .bpp =32 }, + { .code =MEDIA_BUS_FMT_RGB888_1X32_PADHI , .bpp =32 }, + { .code =MEDIA_BUS_FMT_RGB101010_1X30 , .bpp =30 }, + { .code =MEDIA_BUS_FMT_RGB101010_1X7X5_SPWG , .bpp =35 }, + { .code =MEDIA_BUS_FMT_RGB101010_1X7X5_JEIDA , .bpp =35 }, + { .code =MEDIA_BUS_FMT_RGB666_1X36_CPADLO , .bpp =36 }, + { .code =MEDIA_BUS_FMT_RGB888_1X36_CPADLO , .bpp =36 }, + { .code =MEDIA_BUS_FMT_RGB121212_1X36 , .bpp =36 }, + { .code =MEDIA_BUS_FMT_RGB161616_1X48 , .bpp =48 }, + + { .code =MEDIA_BUS_FMT_Y8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_UV8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_UYVY8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_VYUY8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_YUYV8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_YVYU8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_UYVY8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_VYUY8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YUYV8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YVYU8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_Y10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_Y10_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_UYVY10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_VYUY10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YUYV10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YVYU10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_Y12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_UYVY12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_VYUY12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUYV12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YVYU12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_Y14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_Y16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_UYVY8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_VYUY8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YUYV8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YVYU8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YDYUYDYV8_1X16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_UYVY10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_VYUY10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YUYV10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YVYU10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_VUY8_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUV8_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_UYYVYY8_0_5X24 , .dt =MIPI_CSI2_DT_YUV420_8B , .bpp =12 }, + { .code =MEDIA_BUS_FMT_UYVY12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_VYUY12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUYV12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YVYU12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUV10_1X30 , .bpp =30 }, + { .code =MEDIA_BUS_FMT_UYYVYY10_0_5X30 , .bpp =15 }, + { .code =MEDIA_BUS_FMT_AYUV8_1X32 , .bpp =32 }, + { .code =MEDIA_BUS_FMT_UYYVYY12_0_5X36 , .bpp =18 }, + { .code =MEDIA_BUS_FMT_YUV12_1X36 , .bpp =36 }, + { .code =MEDIA_BUS_FMT_YUV16_1X48 , .bpp =48 }, + { .code =MEDIA_BUS_FMT_UYYVYY16_0_5X48 , .bpp =24 }, + + { .code =MEDIA_BUS_FMT_SBGGR8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGBRG8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGRBG8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SRGGB8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SBGGR10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGBRG10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGRBG10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SRGGB10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SGBRG10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SGRBG10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SRGGB10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SBGGR12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SGBRG12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SGRBG12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SRGGB12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SBGGR14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SGBRG14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SGRBG14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SRGGB14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SBGGR16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SGBRG16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SGRBG16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SRGGB16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + + { .code =MEDIA_BUS_FMT_JPEG_1X8 , .bpp =8 }, + + { .code =MEDIA_BUS_FMT_S5C_UYVY_JPEG_1X8 , .bpp =8 }, + + { .code =MEDIA_BUS_FMT_AHSV8888_1X32 , .bpp =8 }, + + { .code =MEDIA_BUS_FMT_META_8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_META_10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_META_12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_META_14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_META_16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_META_20 , .bpp =20 }, + { .code =MEDIA_BUS_FMT_META_24 , .bpp =24 }, +}; + +static const struct media_bus_fmt_info *media_bus_fmt_info_get (u32 bus_fmt) +{ +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (media_bus_fmt_info); i++) { +if (media_bus_fmt_info[i].code == bus_fmt) +return &media_bus_fmt_info[i]; + } + +return NULL ; +} + +u32 media_bus_fmt_to_csi2_dt (int bus_fmt) +{ +const struct media_bus_fmt_info *info =media_bus_fmt_info_get (bus_fmt); + +return info ? info->dt :MIPI_CSI2_DT_INVALIDATE ; +} +EXPORT_SYMBOL_GPL (media_bus_fmt_to_csi2_dt); + +u32 media_bus_fmt_to_csi2_bpp (int bus_fmt) +{ +const struct media_bus_fmt_info *info =media_bus_fmt_info_get (bus_fmt); + +return info ? info->bpp :0 ; +} +EXPORT_SYMBOL_GPL (media_bus_fmt_to_csi2_bpp);
include/media/mipi-csi2.h +26 -0
@@ -44,4 +44,30 @@#define MIPI_CSI2_DT_RAW20 0x2f#define MIPI_CSI2_DT_USER_DEFINED (n) (0x30 + (n))/* 0..7 */ +/* Use one undefined value in spec */ +#define MIPI_CSI2_DT_INVALIDATE 0xff + +/** +* media_bus_fmt_to_csi2_dt - Get MIPI CSI2 data type from media bus format +* +* @bus_fmt: media bus format identifier (MEDIA_BUS_FMT_*) +* +* return MIPI CSI2 data type MIPI_CSI2_DT_*, MIPI_CSI2_DT_INVALIDATE means +* can't get data type from bus_fmt. +*/ +u32 media_bus_fmt_to_csi2_dt (int bus_fmt); + +/** +* media_bus_fmt_to_csi2_bpp - Get media bus format's bit width per pixel +* +* @bus_fmt: media bus format identifier (MEDIA_BUS_FMT_*) +* +* returns bit width per pixel, 0 is invalidate width, which can't get from +* bus_fmt. +* +* Notes: this bpp is suffix from MEDIA_BUS_FMT_*, no pad, not for compressed +* data. +*/ +u32 media_bus_fmt_to_csi2_bpp (int bus_fmt); +#endif /* _MEDIA_MIPI_CSI2_H */
Signature · 1 line
2.43.0
Frank Li
maintainerQuoted 29 lines · Frank Li
Add helper function
media_bus_fmt_to_csi2_bpp()to get media bus fmt's bpp to reduce codes such asstatic const struct imx7_csi_pixfmt pixel_formats[] = { { .fourcc = V4L2_PIX_FMT_UYVY, .codes = IMX_BUS_FMTS( MEDIA_BUS_FMT_UYVY8_2X8, MEDIA_BUS_FMT_UYVY8_1X16 ), .yuv = true, .bpp = 16, }, .....bpp can be removed from
pixel_formatswith this helper function.CSI2 data type is defined by MIPI Camera Serial Interface 2 Spec Ver4.1. See section 9.4.
Add helper function
media_bus_fmt_to_csi2_dt()to convert media bus fmt to MIPI defined data type and avoid below duplicated static array in each CSI2 drivers.{ .code = MEDIA_BUS_FMT_UYVY8_1X16, .data_type = MIPI_CSI2_DT_YUV422_8B, }
Quoted 5 lines
Only add known map for dt type. Need update
media_bus_fmt_infowhen new mapping used.Signed-off-by Frank Li <[email protected]>---
I just pick updated single patch from old thread
https://lore.kernel.org/linux-media/[email protected]/
for the below thread reference
https://lore.kernel.org/linux-media/[email protected]/T/#t
Frank
Quoted 250 lines
Change in v4
- add space after }
- fix bpps value whenm_nXk(m.n*k)
- add comments about bpp defination. only convert from suffix of MEDIA_BUS_FMT_*
- move structmedia_bus_fmt_infoto c file
- change field name fmt to code
There are some open at
https://lore.kernel.org/linux-media/[email protected]/.
this version just fix known review comments.Change in v3:
- squash two help function patch to one.
- usemedia_bus_fmt_infoto do map.--- drivers/media/v4l2-core/v4l2-common.c | 178 ++++++++++++++++++++++++++ include/media/mipi-csi2.h | 26 ++++ 2 files changed, 204 insertions(+)drivers/media/v4l2-core/v4l2-common.c +178
-0@@ -46,6 +46,7 @@#include <linux/uaccess.h> #include <asm/io.h> #include <asm/div64.h> +#include <media/mipi-csi2.h> #include <media/v4l2-common.h> #include <media/v4l2-device.h> #include <media/v4l2-ctrls.h> @@ -806,3 +807,180 @@ struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id,return clk_hw->clk; }EXPORT_SYMBOL_GPL (__devm_v4l2_sensor_clk_get); + +/** +* struct media_bus_fmt_info - information about a media bus format +* @code: media bus format identifier (MEDIA_BUS_FMT_*) +* @dt: data type define in MIPI spec (MIPI_CSI2_DT *) +* @bpp: bit width per pixel, which is suffix from MEDIA_BUS_FMT_*, no pad. no +* compressed data. +*/ +struct media_bus_fmt_info { +u32 code; +u8 dt; +u8 bpp; +}; + +static const struct media_bus_fmt_info media_bus_fmt_info[] = { + { .code =MEDIA_BUS_FMT_RGB444_1X12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB565_1X16 , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_BGR565_2X8_BE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_BGR565_2X8_LE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB565_2X8_BE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB565_2X8_LE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB666_1X18 , .bpp =18 }, + { .code =MEDIA_BUS_FMT_RGB666_2X9_BE , .bpp =18 }, + { .code =MEDIA_BUS_FMT_BGR666_1X18 , .bpp =18 }, + { .code =MEDIA_BUS_FMT_RBG888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB666_1X24_CPADHI , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_BGR666_1X24_CPADHI , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB565_1X24_CPADHI , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB666_1X7X3_SPWG , .bpp =21 }, + { .code =MEDIA_BUS_FMT_BGR888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_BGR888_3X8 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_GBR888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_2X12_BE , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_2X12_LE , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_3X8 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_3X8_DELTA , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_1X7X4_SPWG , .bpp =28 }, + { .code =MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA , .bpp =28 }, + { .code =MEDIA_BUS_FMT_RGB666_1X30_CPADLO , .bpp =30 }, + { .code =MEDIA_BUS_FMT_RGB888_1X30_CPADLO , .bpp =30 }, + { .code =MEDIA_BUS_FMT_ARGB8888_1X32 , .bpp =32 }, + { .code =MEDIA_BUS_FMT_RGB888_1X32_PADHI , .bpp =32 }, + { .code =MEDIA_BUS_FMT_RGB101010_1X30 , .bpp =30 }, + { .code =MEDIA_BUS_FMT_RGB101010_1X7X5_SPWG , .bpp =35 }, + { .code =MEDIA_BUS_FMT_RGB101010_1X7X5_JEIDA , .bpp =35 }, + { .code =MEDIA_BUS_FMT_RGB666_1X36_CPADLO , .bpp =36 }, + { .code =MEDIA_BUS_FMT_RGB888_1X36_CPADLO , .bpp =36 }, + { .code =MEDIA_BUS_FMT_RGB121212_1X36 , .bpp =36 }, + { .code =MEDIA_BUS_FMT_RGB161616_1X48 , .bpp =48 }, + + { .code =MEDIA_BUS_FMT_Y8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_UV8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_UYVY8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_VYUY8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_YUYV8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_YVYU8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_UYVY8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_VYUY8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YUYV8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YVYU8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_Y10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_Y10_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_UYVY10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_VYUY10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YUYV10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YVYU10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_Y12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_UYVY12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_VYUY12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUYV12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YVYU12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_Y14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_Y16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_UYVY8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_VYUY8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YUYV8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YVYU8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YDYUYDYV8_1X16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_UYVY10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_VYUY10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YUYV10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YVYU10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_VUY8_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUV8_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_UYYVYY8_0_5X24 , .dt =MIPI_CSI2_DT_YUV420_8B , .bpp =12 }, + { .code =MEDIA_BUS_FMT_UYVY12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_VYUY12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUYV12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YVYU12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUV10_1X30 , .bpp =30 }, + { .code =MEDIA_BUS_FMT_UYYVYY10_0_5X30 , .bpp =15 }, + { .code =MEDIA_BUS_FMT_AYUV8_1X32 , .bpp =32 }, + { .code =MEDIA_BUS_FMT_UYYVYY12_0_5X36 , .bpp =18 }, + { .code =MEDIA_BUS_FMT_YUV12_1X36 , .bpp =36 }, + { .code =MEDIA_BUS_FMT_YUV16_1X48 , .bpp =48 }, + { .code =MEDIA_BUS_FMT_UYYVYY16_0_5X48 , .bpp =24 }, + + { .code =MEDIA_BUS_FMT_SBGGR8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGBRG8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGRBG8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SRGGB8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SBGGR10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGBRG10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGRBG10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SRGGB10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SGBRG10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SGRBG10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SRGGB10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SBGGR12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SGBRG12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SGRBG12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SRGGB12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SBGGR14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SGBRG14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SGRBG14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SRGGB14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SBGGR16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SGBRG16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SGRBG16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SRGGB16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + + { .code =MEDIA_BUS_FMT_JPEG_1X8 , .bpp =8 }, + + { .code =MEDIA_BUS_FMT_S5C_UYVY_JPEG_1X8 , .bpp =8 }, + + { .code =MEDIA_BUS_FMT_AHSV8888_1X32 , .bpp =8 }, + + { .code =MEDIA_BUS_FMT_META_8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_META_10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_META_12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_META_14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_META_16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_META_20 , .bpp =20 }, + { .code =MEDIA_BUS_FMT_META_24 , .bpp =24 }, +}; + +static const struct media_bus_fmt_info *media_bus_fmt_info_get (u32 bus_fmt) +{ +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (media_bus_fmt_info); i++) { +if (media_bus_fmt_info[i].code == bus_fmt) +return &media_bus_fmt_info[i]; + } + +return NULL ; +} + +u32 media_bus_fmt_to_csi2_dt (int bus_fmt) +{ +const struct media_bus_fmt_info *info =media_bus_fmt_info_get (bus_fmt); + +return info ? info->dt :MIPI_CSI2_DT_INVALIDATE ; +} +EXPORT_SYMBOL_GPL (media_bus_fmt_to_csi2_dt); + +u32 media_bus_fmt_to_csi2_bpp (int bus_fmt) +{ +const struct media_bus_fmt_info *info =media_bus_fmt_info_get (bus_fmt); + +return info ? info->bpp :0 ; +} +EXPORT_SYMBOL_GPL (media_bus_fmt_to_csi2_bpp);include/media/mipi-csi2.h +26
-1@@ -44,4 +44,30 @@#define MIPI_CSI2_DT_RAW20 0x2f#define MIPI_CSI2_DT_USER_DEFINED (n) (0x30 + (n))/* 0..7 */ +/* Use one undefined value in spec */ +#define MIPI_CSI2_DT_INVALIDATE 0xff + +/** +* media_bus_fmt_to_csi2_dt - Get MIPI CSI2 data type from media bus format +* +* @bus_fmt: media bus format identifier (MEDIA_BUS_FMT_*) +* +* return MIPI CSI2 data type MIPI_CSI2_DT_*, MIPI_CSI2_DT_INVALIDATE means +* can't get data type from bus_fmt. +*/ +u32 media_bus_fmt_to_csi2_dt (int bus_fmt); + +/** +* media_bus_fmt_to_csi2_bpp - Get media bus format's bit width per pixel +* +* @bus_fmt: media bus format identifier (MEDIA_BUS_FMT_*) +* +* returns bit width per pixel, 0 is invalidate width, which can't get from +* bus_fmt. +* +* Notes: this bpp is suffix from MEDIA_BUS_FMT_*, no pad, not for compressed +* data. +*/ +u32 media_bus_fmt_to_csi2_bpp (int bus_fmt); +#endif /* _MEDIA_MIPI_CSI2_H */ --2.43.0
Hi Frank,
Thanks for the update. A few minor comments...
Quoted 214 lines · Frank Li
Add helper function
media_bus_fmt_to_csi2_bpp()to get media bus fmt's bpp to reduce codes such asstatic const struct imx7_csi_pixfmt pixel_formats[] = { { .fourcc = V4L2_PIX_FMT_UYVY, .codes = IMX_BUS_FMTS( MEDIA_BUS_FMT_UYVY8_2X8, MEDIA_BUS_FMT_UYVY8_1X16 ), .yuv = true, .bpp = 16, }, .....bpp can be removed from
pixel_formatswith this helper function.CSI2 data type is defined by MIPI Camera Serial Interface 2 Spec Ver4.1. See section 9.4.
Add helper function
media_bus_fmt_to_csi2_dt()to convert media bus fmt to MIPI defined data type and avoid below duplicated static array in each CSI2 drivers.{ .code = MEDIA_BUS_FMT_UYVY8_1X16, .data_type = MIPI_CSI2_DT_YUV422_8B, }Only add known map for dt type. Need update
media_bus_fmt_infowhen new mapping used.Signed-off-by Frank Li <[email protected]>---
Change in v4
- add space after }
- fix bpps value whenm_nXk(m.n*k)
- add comments about bpp defination. only convert from suffix of MEDIA_BUS_FMT_*
- move structmedia_bus_fmt_infoto c file
- change field name fmt to code
There are some open at
https://lore.kernel.org/linux-media/[email protected]/.
this version just fix known review comments.Change in v3:
- squash two help function patch to one.
- usemedia_bus_fmt_infoto do map.--- drivers/media/v4l2-core/v4l2-common.c | 178 ++++++++++++++++++++++++++ include/media/mipi-csi2.h | 26 ++++ 2 files changed, 204 insertions(+)drivers/media/v4l2-core/v4l2-common.c +146
-0@@ -46,6 +46,7 @@#include <linux/uaccess.h> #include <asm/io.h> #include <asm/div64.h> +#include <media/mipi-csi2.h> #include <media/v4l2-common.h> #include <media/v4l2-device.h> #include <media/v4l2-ctrls.h> @@ -806,3 +807,180 @@ struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id,return clk_hw->clk; }EXPORT_SYMBOL_GPL (__devm_v4l2_sensor_clk_get); + +/** +* struct media_bus_fmt_info - information about a media bus format +* @code: media bus format identifier (MEDIA_BUS_FMT_*) +* @dt: data type define in MIPI spec (MIPI_CSI2_DT *) +* @bpp: bit width per pixel, which is suffix from MEDIA_BUS_FMT_*, no pad. no +* compressed data. +*/ +struct media_bus_fmt_info { +u32 code; +u8 dt; +u8 bpp; +}; + +static const struct media_bus_fmt_info media_bus_fmt_info[] = { + { .code =MEDIA_BUS_FMT_RGB444_1X12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB565_1X16 , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_BGR565_2X8_BE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_BGR565_2X8_LE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB565_2X8_BE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB565_2X8_LE , .dt =MIPI_CSI2_DT_RGB565 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_RGB666_1X18 , .bpp =18 }, + { .code =MEDIA_BUS_FMT_RGB666_2X9_BE , .bpp =18 }, + { .code =MEDIA_BUS_FMT_BGR666_1X18 , .bpp =18 }, + { .code =MEDIA_BUS_FMT_RBG888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB666_1X24_CPADHI , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_BGR666_1X24_CPADHI , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB565_1X24_CPADHI , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB666_1X7X3_SPWG , .bpp =21 }, + { .code =MEDIA_BUS_FMT_BGR888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_BGR888_3X8 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_GBR888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_1X24 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_2X12_BE , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_2X12_LE , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_3X8 , .dt =MIPI_CSI2_DT_RGB888 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_3X8_DELTA , .bpp =24 }, + { .code =MEDIA_BUS_FMT_RGB888_1X7X4_SPWG , .bpp =28 }, + { .code =MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA , .bpp =28 }, + { .code =MEDIA_BUS_FMT_RGB666_1X30_CPADLO , .bpp =30 }, + { .code =MEDIA_BUS_FMT_RGB888_1X30_CPADLO , .bpp =30 }, + { .code =MEDIA_BUS_FMT_ARGB8888_1X32 , .bpp =32 }, + { .code =MEDIA_BUS_FMT_RGB888_1X32_PADHI , .bpp =32 }, + { .code =MEDIA_BUS_FMT_RGB101010_1X30 , .bpp =30 }, + { .code =MEDIA_BUS_FMT_RGB101010_1X7X5_SPWG , .bpp =35 }, + { .code =MEDIA_BUS_FMT_RGB101010_1X7X5_JEIDA , .bpp =35 }, + { .code =MEDIA_BUS_FMT_RGB666_1X36_CPADLO , .bpp =36 }, + { .code =MEDIA_BUS_FMT_RGB888_1X36_CPADLO , .bpp =36 }, + { .code =MEDIA_BUS_FMT_RGB121212_1X36 , .bpp =36 }, + { .code =MEDIA_BUS_FMT_RGB161616_1X48 , .bpp =48 }, + + { .code =MEDIA_BUS_FMT_Y8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_UV8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_UYVY8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_VYUY8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_YUYV8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_YVYU8_1_5X8 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_UYVY8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_VYUY8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YUYV8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YVYU8_2X8 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_Y10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_Y10_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_UYVY10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_VYUY10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YUYV10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YVYU10_2X10 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_Y12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_UYVY12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_VYUY12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUYV12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YVYU12_2X12 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_Y14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_Y16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_UYVY8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_VYUY8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YUYV8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YVYU8_1X16 , .dt =MIPI_CSI2_DT_YUV422_8B , .bpp =16 }, + { .code =MEDIA_BUS_FMT_YDYUYDYV8_1X16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_UYVY10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_VYUY10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YUYV10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_YVYU10_1X20 , .dt =MIPI_CSI2_DT_YUV422_10B , .bpp =20 }, + { .code =MEDIA_BUS_FMT_VUY8_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUV8_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_UYYVYY8_0_5X24 , .dt =MIPI_CSI2_DT_YUV420_8B , .bpp =12 }, + { .code =MEDIA_BUS_FMT_UYVY12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_VYUY12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUYV12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YVYU12_1X24 , .bpp =24 }, + { .code =MEDIA_BUS_FMT_YUV10_1X30 , .bpp =30 }, + { .code =MEDIA_BUS_FMT_UYYVYY10_0_5X30 , .bpp =15 }, + { .code =MEDIA_BUS_FMT_AYUV8_1X32 , .bpp =32 }, + { .code =MEDIA_BUS_FMT_UYYVYY12_0_5X36 , .bpp =18 }, + { .code =MEDIA_BUS_FMT_YUV12_1X36 , .bpp =36 }, + { .code =MEDIA_BUS_FMT_YUV16_1X48 , .bpp =48 }, + { .code =MEDIA_BUS_FMT_UYYVYY16_0_5X48 , .bpp =24 }, + + { .code =MEDIA_BUS_FMT_SBGGR8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGBRG8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGRBG8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SRGGB8_1X8 , .dt =MIPI_CSI2_DT_RAW8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SBGGR10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGBRG10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGRBG10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SRGGB10_ALAW8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_BE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_LE , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SBGGR10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SGBRG10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SGRBG10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SRGGB10_1X10 , .dt =MIPI_CSI2_DT_RAW10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_SBGGR12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SGBRG12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SGRBG12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SRGGB12_1X12 , .dt =MIPI_CSI2_DT_RAW12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_SBGGR14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SGBRG14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SGRBG14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SRGGB14_1X14 , .dt =MIPI_CSI2_DT_RAW14 , .bpp =14 }, + { .code =MEDIA_BUS_FMT_SBGGR16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SGBRG16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SGRBG16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + { .code =MEDIA_BUS_FMT_SRGGB16_1X16 , .dt =MIPI_CSI2_DT_RAW16 , .bpp =16 }, + + { .code =MEDIA_BUS_FMT_JPEG_1X8 , .bpp =8 }, + + { .code =MEDIA_BUS_FMT_S5C_UYVY_JPEG_1X8 , .bpp =8 }, + + { .code =MEDIA_BUS_FMT_AHSV8888_1X32 , .bpp =8 }, + + { .code =MEDIA_BUS_FMT_META_8 , .bpp =8 }, + { .code =MEDIA_BUS_FMT_META_10 , .bpp =10 }, + { .code =MEDIA_BUS_FMT_META_12 , .bpp =12 }, + { .code =MEDIA_BUS_FMT_META_14 , .bpp =14 },
drivers/media/v4l2-core/v4l2-common.c struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id, · line 964
Quoted 10 lines
drivers/media/v4l2-core/v4l2-common.c +10
-0+ { .code = MEDIA_BUS_FMT_META_16, .bpp = 16 }, + { .code = MEDIA_BUS_FMT_META_20, .bpp = 20 }, + { .code = MEDIA_BUS_FMT_META_24, .bpp = 24 }, +}; + +static const struct media_bus_fmt_info *media_bus_fmt_info_get (u32 bus_fmt) +{ +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (media_bus_fmt_info); i++) {
Can be defined here.
drivers/media/v4l2-core/v4l2-common.c struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id, · line 972
Quoted 8 lines
drivers/media/v4l2-core/v4l2-common.c +8
-0+if (media_bus_fmt_info[i].code == bus_fmt) +return &media_bus_fmt_info[i]; + } + +return NULL ; +} + +u32 media_bus_fmt_to_csi2_dt (int bus_fmt)
u32 for bus_fmt.
drivers/media/v4l2-core/v4l2-common.c struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id, · line 980
Quoted 8 lines
drivers/media/v4l2-core/v4l2-common.c +8
-0+{ +const struct media_bus_fmt_info *info =media_bus_fmt_info_get (bus_fmt); + +return info ? info->dt :MIPI_CSI2_DT_INVALIDATE ; +} +EXPORT_SYMBOL_GPL (media_bus_fmt_to_csi2_dt); + +u32 media_bus_fmt_to_csi2_bpp (int bus_fmt)
Ditto.
Quoted 11 lines
drivers/media/v4l2-core/v4l2-common.c +6
-0+{ +const struct media_bus_fmt_info *info =media_bus_fmt_info_get (bus_fmt); + +return info ? info->bpp :0 ; +} +EXPORT_SYMBOL_GPL (media_bus_fmt_to_csi2_bpp);include/media/mipi-csi2.h +0
-0
include/media/mipi-csi2.h line 48
Quoted 5 lines
include/media/mipi-csi2.h +2
-0@@ -44,4 +44,30 @@#define MIPI_CSI2_DT_RAW20 0x2f#define MIPI_CSI2_DT_USER_DEFINED (n) (0x30 + (n))/* 0..7 */ +/* Use one undefined value in spec */ +#define MIPI_CSI2_DT_INVALIDATE 0xff
s/INVALID\KATE//
include/media/mipi-csi2.h line 55
Quoted 7 lines
include/media/mipi-csi2.h +7
-0+ +/** +* media_bus_fmt_to_csi2_dt - Get MIPI CSI2 data type from media bus format +* +* @bus_fmt: media bus format identifier (MEDIA_BUS_FMT_*) +* +* return MIPI CSI2 data type MIPI_CSI2_DT_*, MIPI_CSI2_DT_INVALIDATE means
* Return: ...
include/media/mipi-csi2.h line 58
Quoted 3 lines
include/media/mipi-csi2.h +3
-0+* can't get data type from bus_fmt. +*/ +u32 media_bus_fmt_to_csi2_dt (int bus_fmt);
I also realised you'll need linux/types.h for u32.
include/media/mipi-csi2.h line 61
Quoted 3 lines
include/media/mipi-csi2.h +3
-0+ +/** +* media_bus_fmt_to_csi2_bpp - Get media bus format's bit width per pixel
s/width per pixel/depth/
?
include/media/mipi-csi2.h line 65
Quoted 4 lines
include/media/mipi-csi2.h +4
-0+* +* @bus_fmt: media bus format identifier (MEDIA_BUS_FMT_*) +* +* returns bit width per pixel, 0 is invalidate width, which can't get from
Ditto.
Quoted 8 lines
include/media/mipi-csi2.h +7
-0+* bus_fmt. +* +* Notes: this bpp is suffix from MEDIA_BUS_FMT_*, no pad, not for compressed +* data. +*/ +u32 media_bus_fmt_to_csi2_bpp (int bus_fmt); +#endif /* _MEDIA_MIPI_CSI2_H */
Signature · 3 lines
Kind regards, Sakari Ailus
Hi Frank,
Quoted 5 lines · Frank Li
drivers/media/v4l2-core/v4l2-common.c +5
-0+u32 media_bus_fmt_to_csi2_dt (int bus_fmt) +{ +const struct media_bus_fmt_info *info =media_bus_fmt_info_get (bus_fmt); + +return info ? info->dt :MIPI_CSI2_DT_INVALIDATE ;
drivers/media/v4l2-core/v4l2-common.c struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id, · line 986
Quoted 10 lines
drivers/media/v4l2-core/v4l2-common.c +10
-0+} +EXPORT_SYMBOL_GPL (media_bus_fmt_to_csi2_dt); + +u32 media_bus_fmt_to_csi2_bpp (int bus_fmt) +{ +const struct media_bus_fmt_info *info =media_bus_fmt_info_get (bus_fmt); + +return info ? info->bpp :0 ; +} +EXPORT_SYMBOL_GPL (media_bus_fmt_to_csi2_bpp);
Regarding the return values -- could we use int for that so we could use standard error codes, e.g. -EINVAL?
Signature · 3 lines
Regards, Sakari Ailus
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider: - [High] Uninitialized `.dt` fields default to 0 (`MIPI_CSI2_DT_FS`), causing `media_bus_fmt_to_csi2_dt()`…
Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [High] Uninitialized .dt fields default to 0 (MIPI_CSI2_DT_FS), causing media_bus_fmt_to_csi2_dt() to return a valid CSI-2 data type instead of an error.
- [High] Incorrect bit width per pixel (bpp) value for MEDIA_BUS_FMT_AHSV8888_1X32.
- [Low] Exported helper functions use signed int for bus format codes instead of u32.
- [Low] Grammatical errors in constant naming and code comments.
--
commit e06117f0b6bd648be504f0b932d84a4e08205433
Author: Frank Li <[email protected]>
media: v4l2-common: Add helper function media_bus_fmt_to_csi2_(bpp|dt)()
This commit adds helper functions media_bus_fmt_to_csi2_bpp() and media_bus_fmt_to_csi2_dt() to map media bus formats to MIPI CSI-2 data types and bits-per-pixel.
Quoted 4 lines
drivers/media/v4l2-core/v4l2-common.c +0
-0
[ ... ]
Quoted 10 lines
drivers/media/v4l2-core/v4l2-common.c +6
-0@@ -808,3 +809,180 @@ struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id,return clk_hw->clk; }EXPORT_SYMBOL_GPL (__devm_v4l2_sensor_clk_get); + +/** +* struct media_bus_fmt_info - information about a media bus format +* @code: media bus format identifier (MEDIA_BUS_FMT_*) +* @dt: data type define in MIPI spec (MIPI_CSI2_DT *) +* @bpp: bit width per pixel, which is suffix from MEDIA_BUS_FMT_*, no pad. no
drivers/media/v4l2-core/v4l2-common.c struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id, · line 827
Quoted 10 lines
drivers/media/v4l2-core/v4l2-common.c +10
-0+* compressed data. +*/ +struct media_bus_fmt_info { +u32 code; +u8 dt; +u8 bpp; +}; + +static const struct media_bus_fmt_info media_bus_fmt_info[] = { + { .code =MEDIA_BUS_FMT_RGB444_1X12 , .bpp =12 },
Since dt is not explicitly initialized here, it will default to 0. In the MIPI CSI-2 specification, 0x00 is a valid Data Type for Frame Start.
When media_bus_fmt_to_csi2_dt() looks up one of these unmapped formats, will it return 0x00 instead of the expected MIPI_CSI2_DT_INVALIDATE?
If so, does this risk drivers misprogramming the CSI-2 hardware to use Frame Start as a payload data type instead of failing gracefully?
[ ... ]
drivers/media/v4l2-core/v4l2-common.c struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id, · line 949
Quoted 5 lines
drivers/media/v4l2-core/v4l2-common.c +5
-0+ { .code = MEDIA_BUS_FMT_JPEG_1X8, .bpp = 8 }, + + { .code = MEDIA_BUS_FMT_S5C_UYVY_JPEG_1X8, .bpp = 8 }, + + { .code = MEDIA_BUS_FMT_AHSV8888_1X32, .bpp = 8 },
Is this bpp value correct? AHSV8888 consists of four 8-bit channels, and its 1X32 suffix denotes a 32-bit bus width.
Should this be 32 instead of 8 to prevent miscalculating link frequencies or allocating undersized DMA buffers?
Quoted 2 lines
drivers/media/v4l2-core/v4l2-common.c +2
-0+ + { .code = MEDIA_BUS_FMT_META_8, .bpp = 8 },
[ ... ]
drivers/media/v4l2-core/v4l2-common.c struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id, · line 972
Quoted 13 lines
drivers/media/v4l2-core/v4l2-common.c +13
-0+static const struct media_bus_fmt_info *media_bus_fmt_info_get (u32 bus_fmt) +{ +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (media_bus_fmt_info); i++) { +if (media_bus_fmt_info[i].code == bus_fmt) +return &media_bus_fmt_info[i]; + } + +return NULL ; +} + +u32 media_bus_fmt_to_csi2_dt (int bus_fmt)
Is it intentional to use a signed int for bus_fmt here?
The V4L2 subsystem typically defines and stores media bus format codes as unsigned 32-bit integers (u32). The internal media_bus_fmt_info_get() helper correctly uses u32.
drivers/media/v4l2-core/v4l2-common.c struct clk *__devm_v4l2_sensor_clk_get(struct device *dev, const char *id, · line 980
Quoted 8 lines
drivers/media/v4l2-core/v4l2-common.c +8
-0+{ +const struct media_bus_fmt_info *info =media_bus_fmt_info_get (bus_fmt); + +return info ? info->dt :MIPI_CSI2_DT_INVALIDATE ; +} +EXPORT_SYMBOL_GPL (media_bus_fmt_to_csi2_dt); + +u32 media_bus_fmt_to_csi2_bpp (int bus_fmt)
Similar to the function above, could this also take a u32 for bus_fmt to match the subsystem standard?
Quoted 11 lines
drivers/media/v4l2-core/v4l2-common.c +6
-0+{ +const struct media_bus_fmt_info *info =media_bus_fmt_info_get (bus_fmt); + +return info ? info->bpp :0 ; +} +EXPORT_SYMBOL_GPL (media_bus_fmt_to_csi2_bpp);include/media/mipi-csi2.h +0
-0
include/media/mipi-csi2.h line 48
Quoted 5 lines
include/media/mipi-csi2.h +2
-0@@ -44,4 +44,30 @@#define MIPI_CSI2_DT_RAW20 0x2f#define MIPI_CSI2_DT_USER_DEFINED (n) (0x30 + (n))/* 0..7 */ +/* Use one undefined value in spec */ +#define MIPI_CSI2_DT_INVALIDATE 0xff
This isn't a bug, but invalidate is a verb. To follow typical kernel state naming conventions, this should probably be named MIPI_CSI2_DT_INVALID or MIPI_CSI2_DT_UNKNOWN.
Quoted 7 lines
include/media/mipi-csi2.h +7
-0+ +/** +* media_bus_fmt_to_csi2_dt - Get MIPI CSI2 data type from media bus format +* +* @bus_fmt: media bus format identifier (MEDIA_BUS_FMT_*) +* +* return MIPI CSI2 data type MIPI_CSI2_DT_*, MIPI_CSI2_DT_INVALIDATE means
include/media/mipi-csi2.h line 65
Quoted 10 lines
include/media/mipi-csi2.h +10
-0+* can't get data type from bus_fmt. +*/ +u32 media_bus_fmt_to_csi2_dt (int bus_fmt); + +/** +* media_bus_fmt_to_csi2_bpp - Get media bus format's bit width per pixel +* +* @bus_fmt: media bus format identifier (MEDIA_BUS_FMT_*) +* +* returns bit width per pixel, 0 is invalidate width, which can't get from
This isn't a bug, but there's a grammatical error here. It says invalidate width instead of invalid width.
Quoted 8 lines
include/media/mipi-csi2.h +7
-0+* bus_fmt. +* +* Notes: this bpp is suffix from MEDIA_BUS_FMT_*, no pad, not for compressed +* data. +*/ +u32 media_bus_fmt_to_csi2_bpp (int bus_fmt); +#endif /* _MEDIA_MIPI_CSI2_H */
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
kernel test robot
build botkernel test robot noticed the following build errors:
Hi Frank,
kernel test robot noticed the following build errors:
[auto build test ERROR on linuxtv-media-pending/master]
[also build test ERROR on media-tree/master sailus-media-tree/master linus/master v7.1-rc3 next-20260508] [cannot apply to sailus-media-tree/streams]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Frank-Li/media-v4l2-common-Add-helper-function-media_bus_fmt_to_csi2_-bpp-dt/20260515-161325 base: https://git.linuxtv.org/media-ci/media-pending.git master patch link: https://lore.kernel.org/r/20260513205949.105444-1-Frank.Li%40nxp.com patch subject: [PATCH v4 1/1] media: v4l2-common: Add helper function media_bus_fmt_to_csi2_(bpp|dt)() config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260516/[email protected]/config) compiler: nios2-linux-gcc (GCC) 11.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260516/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
In file included from drivers/media/platform/rockchip/rkisp1/rkisp1-common.c:8:
>> include/media/mipi-csi2.h:58:1: error: unknown type name 'u32'
58 | u32 media_bus_fmt_to_csi2_dt(int bus_fmt);
| ^~~
include/media/mipi-csi2.h:71:1: error: unknown type name 'u32'
71 | u32 media_bus_fmt_to_csi2_bpp(int bus_fmt);
| ^~~vim +/u32 +58 include/media/mipi-csi2.h
49
50 /**
51 * media_bus_fmt_to_csi2_dt - Get MIPI CSI2 data type from media bus format
52 *
53 * @bus_fmt: media bus format identifier (MEDIA_BUS_FMT_*)
54 *
55 * return MIPI CSI2 data type MIPI_CSI2_DT_*, MIPI_CSI2_DT_INVALIDATE means
56 * can't get data type from bus_fmt.
57 */
> 58 u32 media_bus_fmt_to_csi2_dt(int bus_fmt);
59 --
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki