man/man2/seccomp.2: Document SECCOMP_FILTER_FLAG_TSYNC_ESRCH
PATCH v2 1/2 man/man2/seccomp.2: Document SECCOMP_FILTER_FLAG_TSYNC_ESRCH
Document SECCOMP_FILTER_FLAG_TSYNC_ESRCH flag, which allows to use SECCOMP_FILTER_FLAG_TSYNC and SECCOMP_FILTER_FLAG_NEW_LISTENER flags together by returning ESRCH on synchronization error instead of the thread ID.
<https://lore.kernel.org/r/[email protected]>
--- man/man2/seccomp.2 | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
man/man2/seccomp.2 +15 -0
@@ -241,6 +241,21 @@ .SH DESCRIPTION .B SECCOMP_MODE_STRICT or if it has attached new seccomp filters to itself, diverging from the calling thread's filter tree. +.TP +.BR SECCOMP_FILTER_FLAG_TSYNC_ESRCH " (since Linux 5.7)" +.\" commit 51891498f2da78ee64dfad88fa53c9e85fb50abf +Return +.B ESRCH +instead of the thread ID on synchronization failure if +.B SECCOMP_FILTER_FLAG_TSYNC +was specified. +.IP +If this flag is not set, using +.B SECCOMP_FILTER_FLAG_NEW_LISTENER +and +.B SECCOMP_FILTER_FLAG_TSYNC +flags together results in +.BR EINVAL . .RE .TP .BR SECCOMP_GET_ACTION_AVAIL " (since Linux 4.14)"
Signature · 1 line
2.52.0
Alejandro Colomar
maintainerHi,
Quoted 7 lines · funsafemath
Document
SECCOMP_FILTER_FLAG_TSYNC_ESRCHflag, which allows to useSECCOMP_FILTER_FLAG_TSYNCandSECCOMP_FILTER_FLAG_NEW_LISTENERflags together by returning ESRCH on synchronization error instead of the thread ID.
Would you mind signing the patch?
Quoted 8 lines
man/man2/seccomp.2 | 15 +++++++++++++++ 1 file changed, 15 insertions(+)man/man2/seccomp.2 +0
-0
man/man2/seccomp.2 .SH DESCRIPTION · line 248
Quoted 8 lines
man/man2/seccomp.2 +5
-0@@ -241,6 +241,21 @@ .SH DESCRIPTION .B SECCOMP_MODE_STRICT or if it has attached new seccomp filters to itself, diverging from the calling thread's filter tree. +.TP +.BR SECCOMP_FILTER_FLAG_TSYNC_ESRCH " (since Linux 5.7)" +.\" commit 51891498f2da78ee64dfad88fa53c9e85fb50abf +Return +.B ESRCH
I expect that in user space, we'll see -1 in the return value, and ESRCH in errno, right? If so, we should say "Fail with ESRCH ...".
man/man2/seccomp.2 .SH DESCRIPTION · line 250
Quoted 2 lines
man/man2/seccomp.2 +2
-0+instead of the thread ID on synchronization failure if +.B SECCOMP_FILTER_FLAG_TSYNC
Spurious double space. s/ / /
Have a lovely day!
Alex
Quoted 14 lines
man/man2/seccomp.2 +8
-0+was specified. +.IP +If this flag is not set, using +.B SECCOMP_FILTER_FLAG_NEW_LISTENER +and +.B SECCOMP_FILTER_FLAG_TSYNC +flags together results in +.BR EINVAL . .RE .TP .BR SECCOMP_GET_ACTION_AVAIL " (since Linux 4.14)"Signature · 1 line
2.52.0
Signature · 1 line
<https://www.alejandro-colomar.es>
Quoted 16 lines · Alejandro Colomar
Hi,
Quoted 7 lines · funsafemath
Document
SECCOMP_FILTER_FLAG_TSYNC_ESRCHflag, which allows to useSECCOMP_FILTER_FLAG_TSYNCandSECCOMP_FILTER_FLAG_NEW_LISTENERflags together by returning ESRCH on synchronization error instead of the thread ID.Would you mind signing the patch?
Quoted 3 lines
man/man2/seccomp.2 | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
Quoted 16 lines
man/man2/seccomp.2 .SH DESCRIPTION · line 248
Quoted 13 lines
man/man2/seccomp.2 +5
-0@@ -241,6 +241,21 @@ .SH DESCRIPTION .B SECCOMP_MODE_STRICT or if it has attached new seccomp filters to itself, diverging from the calling thread's filter tree. +.TP +.BR SECCOMP_FILTER_FLAG_TSYNC_ESRCH " (since Linux 5.7)" +.\" commit 51891498f2da78ee64dfad88fa53c9e85fb50abf +Return +.B ESRCHI expect that in user space, we'll see -1 in the return value, and ESRCH in errno, right? If so, we should say "Fail with ESRCH ...".
Yes, exactly. Probably worth changing the wording in the commit message as well.
Tycho
Alejandro Colomar
maintainerHi Tycho,
Quoted 34 lines · Tycho Andersen
Quoted 16 lines · Alejandro Colomar
Hi,
Quoted 7 lines · funsafemath
Document
SECCOMP_FILTER_FLAG_TSYNC_ESRCHflag, which allows to useSECCOMP_FILTER_FLAG_TSYNCandSECCOMP_FILTER_FLAG_NEW_LISTENERflags together by returning ESRCH on synchronization error instead of the thread ID.Would you mind signing the patch?
Quoted 3 lines
man/man2/seccomp.2 | 15 +++++++++++++++ 1 file changed, 15 insertions(+)Quoted 16 lines
man/man2/seccomp.2 .SH DESCRIPTION · line 248
Quoted 13 lines
man/man2/seccomp.2 +5
-0@@ -241,6 +241,21 @@ .SH DESCRIPTION .B SECCOMP_MODE_STRICT or if it has attached new seccomp filters to itself, diverging from the calling thread's filter tree. +.TP +.BR SECCOMP_FILTER_FLAG_TSYNC_ESRCH " (since Linux 5.7)" +.\" commit 51891498f2da78ee64dfad88fa53c9e85fb50abf +Return +.B ESRCHI expect that in user space, we'll see -1 in the return value, and ESRCH in errno, right? If so, we should say "Fail with ESRCH ...".
Quoted 2 lines
Yes, exactly. Probably worth changing the wording in the commit message as well.
Thanks! I've amended the commit message while applying v2.
Have a lovely night!
Alex
Quoted 2 lines
Tycho
Signature · 1 line
<https://www.alejandro-colomar.es>
v2 cover Document seccomp flags
In reply to funsafemathHello,
Yes, a libc wrapper would return -1, I've changed the wording and applied other suggestions.
funsafemath (2):
man/man2/seccomp.2: Document SECCOMP_FILTER_FLAG_TSYNC_ESRCH man/man2/seccomp.2: Document SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV
man/man2/seccomp.2 | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)
Range-diff against v1:
1: c3c3b728b ! 1: fec59f483 man/man2/seccomp.2: Document SECCOMP_FILTER_FLAG_TSYNC_ESRCH
@@ Commit message
<https://lore.kernel.org/r/[email protected]>
+ Signed-off-by: funsafemath <[email protected]>
+
## man/man2/seccomp.2 ##
@@ man/man2/seccomp.2: .SH DESCRIPTION
.B SECCOMP_MODE_STRICT
@@ man/man2/seccomp.2: .SH DESCRIPTION
+.TP
+.BR SECCOMP_FILTER_FLAG_TSYNC_ESRCH " (since Linux 5.7)"
+.\" commit 51891498f2da78ee64dfad88fa53c9e85fb50abf
-+Return
++Fail with
+.B ESRCH
-+instead of the thread ID on synchronization failure if
-+.B SECCOMP_FILTER_FLAG_TSYNC
++instead of returning the thread ID on synchronization failure if
++.B SECCOMP_FILTER_FLAG_TSYNC
+was specified.
+.IP
+If this flag is not set, using
2: 423b0141b ! 2: 8ead033b8 man/man2/seccomp.2: Document SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV
@@ Commit message
Relevant kernel documentation: <Documentation/userspace-api/seccomp_filter.rst>
+ Signed-off-by: funsafemath <[email protected]>
+
## man/man2/seccomp.2 ##
@@ man/man2/seccomp.2: .SH DESCRIPTION
.B SECCOMP_FILTER_FLAG_TSYNC
@@ man/man2/seccomp.2: .SH DESCRIPTION
+.\" commit c2aa2dfef243efe213a480a1ee8566507a5152f4 +Ignore non-fatal signals until the supervisor sends a response. +.IP
++The
+.B SECCOMP_FILTER_FLAG_NEW_LISTENER
+flag must be set.
.RE
Signature · 1 line
2.52.0
Alejandro Colomar
maintainerRe: [PATCH v2 0/2] Document seccomp flags
Hi,
Quoted 7 lines · funsafemath
Hello,
Yes, a libc wrapper would return -1, I've changed the wording and applied other suggestions.
funsafemath (2):
man/man2/seccomp.2: DocumentSECCOMP_FILTER_FLAG_TSYNC_ESRCHman/man2/seccomp.2: DocumentSECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV
Thanks! I've applied both patches.
Have a lovely night!
Alex
Quoted 50 lines
man/man2/seccomp.2 | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)Range-diff against v1:
1:c3c3b728b! 1:fec59f483man/man2/seccomp.2: DocumentSECCOMP_FILTER_FLAG_TSYNC_ESRCH
@@ Commit message<https://lore.kernel.org/r/[email protected]>
+ Signed-off-by: funsafemath <[email protected]>
+
## man/man2/seccomp.2 ##
@@ man/man2/seccomp.2: .SH DESCRIPTION
.BSECCOMP_MODE_STRICT
@@ man/man2/seccomp.2: .SH DESCRIPTION
+.TP
+.BRSECCOMP_FILTER_FLAG_TSYNC_ESRCH" (since Linux 5.7)"
+.\" commit51891498f2da78ee64dfad88fa53c9e85fb50abf
-+Return
++Fail with
+.B ESRCH
-+instead of the thread ID on synchronization failure if
-+.BSECCOMP_FILTER_FLAG_TSYNC
++instead of returning the thread ID on synchronization failure if
++.BSECCOMP_FILTER_FLAG_TSYNC
+was specified.
+.IP
+If this flag is not set, using
2:423b0141b! 2:8ead033b8man/man2/seccomp.2: DocumentSECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV
@@ Commit messageRelevant kernel documentation: <
Documentation/userspace-api/seccomp_filter.rst>+ Signed-off-by: funsafemath <[email protected]>
+
## man/man2/seccomp.2 ##
@@ man/man2/seccomp.2: .SH DESCRIPTION
.BSECCOMP_FILTER_FLAG_TSYNC
@@ man/man2/seccomp.2: .SH DESCRIPTION
+.\" commitc2aa2dfef243efe213a480a1ee8566507a5152f4+Ignore non-fatal signals until the supervisor sends a response. +.IP
++The
+.BSECCOMP_FILTER_FLAG_NEW_LISTENER
+flag must be set.
.RESignature · 1 line
2.52.0
Signature · 1 line
<https://www.alejandro-colomar.es>
PATCH v2 1/2 man/man2/seccomp.2: Document SECCOMP_FILTER_FLAG_TSYNC_ESRCH
In reply to funsafemathDocument SECCOMP_FILTER_FLAG_TSYNC_ESRCH flag, which allows to use SECCOMP_FILTER_FLAG_TSYNC and SECCOMP_FILTER_FLAG_NEW_LISTENER flags together by returning ESRCH on synchronization error instead of the thread ID.
<https://lore.kernel.org/r/[email protected]>
--- man/man2/seccomp.2 | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
man/man2/seccomp.2 +15 -0
@@ -241,6 +241,21 @@ .SH DESCRIPTION .B SECCOMP_MODE_STRICT or if it has attached new seccomp filters to itself, diverging from the calling thread's filter tree. +.TP +.BR SECCOMP_FILTER_FLAG_TSYNC_ESRCH " (since Linux 5.7)" +.\" commit 51891498f2da78ee64dfad88fa53c9e85fb50abf +Fail with +.B ESRCH +instead of returning the thread ID on synchronization failure if +.B SECCOMP_FILTER_FLAG_TSYNC +was specified. +.IP +If this flag is not set, using +.B SECCOMP_FILTER_FLAG_NEW_LISTENER +and +.B SECCOMP_FILTER_FLAG_TSYNC +flags together results in +.BR EINVAL . .RE .TP .BR SECCOMP_GET_ACTION_AVAIL " (since Linux 4.14)"
Signature · 1 line
2.52.0
PATCH v2 2/2 man/man2/seccomp.2: Document SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV
In reply to funsafemathDocument the SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV flag,
which makes the process ignore non-fatal signals until the supervisor sends a response
Relevant kernel documentation: <Documentation/userspace-api/seccomp_filter.rst>
--- man/man2/seccomp.2 | 8 ++++++++ 1 file changed, 8 insertions(+)
man/man2/seccomp.2 +8 -0
@@ -256,6 +256,14 @@ .SH DESCRIPTION .B SECCOMP_FILTER_FLAG_TSYNC flags together results in .BR EINVAL . +.TP +.BR SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV " (since Linux 5.19)" +.\" commit c2aa2dfef243efe213a480a1ee8566507a5152f4 +Ignore non-fatal signals until the supervisor sends a response. +.IP +The +.B SECCOMP_FILTER_FLAG_NEW_LISTENER +flag must be set. .RE .TP .BR SECCOMP_GET_ACTION_AVAIL " (since Linux 4.14)"
Signature · 1 line
2.52.0